From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82BC4C2D0CD for ; Mon, 19 May 2025 14:55:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 71C3F6B00C1; Mon, 19 May 2025 10:55:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 67BF76B00C5; Mon, 19 May 2025 10:55:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4F5316B00D2; Mon, 19 May 2025 10:55:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 2A1D76B00C1 for ; Mon, 19 May 2025 10:55:44 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 634111206B0 for ; Mon, 19 May 2025 14:55:47 +0000 (UTC) X-FDA: 83459956734.17.EE5D18D Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf05.hostedemail.com (Postfix) with ESMTP id A4131100011 for ; Mon, 19 May 2025 14:55:45 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=azJywjW5; spf=pass (imf05.hostedemail.com: domain of broonie@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=broonie@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747666545; a=rsa-sha256; cv=none; b=XK8LyIiXSToDdnk9iZPS6uA/9UtF/4M5tGl59Sh05KOqrTsSfSzhKNgAFrbbZRgehvaODL 57bKx9S8xeheFVoPCvQm29QoonMpuGDQgzl82KSHzrjGTKo/pg27PHQKllXywJCl7/g3rr PN1zj4PSutgFCAT0iPcuFowoPBzJ5s4= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=azJywjW5; spf=pass (imf05.hostedemail.com: domain of broonie@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=broonie@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747666545; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=zY3H8h2/LnTS38+hdbBOR3Sc6FoXyDwqWv8xUQ3F5H8=; b=xNF1bofXPUlpJCLVizbaim8qHKsYSQKEnMA/mT5v8jw2Tg9Bnrn6Zl7kqAbi2r4wQIFno5 QdJcroMAxljTPP6cW9VHj3snzU2T28VCcKWp+RvLPSCTjU5LGdf8ecXarCH7ppH/AzsQrc RaXQnDQYDPwQ7cKS4ckC4G3HCZBzKzw= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id D6254A4DEC1; Mon, 19 May 2025 14:55:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3471AC4CEE4; Mon, 19 May 2025 14:55:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1747666544; bh=+X76iYUuy9DsVDbkt7YyPLXZmVHqkBUvv95NS/ecbuE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=azJywjW5goGMJCUc2P54PElSOo8JWGM8mqdZQsYrORxyAGU1FV1GyaPuEnsfpeY23 jaB2g2WqGjFM+7z89oBUL+YbxXsK8WD5cmfBkRjJN00KhEXAG9tE1PyF0pJ6pOWSOw JLki26GX+/BzJYgCbhp6AHYIZ6ppiM3N2n4uTsDzfYFLCIiogrr3HlOzb0BDHBr6Ue fR1KdCjw6uQBLSMQe/jU+N2ac5or2ZekJiUD6je/GTa8f8b8goJUoq136xktdkOa7X D5qpAa3YkFM3gfHJuIWWdP98xFmSYvfMnqwEw4B5cNqp2JSsYiMPwNCf0LWIOtDKmo NG0Mlly7htn7Q== Date: Mon, 19 May 2025 15:55:40 +0100 From: Mark Brown To: David Hildenbrand Cc: Andrew Morton , Shuah Khan , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] selftests/mm: Fix test result reporting in gup_longterm Message-ID: References: <20250515-selftests-mm-gup-longterm-dups-v1-1-05f8f731cf63@kernel.org> <58dbef73-6e37-46de-9092-365456306b27@redhat.com> <46d151d7-c04b-4538-9725-dc4f46ac8ac1@redhat.com> <8131ce62-0cee-455f-9eeb-e2bbed244402@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="M2L5/cXLTc0+AzCR" Content-Disposition: inline In-Reply-To: <8131ce62-0cee-455f-9eeb-e2bbed244402@redhat.com> X-Cookie: We have ears, earther...FOUR OF THEM! X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: A4131100011 X-Stat-Signature: 6mptobqmwcka7fhbcsb7hfcrxid7dbsa X-HE-Tag: 1747666545-612018 X-HE-Meta: U2FsdGVkX18Sem3R+2//oH0j5RdEngjD6278+SbC11+FoQRKTbnXbPh62IkE3DRNrW2ElmCM56KwOwoNftC57Q2UUT2O2bK7WtpmlQxC53anxCFp5nqkI4R3Ua2n6Jj4c67pkFz5OAp3dBTs0+JM6odmsNpbxMSsA4zX14sZRSnxAVILicrDw4miyQWS68r37+ru9DsBTyH2u0SSr2pdi05Qxeo2lobx/rhGNZkbj++vPxIKGwV25PZoNo+wig7KClQ0t0L1OHpD/u40rQZujEx2rOtQVp+ub1rdITWDQnSCNtXFUNYqYpCMlKZgrHA2bno64/jgk1+OJoa0DxAyNk/r8uT66hrKtLqKU6FC+zathqtMA846VFwS58/5JAg0aL4d/M5ntajw9nzy/KqI3XZulu9t9jrzreJSEPO1l0Ptf7wFQxIMwjQ71KsAvxOSoGtCxi56M6UKMXjXRncIa6iNyr8xqwQ5UhfCFMAo2LjDhav55l+Oxn5fvH7HpjvBjy3l7gsLmi9jmxiqi+E8MvuvgHudXvhVVlQjDTgjNSIvAkS85e8iRh+0Rs+Y7QTeU03kgj6j21MvwNfD7qKhz/KHl+meRxmylrqBSX5Ik2LtrOKImptr3DuOLHNgm5OyQXboQssj45i1f9Xa9xXtrGB+GGsxJxRD6f3TWO0GjQR0xvqdrpcBWGTQm9zhooSfEjJsYyg1vCEAVWQO4+Di4l7k0OGgAykWuNaYenz3JYUtx10oXPzY8ga1fKf86PzIrWXPdWQWwM+IxGclkdDkRNp7o9anIS1JdYAL6oNST2unudkdOqzh6yNHXcBag6K9PnGRXMlMbNrfq0fx1oJddnNM+uBwHPngKSBqWae9n3TcemnRpDE6RikFUzB3dQvwHCgyFQURX4Pl5Uuc3eLSdRtHh9mU1YuZTxzvx7VyKqDmXE1DyvLgfRRnFhmEQbIe7qk6tTjOMbZZguF0zGi jXJEK7vg 58/EpfluvFxUK8NhOl9vRodVrfmrT8BDbzdnN13LOAskjNRrNOCQLTbRdBBcXMD0OMeqIyqEfoasZvmRpXD31hrgVBKh0qBsZFOvnH/IysGeCsOc419xEK15TB6qrxdoRsxV263Ss8GH8uBxxyLx2iTsiyH1LON/MLRsrm69LvGyOZ0cdyrh/ZKUp1UqU5LJSXqRCeZ91AM2nEWi7fFGi0DJCdMImUpgdZp/YfDAx1ioswkjz29q5h5YBF/hzr0Y9LgEle4vo4MDHhQ4sgUEsR/kSRbPHHV0FUEmMNRUBJ4+RiG5ijmZpixm1QwYLrmw6swYVDdQChaB+HVSoV7fLZPSqc+GYnlNfWMX7 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: --M2L5/cXLTc0+AzCR Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, May 19, 2025 at 03:28:47PM +0200, David Hildenbrand wrote: > On 16.05.25 20:07, Mark Brown wrote: > > On Fri, May 16, 2025 at 04:12:08PM +0200, David Hildenbrand wrote: > > [Converting to kselftet_harness] > > > > That'd certainly work, though doing that is more surgery on the test > > > > than I personally have the time/enthusiasm for right now. > > > Same over here. > > > But probably if we touch it, we should just clean it up right away. Well, > > > if we decide that that is the right cleanup. (you mention something like that > > > in your patch description :) > > OTOH there's something to be said for just making incremental > > improvements in the tests where we can, they tend not to get huge > > amounts of love in general which means perfect can very much be the > > enemy of good. If there's some immediate prospect of someone doing a > > bigger refactoring then that'd be amazing, but if not then it seems > > useful to make things play better with the automation for now. > I would agree if it would be a handful of small changes. > But here we are already at > 1 file changed, 107 insertions(+), 56 deletions(-) Those are pretty mechanical changes due to the amount of chat from the program rather than a more substantial reconstruction of the logic which is rather more risky for a drive by. --M2L5/cXLTc0+AzCR Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmgrRmsACgkQJNaLcl1U h9DuZAf+P60cnZrBiz7qi76C5eLIVuVj+QIAm2cpmnirdllp9oYWisfl93q5Pgpd 6S4imW+gEU8sWAQXlo10YjV05db/QpkGeK5gnzxjCwa58LPMM5rzX5qyAOfvEKlU vuvYzGzUOt5rCptsHz+Wbn6d/hMH/ObmNSJ9J1Swisgz+oSLB2jbgatlQKiT+3Ot 6BuRN7ESdCHc0tMvG2/hBy37HDyql+R6hRzQLt1vJiCpMv/tbnNgM4o+apWK/2Hj JMAHkkxZDOgquo9lWQcTn0BbQjTJxFFqndIzJzCCwapvu09jJ3P7kk0AVvPJYrsg D8d+sL1akSM6lTPgt4cSNZm9EpxZnA== =DeB+ -----END PGP SIGNATURE----- --M2L5/cXLTc0+AzCR--