linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: David Hildenbrand <david@redhat.com>
To: kernel test robot <lkp@intel.com>
Cc: oe-kbuild-all@lists.linux.dev,
	Andrew Morton <akpm@linux-foundation.org>,
	Linux Memory Management List <linux-mm@kvack.org>,
	Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
Subject: Re: [linux-next:master 6034/7427] arch/sh/include/asm/atomic-irq.h:69:undefined reference to `page_range_contiguous'
Date: Tue, 9 Sep 2025 11:47:06 +0200	[thread overview]
Message-ID: <d3c68577-131f-48e0-84be-cb4424e3fa9e@redhat.com> (raw)
In-Reply-To: <202509100708.5mJZ2cLm-lkp@intel.com>

On 09.09.25 11:31, kernel test robot wrote:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> head:   65dd046ef55861190ecde44c6d9fcde54b9fb77d
> commit: 73f5c4c5c6a36a130ccba6809337e42ccf8350fa [6034/7427] mm/gup: drop nth_page() usage in unpin_user_page_range_dirty_lock()
> config: sh-randconfig-r121-20250908 (https://download.01.org/0day-ci/archive/20250910/202509100708.5mJZ2cLm-lkp@intel.com/config)
> compiler: sh4-linux-gcc (GCC) 15.1.0
> reproduce: (https://download.01.org/0day-ci/archive/20250910/202509100708.5mJZ2cLm-lkp@intel.com/reproduce)
> 
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202509100708.5mJZ2cLm-lkp@intel.com/
> 
> All errors (new ones prefixed by >>):
> 
>     sh4-linux-ld: crypto/testmgr.o: in function `sg_set_buf':
>     testmgr.c:(.text+0x8fc): undefined reference to `page_range_contiguous'
>     sh4-linux-ld: drivers/usb/core/devio.o: in function `sg_set_buf':
>     devio.c:(.text+0xd54): undefined reference to `page_range_contiguous'
>     sh4-linux-ld: drivers/media/common/videobuf2/videobuf2-dma-contig.o: in function `vb2_dc_dmabuf_ops_attach':
>     videobuf2-dma-contig.c:(.text+0x920): undefined reference to `page_range_contiguous'
>     sh4-linux-ld: net/core/skbuff.o: in function `__skb_to_sgvec':
>     skbuff.c:(.text+0x2180): undefined reference to `page_range_contiguous'
>     sh4-linux-ld: mm/gup.o: in function `unpin_user_page_range_dirty_lock':
>>> arch/sh/include/asm/atomic-irq.h:69:(.text+0xe34): undefined reference to `page_range_contiguous'
>     sh4-linux-ld: fs/ecryptfs/crypto.o:crypto.c:(.text+0x954): more undefined references to `page_range_contiguous' follow
> 

Yes, can reproduce that. The config has CONFIG_SPARSEMEM without VMEMMAP and:

# CONFIG_MMU is not set

I'm surprised that we can have SPARSEMEM with NOMMU. What a time to be alive.

The following seems to fix it:

diff --git a/mm/util.c b/mm/util.c
index 248f877f629b..6c1d64ed0221 100644
--- a/mm/util.c
+++ b/mm/util.c
@@ -1306,6 +1306,7 @@ unsigned int folio_pte_batch(struct folio *folio, pte_t *ptep, pte_t pte,
  {
         return folio_pte_batch_flags(folio, NULL, ptep, &pte, max_nr, 0);
  }
+#endif /* CONFIG_MMU */
  
  #if defined(CONFIG_SPARSEMEM) && !defined(CONFIG_SPARSEMEM_VMEMMAP)
  /**
@@ -1342,4 +1343,3 @@ bool page_range_contiguous(const struct page *page, unsigned long nr_pages)
  }
  EXPORT_SYMBOL(page_range_contiguous);
  #endif
-#endif /* CONFIG_MMU */


-- 
Cheers

David / dhildenb



      reply	other threads:[~2025-09-09  9:47 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-09  9:31 kernel test robot
2025-09-09  9:47 ` David Hildenbrand [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d3c68577-131f-48e0-84be-cb4424e3fa9e@redhat.com \
    --to=david@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-mm@kvack.org \
    --cc=lkp@intel.com \
    --cc=lorenzo.stoakes@oracle.com \
    --cc=oe-kbuild-all@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox