From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9D631C7EE30 for ; Wed, 2 Jul 2025 09:16:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 30E936B00BA; Wed, 2 Jul 2025 05:16:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2E5AC6B00BE; Wed, 2 Jul 2025 05:16:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1D4936B00BF; Wed, 2 Jul 2025 05:16:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 0E6746B00BA for ; Wed, 2 Jul 2025 05:16:32 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 9F2BC140210 for ; Wed, 2 Jul 2025 09:16:31 +0000 (UTC) X-FDA: 83618768982.16.B4E1096 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf03.hostedemail.com (Postfix) with ESMTP id 2C52F20007 for ; Wed, 2 Jul 2025 09:16:28 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=a0yH7iHC; spf=pass (imf03.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751447789; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=VhvKivkRdMQ8hNFJSsUo2kra//5VvojDXBm2vAANYo0=; b=GzgE8Ih8E0AtoaF3gq+0btNHLjYYNPBj5N6AsxVLm3dqulUkRQ29CsmzWUgyYo4cka7Ei8 LTxNddSOmBKd1EIxM0l246EibBiVBMtpPIxWps4Ep5eyueUPA23VQoDVU+m3thdUuA2Ua4 GBbQANsUCgE480ovVeKtHjxknSMYiJ0= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=a0yH7iHC; spf=pass (imf03.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751447789; a=rsa-sha256; cv=none; b=PFBgOdhyC5kNVspPOvHbb8YEIJR2PBrgvw0e0ws6RDNIjA2LY7/qYFfLARjcLA8Hm2JZ8C xBUq/Hu8qmqSUfRDdSC5L4t6l3+1Js4CLMMiWnGms+WtosSVaY1u/YFqXX1rCv4fiE8XEu gNecsEqs0su7d7IU13n6mYWbPje3Is4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1751447788; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=VhvKivkRdMQ8hNFJSsUo2kra//5VvojDXBm2vAANYo0=; b=a0yH7iHCDvPSP9bcXNtAQqfeU5di2OLSN0Us90osnQJAFbSJZOzXynWcNnjkOmxQEA0eF0 v6R189iHvNu7TZZr896RHrKMquRLuB25GP1Tl9REMyCxl0ZJC7L2kU4+W6OfCXsPz7Iw76 RhO3QhP3Pj/Cq1QsILGpW1vHmrxEm2w= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-494-VUVmvwXgPqCgq9TU9fbUOA-1; Wed, 02 Jul 2025 05:16:27 -0400 X-MC-Unique: VUVmvwXgPqCgq9TU9fbUOA-1 X-Mimecast-MFC-AGG-ID: VUVmvwXgPqCgq9TU9fbUOA_1751447786 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-3a4f65a705dso2528555f8f.2 for ; Wed, 02 Jul 2025 02:16:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751447786; x=1752052586; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=VhvKivkRdMQ8hNFJSsUo2kra//5VvojDXBm2vAANYo0=; b=X5Q40JIy6yvIDhcXGIJz8h4SrfyoNrqviVDq6URe2Rcgs6hoptKRMHAsCNzAv//oq2 Wn+S2p+dNKVBHEkNcdxYnqSwayi74S13w6EITC92e+x4FKfhhTAWp4YCvNLUmeEKgFm+ kx02ccMxNhd+ZIaP1yi59AzA1i8o6tvpSxCEedoOXuDB/zY+bYgBKNNQ4kqYIntNyjBU BVqcjB0YRkrjiKesD+Wj8rgoZFMmTbbJHtuutujfYvCgFg8X/kT+vfrzvdvQnJUhnHAX 1ErO9Pkew0VLVBcMSSaw79QiTBfGnWpojbAyxIwdeAtfjkgdUelm24u6Q+ywM/eVS8QV V5eQ== X-Forwarded-Encrypted: i=1; AJvYcCUZz+gACnCTS7i8ucc4yfKgLQocxoAp28Uh33BCpV+UrWcct3B663aYjbd9CrW2mXHZl6kgZFF9Mw==@kvack.org X-Gm-Message-State: AOJu0YwiUAJ222fnBVq+lTGUFuH6+dQ8ULjUgrt3GpxwBmrZtY1t8jjS GqbTQNHC20NjZtyx22YbSlra968iQeYwHLrIt8lWgXrUjHQ2vdWMZ+QNvFrJL0hFCiGkh0H/+al xRTXa5dhbKuz+UcTFUrdLCICJcBtUSFt45Vd8QET8bMRoRQzJjcdX X-Gm-Gg: ASbGnctSiA1uYHgolLvNsu+9jbWwgvnFLfDloQUltVpzbtkuMWEqf0+KtQOql9WdoEX +e2ABMt1Yn9JEsnVOSesN2URfQCFEvDz/dkGUXb/FaiB0wyG2+hZRk5dDAVQUNfFJDf5bRNCBMH 4B1llvY/SvmdrLO9CiF4Wx+lQ6f6ooKlDDI/unlH+jlIiYSfdlg+nzRLXKkLyVB5qC+k1qsNWy4 IbqfiZTl3ZmBI7cF3KmH7zKq3YKGCSLXtuT8R69lOP/Ld6egrwJFnHSkOO3mQeU/uFHFCb9Iua3 oMo/846jVaeYBmydxcJpci669FH4kG2mRSs6JzQAlS20Ku5q6BXCaGU= X-Received: by 2002:a05:6000:4a14:b0:3a4:fa09:d13b with SMTP id ffacd0b85a97d-3b201f7a27dmr1358423f8f.59.1751447786043; Wed, 02 Jul 2025 02:16:26 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGp5EpgeCvR4tiZ/g3Grd0EyFOBAFYllhb6V2TK4S4696v0tuBql0sF0ZVkxL7xaoEGSd7dCw== X-Received: by 2002:a05:6000:4a14:b0:3a4:fa09:d13b with SMTP id ffacd0b85a97d-3b201f7a27dmr1358369f8f.59.1751447785538; Wed, 02 Jul 2025 02:16:25 -0700 (PDT) Received: from ?IPV6:2a09:80c0:192:0:5dac:bf3d:c41:c3e7? ([2a09:80c0:192:0:5dac:bf3d:c41:c3e7]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a88c7facf9sm15399967f8f.22.2025.07.02.02.16.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 02 Jul 2025 02:16:24 -0700 (PDT) Message-ID: Date: Wed, 2 Jul 2025 11:16:23 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 23/29] mm/page-alloc: remove PageMappingFlags() To: Lorenzo Stoakes Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-doc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, virtualization@lists.linux.dev, linux-fsdevel@vger.kernel.org, Andrew Morton , Jonathan Corbet , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Jerrin Shaji George , Arnd Bergmann , Greg Kroah-Hartman , "Michael S. Tsirkin" , Jason Wang , Xuan Zhuo , =?UTF-8?Q?Eugenio_P=C3=A9rez?= , Alexander Viro , Christian Brauner , Jan Kara , Zi Yan , Matthew Brost , Joshua Hahn , Rakie Kim , Byungchul Park , Gregory Price , Ying Huang , Alistair Popple , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , "Matthew Wilcox (Oracle)" , Minchan Kim , Sergey Senozhatsky , Brendan Jackman , Johannes Weiner , Jason Gunthorpe , John Hubbard , Peter Xu , Xu Xin , Chengming Zhou , Miaohe Lin , Naoya Horiguchi , Oscar Salvador , Rik van Riel , Harry Yoo , Qi Zheng , Shakeel Butt References: <20250630130011.330477-1-david@redhat.com> <20250630130011.330477-24-david@redhat.com> <8ff24777-988a-4d1d-be97-e7184abfa998@lucifer.local> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: msW2w56z2JSzoOy7ieKAbc2niPVdu1hzvkZchNzrLio_1751447786 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: xw5p5k9fedcmy53k5pwkeay69drxs4s9 X-Rspamd-Queue-Id: 2C52F20007 X-Rspamd-Server: rspam11 X-Rspam-User: X-HE-Tag: 1751447788-317040 X-HE-Meta: U2FsdGVkX1+TXoVFWeMQiAK8Ll6cMYaJvWL19doDGxgzLCCAAxZGcPUAziTArh0Kyg0MG7J5FQ7xnuZm32GIqcbxcjeONsGnnw6GQyKbkDKB2RsWvVtvDkOb5AyYoFs2TGxG/nR0eD/OOdBGQbIfDDRK3p0XPtSgEotSPlf9mWPqXUHServqRMGnqiju4YwevG3Qe68uivAZhuQmtZWemOuS2YLtZ34SCe4H+1DD+A0hLds5YCYkokOP5ero170lCo31xKOij68YQcno6VeMqAOt/3IB4YFIZw+oskEg3WXd6+s86yrevn9QFqPiw8EDlTvVDElGWrjOfEQehRlSFuBZMiRM8k/HItAPnDdFDa90QFEjcO0Wvq7Fob/TuQGrA1IhFKwngvHDky1yK4/23CrWqbFA590c9/or7v3ZfkH9S6E4sLB7dRBvbZYKQHesvdJQ3F6huV0f6KbKzoCycpCtJXy5tWrORaM9ot0bfx1oQwiokindNMM/g5BogiAgMEabNVJaXFxjccUmhDezlfN0MdDaiks9+rnnHylvg2N3rxq+NtLFQzEPq3aJMFFhJAcLzC+fpDjlmdf64dbY8onAUU8C7QU0BnrDvoK8xTzDaJmVxG/sNYmVujGLsTlmyZNeYvHTXALNdjZZVN6y8fv7Eb0jgkxH7kXqGtnWW7YGQzRL3FE5By5Fd2h0SK9yl5dtmAh61Mbcys8WA9xvc8LqFxSKBtkUEBtPCXY9J5RdLGM9VXkObZkz/sH4f1e9ADqbQNBDKJMpLYlOJzdQS0WnzcMcBaOj6YYtElfpv3S533p2THMVAkskTCOd0eTzgTiaA/gj9TXWlmAFxvrSBN5bteJZU32ZjW+62xYOmo1Wx461F+D3LN+PURlHDY9J2e8SJcrDkOVNZtetWTkJbKtXsfB45CVrdXB7tjiRO6JuFGRvDEHIIVRA2Bm8Niczv/+J9ZpAZbAUUadfpH0 JKH1NGBA ikkI7bsP8kthadRDz4dzLQstOjNI5uCyT2e4QGAmJUnEFOZCDJYpigKu939Dzi3C4baPmBgBH3clGPIyF+FMN5+klrG7QZ7iEZ+/I2u4YwL0+4ZgKXSaJTC/4RlDiOPEmuEVrXPTfWqWkQdUl6Ao5CRhzSiTCm/wsAcj4tRxdDuJeZyBL1DtlV9Rr2ZK7wwDWyD/bbGVVUs56IImhZYFANkiqRXtef10yAPBkgvbw2F30xKQ+xjsxPrBQA6LzYkPgnGdO1Em4ALKQ0Mn7rordiPEjCpZl7jLCh5Js91iHuKN8mCAD+P0hFk6H4DrUBWtS3inFQqpC19fZjLzLXyn5yB//+9yb3FX8vMhGN0vOyQyIDZLZFUf+WBSyLJzIPCWga0hE87maVrOtozVj73F8Rk3j2lNHHLzGcfbNgAXF8WGjkmuxL2D9lkWPnUqqhSMnzDNW3GBNj0ortVhFcjJyLd+jf0+4PSpaGmjC+w0mEOB9Grz2Dh/pS3xdaQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 02.07.25 11:09, Lorenzo Stoakes wrote: > On Wed, Jul 02, 2025 at 11:02:21AM +0200, David Hildenbrand wrote: >> On 02.07.25 10:49, Lorenzo Stoakes wrote: >>> On Tue, Jul 01, 2025 at 09:34:41PM +0200, David Hildenbrand wrote: >>>> On 01.07.25 15:02, Lorenzo Stoakes wrote: >>>>> On Mon, Jun 30, 2025 at 03:00:04PM +0200, David Hildenbrand wrote: >>>>>> We can now simply check for PageAnon() and remove PageMappingFlags(). >>>>>> >>>>>> ... and while at it, use the folio instead and operate on >>>>>> folio->mapping. >>>>> >>>>> Probably worth mentioning to be super crystal clear that this is because >>>>> now it's either an anon folio or a KSM folio, both of which set the >>>>> FOLIO_MAPPING_ANON flag. >>>> >>>> "As PageMappingFlags() now only indicates anon (incl. ksm) folios, we can >>>> now simply check for PageAnon() and remove PageMappingFlags()." >>> >>> Sounds good! Though the extremely nitty part of me says 'capitalise KSM' :P >> >> Like we do so consistently with vma, pte and all the other acronyms ;) > > Don't forget pae which now means something different depending on whether you're > talking about x86-64 page tables or anon exclusive flags... :>) Heh, I don't think we ever used PAE in the src + git log when talking about PageAnonExclusive at least :) -- Cheers, David / dhildenb