From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E05EC433C1 for ; Fri, 26 Mar 2021 08:18:57 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 911EA61494 for ; Fri, 26 Mar 2021 08:18:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 911EA61494 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 152766B0036; Fri, 26 Mar 2021 04:18:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1027E6B006E; Fri, 26 Mar 2021 04:18:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EE3EF6B0070; Fri, 26 Mar 2021 04:18:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0228.hostedemail.com [216.40.44.228]) by kanga.kvack.org (Postfix) with ESMTP id D24AE6B0036 for ; Fri, 26 Mar 2021 04:18:55 -0400 (EDT) Received: from smtpin33.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 818EC8249980 for ; Fri, 26 Mar 2021 08:18:55 +0000 (UTC) X-FDA: 77961324630.33.4BB5FCC Received: from szxga07-in.huawei.com (szxga07-in.huawei.com [45.249.212.35]) by imf07.hostedemail.com (Postfix) with ESMTP id D9210A0009E2 for ; Fri, 26 Mar 2021 08:18:53 +0000 (UTC) Received: from DGGEMS402-HUB.china.huawei.com (unknown [172.30.72.60]) by szxga07-in.huawei.com (SkyGuard) with ESMTP id 4F6FDq6hbkz9tm1; Fri, 26 Mar 2021 16:16:43 +0800 (CST) Received: from [10.174.177.149] (10.174.177.149) by DGGEMS402-HUB.china.huawei.com (10.3.19.202) with Microsoft SMTP Server id 14.3.498.0; Fri, 26 Mar 2021 16:18:38 +0800 Subject: Re: [PATCH -next] mm/page_alloc: remove duplicated include from page_alloc.c To: Matthew Wilcox CC: Andrew Morton , , , , Hulk Robot References: <20210326025542.3565329-1-miaoqinglang@huawei.com> <20210326034208.GC1719932@casper.infradead.org> From: Qinglang Miao Message-ID: Date: Fri, 26 Mar 2021 16:18:38 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20210326034208.GC1719932@casper.infradead.org> Content-Type: text/plain; charset="gbk"; format=flowed X-Originating-IP: [10.174.177.149] X-CFilter-Loop: Reflected X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: D9210A0009E2 X-Stat-Signature: pcudgsmiwpdzmdmw5d4xzbh5bpq718yd Received-SPF: none (huawei.com>: No applicable sender policy available) receiver=imf07; identity=mailfrom; envelope-from=""; helo=szxga07-in.huawei.com; client-ip=45.249.212.35 X-HE-DKIM-Result: none/none X-HE-Tag: 1616746733-66127 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hey, Matthew Thanks for your advice towards hulk robot. We'd like to improve the=20 capbility of hulk robot whole the time. This patch is just a small cleanup reported by hulk robot, But the robot=20 can do more than this. For example, it finds crucial and useful bugs as=20 well. As for 'Untangle the mass of header includes' you mentioned, could you=20 please offer more details? Because I didn't find pagemap.h in=20 net/ipv4/tcp.c in -next like what you said. =D4=DA 2021/3/26 11:42, Matthew Wilcox =D0=B4=B5=C0: > On Fri, Mar 26, 2021 at 10:55:42AM +0800, Qinglang Miao wrote: >> Remove duplicated include. >> >> Reported-by: Hulk Robot >> Signed-off-by: Qinglang Miao >=20 > can't you make hulk robot do something useful, like untangle the > mass of header includes? For example, in -next, net/ipv4/tcp.c > has a dependency on pagemap.h. Why? > . >=20