From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 302CDC25B75 for ; Fri, 31 May 2024 14:02:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 681EF6B008A; Fri, 31 May 2024 10:02:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 630D86B008C; Fri, 31 May 2024 10:02:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4ABAD6B0092; Fri, 31 May 2024 10:02:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 2AF106B008A for ; Fri, 31 May 2024 10:02:25 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id D804F1A1737 for ; Fri, 31 May 2024 14:02:24 +0000 (UTC) X-FDA: 82178855808.30.9297F6B Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf26.hostedemail.com (Postfix) with ESMTP id 720DC140028 for ; Fri, 31 May 2024 14:02:20 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=AT4MM6mk; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=0OatNrvP; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=AT4MM6mk; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=0OatNrvP; dmarc=none; spf=pass (imf26.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717164140; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=EunJqT1CozKZdaI19g3ItEK6ri7ko98hSIo6nYBgiXw=; b=jQt/Mj/jOVli3R6kBlGzBKyctbrNtIhiFCjEJuwXl7SCHl/yLjPTzwitBMnw+nLcaJT0FM pIK6Xrn5bv0sH5TJDY0E+1Nibj2ef8xExBdhmDMKZh1+JUIP33SpYf4yHw0SgeUgT6hlsq snGqHs61tgMHAg4RR1XH5G8T9CbDeyo= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=AT4MM6mk; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=0OatNrvP; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=AT4MM6mk; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=0OatNrvP; dmarc=none; spf=pass (imf26.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717164140; a=rsa-sha256; cv=none; b=1fGNogqS/mZxcvh2oYUZFP8w6yCHVvO8/yBg9cT7nAqbI4//fQzgjrsMiNYyuZ9g3JqTbp f3zpBEE7b1h7DkL7v4T9hZxgeVhtGFWdH/JxyckVrp9SPR8IeMWCtbt+CAixLcdjHQpKSq O/nipoN4a0zZV36cD0Ft9YiocxKRzF0= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 7E4B11FB56; Fri, 31 May 2024 14:02:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1717164138; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=EunJqT1CozKZdaI19g3ItEK6ri7ko98hSIo6nYBgiXw=; b=AT4MM6mkrFGRgTvjdPm0WfO6+OHuwnnV3BCRL+3LGg9IecR2+aRKuYEdHCxARs8o6t4qSw c5lq+Hq0hbF3u2li954wIQ0UbSDYtdupjlMeo4ujW84itCqbj4vnnc62uUDAA+Uymq6Tio EcNeBy0bpiU+cG76GT+zopeEF9azpHQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1717164138; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=EunJqT1CozKZdaI19g3ItEK6ri7ko98hSIo6nYBgiXw=; b=0OatNrvPQP6EfRzNtg1LyryqxytsyF0GN3yLSMLNHl2W0DjM3rL5XAsfsKEHIGCZUKyAUO ptGjnjWPjP7eb+CA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1717164138; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=EunJqT1CozKZdaI19g3ItEK6ri7ko98hSIo6nYBgiXw=; b=AT4MM6mkrFGRgTvjdPm0WfO6+OHuwnnV3BCRL+3LGg9IecR2+aRKuYEdHCxARs8o6t4qSw c5lq+Hq0hbF3u2li954wIQ0UbSDYtdupjlMeo4ujW84itCqbj4vnnc62uUDAA+Uymq6Tio EcNeBy0bpiU+cG76GT+zopeEF9azpHQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1717164138; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=EunJqT1CozKZdaI19g3ItEK6ri7ko98hSIo6nYBgiXw=; b=0OatNrvPQP6EfRzNtg1LyryqxytsyF0GN3yLSMLNHl2W0DjM3rL5XAsfsKEHIGCZUKyAUO ptGjnjWPjP7eb+CA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 67D1B132C2; Fri, 31 May 2024 14:02:18 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id qKTGGGrYWWb3bwAAD6G6ig (envelope-from ); Fri, 31 May 2024 14:02:18 +0000 Message-ID: Date: Fri, 31 May 2024 16:02:18 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm: Reduce the number of slab->folio casts Content-Language: en-US To: "Matthew Wilcox (Oracle)" Cc: linux-mm@kvack.org References: <20240531122904.2790052-1-willy@infradead.org> From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJkBREIBQkRadznAAoJECJPp+fMgqZkNxIQ ALZRqwdUGzqL2aeSavbum/VF/+td+nZfuH0xeWiO2w8mG0+nPd5j9ujYeHcUP1edE7uQrjOC Gs9sm8+W1xYnbClMJTsXiAV88D2btFUdU1mCXURAL9wWZ8Jsmz5ZH2V6AUszvNezsS/VIT87 AmTtj31TLDGwdxaZTSYLwAOOOtyqafOEq+gJB30RxTRE3h3G1zpO7OM9K6ysLdAlwAGYWgJJ V4JqGsQ/lyEtxxFpUCjb5Pztp7cQxhlkil0oBYHkudiG8j1U3DG8iC6rnB4yJaLphKx57NuQ PIY0Bccg+r9gIQ4XeSK2PQhdXdy3UWBr913ZQ9AI2usid3s5vabo4iBvpJNFLgUmxFnr73SJ KsRh/2OBsg1XXF/wRQGBO9vRuJUAbnaIVcmGOUogdBVS9Sun/Sy4GNA++KtFZK95U7J417/J Hub2xV6Ehc7UGW6fIvIQmzJ3zaTEfuriU1P8ayfddrAgZb25JnOW7L1zdYL8rXiezOyYZ8Fm ZyXjzWdO0RpxcUEp6GsJr11Bc4F3aae9OZtwtLL/jxc7y6pUugB00PodgnQ6CMcfR/HjXlae h2VS3zl9+tQWHu6s1R58t5BuMS2FNA58wU/IazImc/ZQA+slDBfhRDGYlExjg19UXWe/gMcl De3P1kxYPgZdGE2eZpRLIbt+rYnqQKy8UxlszsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZAUSmwUJDK5EZgAKCRAiT6fnzIKmZOJGEACOKABgo9wJXsbWhGWYO7mD 8R8mUyJHqbvaz+yTLnvRwfe/VwafFfDMx5GYVYzMY9TWpA8psFTKTUIIQmx2scYsRBUwm5VI EurRWKqENcDRjyo+ol59j0FViYysjQQeobXBDDE31t5SBg++veI6tXfpco/UiKEsDswL1WAr tEAZaruo7254TyH+gydURl2wJuzo/aZ7Y7PpqaODbYv727Dvm5eX64HCyyAH0s6sOCyGF5/p eIhrOn24oBf67KtdAN3H9JoFNUVTYJc1VJU3R1JtVdgwEdr+NEciEfYl0O19VpLE/PZxP4wX PWnhf5WjdoNI1Xec+RcJ5p/pSel0jnvBX8L2cmniYnmI883NhtGZsEWj++wyKiS4NranDFlA HdDM3b4lUth1pTtABKQ1YuTvehj7EfoWD3bv9kuGZGPrAeFNiHPdOT7DaXKeHpW9homgtBxj 8aX/UkSvEGJKUEbFL9cVa5tzyialGkSiZJNkWgeHe+jEcfRT6pJZOJidSCdzvJpbdJmm+eED w9XOLH1IIWh7RURU7G1iOfEfmImFeC3cbbS73LQEFGe1urxvIH5K/7vX+FkNcr9ujwWuPE9b 1C2o4i/yZPLXIVy387EjA6GZMqvQUFuSTs/GeBcv0NjIQi8867H3uLjz+mQy63fAitsDwLmR EP+ylKVEKb0Q2A== In-Reply-To: <20240531122904.2790052-1-willy@infradead.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Action: no action X-Rspamd-Queue-Id: 720DC140028 X-Stat-Signature: h8r11m86gjau11qb3uhitg9utkzw7zfy X-Rspam-User: X-Rspamd-Server: rspam04 X-HE-Tag: 1717164140-264368 X-HE-Meta: U2FsdGVkX1/f0NNMNCkOwKv4FLkpJqM1miPISUpR925I6p1kwiB7pbpkaX4oy9BP/JDvVzMC84Z6WCd4uDfg+Bgv6oAqn8cT71muP0JARJtCJHXgh71D/iqWGJbMXsbdPXgoJw3pNqjgcKX/MV4YsPbw3Cz4h9zbFeSrsHpMocDH1Kg9v5swMfQonlIuEzWxQehJu7bIGHV0WuGw6enfeXb12JYwQJ5W4fghNAorWM+0zZnCuTLmZCxHvYN5uvJK0WEcx3NOMzdzjomR0KbM2sQWQioOzj0TDOlulIV1vEuO1BPryoyie3ANCzZrBq9h5gci8Kh6QDJibIs/23RSBr9ZcjxAVX2WvCS9WelKuaqPwM9TGG69yQ2xgZObDS7hVNva7ygpjGhJSNT9Q0R9OLWuRjZmc0d0MDb636dtcTr38k16ccRP6xdIbFZW2pqDmGx2/5ysbkPtsAeJu4ZcPczs5oOOc0VsBP48hH7cm1O9bv7u1MOVHzF4SIqHJQtNbWDTzIe5HOElfmA9K1SZN/LGobetX9Czr5I0i+eHlgoup5M0dXHSaZ24oMUUSZvqg0mXX4qpOxZiQl8Jv3EePSmEUdH/7OWZgmsxAMQo8djXjMvPT8KcJUSXoifgsThuZscEueHflYT6pdVcXfTREFdyDBl/YlPUEvshEEsO9gEW7M1ddG48SJc0LORDYEJLT1ilW53M1NODc8mFQzUNwDNysR8loI2jFQ/LfPP3PaoHJd5hy5oGPMJtXNgaGQ4pppsNmPW3KrTxnPTAI1B941Q9MZcPr5bnH1yQ26jiHXGdP2poGdPFhmp8YAkd8RDcuAVaVvso8pup+yj71HLfiGh0HHNhGAUw1+txKliQgZMl3XtIudvPu0rOMZNE/4y+FmYL1zoCK11fJK+nO4UYJfn2gHhurz0PJ8QcXQwPAzrthoWWnyzBNvxLCq1IUmbfL47HoBb4CJpJTWCLJis /uTCQyv3 MJcmYF2cbHVOH0ffyFelRPIlxS9Pta9e81fOfrm/rhtQsAPQcT8iGIIhpCE7xDHvpyJ7/5VFEqIpvxca2qHgKXPMRfqzFNFo6sdevjtbkEMWqavbSG0FxZ3+5fRvnRwaX1f1htMIcIL7sv8llRGUqdGjyg0HxSfqCy0nPoIMgvaqVpmJcWHVGL5yA8uHDLyjj0FkSdrzfLXUUEFS2hJAXug/E09V4IRd3pHEYTliXVK4k2gO3AYn+5Xx8QkIn8c5EwkNj3e3T0az9ELvvzZNAw0/6s3Sl00DKEwk3tlxbc78szmkcpCKvzshT6lnLwV9byFrO X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 5/31/24 2:29 PM, Matthew Wilcox (Oracle) wrote: > Mark a few more folio functions as taking a const folio pointer, which > allows us to remove a few places in slab which cast away the const. > > Signed-off-by: Matthew Wilcox (Oracle) Added to slab/for-6.11/cleanups, at least for now. If there's more incoming outside of slab that needs the changed stuff from mm.h, we might need to move it. Thanks. > --- > include/linux/mm.h | 6 +++--- > mm/slab.h | 4 ++-- > mm/slub.c | 6 ++---- > 3 files changed, 7 insertions(+), 9 deletions(-) > > diff --git a/include/linux/mm.h b/include/linux/mm.h > index a20a6be730a1..4bb841086438 100644 > --- a/include/linux/mm.h > +++ b/include/linux/mm.h > @@ -1105,7 +1105,7 @@ static inline unsigned int compound_order(struct page *page) > * > * Return: The order of the folio. > */ > -static inline unsigned int folio_order(struct folio *folio) > +static inline unsigned int folio_order(const struct folio *folio) > { > if (!folio_test_large(folio)) > return 0; > @@ -2148,7 +2148,7 @@ static inline struct folio *folio_next(struct folio *folio) > * it from being split. It is not necessary for the folio to be locked. > * Return: The base-2 logarithm of the size of this folio. > */ > -static inline unsigned int folio_shift(struct folio *folio) > +static inline unsigned int folio_shift(const struct folio *folio) > { > return PAGE_SHIFT + folio_order(folio); > } > @@ -2161,7 +2161,7 @@ static inline unsigned int folio_shift(struct folio *folio) > * it from being split. It is not necessary for the folio to be locked. > * Return: The number of bytes in this folio. > */ > -static inline size_t folio_size(struct folio *folio) > +static inline size_t folio_size(const struct folio *folio) > { > return PAGE_SIZE << folio_order(folio); > } > diff --git a/mm/slab.h b/mm/slab.h > index 5f8f47c5bee0..b16e63191578 100644 > --- a/mm/slab.h > +++ b/mm/slab.h > @@ -166,7 +166,7 @@ static_assert(IS_ALIGNED(offsetof(struct slab, freelist), sizeof(freelist_aba_t) > */ > static inline bool slab_test_pfmemalloc(const struct slab *slab) > { > - return folio_test_active((struct folio *)slab_folio(slab)); > + return folio_test_active(slab_folio(slab)); > } > > static inline void slab_set_pfmemalloc(struct slab *slab) > @@ -211,7 +211,7 @@ static inline struct slab *virt_to_slab(const void *addr) > > static inline int slab_order(const struct slab *slab) > { > - return folio_order((struct folio *)slab_folio(slab)); > + return folio_order(slab_folio(slab)); > } > > static inline size_t slab_size(const struct slab *slab) > diff --git a/mm/slub.c b/mm/slub.c > index 95e0a3332c44..b8ba068ca079 100644 > --- a/mm/slub.c > +++ b/mm/slub.c > @@ -962,11 +962,9 @@ void print_tracking(struct kmem_cache *s, void *object) > > static void print_slab_info(const struct slab *slab) > { > - struct folio *folio = (struct folio *)slab_folio(slab); > - > pr_err("Slab 0x%p objects=%u used=%u fp=0x%p flags=%pGp\n", > slab, slab->objects, slab->inuse, slab->freelist, > - folio_flags(folio, 0)); > + &slab->__page_flags); > } > > /* > @@ -2532,7 +2530,7 @@ static void discard_slab(struct kmem_cache *s, struct slab *slab) > */ > static inline bool slab_test_node_partial(const struct slab *slab) > { > - return folio_test_workingset((struct folio *)slab_folio(slab)); > + return folio_test_workingset(slab_folio(slab)); > } > > static inline void slab_set_node_partial(struct slab *slab)