From: "Jürgen Groß" <jgross@suse.com>
To: Baoquan He <bhe@redhat.com>, linux-kernel@vger.kernel.org
Cc: linux-mm@kvack.org, mhocko@kernel.org, david@redhat.com,
akpm@linux-foundation.org
Subject: Re: [Patch v2] mm/hotplug: Only respect mem= parameter during boot stage
Date: Tue, 10 Dec 2019 10:07:50 +0100 [thread overview]
Message-ID: <d3752014-9db1-9dc6-7268-b510a3dab553@suse.com> (raw)
In-Reply-To: <20191210084413.21957-1-bhe@redhat.com>
On 10.12.19 09:44, Baoquan He wrote:
> In commit 357b4da50a62 ("x86: respect memory size limiting via mem=
> parameter") a global varialbe global max_mem_size is added to store
> the value parsed from 'mem= ', then checked when memory region is
> added. This truly stops those DIMM from being added into system memory
> during boot-time.
>
> However, it also limits the later memory hotplug functionality. Any
> memory board can't be hot added any more if its region is beyond the
> max_mem_size. System will print error like below:
>
> [ 216.387164] acpi PNP0C80:02: add_memory failed
> [ 216.389301] acpi PNP0C80:02: acpi_memory_enable_device() error
> [ 216.392187] acpi PNP0C80:02: Enumeration failure
>
> From document of 'mem= ' parameter, it should be a restriction during
> boot, but not impact the system memory adding/removing after booting.
>
> mem=nn[KMG] [KNL,BOOT] Force usage of a specific amount of memory
> ...
>
> So fix it by also checking if it's during boot-time when restrict memory
> adding. Otherwise, skip the restriction.
>
> Fixes: 357b4da50a62 ("x86: respect memory size limiting via mem= parameter")
> Signed-off-by: Baoquan He <bhe@redhat.com>
Reviewed-by: Juergen Gross <jgross@suse.com>
Juergen
next prev parent reply other threads:[~2019-12-10 9:07 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-10 8:44 Baoquan He
2019-12-10 9:07 ` Jürgen Groß [this message]
2019-12-10 9:24 ` Balbir Singh
2019-12-10 9:34 ` Baoquan He
2019-12-10 9:36 ` David Hildenbrand
2019-12-10 9:37 ` David Hildenbrand
2019-12-10 9:41 ` Balbir Singh
2019-12-10 9:50 ` Michal Hocko
2019-12-10 10:11 ` Baoquan He
2019-12-10 10:21 ` Michal Hocko
2019-12-10 9:32 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d3752014-9db1-9dc6-7268-b510a3dab553@suse.com \
--to=jgross@suse.com \
--cc=akpm@linux-foundation.org \
--cc=bhe@redhat.com \
--cc=david@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox