From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9AEA5C5AE59 for ; Tue, 3 Jun 2025 17:48:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 109476B04D6; Tue, 3 Jun 2025 13:48:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0BAA06B04D8; Tue, 3 Jun 2025 13:48:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F39EF6B04D9; Tue, 3 Jun 2025 13:48:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id CF7F56B04D6 for ; Tue, 3 Jun 2025 13:48:22 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 82CB8160FA8 for ; Tue, 3 Jun 2025 17:48:22 +0000 (UTC) X-FDA: 83514823644.04.2128F3F Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf30.hostedemail.com (Postfix) with ESMTP id BE74B80005 for ; Tue, 3 Jun 2025 17:48:20 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=bZS9ofb0; spf=pass (imf30.hostedemail.com: domain of broonie@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=broonie@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1748972900; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=DL2IwZUKfXKmOZ6zLhmIr8RdtR8ty1qb9/ifCwXfpBQ=; b=PH2My+k6AYK2qAGm4hdldeHi2Sc6/ruOnReyV0L3PI/5/qf4BbX7CETnOYxpR/vkAYNBJr 55GcEhgW2oZUb2Sg3tZRlSLrPq0jMUGNrD6fAP9U511QCFtnNYH8eWmYncVNDBJohOQYGn pO2CT3Cois+xBz3O8IOdQmxb4lUT5vo= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=bZS9ofb0; spf=pass (imf30.hostedemail.com: domain of broonie@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=broonie@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1748972900; a=rsa-sha256; cv=none; b=aOJY5UzVwTbBg040mZmt2zTUWaMmxzIPqDkHVP9WdhMD1bK4AkQKYzaBHSM3tZ/jCI3DCX aL9bAAQB825ekrWDnhBfnMRagkr5lsollr8I3wk0UKQ1cva+Z5RnnNJLOMD2iGm2t1pSvt +UDbhObwWNMaj2UWRMtbNUF4wv2R8bw= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 0EFDF5C00A4; Tue, 3 Jun 2025 17:46:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 85648C4CEED; Tue, 3 Jun 2025 17:48:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1748972899; bh=/bJik437uCvG2J2xH49twy7gVaKeJgLVX8yKO4jtZdc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=bZS9ofb0NDaPjvezgv5QXCOt2mP/X2g1DEpaax2ccunqkgZnmUYy88EZfLl200LbJ qIUBgvy097dB1hP+/t0qK7Ja58+QAbwa34N4neFBKUC2OT9Jhe9Nr1j0xXJoXb0LUw I95vCMb6WkDNXBGB3i8TiQB25B9rsco/q6yJy68UEzabzB337gBeR1ZhBuyEDgFoXn jl9xbI4LELCe238jjInxcsx81oVqluL/afJ+z4R3Kma8cJWE0ER5R5xHRfjUmtv9Hi 9yuo7+ZzBLm7XZ57NYsbVRpAnNA0tnRHHHKxD9q8PAvH2ctgLE1FzuIVVJRcvjQQCk G1cNlJtk968qA== Date: Tue, 3 Jun 2025 18:48:14 +0100 From: Mark Brown To: David Hildenbrand Cc: Andrew Morton , Shuah Khan , Lorenzo Stoakes , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 3/4] selftests/mm: Report unique test names for each cow test Message-ID: References: <20250527-selftests-mm-cow-dedupe-v2-0-ff198df8e38e@kernel.org> <20250527-selftests-mm-cow-dedupe-v2-3-ff198df8e38e@kernel.org> <9961082f-848d-43d3-b97d-3df675ca4415@sirena.org.uk> <4676a010-a977-4d5a-b42a-edbbea7d356d@redhat.com> <27f74a9c-8bf9-4877-ba14-82dcd79f6d0d@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="Um4wpX+2twulJPeY" Content-Disposition: inline In-Reply-To: <27f74a9c-8bf9-4877-ba14-82dcd79f6d0d@redhat.com> X-Cookie: Avec! X-Stat-Signature: oh5qh8999nongquzrp3knwrk4ejf4sa1 X-Rspamd-Queue-Id: BE74B80005 X-Rspam-User: X-Rspamd-Server: rspam02 X-HE-Tag: 1748972900-437880 X-HE-Meta: U2FsdGVkX18kRBjNqkadbLfQRgG0LEF0o/wBQKaauac9wWqN+OvfeGVjGBLk/MtpQDPtV5d3tx1g9YBEmScJeswlSB0vI/HoHWY0hm7oO1Uw7x8lqmbR1oEgTjDbWSUNjyNFS+whqWPGyR9/0N8tw04hMbPmjkt4GVQvDsPF7u6qJh6AlbXwfrZqkVtvVule+0hV475gIViOMICVm9xU/DVeISrB1Guw0HEx0bO7LaisTWMTOT5GKaD/exq48vG2x3Zjum+aH+z4EqjCNhnQevK20l8Us+Og4hO979L4VbOZItPb5X/BdsJL/IazpQBhOqNN1699taCIuniErp61IKNsoh1HZPDjkmA/aDB6t1HRHFV8wczW73ktAMxb+J7cS6WbyWCpbLD3DirMyi02s8gNZXHTxUVlCx3XSPpI5sszSZGlB2rhG0IgeejSVQIz7P46tjxxpg+QhGbl5/6iAtjdbLc0zvqq20TIfZGFOR4xwI66k7lzotT7h3uhqXzm5o0n3eCzYQBoYwJTzf9oIkmYYruC3Ewo4XTLRRpnD0v/8lUSOJXSXVspfyvX0zcWGqNVS2sc+T9B5gFgAPH/HmcaxAr4PACr62cWDbrBlRmWohtc+AAoS5bp1QUymO6U4In/DG2eSFwytT2UiK0NuGLhX1XQHOKM8U+CyEvNxTHk+A4NWPpGh0hmworcl2nA54i56ad9l2LHh2Y5Bw2wqNR7wAtrbxO7IEKU+Ol6O2H/nORNCznynQ8hJAypQ98HyjWyduJBr1hJaznn3xVUSLFsYHbD6IIq4kzE+x3NtjF9yc0YrFplQqJ5AGNkqiO+S6YAJGdN8cSWK8UhL3SqvFQzwy5FFx/I9tWmmrRxztdYvpuNWwVE7L6CgMBY1UwBbO59ArZPejiUevhMLn+rtO0gM82VoKqtOEXeFjq9Ktn3w2/+jzRO4VLwFdGVe9OnCWMeKwce6wUowZUNEdN 70Hsv2vu xnzzU1mHCMHutHcF23d7M/TfVEDJHOlD78/i3Ft9cA/OhGNDpep+d9X/qU2wIwuelhtN2CbS9sXlhyuWuC781EYNhk8aGaNsAHT22N+CezUAt93NejN++f3uK0Gjn5BaWhKROooi1gaSD+R9fi4rhagPDvXr7+p6iKhNDpEQO/bnxV6IT8jTahqDz36a2oWO6aJ/RK2iOa2RYWRrENr7NuwvfJuqEbs4t1jvOSakjR2jBTpR1Jww5u3HCqo1RPrgxHRL7JvFKxyZYAElDpC2eiRDmRGWACLjPHGYFfGQbzZooYEtLzgHjVTwghQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: --Um4wpX+2twulJPeY Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jun 03, 2025 at 06:57:38PM +0200, David Hildenbrand wrote: > On 03.06.25 17:22, Mark Brown wrote: > > Like I've been saying this is just the final test result, in this case I > > would expect that for the actual thing we're trying to test any > > confusion would be addressed in the name of the test so that it's clear > > what it was trying to test. So adding "Leak from parent to child" to > > the name of all the tests? >=20 > I agree that printing something in case KSFT_PASS does not make sense > indeed. >=20 > But if something goes wrong (KSFT_FAIL/KSFT_SKIP) I would expect a reason= in > all cases. >=20 > IIRC kselftest_harness.h behaves that way: That's mostly just it being chatty because it uses an assert based idiom rather than explicit pass/fail reports, it's a lot less common for things written directly to kselftest.h where it's for example fairly common to see a result detected directly in a ksft_result() call. That does tend to be quite helpful when looking at the results, you don't need to dig out the logs so often. --Um4wpX+2twulJPeY Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmg/NV0ACgkQJNaLcl1U h9BEpwf6A29UZlTq8RsOX6S08/JBBgyWvxg5Nb4Q6Y18BqZ2o7rpodQ+A8CRQ337 VwySqLAvBK14tjny7z3LnB7KKZXcjLCGicuiCZuynUQMRx0O1to0eRSjdg58qMhx jY5e623v9gjH1Pq4g9/LlzEL6jznOSVywEUhA7FzFb6Nl1t71i2zTFSmraKdflYU GVXShtTmcs/nonWoglyLQJ5eWoftKee7zD+1DfgVNsbk+mlGV2USHK6sgbyjSFoQ /yn2EwEoLW8TLj3Bn1GPKd3Dd1keYnUBZhKIhcNVmgwr64fk6WsQ1sLu75HDgfJk bejoc6AuiGMtlinx2I2ckuxlCHywmg== =mrN6 -----END PGP SIGNATURE----- --Um4wpX+2twulJPeY--