From: Lorenzo Stoakes <lstoakes@gmail.com>
To: Matthew Wilcox <willy@infradead.org>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Baoquan He <bhe@redhat.com>, Uladzislau Rezki <urezki@gmail.com>,
David Hildenbrand <david@redhat.com>,
Liu Shixin <liushixin2@huawei.com>, Jiri Olsa <jolsa@kernel.org>
Subject: Re: [PATCH 4/4] mm: vmalloc: convert vread() to vread_iter()
Date: Sun, 19 Mar 2023 06:16:13 +0000 [thread overview]
Message-ID: <d3582147-707d-4d8d-b062-3de7aa898928@lucifer.local> (raw)
In-Reply-To: <ZBZ4kLnFz9MEiyhM@casper.infradead.org>
On Sun, Mar 19, 2023 at 02:50:56AM +0000, Matthew Wilcox wrote:
> On Sun, Mar 19, 2023 at 12:20:12AM +0000, Lorenzo Stoakes wrote:
> > /* for /proc/kcore */
> > -extern long vread(char *buf, char *addr, unsigned long count);
> > +extern long vread_iter(char *addr, size_t count, struct iov_iter *iter);
>
> I don't love the order of the arguments here. Usually we follow
> memcpy() and have (dst, src, len). This sometimes gets a bit more
> complex when either src or dst need two arguments, but that's not the
> case here.
Indeed it's not delightful, I did this purely to mimic the order of
copy_to_iter() and friends which place iter last, however on second thoughts I
think placing iter first would be better here where we have the freedom to order
things more sensibly.
I'll respin with a fix.
next prev parent reply other threads:[~2023-03-19 6:18 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-19 0:20 [PATCH 0/4] convert read_kcore(), vread() to use iterators Lorenzo Stoakes
2023-03-19 0:20 ` [PATCH 1/4] fs/proc/kcore: Avoid bounce buffer for ktext data Lorenzo Stoakes
2023-03-19 0:20 ` [PATCH 2/4] mm: vmalloc: use rwsem, mutex for vmap_area_lock and vmap_block->lock Lorenzo Stoakes
2023-03-19 0:20 ` [PATCH 3/4] fs/proc/kcore: convert read_kcore() to read_kcore_iter() Lorenzo Stoakes
2023-03-19 0:20 ` [PATCH 4/4] mm: vmalloc: convert vread() to vread_iter() Lorenzo Stoakes
2023-03-19 1:46 ` kernel test robot
2023-03-19 6:08 ` Lorenzo Stoakes
2023-03-19 2:16 ` kernel test robot
2023-03-19 6:03 ` Lorenzo Stoakes
2023-03-19 2:50 ` Matthew Wilcox
2023-03-19 6:16 ` Lorenzo Stoakes [this message]
2023-03-19 22:28 ` David Laight
2023-03-20 8:30 ` Lorenzo Stoakes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d3582147-707d-4d8d-b062-3de7aa898928@lucifer.local \
--to=lstoakes@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=bhe@redhat.com \
--cc=david@redhat.com \
--cc=jolsa@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=liushixin2@huawei.com \
--cc=urezki@gmail.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox