From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 66653C54E49 for ; Mon, 26 Feb 2024 01:11:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D802A6B0126; Sun, 25 Feb 2024 20:11:17 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D097C6B0127; Sun, 25 Feb 2024 20:11:17 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BAA146B0128; Sun, 25 Feb 2024 20:11:17 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id A7B626B0126 for ; Sun, 25 Feb 2024 20:11:17 -0500 (EST) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 48EB41605EF for ; Mon, 26 Feb 2024 01:11:17 +0000 (UTC) X-FDA: 81832176594.22.52B5268 Received: from out30-100.freemail.mail.aliyun.com (out30-100.freemail.mail.aliyun.com [115.124.30.100]) by imf22.hostedemail.com (Postfix) with ESMTP id 2B0ACC000B for ; Mon, 26 Feb 2024 01:11:13 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=RFp18SrC; dmarc=pass (policy=none) header.from=linux.alibaba.com; spf=pass (imf22.hostedemail.com: domain of joseph.qi@linux.alibaba.com designates 115.124.30.100 as permitted sender) smtp.mailfrom=joseph.qi@linux.alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708909875; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=jQ2dZcVJPaCKNom3iNa7RkigITsK151L7vDe+k/SP3A=; b=VuhxsZNFa+pIobTp0vySanG1PrSuyx9GHw59VoMIViKKqrLMhuhqwk05StnbMY9G1Is34K iVLviw8TJ0Qi7+OQuZolGXdILpkMl4RpSq5s5zrMTvDgPzxVV5E6tpZrDxq5T8/gnLqOGH osJ4guxDkS3XOijkdfHIWvcxksfcDqE= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=RFp18SrC; dmarc=pass (policy=none) header.from=linux.alibaba.com; spf=pass (imf22.hostedemail.com: domain of joseph.qi@linux.alibaba.com designates 115.124.30.100 as permitted sender) smtp.mailfrom=joseph.qi@linux.alibaba.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708909875; a=rsa-sha256; cv=none; b=dFZvSvcMQiniQsCiLRkjvzi0Vjr3B6qzzamZ/t5yg4/ry8GP8Dh+rARanRj2ozdJvvzwzo WgFuUP5gBhjBML/XqUCzkoCAMmHqG1AYgBioTc/7WTHKA8DtAOFxWTNSHYwIVQ6VlTaKkm /8IYZKZ4q3bgP2scmk7g/rfJ56zsw1k= DKIM-Signature:v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1708909871; h=Message-ID:Date:MIME-Version:Subject:To:From:Content-Type; bh=jQ2dZcVJPaCKNom3iNa7RkigITsK151L7vDe+k/SP3A=; b=RFp18SrCaG8dEabF2MxMMANgXTciIwTDHl7LUaieMOTw8BJMjxXPjOXzeyIFs3xYOQcj1kbuH+qA3qo1Xwbhp9XcSVEgg8vkGQR5DXUtDa46bB4Y4Y0b5iuXzOv8yVhnpSmYeWd/8QMtGe9VDo8Z8mp5ak8+4FE2/ZY1G8l8TZ0= X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R211e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018046060;MF=joseph.qi@linux.alibaba.com;NM=1;PH=DS;RN=16;SR=0;TI=SMTPD_---0W19okBT_1708909869; Received: from 30.221.128.188(mailfrom:joseph.qi@linux.alibaba.com fp:SMTPD_---0W19okBT_1708909869) by smtp.aliyun-inc.com; Mon, 26 Feb 2024 09:11:10 +0800 Message-ID: Date: Mon, 26 Feb 2024 09:11:09 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] ocfs2: remove SLAB_MEM_SPREAD flag usage Content-Language: en-US To: Chengming Zhou , mark@fasheh.com, jlbec@evilplan.org, brauner@kernel.org, jlayton@kernel.org, keescook@chromium.org, akpm Cc: jack@suse.cz, zhouchengming@bytedance.com, azeemshaikh38@gmail.com, ocfs2-devel@lists.linux.dev, linux-kernel@vger.kernel.org, linux-mm@kvack.org, vbabka@suse.cz, roman.gushchin@linux.dev, Xiongwei.Song@windriver.com References: <20240224135008.829878-1-chengming.zhou@linux.dev> <34678776-859a-42f2-802b-0c7bc90bdfdc@linux.dev> From: Joseph Qi In-Reply-To: <34678776-859a-42f2-802b-0c7bc90bdfdc@linux.dev> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 2B0ACC000B X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: myu5y97h31ih73xbms67cqzkbnktmcsf X-HE-Tag: 1708909873-185884 X-HE-Meta: U2FsdGVkX1+EmVr5BSyo3cYEa2cX8YosOPpJxBuBvQ9I5IErZ10uHA2MDqWXvJ8MoAXXHz1D5yLystxpdE2bTv2q+B1tJC0WzC4kAWIgLVs2U5lPRTejjiIx/c+8hgTc9rhJTXsQWHnk7qGmhQi8PQoWzHI3Iv36VibUU7XqneT494aLE8N6ckkUYwmu+nikrgMp+63TwCelzJlxY3zLoST2xA/YLNpUJeLCKwyloFwfgxta26lR2/QaZ5AUVEES9sx6NFDScEcrQN0nrqjI8b/PcCHO7oORkgzfcuYxhBZ2odPNLE/Wm/6fga+aFJqO8hUPiOTSBG7KrqSxLCmTI5VGF1ML057PJlfUZ8jdqdtQ9cbf89E8NY+8XG6Fd8PeLLln7v+VAYLdE2Un7GLxWSCJ0ljynWvofwcj1mPCntFOoo+BuXCzT7dVmLjQ3/PJ8gE+IqL2Z5yl7cIrr1RfFf+jUnDUlr1PN8eBISkH7MzBo0jv2ySH70MpMyrOqJPIij6lx+uRHYiehZN4Gd0W9geBB1oVxlyglRANBsqkWOf4jUXSlAdnysy36Uy/1vn9pe4VFWd9ZCHkWguOqaiByPS1k4CcFFcMaWgtHfd0zrnetJFHxM+q91Mu7gZvCacRr3tsd4DSuY6P16Oc7kaHTjBb5wuXzgKzfm09jCwbkHi5tBCguccAvc8yraaq/xECnSPNz2vXStmGnPOghA74I87vLhafIB+6IjHQdUmIimEz0J8a2igjxgsxI8ntjawuPbkP7/OJsn2LfzIGmCj0iIgtDnU24Qnn4PBgOUCfcI0qqdp6rRnLDk+85P1UIPgG/bHmFIEuur3YRUa/XWkFU5Swlda81mCXc1ER6e9aDFbcN761uDT8vUe1YMt1b/FP75EaL6Ph3C1WP3ERlfNynjw3m/XkkQ578K4dSk8b7bR22IZpXXRkSIscBITknq9UMome1FtWJNEjAmtSdbt G2g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2/25/24 9:02 PM, Chengming Zhou wrote: > On 2024/2/25 20:20, Joseph Qi wrote: >> >> >> On 2/24/24 9:50 PM, chengming.zhou@linux.dev wrote: >>> From: Chengming Zhou >>> >>> The SLAB_MEM_SPREAD flag is already a no-op as of 6.8-rc1, remove >>> its usage so we can delete it from slab. No functional change. >>> >> If I understand correctly, you are referring the following patch: >> https://lore.kernel.org/all/20240223-slab-cleanup-flags-v2-1-02f1753e8303@suse.cz/ >> >> But it seems that the above patch is not included in mainline yet. >> Or am I missing something? > > I realize my commit message should explain more why it's a no-op, my bad. > > The SLAB_MEM_SPREAD flag used to be implemented in SLAB, which was > removed so it became a dead flag as of v6.8-rc1. That series[1] > mark it obsolete to avoid confusion for users. So here we can just > remove all its users, which has no functional changes. > > [1] https://lore.kernel.org/all/20240223-slab-cleanup-flags-v2-1-02f1753e8303@suse.cz/ > Take more look at v6.8-rc1, I've found the following commit: 16a1d968358a ("mm/slab: remove mm/slab.c and slab_def.h") It seems that after this commit, there is no user of 'SLAB_MEM_SPREAD'. So, Acked-by: Joseph Qi