From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5682CC369C2 for ; Tue, 22 Apr 2025 23:59:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A86986B0005; Tue, 22 Apr 2025 19:59:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A358E6B0007; Tue, 22 Apr 2025 19:59:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8D54A6B0008; Tue, 22 Apr 2025 19:59:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 6F1916B0005 for ; Tue, 22 Apr 2025 19:59:06 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 659671222D1 for ; Tue, 22 Apr 2025 23:59:06 +0000 (UTC) X-FDA: 83363348292.28.5EC95E9 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf04.hostedemail.com (Postfix) with ESMTP id F220340005 for ; Tue, 22 Apr 2025 23:59:03 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=d9IrLbm3; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf04.hostedemail.com: domain of llong@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=llong@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745366344; a=rsa-sha256; cv=none; b=Nv74zJthZl7lAJn45wgvXk+nSPN1XMEKZf5em6+0kxanor8TLs5IE0sQDlOdcVyO4seVsO QqeCnfEddNeq5pHcw683hEOMG/QR4AqF4tdYz9/gJ8DTu1VJwqxsm56235bLfwWa9cUbh9 Kyrjnr6n4mS+lbT/FI86xJuJAMmiQtM= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=d9IrLbm3; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf04.hostedemail.com: domain of llong@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=llong@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745366344; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=63HEfvI0xRJFn4lxbujdZVDH/3cOldCuAF+EjtzBudU=; b=F3rjjihXLhYG5TTYXAyHH7JlxrZ1aKvfQgKCvTQrlxCSFfyLv4uO8OGF6oNkrY9/ge4Vj2 ETmckyjbmEh5fg0lVNopDUadF9E/ZNoI/nFehnwLtsBX+AStcsV7Jlq3FsKreEjrM4l024 oUS7owfBA1K9Bp6GBX5g3zk/LQY3SJY= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1745366343; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=63HEfvI0xRJFn4lxbujdZVDH/3cOldCuAF+EjtzBudU=; b=d9IrLbm3FnK9nCmQgt+LrG7QOgqH4+CBHExyp6wZKb6u/MPLNwFO1ZSSYuJ9GG9jKXX+h1 iy/yKip2UK56TiVV/zBF8iCEuZ95pDQihQ6BTCG9BLNgI/SftDP9jiQqcDKAxjg481uqqD yaqx+1JJkZFE3IaCquiv+fp/xstB3ms= Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-646-dGou3CRMOiCSOYlYuBgleQ-1; Tue, 22 Apr 2025 19:58:59 -0400 X-MC-Unique: dGou3CRMOiCSOYlYuBgleQ-1 X-Mimecast-MFC-AGG-ID: dGou3CRMOiCSOYlYuBgleQ_1745366339 Received: by mail-qv1-f70.google.com with SMTP id 6a1803df08f44-6e8f9450b19so9892806d6.1 for ; Tue, 22 Apr 2025 16:58:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745366339; x=1745971139; h=in-reply-to:content-language:references:cc:to:subject:user-agent :mime-version:date:message-id:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=63HEfvI0xRJFn4lxbujdZVDH/3cOldCuAF+EjtzBudU=; b=wqknvbeX1c5DJOk74Ms5ZhWIIMZStHlF8U8Ld6BFIfeg7KNfbVW8B7zpmjqa2d6eqe ykdWNzkE7H3BvOJtm1ZogWUedYOwFQr75ajwIH9e87WAv7XLtGYXsEFsaFVNLOxYv7mP RxVfjyJV76Ok63pAPnpHkzO03WL3B8tee6fb29uL61rYmlY76YqWfKoeHM6ZaT3meEL0 JB/IKKUWXl3d5en/5NwYaw7UT+M5f/38YStQv/0VKyRBj6jTW964b8kxblupfK5666/H CLu5yVr0ssrbLu+H1Dk7qhJNn6TttKiVPS4dDNyuvq44cSbMWI+7oosB3DTcRTqKAh9Y Pk+w== X-Forwarded-Encrypted: i=1; AJvYcCVoZH2ZNRJaYheHfBkqU7MF6RJ0ybS9AHh396GNVeGKzp14p+487+39GPLkHNcPMztLCkpKzDkVig==@kvack.org X-Gm-Message-State: AOJu0YycOBWk/XvS1cWQcf4UrT/0n8AvkoGJ50KW6c0YoLJdD4LfLyae 6Mm+AWsJh1IPq5l+OtFBMdsRO7yVM+aXCV2cyGjlAvR50J5xbRLIYRJDjbUBlWgTDqJJBifM61O 8v1F9eLREqS+C5VAtCeEFJVenp6Yx5oX/Ak2UklXtBo5n8Qaq X-Gm-Gg: ASbGncv4iq/x4ntPbakWuPyON1Yk6cpXrp49KWSdhddlbXyZw3TAAbsSi2W3UqvH++1 Wo5f39Y/9/u4FJdfW5M08xZ5NREJc0jSzxc/u1tl5NOoVX3yp/C0os8s7n7n8+uuFUWtLBWUoVm +GVNU8azKMb/yTnR26xvgEp83KFmVdpADYkhapRsbSs/GTtFdomFet8JS8zLiOiIBaKHdbBoAWM 5Dy28fB50tV2EkHe7AmdInDLPD6eGq9NX4wSM9jR2sQxK6daSuwJlxy+M/CJPHjfv1yUubkRcmh xcjZ9EOJZY1c8JYCwdDnNPjddUnBYhjW8ME13ZlJQqgUxQ7A57PRi1wwWA== X-Received: by 2002:ad4:5be4:0:b0:6e2:485d:fddd with SMTP id 6a1803df08f44-6f4b49e402dmr17459586d6.1.1745366338755; Tue, 22 Apr 2025 16:58:58 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGAmUdo/7mYHVUzu0jQXpwABcFGHAhb7qRsbzLtSN07AFSPMdEN6oHzMVC9yFTjLrJc3wMMzw== X-Received: by 2002:ad4:5be4:0:b0:6e2:485d:fddd with SMTP id 6a1803df08f44-6f4b49e402dmr17459386d6.1.1745366338419; Tue, 22 Apr 2025 16:58:58 -0700 (PDT) Received: from ?IPV6:2601:408:c101:1d00:6621:a07c:fed4:cbba? ([2601:408:c101:1d00:6621:a07c:fed4:cbba]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6f2c2c21d9bsm63217866d6.96.2025.04.22.16.58.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 22 Apr 2025 16:58:57 -0700 (PDT) From: Waiman Long X-Google-Original-From: Waiman Long Message-ID: Date: Tue, 22 Apr 2025 19:58:56 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 1/2] selftests: memcg: Allow low event with no memory.low and memory_recursiveprot on To: =?UTF-8?Q?Michal_Koutn=C3=BD?= , Waiman Long Cc: Johannes Weiner , Michal Hocko , Roman Gushchin , Shakeel Butt , Muchun Song , Andrew Morton , Tejun Heo , Shuah Khan , linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org References: <20250415210415.13414-1-longman@redhat.com> <20250415210415.13414-2-longman@redhat.com> <0033f39f-ff47-4645-9b1e-f19ff39233e7@redhat.com> In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: _fQC2fIG74esXjovs8xcyiGN3qKGNXEi0OULTSG3tTQ_1745366339 X-Mimecast-Originator: redhat.com Content-Type: multipart/alternative; boundary="------------MC9kfMGxJNphBn9XIMGeM0dK" Content-Language: en-US X-Rspamd-Queue-Id: F220340005 X-Rspam-User: X-Rspamd-Server: rspam07 X-Stat-Signature: s65wbfogsshhro9cq1h86onmzyjsyezm X-HE-Tag: 1745366343-291514 X-HE-Meta: U2FsdGVkX1/WlIFyNDXG0I3yxScNdw/liPbHo92Nbkkp9ZEkYaIlH5IDHzh14D3nI3v2ZSsuzuL2Bbq7+DtOapbjQ4Hd5xWsJ07dJAkbJv63Za8ljpMN8GFhSKTMmHONv1E4EKGC3RQ8elILqXRgx5rWk0xshotEJa0sA+XElHJ/NPiPhJOU90cH0mQc3zcNsZmKv7rE2TQHwgpGhJwaMbciNAx+ZPC/YObOYlDyc/7PA6CitU6ecViJ7jPz+BKHNQWg4BQQgfULWjripwhcffLfUKRA48O6+r7OxA/YIsCFpejNPk5FaQBfLvQaC3wq1hORkMqubKbuwu8nws4dRTAWRIdC0RvqlRTPpUVCOi8/mJmhXoq6mjSkhSMAKrrPl2/c6XuOkTlQhj6llXqg59ZoobCOe99NAN54JWgLzSmPuUJYLg20PIxWnGE3rhDcJd9XmFxmMP/MP88vL5rcM4CvGq67tUtaAe5Z/c/nwVbhInquKF2Jsr1xzSjwEn5xer2OuhduaK/dFqpFoz9oDLzV0FXt1BHOOfBkkHnV76hiegHrELukSt4uNdRYNTGnesw66Lj18xPos17tMEHhKES1LfAV26gHTFvymUrwnAP+L+vsAnP2Ux/l2Sh2ufNskixl9z8N0QCYQCByoT7N6BJdO2twCYi72ktbTJwlEh1o5aN7msWEt5w6SCDs5wz2JNW9/36FSnVYLTiG/vx9oK03yIcf7K6apJ/gWz2XbP58cyGUjCKy01UVeF5INJSJSQ5ovZrILCS05ZcUfuoAched4PvZfDj7aFEcQmaJ8WdtJTwmYSjHzkn3iGsuWfkMDqUlU8Q1hpkjF9BWg7NV9oo2wOACLQj0QsqtX/yVD8vwBhUGTBamnvnRqyoYQ/D6EHiIlX81EjVaIqx4aHbaol8x946hTSx3ImlyLGE6B46Jt9eyFU2bORomfPw9Hs5dK75/qfcikbzfbwHrXnJ AsCfiyVP fpZ/DX3JijJWTFkzktC3JZqjkJyxBakWHzBY7S5tkhF4Z2RkoJPJkwhkaS0hZmmIDStpJ+25LBo49TfWuI1jgIp6mYYmJGsgFSYQGwYABNp12fgbSv0H8LPuZxqmoknoC4RYkUV6b9rA4nf+ykZ7HEajPtOQihosbf3LurFb1IZ5uoAaw0V8thTwvTlwUAnOk6uMVS/FgXPxf/lF7t5svt5HUzb1ei6REwprKE006xE8LTrZ58D3fmM6QVgySt9jVkdlxYySi3QrC+K76XEKJHBECS/ooRsAQMDdj4dDKQm4EE8VDglUQbhj2sni1u+0QDEos5kLu97vG9FxYy6XJ/rBv2Fu/CPCenpYyEF3dfN1Ug3mR+aJfOryXN0r+6Kae6HFjrsCOElXcv3bQsw5WDFDDZLJkI5MrhjVTMYGpfoOKp1frZ2RZOX9UhtejmZ8AwE7JI3hyFMAYko/AZ8xuI0bkBcGJzX2zkdyeJ7Z1bXSf0JT296/ug5vGIyzLZYutEnG7Gb81r7UVza7NZrZfVaD/FbSVZIp6S6f/lDlolfxHJt6Pfc4+6VYrXrzR6efxRaJjeFxZtsFsmQ/CGDJ43TXVN93Pxxn530jALhH15x9r3tAmd/QgKb5yVkwpR5mr7M1Vh0F/j8qzplWqL9AATMg+sA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: This is a multi-part message in MIME format. --------------MC9kfMGxJNphBn9XIMGeM0dK Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 4/22/25 8:11 AM, Michal Koutný wrote: > On Sun, Apr 20, 2025 at 05:48:15PM -0400, Waiman Long wrote: >> I was referring to the suggestion that the setting of memory_recursiveprot >> mount option has a material impact of the child 2 test result. Roman >> probably didn't have memory_recursiveprot set when developing this selftest. > The patch in its v7 form is effectively a revert of > 1d09069f5313f ("selftests: memcg: expect no low events in unprotected sibling") > > i.e. this would be going in circles (that commit is also a revert) hence > I suggested to exempt looking at memory.events:low entirely with > memory_recursiveprot (and check for 0 when !memory_recursiveprot) -- > which is something new (and hopefully universally better :-) Ah, you had done a lot of work for the test_memcontrol selftest. Am I correct to assume that the purpose of 1d09069f5313f ("selftests: memcg: expect no low events in unprotected sibling") is to force a failure in the test_memcg_low test to force a change in the current behavior? Or was it the case that it didn't fail when you submit your patch? Cheers, Longman --------------MC9kfMGxJNphBn9XIMGeM0dK Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 8bit


On 4/22/25 8:11 AM, Michal Koutný wrote:
On Sun, Apr 20, 2025 at 05:48:15PM -0400, Waiman Long <llong@redhat.com> wrote:

I was referring to the suggestion that the setting of memory_recursiveprot
mount option has a material impact of the child 2 test result. Roman
probably didn't have memory_recursiveprot set when developing this selftest.

The patch in its v7 form is effectively a revert of
	1d09069f5313f ("selftests: memcg: expect no low events in unprotected sibling")

i.e. this would be going in circles (that commit is also a revert) hence
I suggested to exempt looking at memory.events:low entirely with
memory_recursiveprot (and check for 0 when !memory_recursiveprot) --
which is something new (and hopefully universally better :-)

Ah, you had done a lot of work for the test_memcontrol selftest. Am I correct to assume that the purpose of 1d09069f5313f ("selftests: memcg: expect no low events in unprotected sibling") is to force a failure in the test_memcg_low test to force a change in the current behavior? Or was it the case that it didn't fail when you submit your patch?

Cheers, Longman

--------------MC9kfMGxJNphBn9XIMGeM0dK--