From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02B08C3DA63 for ; Tue, 23 Jul 2024 03:24:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8AAF86B0089; Mon, 22 Jul 2024 23:24:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 859786B008A; Mon, 22 Jul 2024 23:24:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 721A06B008C; Mon, 22 Jul 2024 23:24:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 556B06B0089 for ; Mon, 22 Jul 2024 23:24:32 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 11E20161BEB for ; Tue, 23 Jul 2024 03:24:32 +0000 (UTC) X-FDA: 82369574784.09.C562C21 Received: from szxga07-in.huawei.com (szxga07-in.huawei.com [45.249.212.35]) by imf21.hostedemail.com (Postfix) with ESMTP id 9E7411C0009 for ; Tue, 23 Jul 2024 03:24:28 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=none; spf=pass (imf21.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.35 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721705023; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LRJ+IbtJmkuSqs07ogpRgOD93h3139oWP3wciVMyifI=; b=Yn73XPMD9xat0H5lLFpp1eVUN5nKhJr51f4kDIXWo5zZeEekGRiKigIYD0JTwzjkMh2gEC v6JE9n7Zo3hOcirXh6h6zD5IoYsyVgIB/gJGU/u76YA/Rs9sQbvr6uWCr90QdxVbdUTtyn OiQHz/LfElUFhrCVr3iVA7hTHo619W4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721705023; a=rsa-sha256; cv=none; b=LzapMzzeKJzl7w2t87n3mvZ9jrPta3esHornrUNdaREr/SyNJX9mrRsxkEILjQbnZdqYzY Rzq6DHJutfe7ju+FGH8MzWlDzInBPm2LJoLr+ItLKhu3QQVZpkYCH/uV0a6XbVhlutq9SV h5flZg8zskYAwNilXk/NNmZk7kAFVEE= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=none; spf=pass (imf21.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.35 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com Received: from mail.maildlp.com (unknown [172.19.88.163]) by szxga07-in.huawei.com (SkyGuard) with ESMTP id 4WSj7h2QvBz1X4fJ; Tue, 23 Jul 2024 11:20:00 +0800 (CST) Received: from dggpemf100008.china.huawei.com (unknown [7.185.36.138]) by mail.maildlp.com (Postfix) with ESMTPS id 62D14180028; Tue, 23 Jul 2024 11:24:24 +0800 (CST) Received: from [10.174.177.243] (10.174.177.243) by dggpemf100008.china.huawei.com (7.185.36.138) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Tue, 23 Jul 2024 11:24:23 +0800 Message-ID: Date: Tue, 23 Jul 2024 11:24:23 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 3/3] memory tiering: count PGPROMOTE_SUCCESS when mem tiering is enabled. Content-Language: en-US To: Zi Yan , Andrew Morton , CC: David Hildenbrand , "Huang, Ying" , Baolin Wang , References: <20240722172917.503370-1-ziy@nvidia.com> <20240722172917.503370-3-ziy@nvidia.com> <5230d72e-81fa-4ef1-b386-90bd3b06bf0e@huawei.com> From: Kefeng Wang In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.177.243] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To dggpemf100008.china.huawei.com (7.185.36.138) X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 9E7411C0009 X-Stat-Signature: 8cd37t7zski3bu1xzf8cxr83ogbx6rsx X-HE-Tag: 1721705068-709330 X-HE-Meta: U2FsdGVkX19F8CGFUiO1Sxz9qEZK+6oGFdaiZ80ssIYotILHrbaT/IcE3Ra+rFKbCY0PTq0W+OtjTjSEg2a5PhzJIgHeQKzmqtYldMQ2xKjlQRY6DUMsw0XGi1YnaXfeP5x8en42LF5w+0+cbJM/ZY4bJDpzeM8xqU6bwUnNZGQohfAlCJqOtWeVWpfKjepppM1vHpMZopmXqUnt1SUqsvyqgzhg5adccTG0AaZlydtp/vFW3ZWPWx48CdLu+nlcaNwS801rzTLX2fwdiq9ZShHb9C8HFUqksBpDQlkavkOPJZ2VTQnSY/Tyx8SwuQrA5bqCqyyBWjwYWhYUa4hLOWkFlZpAtnmjcdVjOlmAj6pPw9MzWqsyhacwGuhVGudwxaKNNS6Yqk/Wx5Q6IGdX+TrhuToCJkURTsG+bEb92z0arnFfqnUhyc9w7rt9NqDF/ufhvOUtGcLMR+aeks4RV40NjE3cWptx2woIG0ic24ixNqUXKqL4rs5RK/ysPKPKhm93mkl9i5dAFrvoeYAzSD2EA1hHrTOE5qXqDl5CXL5Mn0cm6mK5dYH8FbNjzWLKPyTnX7lwogpegvOf1rQHa9oV+LrJb25OjOKyjPRe4dstRNQdFgmQ47uUMWBA3/U+Z85SWL99j7+tw1mqdEnga0Pj2RuU8+THWUBQs7Y0KUlZ9HSzH+kLjQZ8jUyQlJG/Sk3dEdVOP/rgcdXgJdxJsDoZO6OGsvf3fr/QN2J+xGcDazt8EBt1N0s/JAX68gQRZJvvUv/GBmfhWwGG7mSDvgC2BPRrjNmlKZ3wA7jYlZ4+V506vFCM3C2jy8Ta/D2HCLKrxTl/ljZUVXeuvfdFiVBYRLx1YfPzGzLKVYROWZjiQacXXhZacwWIs829CtBAZObXqilgfKTfZ9HVnydf9hGoZu9ew7uyl28EMirOLL3MuvAd93MbqUkus+5ACpiYiox2LamgtP1YdyWxdZJ JTaVx69Z 5gQbixJtNtA2+vZK47Ah7WDr5/cOWBGQRA1oAsuq51JJ0BlLC2KCRzTfvXofBlUsVfKmH5nbKUW/Hvof8fwrHzhbJRk8Ixo5Vw2YKyAyXGIVF+PU61E60HIH0rDJj9PVFL84XJyIulQIuq6EI+P9Qi80EegfJ5x8GrDTyKQnSu6Def0KC4V4frVSg7dGPiedmpj1UKbcMlqBJQHvWF0MCWQNgEXw4oZEq0mUi+Y8X4JyjBbziX1BiHYgNhsLATLWEr5AXZctiGTt0sIHTQZ8yz1W77sVWAoXxHh5NF1+FZUBmtV7Wq897XxKf2h8Oyam7aR6z X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/7/23 9:54, Zi Yan wrote: > On Mon Jul 22, 2024 at 9:48 PM EDT, Kefeng Wang wrote: >> >> >> On 2024/7/23 1:29, Zi Yan wrote: >>> memory tiering can be enabled/disabled at runtime and >>> sysctl_numa_balancing_mode & NUMA_BALANCING_MEMORY_TIERING is used to check >>> it. In migrate_misplaced_folio(), the check is missing when >>> PGPROMOTE_SUCCESS is incremented. Add the missing check. >>> >>> Reported-by: Kefeng Wang >>> Closes: https://lore.kernel.org/linux-mm/f4ae2c9c-fe40-4807-bdb2-64cf2d716c1a@huawei.com/ >>> Fixes: 33024536bafd ("memory tiering: hot page selection with hint page fault latency") >>> Signed-off-by: Zi Yan >> >> Reviewed-by: Kefeng Wang >> > Thanks. > >>> --- >>> mm/migrate.c | 4 +++- >>> 1 file changed, 3 insertions(+), 1 deletion(-) >>> >>> diff --git a/mm/migrate.c b/mm/migrate.c >>> index bdbb5bb04c91..b819809da470 100644 >>> --- a/mm/migrate.c >>> +++ b/mm/migrate.c >>> @@ -2630,7 +2630,9 @@ int migrate_misplaced_folio(struct folio *folio, struct vm_area_struct *vma, >>> putback_movable_pages(&migratepages); >>> if (nr_succeeded) { >>> count_vm_numa_events(NUMA_PAGE_MIGRATE, nr_succeeded); >>> - if (!node_is_toptier(folio_nid(folio)) && node_is_toptier(node)) >>> + if ((sysctl_numa_balancing_mode & NUMA_BALANCING_MEMORY_TIERING) >>> + && !node_is_toptier(folio_nid(folio)) >>> + && node_is_toptier(node)) >>> mod_node_page_state(pgdat, PGPROMOTE_SUCCESS, >>> nr_succeeded); >> >> The should be in advance of patch2, and change above to use >> folio_has_cpupid() helper() too. > > It shares the same logic of !folio_has_cpupid() but it might be confusing to > put !folio_has_cpupid(folio) && node_is_toptier(node) here. folio's > cpupid has nothing to do with the stats here, thus I did not use the > function. If folio don't include access time, we do migrate it but it isn't a promotion, so don't count it, other comments? PS: Could we rename folio_has_cpupid() to folio_has_access_time(), even without memory_tiering, we still have cpupid in folio, right? >