From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76993C25B76 for ; Wed, 5 Jun 2024 14:28:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D7DE76B008C; Wed, 5 Jun 2024 10:28:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D2EBF6B0092; Wed, 5 Jun 2024 10:28:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BA7EB6B0093; Wed, 5 Jun 2024 10:28:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 9AA286B008C for ; Wed, 5 Jun 2024 10:28:38 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 2A523A148E for ; Wed, 5 Jun 2024 14:28:38 +0000 (UTC) X-FDA: 82197065916.26.293FEF2 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf03.hostedemail.com (Postfix) with ESMTP id C718D20002 for ; Wed, 5 Jun 2024 14:28:35 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=dJq4E3AP; spf=pass (imf03.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717597715; a=rsa-sha256; cv=none; b=p76daNe7x9ImJYIDHs/vNLQ2keWgzsokwfXaTkRFRGZiPDiXnVNW4UAb1RAWZd7zYpAsSL a0s+Ba36cpz71jBHOul2ImwfHkckjBy6XwWvshBOylheU720pMPeehNe39RJeQD723208a GVaHUkyOwZXi+eHYmQ5SvR6jBq0OK8E= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=dJq4E3AP; spf=pass (imf03.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717597715; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=VxIffXnjUYvHBO052LXyySGWsjqpIrP39OP6YN4p2SI=; b=PZmYyxLZuQkhIgvTXgBHmbKnqJUZGyrFWj5kBKHqFz+9wv2mzALNlMjMa/bY395luMvcEB 8NUdsFGYvF0lXfVGMK4cdzrFhcogB2lIVodfWsoYmf7FKp65ZKh3J6X4geaVnZ5utdv7J8 dcjsx6L+jwW+dG02vGfCbBT8cEYBEWQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1717597715; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=VxIffXnjUYvHBO052LXyySGWsjqpIrP39OP6YN4p2SI=; b=dJq4E3APEGUoNBJyHYccbX5FKGRAp3In1xuWgcB95clK3eYa2/pgfLgeA7rxyjz+1fQ45m yNwPgnqJH3hl1zHTlimDJMVvqDMysF0IwtFf+bkHpHksh4bObITDmxw6/2FaZFo0SDZzxM phEw4tzlwACecCTgWzj3Fyih6fhmioM= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-138-fvHBZygIOoW4YPGrcRALPA-1; Wed, 05 Jun 2024 10:28:30 -0400 X-MC-Unique: fvHBZygIOoW4YPGrcRALPA-1 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-35e7cce4c32so1715140f8f.3 for ; Wed, 05 Jun 2024 07:28:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717597709; x=1718202509; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=VxIffXnjUYvHBO052LXyySGWsjqpIrP39OP6YN4p2SI=; b=fXz/Pxi89RkR6hvPgmr+YVUtxqtKfgPfHK4n6qbXQdBj4W1TWKI2l20EGtLHcIDpqT B9sWeRJURCf22cKZJDaFcWlvoqIYPms+gxV1A/BgNWPH+pu6wHF2dNaiZlkIHPqwspVF zJZTSmRFizpngh140Vcx1mwGl8PSGbWtIkiQxRE+yFXnbNufKpr5c8FjtxILs5ftUUz2 nDTtmJdHbP40v/ytjj9StVysdGwVgefUMbeazttSFSyKWHMlI76uSLVWJlpx5e4cZrg3 G9VsVfGo0QsdQWUUR+yQl8cp5r+0qhFm/qhUIb6WaY96O0f1k+OKLMacjpOvtRAexTg/ 5RvQ== X-Forwarded-Encrypted: i=1; AJvYcCVpH9tNtZuKEgXGLB9C42TzuO2IOzhwwTTeMed8LNeHvMWSCaOogLL64C+hL720SCkPWcf0jodrGxD0WLNUbtiYC0Q= X-Gm-Message-State: AOJu0YyU76oMdq5joSwz9HbBZDUu8iRhWjIgIoxraQCUVkOZr543+QBz HO7B/LEQ5tt9GfYlVgllxkaPc4TAcicx9h9piQyvRV9YuERh7LwsQqMu+V9z1yydOQnvForyFUF kmht6HMlTLTbVZE89tjzAenGYlkstLr2E0ibWqRHYGptm8Pl9 X-Received: by 2002:a5d:56cf:0:b0:357:e715:f52b with SMTP id ffacd0b85a97d-35e84070f49mr1879666f8f.20.1717597709035; Wed, 05 Jun 2024 07:28:29 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGhbqtvPOCCdKJSv46h65rz+enYr0CQoR+/VdaCKU4/I53blN8X0B/qGtkis1jQrRM44WPP5A== X-Received: by 2002:a5d:56cf:0:b0:357:e715:f52b with SMTP id ffacd0b85a97d-35e84070f49mr1879644f8f.20.1717597708568; Wed, 05 Jun 2024 07:28:28 -0700 (PDT) Received: from ?IPV6:2003:cb:c706:3100:19a8:d898:8e69:6aff? (p200300cbc706310019a8d8988e696aff.dip0.t-ipconnect.de. [2003:cb:c706:3100:19a8:d898:8e69:6aff]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-35dd04cafb8sm14635656f8f.37.2024.06.05.07.28.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 05 Jun 2024 07:28:28 -0700 (PDT) Message-ID: Date: Wed, 5 Jun 2024 16:28:26 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 2/3] mm/rmap: integrate PMD-mapped folio splitting into pagewalk loop To: Lance Yang Cc: akpm@linux-foundation.org, willy@infradead.org, sj@kernel.org, baolin.wang@linux.alibaba.com, maskray@google.com, ziy@nvidia.com, ryan.roberts@arm.com, 21cnbao@gmail.com, mhocko@suse.com, fengwei.yin@intel.com, zokeefe@google.com, shy828301@gmail.com, xiehuan09@gmail.com, libang.li@antgroup.com, wangkefeng.wang@huawei.com, songmuchun@bytedance.com, peterx@redhat.com, minchan@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20240521040244.48760-1-ioworker0@gmail.com> <20240521040244.48760-3-ioworker0@gmail.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: C718D20002 X-Rspam-User: X-Rspamd-Server: rspam12 X-Stat-Signature: zx6yyyadfbesim4un3e3zogcaax4y3dt X-HE-Tag: 1717597715-29567 X-HE-Meta: U2FsdGVkX18KmfCdSrx0G5XatFkAMQWrWtMLq3KfKlKA16aUM/xzCgyWojb1PssVyKE3JX3hYeCDsZn5IlztB/m/HfNcagIv2VHuPDYR3nQutPVywJ2V8hKjRq9z7TL/TkpyOitXq4ySQFAsd4keiK21cgcy0bAPwErSMSagIyDc0l/ysUpvAs6refBOII0bXTXDibyBMIt1ryVVyzGW/EEdMOgelycd2g2SLVfK46tmJii/fxC/uK9z5Y7Lf4kF16BVVIVPSy/Inre1YhKtN3w5tullUIAWXSeQS2sFhdgzQA5FqnWB2oXCL078qQGs8NIErSS9HjwchCwlF2qGyr6GwSMc3mAlTsHDbyJwHXnDx5XJJHdrsEOPu8ZgaEADpowuS183Tg4rlTcANthZ70Od0GGnDabarWBmkbo+Sw2E4J1taIc4/H1DbFelwyAzq4B/4Af98CQa+xNs20X05Kx+RYq1VB2mEovzkBKDA7aFbwZD/1dP5BaH2o9Eh1b7jQ9l/rlGKmyYBJMoL+3rgGe57e90LmCponVz+dHiitzIRrq5IDkzARZRjb+ZXXJSo02mf7VpNLL7klhd8IgL2MZUlwj7gcuquqH3b22c8oiiJtMFT08sZW/8SoALgvzshlASwr+B6R7xCmwisWfMKLcz33CjOvVA12lsJCfXupG2/ABYXh234xZjgU1PXGOMP8+idLuv7SIyDAtx21s5A//b+Z9DyKAg1j61bC8wRbYWBkN5b7l7m/+kz8MjlBxh7P72H8jg30eEyTewe8vcMm2UfXH2X+mLv1hwhhC9W1MsOWGUdXWVSOzFcTPEnvvFXfiNmXvwgahVs5YteXQuXVwwkdzKMyXopd5clHnTnkm9zS+2aR+62ID8jzRohylTGvh3b37+CDASU2dn6ZP3lrzG0Tb+O8Xo1QVe6n+3EsgGeqZJyIt4e318xyrNumY8XBYV4zuByQKM/GFDsMr xFW10JXA dNfOkCk2Kw06v4m6Iv5FQ61mCa6AmHsbnxvC/EaX+NLliVeTtNDqE7LPHp/AkrDtLU5WXXu/ggrWdifgJ0MINYtL5ei+lShomJVXMZQq5RgBTYZtHSbmd+WOK/lico/RpCd85uuj6w4B0qEXBSaqUhO2JBk0PICI/SZ2LqmFX0p/zTB0LjJZOmHlgEJx2b2e2QpFbXD/gCytWO8GSNl9ot3OQzI182d5NYhzeFzMabaYq6wWzkmwBdLwiXs5P01/wHqIUBBBrBdT7h0tXhFUsDk8uADGGhEBbKlJ7S+yZmZHyJ6KO/IfxiVWi/RsojOyaymwtPVLDzUwCtimNqUrzQKqukmIsOBVScH9yu4w/DXTz83pBj7kNV5+RWricf3MS2zg0cPm5yOpyCzF3aPLRzgmKDAuOlYqwesqp7seRGUhgqKliuRD3kE/PEKubGGMw34KTdnOi1q/Buw6tcP2nkSTG7LCM6pyxF3mOpLeIs+uViXiXay9FrxxyoCynByVRUEQDPeMDt6PLc6uIagxOW58jGDVbrQJ3TtUixaKCzKQWpMXbVU1iqTOaYQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 05.06.24 16:20, Lance Yang wrote: > Hi David, > > On Wed, Jun 5, 2024 at 8:46 PM David Hildenbrand wrote: >> >> On 21.05.24 06:02, Lance Yang wrote: >>> In preparation for supporting try_to_unmap_one() to unmap PMD-mapped >>> folios, start the pagewalk first, then call split_huge_pmd_address() to >>> split the folio. >>> >>> Since TTU_SPLIT_HUGE_PMD will no longer perform immediately, we might >>> encounter a PMD-mapped THP missing the mlock in the VM_LOCKED range during >>> the page walk. It’s probably necessary to mlock this THP to prevent it from >>> being picked up during page reclaim. >>> >>> Suggested-by: David Hildenbrand >>> Suggested-by: Baolin Wang >>> Signed-off-by: Lance Yang >>> --- >> >> [...] again, sorry for the late review. > > No worries at all, thanks for taking time to review! > >> >>> diff --git a/mm/rmap.c b/mm/rmap.c >>> index ddffa30c79fb..08a93347f283 100644 >>> --- a/mm/rmap.c >>> +++ b/mm/rmap.c >>> @@ -1640,9 +1640,6 @@ static bool try_to_unmap_one(struct folio *folio, struct vm_area_struct *vma, >>> if (flags & TTU_SYNC) >>> pvmw.flags = PVMW_SYNC; >>> >>> - if (flags & TTU_SPLIT_HUGE_PMD) >>> - split_huge_pmd_address(vma, address, false, folio); >>> - >>> /* >>> * For THP, we have to assume the worse case ie pmd for invalidation. >>> * For hugetlb, it could be much worse if we need to do pud >>> @@ -1668,20 +1665,35 @@ static bool try_to_unmap_one(struct folio *folio, struct vm_area_struct *vma, >>> mmu_notifier_invalidate_range_start(&range); >>> >>> while (page_vma_mapped_walk(&pvmw)) { >>> - /* Unexpected PMD-mapped THP? */ >>> - VM_BUG_ON_FOLIO(!pvmw.pte, folio); >>> - >>> /* >>> * If the folio is in an mlock()d vma, we must not swap it out. >>> */ >>> if (!(flags & TTU_IGNORE_MLOCK) && >>> (vma->vm_flags & VM_LOCKED)) { >>> /* Restore the mlock which got missed */ >>> - if (!folio_test_large(folio)) >>> + if (!folio_test_large(folio) || >>> + (!pvmw.pte && (flags & TTU_SPLIT_HUGE_PMD))) >>> mlock_vma_folio(folio, vma); >> >> Can you elaborate why you think this would be required? If we would have >> performed the split_huge_pmd_address() beforehand, we would still be >> left with a large folio, no? > > Yep, there would still be a large folio, but it wouldn't be PMD-mapped. > > After Weifeng's series[1], the kernel supports mlock for PTE-mapped large > folio, but there are a few scenarios where we don't mlock a large folio, such > as when it crosses a VM_LOCKed VMA boundary. > > - if (!folio_test_large(folio)) > + if (!folio_test_large(folio) || > + (!pvmw.pte && (flags & TTU_SPLIT_HUGE_PMD))) > > And this check is just future-proofing and likely unnecessary. If encountering a > PMD-mapped THP missing the mlock for some reason, we can mlock this > THP to prevent it from being picked up during page reclaim, since it is fully > mapped and doesn't cross the VMA boundary, IIUC. > > What do you think? > I would appreciate any suggestions regarding this check ;) Reading this patch only, I wonder if this change makes sense in the context here. Before this patch, we would have PTE-mapped the PMD-mapped THP before reaching this call and skipped it due to "!folio_test_large(folio)". After this patch, we either a) PTE-remap the THP after this check, but retry and end-up here again, whereby we would skip it due to "!folio_test_large(folio)". b) Discard the PMD-mapped THP due to lazyfree directly. Can that co-exist with mlock and what would be the problem here with mlock? So if the check is required in this patch, we really have to understand why. If not, we should better drop it from this patch. At least my opinion, still struggling to understand why it would be required (I have 0 knowledge about mlock interaction with large folios :) ). -- Cheers, David / dhildenb