From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E21FC3DA4A for ; Fri, 16 Aug 2024 17:56:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 77C3E8D00A5; Fri, 16 Aug 2024 13:56:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 72B978D00A2; Fri, 16 Aug 2024 13:56:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5F3AC8D00A5; Fri, 16 Aug 2024 13:56:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 3FCDB8D00A2 for ; Fri, 16 Aug 2024 13:56:39 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id D2BDC1401F9 for ; Fri, 16 Aug 2024 17:56:38 +0000 (UTC) X-FDA: 82458863676.14.CA853FC Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf27.hostedemail.com (Postfix) with ESMTP id 8C0CE40012 for ; Fri, 16 Aug 2024 17:56:36 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=gmIJyHGP; spf=pass (imf27.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723830959; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=N887NcL0MqOj2hQysbs1Gth/iAPZml/fUaJ1WOFD+aw=; b=xochKyjbDcqMWyUVgkI2bZHdRw/gG6A2bp7i8H4OQzWrWp05CFP0NMmAOws/x86pPBcjje kEDA7wMwufxQ7mospaL7+MyfPcJQuHCrj7OX7e11JCPZaXq6ir/FT0IaQwTICTlikyOeCU Uu6riY2yEby0RI3TWyTPydoZCUC0ksQ= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=gmIJyHGP; spf=pass (imf27.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1723830959; a=rsa-sha256; cv=none; b=WGoUfk3Jc/g9t5d8zw0ypCB2AGLOiAQhDGW2QYdiqvEH9o2yqLq5gJ8e0bM53S2SN+3kVz 96cZecqwGoRGpr3iJpT36aoRh/zDvLCUfiIkP6uH04JIb5UYBSbm1wRTnA/X41ZyKBM3td o7ucfSisREUmLKdsBA/hZiByt7C5ztk= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1723830995; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=N887NcL0MqOj2hQysbs1Gth/iAPZml/fUaJ1WOFD+aw=; b=gmIJyHGPoojInFbKKnqps0eflY7Yrysb8M5qn1onheXQcDwNtvpXKUdnIIiAgNkrj5oLRR fvYZ/AenXyM8X6rtnM+3/zy7Dxj64u0mKTMBs61jCx+lcXAwsq5IYfR7SmvSkF2tLyOixD k7VnwtODjUY0c+3HXUBhKdYpLNMAiD4= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-556-eGSzOovHPy2NWQHPD2H8BQ-1; Fri, 16 Aug 2024 13:56:34 -0400 X-MC-Unique: eGSzOovHPy2NWQHPD2H8BQ-1 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-4281310bf7aso16145865e9.1 for ; Fri, 16 Aug 2024 10:56:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723830993; x=1724435793; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=N887NcL0MqOj2hQysbs1Gth/iAPZml/fUaJ1WOFD+aw=; b=uooxORe4IJfxR+xyYRsOUfOP3yuJA/U7Vl6XokKjaMLZKCUv1OpUFXNhPBwGnvRtl+ wzQh/fVCaFuUdxJrEHx6xoj0d7btQA85TV3EsYkukGEMuCYBQY0o62fOTqC3AK+pJO1/ Vq8uzImOf8UbpNGXNKjG1PIMQYlfRkd3oy5nC0mK2EV7SQm8Ej3r6vtRyr91Pj5RfJ72 HywAQ9GGpeLyXUzdjemE2F1uSp9drftJJZ8VJC3cBrOCk8Csgw45+hIfQIZR/aqh0f0q KIAT6nnPWtqVDXH6TKxcFD7pGyWtfryT3gRKb2Xls/vDp+nT7qEgwmiE8mKoBmPytEHr FZtA== X-Forwarded-Encrypted: i=1; AJvYcCVVML40yCiy1PMuIUr6SRi6j9begvcDcfzjV46O6l0GyffHDeLI8zmqE6x7JEpwwiOylEOHtaVWSdojlhhAW8AcAEs= X-Gm-Message-State: AOJu0YxMBVtVZHYTkHK6oif55Im/GNVYUkjHCQ5xAAzQmvS0gnyOL5/r I+R20emMxHt+72JVjHp+67fa/rG9husown9/DsdMmP1uzo5Q30Hyd+DCfF42JUTi+aMgp/5cOzS QFlFRCpM2BL46gpWgDueVOtZvETgb0XvxLiFRCZE8NEcdo/K/ X-Received: by 2002:a05:600c:3b04:b0:429:994:41a2 with SMTP id 5b1f17b1804b1-429ed785b80mr21318985e9.7.1723830993403; Fri, 16 Aug 2024 10:56:33 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHD7YlRhLCoJ0q/8oapuwa6a/Pxhf3h8xRE1yVEHeD5piFXRKbP506fq8bpnjsX6vqve4Bqdg== X-Received: by 2002:a05:600c:3b04:b0:429:994:41a2 with SMTP id 5b1f17b1804b1-429ed785b80mr21318815e9.7.1723830992802; Fri, 16 Aug 2024 10:56:32 -0700 (PDT) Received: from ?IPV6:2003:cb:c721:b900:4f34:b2b7:739d:a650? (p200300cbc721b9004f34b2b7739da650.dip0.t-ipconnect.de. [2003:cb:c721:b900:4f34:b2b7:739d:a650]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-429eea70115sm24015035e9.36.2024.08.16.10.56.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 16 Aug 2024 10:56:32 -0700 (PDT) Message-ID: Date: Fri, 16 Aug 2024 19:56:30 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 06/19] mm/pagewalk: Check pfnmap early for folio_walk_start() To: Peter Xu Cc: Jason Gunthorpe , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Sean Christopherson , Oscar Salvador , Axel Rasmussen , linux-arm-kernel@lists.infradead.org, x86@kernel.org, Will Deacon , Gavin Shan , Paolo Bonzini , Zi Yan , Andrew Morton , Catalin Marinas , Ingo Molnar , Alistair Popple , Borislav Petkov , Thomas Gleixner , kvm@vger.kernel.org, Dave Hansen , Alex Williamson , Yan Zhao References: <20240809160909.1023470-1-peterx@redhat.com> <20240809160909.1023470-7-peterx@redhat.com> <20240814130525.GH2032816@nvidia.com> <81080764-7c94-463f-80d3-e3b2968ddf5f@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: 8C0CE40012 X-Stat-Signature: ufm7e8d4qu19q1ho5n4oiywnsydyhwzb X-HE-Tag: 1723830996-269899 X-HE-Meta: U2FsdGVkX19VWMprp7Lz9GpCZa0RKOXE0CZQY7f0fNNTSlMt7FV6vI+HtChxHPxJf6i5WCaPoBtlwjGjcZOoxErUyxlwZZ36k+3EsdMXb5rN1PpqJ3Ld27elYuNi+W3OWiul56NAdYrD8RQbhLWFuAHUfzlUwjw1+/RQXCNECo0p4va/jQWAOx8LWLnkay8WoUIaMvRH4zuqzvCdCAKkHR3Xr5qMzy0irIuiCPxdeo4UuD7B6C3EHu1fUPU7oiQ+A+KW+Q418DMfLDOZdeoNvh4zM89+h6PrHZ1v990eA++quYZuzPYG6KNLIFTqG5aNRFIs97D98QOsYrvpKJy30KwV2FP3xjgWWNP8Dt7HM3sonhvHUD252mnuRVTUzc9Ks2LhqPAlvLlLsnJFcyb9lrVIHMEL6m5Ql06oYUcwkzl0WAlSiZ5uGyo7/JR2WhsYJ7F1kokmdhiRgixY4WRS5O0tUzCYmfhzFVDzp4JB6vtargAerHdnrgD+50LZFuIQChUpGdXVkwr9l2nbNbLTtPzIG4tD7VnEOUUPyEhLQ/oViKY7WOV3L1PBfz97JJQyMCRoT+vfDJt09jq+9v61PpojVCLtzpGlx93Kca0qT0rCZ5m5cW3yWNCOWpsBaLvluCrHeSRa0yacSbfGMgZeH+uBGJYyWRJb6ly5a3/JWHH1jWJFfpOctbifd3xwtHeyfbgNNbHipfmBnSThQhzuP0xYswjLqdIgEhS/WgWZtvzAzB1QC95quRxeSEJZc9Oueh36nBZYi6J8Uan+lgysDBU06AXQH3UFyGNoY5daWdOCOkoIuJKsl/KhEwDInETVu6z4CNagt+7hA9hFcguXcb0nErKE6UvERMMWS1cnG153YKc/N0VxhkCu8QGQb7JGx7EljJMCspRKq2kYg+pojzr7ArJy0dJCI4ZKA+zt5ZXkUQ7msmjCnVnyY2jIn8eXodTVhTnZFH7m4i+r831 KN7/BCMH llsqVd421c7k0EehGV216WYfFp3DzJrT4tbMsRn1MJujA4DSvpP+j7OGocBsHgAXqHzmi3CZCwUim3GtB7cCdyJP1v97uwoce5DbEDlxQ3BnMNiKz78Vfx+lgcGXICAxHzuH4Q7IqtTSUyxVkb5oKWypi6JFfdYdITCLmDat90HT9zhGsnRwF5bWwsa4a9R/DoOMeQSztgcB/MZmmVyPEB8u8V6WtTgKKfcgX8LMEeG/o92O2gwmmR3fMTgzQlOmcQyGFCisqDM9bwk3KtM743FxZsWwtGfZ66+yab6hq8dGB0s1ovWOVRqOZTztPEO82FouV2BQv8ZPyggT/F2x+lKnL+HiJCn9ENcu9rcT5/HO1Xmpj20HFfZ3pFli2AebhenYgdYqYFln+OSi2UrKs9Df96zid368QvTKGOLG8345LDA0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 16.08.24 16:21, Peter Xu wrote: > On Fri, Aug 16, 2024 at 11:30:31AM +0200, David Hildenbrand wrote: >> On 14.08.24 15:05, Jason Gunthorpe wrote: >>> On Fri, Aug 09, 2024 at 07:25:36PM +0200, David Hildenbrand wrote: >>> >>>>>> That is in general not what we want, and we still have some places that >>>>>> wrongly hard-code that behavior. >>>>>> >>>>>> In a MAP_PRIVATE mapping you might have anon pages that we can happily walk. >>>>>> >>>>>> vm_normal_page() / vm_normal_page_pmd() [and as commented as a TODO, >>>>>> vm_normal_page_pud()] should be able to identify PFN maps and reject them, >>>>>> no? >>>>> >>>>> Yep, I think we can also rely on special bit. >>> >>> It is more than just relying on the special bit.. >>> >>> VM_PFNMAP/VM_MIXEDMAP should really only be used inside >>> vm_normal_page() because thay are, effectively, support for a limited >>> emulation of the special bit on arches that don't have them. There are >>> a bunch of weird rules that are used to try and make that work >>> properly that have to be followed. >>> >>> On arches with the sepcial bit they should possibly never be checked >>> since the special bit does everything you need. >>> >>> Arguably any place reading those flags out side of vm_normal_page/etc >>> is suspect. >> >> IIUC, your opinion matches mine: VM_PFNMAP/VM_MIXEDMAP and pte_special()/... >> usage should be limited to vm_normal_page/vm_normal_page_pmd/ ... of course, >> GUP-fast is special (one of the reason for "pte_special()" and friends after >> all). > > The issue is at least GUP currently doesn't work with pfnmaps, while > there're potentially users who wants to be able to work on both page + > !page use cases. Besides access_process_vm(), KVM also uses similar thing, > and maybe more; these all seem to be valid use case of reference the vma > flags for PFNMAP and such, so they can identify "it's pfnmap" or more > generic issues like "permission check error on pgtable". What at least VFIO does is first try GUP, and if that fails, try follow_fault_pfn()->follow_pte(). There is a VM_PFNMAP check in there, yes. Ideally, follow_pte() would never return refcounted/normal pages, then the PFNMAP check might only be a performance improvement (maybe). > > The whole private mapping thing definitely made it complicated. Yes, and follow_pte() for now could even return ordinary anon pages. I spotted that when I was working on that VM_PAT stuff, but I was to unsure what to do (see below that KVM with MAP_PRIVATE /dev/mem might just work, no idea if there are use cases?). Fortunately, vfio calls is_invalid_reserved_pfn() and refuses anything that has a struct page. I think KVM does something nasty: if it something with a "struct page", and it's not PageReserved, it would take a reference (if I get kvm_pfn_to_refcounted_page()) independent if it's a "normal" or "not normal" page -- it essentially ignores the vm_normal_page() information in the page tables ... So anon pages in pivate mappings from follow_pte() might currently work with KVM ... because of the way KVM uses follow_pte(). I did not play with it, so I'm not sure if I am missing some detail. -- Cheers, David / dhildenb