From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 77E97CD13CF for ; Mon, 2 Sep 2024 14:13:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E96078D00DD; Mon, 2 Sep 2024 10:13:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E1F918D0065; Mon, 2 Sep 2024 10:13:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CC0578D00DD; Mon, 2 Sep 2024 10:13:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id AB9CF8D0065 for ; Mon, 2 Sep 2024 10:13:55 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 4DDBF81D60 for ; Mon, 2 Sep 2024 14:13:55 +0000 (UTC) X-FDA: 82519992030.17.DBDBD06 Received: from mail-4018.proton.ch (mail-4018.proton.ch [185.70.40.18]) by imf27.hostedemail.com (Postfix) with ESMTP id E37024001B for ; Mon, 2 Sep 2024 14:13:52 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=yhndnzj.com header.s=protonmail2 header.b=Pz+Rc1H6; spf=pass (imf27.hostedemail.com: domain of me@yhndnzj.com designates 185.70.40.18 as permitted sender) smtp.mailfrom=me@yhndnzj.com; dmarc=pass (policy=quarantine) header.from=yhndnzj.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725286340; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=uGPV9tAR75BtaCLwmnuCOAw4KGDFFnJEqjWSWmwE5Gs=; b=MaZqxYDI7O0U+A8Q58qZXtPGo5rRSuO5LN5GjD8ISxNSNosw3K57YUtDa+Ur56yKf2rt6P OL8MzEG5357ElUYcQJpf4TePPaRE/+i9tvBq7CPnsmAyzN7vdShqKon6KB6rM7p5OXPVYy 0UNfMw2Ovzjd9kEO2+1N4VaMX/H6fMQ= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725286340; a=rsa-sha256; cv=none; b=gcc6nUqrMAnQSC5OFkrKL9nIyyV3rDbxHR92ANX/SJ849/wU9CRZgusE14dsMDS3XNhMlc 5fDNU0QXkjfv+pQUacAlnrKyh0ES9gIKQYKd44K0q7ZcaU/t3GgrSiewMtTHsnaAwg0h/f 4ok2docxGGQ4+Ap2tcO+lCpf0oLqbg8= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=yhndnzj.com header.s=protonmail2 header.b=Pz+Rc1H6; spf=pass (imf27.hostedemail.com: domain of me@yhndnzj.com designates 185.70.40.18 as permitted sender) smtp.mailfrom=me@yhndnzj.com; dmarc=pass (policy=quarantine) header.from=yhndnzj.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yhndnzj.com; s=protonmail2; t=1725286429; x=1725545629; bh=uGPV9tAR75BtaCLwmnuCOAw4KGDFFnJEqjWSWmwE5Gs=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=Pz+Rc1H6l8xE+LNq1VflhrnR6hZy/Zy65dlMYNFu0Q8+2bXbIZ8uwxqaYPoqjRD18 eHNaNmifT8ruB1nWzp4M976xXzqEIpjnI/i8sg906lFytRLJH5mLzDehjT3c5dNfeH olHtHEN6vipEHN+87gDxRj1iVr3lLiZVKbig94IjnwUcfcYczG2oPfBkF2OFiAy7pO PsHkX1Wx1+KZeSTOogz0TkTPux4oi5KkSfScEeXHulppwGMkWDrNXzeiHZNbRBsVwi SAxKg2a8G+fqZcYOA0Q4/R+0sOE95H+JTuSkM6W1mHWMUuMRxmcWsm+nhDRIkWr0Qe JWO4oYs9ILFfg== Date: Mon, 02 Sep 2024 14:13:43 +0000 To: Andrew Morton From: Mike Yuan Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, cgroups@vger.kernel.org, Nhat Pham , Yosry Ahmed , Johannes Weiner , Muchun Song , Shakeel Butt , Roman Gushchin , Michal Hocko Subject: Re: [PATCH v3 3/3] Documentation/cgroup-v2: clarify that zswap.writeback is ignored if zswap is disabled Message-ID: In-Reply-To: <20240823162506.12117-3-me@yhndnzj.com> References: <20240823162506.12117-1-me@yhndnzj.com> <20240823162506.12117-3-me@yhndnzj.com> Feedback-ID: 102487535:user:proton X-Pm-Message-ID: 1b059982da0bd1a3cba5619155b6e8cc6ca71b5c MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: E37024001B X-Stat-Signature: u6ner388u7qhc5ercf5zmrgyg6a4jpaz X-HE-Tag: 1725286432-697555 X-HE-Meta: U2FsdGVkX19j8aq8Ors5nl0AXZ13n8VYo8v1W5IxmV4Wrk07r9BfeQZFhJfuMdQ2r9+DEUm8lbVswvoCeXHBxXKRHnE5+9+ml9DHV4xlcZqnRcAiJM7EaRqLStDtMGrm5rymTYx95hSH9a25fo/vnf/WjKIdvROQGMBKkXbh0nLOkPyze1XlfNPBPgCqX0ykcLsxrJTFR7FDvW8LC3FbvK+KzALZNpSO9mmkW5hucAmWPNnmXxSXpehvY1cCrvBuc545Y5bypiU2qKmu0oxSq5CI94nEvZdFmcZLaMjf2xPAz+22uupdS10xgtG+lkuWz+uDp1i1VpG8B39WpcOhnUKce+P/LWmNE5XPOnA3P30x/r+sFUhFzLq5m4BQv4AMSJ2u8li1YYf5h+FSeL27ZDj9OVcyKhphshvfuyBug1jSxnkFXRLk1zV7N7yhg0mZL9iNQd20c0PG/YWP/KHLctIy1FmwKXe5t0WfQLfrJNQRCoECJN0cL1sS7aj7uvy2NZU1no7vIwGDQXGOYnNesAutfolIOJPSp5wd9xnRrPCuVbR4FVUVzjyR48eF0zhCo9GQhGIh9l48gUz5oQ1QfKxAA8gUO+GzDB71cNAwwlnsjw8Yly8PMcd5rggcRL3w+IVCle70GRSOBF3zkH53itB/SpvNpQmj3X6gqLfnKXKyDLfXOsdEeSHXTsFxTEtliEULzpFKCH1nlXp4nn8IQLqhwh1UC8G+KocSMVzoBepUp+fsvNMmga4CaT5qgAYdU8uMFZ1or7YfjJJTCq7JOXDmVrCSNlp60Ocmdr08Q1exR8PRo9T2E0TPa9/zxDgoo7yl3n6WUF7xYzlgNByCeqSpDOLnXkoxVtrPEpf1f6UKOgczAxRKaQ8V/0/ztNT26Nm36B/kfDI2kuNhcdA9u6d/e0S2BCBNhC9NW8WJvIR8VzRCoqY055HUBYhxE+6UYrUPxlK2pngN6Fxwcv3 oAJZX9ba DhBxcVuSgTw41xmh+xIY3k4RybInJvcTY4d3nWDhlivGDQ0HEdckBYLZ+t5wkMaG2+63p1v13/VioyvM7c/i6ZlYp5eZbKxEODjrftfHzA06I4VtBxWTcsTzlrDiQwHqD2NaT9fsVI7tJIAM8TZPmAN5dyFGZDGFtnOA+htyVzRTnpg00FL379xe+CDBkjY0+hcpCYw+OYQqFTO7RiniaJTIiOo+NY6jzWw5ST94v+4myeG1JoEkJhxPsyb69pP63NHEDLeqLte1UmcTI5VsC5g0GzJmzf3vAQHRQ5mcpbqEm1WH32gyG7qAsAQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > As discussed in [1], zswap-related settings natually > lose their effect when zswap is disabled, specifically > zswap.writeback here. Be explicit about this behavior. >=20 > [1] > https://lore.kernel.org/linux-kernel/CAKEwX=3DMhbwhh-=3DxxCU-RjMXS_n=3DRp= V3Gtznb2m_3JgL+jzz++g@mail.gmail.com/ >=20 > Cc: Nhat Pham > Cc: Yosry Ahmed >=20 > Signed-off-by: Mike Yuan > --- > =C2=A0Documentation/admin-guide/cgroup-v2.rst | 2 ++ > =C2=A01 file changed, 2 insertions(+) >=20 > diff --git a/Documentation/admin-guide/cgroup-v2.rst > b/Documentation/admin-guide/cgroup-v2.rst > index 95c18bc17083..a1723e402596 100644 > --- a/Documentation/admin-guide/cgroup-v2.rst > +++ b/Documentation/admin-guide/cgroup-v2.rst > @@ -1731,6 +1731,8 @@ The following nested keys are defined. > =C2=A0 > =C2=A0=09Note that this is subtly different from setting > memory.swap.max to > =C2=A0=090, as it still allows for pages to be written to the zswap > pool. > +=09This setting has no effect if zswap is disabled, and > swapping > +=09would be allowed unless memory.swap.max is set to 0. > =C2=A0 > =C2=A0=C2=A0 memory.pressure > =C2=A0=09A read-only nested-keyed file. Hmm, Andrew, it seems that the commit messages of this and the previous patch are somehow reversed/mismatched? [1][2] Could you please confirm and fix it? [1]: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git/commit/?h=3Dmm-= unstable&id=3Deef275964326760bb55803b167854981cab97e55 [2]: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git/commit/?h=3Dmm-= unstable&id=3D42c3628a37400c2bc4199b9f8423be701646d4e0