From: Mike Yuan <me@yhndnzj.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
cgroups@vger.kernel.org, Nhat Pham <nphamcs@gmail.com>,
Yosry Ahmed <yosryahmed@google.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Muchun Song <muchun.song@linux.dev>,
Shakeel Butt <shakeel.butt@linux.dev>,
Roman Gushchin <roman.gushchin@linux.dev>,
Michal Hocko <mhocko@kernel.org>
Subject: Re: [PATCH v3 3/3] Documentation/cgroup-v2: clarify that zswap.writeback is ignored if zswap is disabled
Date: Mon, 02 Sep 2024 14:13:43 +0000 [thread overview]
Message-ID: <d305db940e461c92a618dd26224144a5105274b3.camel@yhndnzj.com> (raw)
In-Reply-To: <20240823162506.12117-3-me@yhndnzj.com>
> As discussed in [1], zswap-related settings natually
> lose their effect when zswap is disabled, specifically
> zswap.writeback here. Be explicit about this behavior.
>
> [1]
> https://lore.kernel.org/linux-kernel/CAKEwX=Mhbwhh-=xxCU-RjMXS_n=RpV3Gtznb2m_3JgL+jzz++g@mail.gmail.com/
>
> Cc: Nhat Pham <nphamcs@gmail.com>
> Cc: Yosry Ahmed <yosryahmed@google.com>
>
> Signed-off-by: Mike Yuan <me@yhndnzj.com>
> ---
> Documentation/admin-guide/cgroup-v2.rst | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/admin-guide/cgroup-v2.rst
> b/Documentation/admin-guide/cgroup-v2.rst
> index 95c18bc17083..a1723e402596 100644
> --- a/Documentation/admin-guide/cgroup-v2.rst
> +++ b/Documentation/admin-guide/cgroup-v2.rst
> @@ -1731,6 +1731,8 @@ The following nested keys are defined.
>
> Note that this is subtly different from setting
> memory.swap.max to
> 0, as it still allows for pages to be written to the zswap
> pool.
> + This setting has no effect if zswap is disabled, and
> swapping
> + would be allowed unless memory.swap.max is set to 0.
>
> memory.pressure
> A read-only nested-keyed file.
Hmm, Andrew, it seems that the commit messages of this and the previous
patch are somehow reversed/mismatched? [1][2] Could you please confirm
and fix it?
[1]:
https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git/commit/?h=mm-unstable&id=eef275964326760bb55803b167854981cab97e55
[2]:
https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git/commit/?h=mm-unstable&id=42c3628a37400c2bc4199b9f8423be701646d4e0
next prev parent reply other threads:[~2024-09-02 14:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-23 16:27 [PATCH v3 1/3] mm/memcontrol: respect zswap.writeback setting from parent cg too Mike Yuan
2024-08-23 16:27 ` [PATCH v3 2/3] selftests: test_zswap: add test for hierarchical zswap.writeback Mike Yuan
2024-08-23 16:27 ` [PATCH v3 3/3] Documentation/cgroup-v2: clarify that zswap.writeback is ignored if zswap is disabled Mike Yuan
2024-09-02 14:13 ` Mike Yuan [this message]
2024-09-02 21:02 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d305db940e461c92a618dd26224144a5105274b3.camel@yhndnzj.com \
--to=me@yhndnzj.com \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=muchun.song@linux.dev \
--cc=nphamcs@gmail.com \
--cc=roman.gushchin@linux.dev \
--cc=shakeel.butt@linux.dev \
--cc=yosryahmed@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox