From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A3B7C8303D for ; Fri, 4 Jul 2025 14:14:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 917266B8054; Fri, 4 Jul 2025 10:14:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8C4C16B803F; Fri, 4 Jul 2025 10:14:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 767106B8054; Fri, 4 Jul 2025 10:14:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 60CA56B803F for ; Fri, 4 Jul 2025 10:14:05 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id D54A2125ACD for ; Fri, 4 Jul 2025 14:14:04 +0000 (UTC) X-FDA: 83626776408.06.DA1CDD8 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by imf01.hostedemail.com (Postfix) with ESMTP id 6431C4000D for ; Fri, 4 Jul 2025 14:14:01 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2025-04-25 header.b=rJFO0n8Z; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=PlJ2ETR5; spf=pass (imf01.hostedemail.com: domain of liam.howlett@oracle.com designates 205.220.177.32 as permitted sender) smtp.mailfrom=liam.howlett@oracle.com; dmarc=pass (policy=reject) header.from=oracle.com; arc=pass ("microsoft.com:s=arcselector10001:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751638441; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=61BD5LSAL3ePTcp2nTnOYpbzqeA7fXDqaycmyY99YSY=; b=d9LNq2cb6esqrF0TXwmlv4BnWYhni1Xp7Wz9GIhwcBDYbSKKPG3hDOa90tZr2ZStZwK3ot rw4OVVntJw0KzWgZcPLmzDEvNQahc30FrOaeWkJzRTcnQ7jZC/5QyM3KJqcC80IArEpVhR bicC0pg1O1M8N3ZeeZ3TlyjurLy7fgE= ARC-Authentication-Results: i=2; imf01.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2025-04-25 header.b=rJFO0n8Z; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=PlJ2ETR5; spf=pass (imf01.hostedemail.com: domain of liam.howlett@oracle.com designates 205.220.177.32 as permitted sender) smtp.mailfrom=liam.howlett@oracle.com; dmarc=pass (policy=reject) header.from=oracle.com; arc=pass ("microsoft.com:s=arcselector10001:i=1") ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1751638441; a=rsa-sha256; cv=pass; b=63RpZ6JDIy5/j5rBhKle425HQbJSrV1O7cHSBsgSn8gWbiq8ylUh1r6qSCvJ/FD7pJtZdF fW2v6c7sdwCeVIBMe1NJCXlQQUNj6aABuJFjDhm8yR7l2saMeobPlqJHEcd+XIPYOu6seu VYe4XJ3OUa0P+auVUE6BLr/aNbNHpTI= Received: from pps.filterd (m0246632.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 5649Ysck000354; Fri, 4 Jul 2025 14:13:58 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=corp-2025-04-25; bh=61BD5LSAL3ePTcp2nT nOYpbzqeA7fXDqaycmyY99YSY=; b=rJFO0n8Zn1mkhf6yXqI3ua+3hTMetWIawi dkC9occVCzlgfhXQWXio3IMvo9ZD2WzXpA95sYXVggBMJA/TNLxnzWiKHCVGmqH1 64oPlMnoMELf1sZuO7igQy2lDpmukJu76CpqaYhB0+1WtUeM3Y958ahQThFSXlki xw6At6sArIa2O8B+w/afhrVTFY6RHuAoI2+js4/stoXghRqhfPSkfTe0AlRA137y K3AhJnQzk7NfVaDDaiedoytFxJgT5Tu5cnHvXIzj5vHjDUhXBezN6L+ylWzdMxsr r6k105LYTSqZxGFHJcAFYsr8vTB1FVwGUJsz7DD/oW0bRNK943eA== Received: from iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta01.appoci.oracle.com [130.35.100.223]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 47j80watq3-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 04 Jul 2025 14:13:57 +0000 (GMT) Received: from pps.filterd (iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 564C5CSt032461; Fri, 4 Jul 2025 14:13:57 GMT Received: from nam04-bn8-obe.outbound.protection.outlook.com (mail-bn8nam04on2062.outbound.protection.outlook.com [40.107.100.62]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 47j6un5c3w-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 04 Jul 2025 14:13:57 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=drRhdlrGG2s60zyhJh6Ke8stkIlNYSNEl2hDn4OWzwkBYItqkIQeKYpfCxmMQIxgHxpLNQ7L1ii1u4GhmSXI+KlS3kfQ4/GEMo/eSddBn9705/TaLLUPPQMoMRgRv3aDTcd/KNJoeM4tdVT/gwFpBmKyH5nobOg7R3ACpA4++zguUWcOnBi5Sp+9Ax+RiZckxPZOC0HtaJ+I5saP/Aoz66NZgMMNv8I8dW/urbZsHy4NDqjGbADohPc2KA9t9OHu7/5taeCIhcx9beGwn6XQcmkB8Y0pRBTXxXIwikCWWVlWGTEmddw7X7BJi2D2C2m67Ifyw/J2HXxo40pVzN6cOg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=61BD5LSAL3ePTcp2nTnOYpbzqeA7fXDqaycmyY99YSY=; b=K+U7as0IYNrUD1Lz/yzqTJ1Y2hUDNyjrRbj4hJ/8bzxPbNUuq9e0wdozNj72dIoQADLYI3R6ezTMn2+JlvC9rbg3VPy1+xXGRGjEQ2NJfrW2KT9pXm2xtYWkzBYnre8U79uK17O0Rz6C5gNInhBGzjgelG4Td2MSiQd8uyQ8vVR5EoD/KJaDW79RwOVivMmzDLBhrVcjOn5cd1gR5yedYGP5Wv1MNjeV8CuJxnIlBvabfw4LanQ9cWoMJEif+aDqvxqTNILxn1Wjmn7Y1KdDdTSbnaseqwnatAmdoZYy0jzy5iifDcPDbrh6bMsGYn0PpJd/7QZuoNl1SJcNjyI59A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=61BD5LSAL3ePTcp2nTnOYpbzqeA7fXDqaycmyY99YSY=; b=PlJ2ETR51Ar2I2VmbYr0+sYbGu+/yaYhbSwQIZHaiOl80RCD1G/8cFeCrvgU13b0x+hbjrr89yTjLY5mPRED4f2hC9KQGXzkibBTfreihTePIxbuBt7LqLPRCwdgoevku9gjeDYC7o5H96KMoT21Spa0q7JPeIW9DdWtzKXc4Gk= Received: from PH0PR10MB5777.namprd10.prod.outlook.com (2603:10b6:510:128::16) by IA3PR10MB8163.namprd10.prod.outlook.com (2603:10b6:208:515::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8901.23; Fri, 4 Jul 2025 14:13:41 +0000 Received: from PH0PR10MB5777.namprd10.prod.outlook.com ([fe80::75a8:21cc:f343:f68c]) by PH0PR10MB5777.namprd10.prod.outlook.com ([fe80::75a8:21cc:f343:f68c%6]) with mapi id 15.20.8880.015; Fri, 4 Jul 2025 14:13:41 +0000 Date: Fri, 4 Jul 2025 10:13:10 -0400 From: "Liam R. Howlett" To: Dev Jain Cc: akpm@linux-foundation.org, richard.weiyang@gmail.com, maple-tree@lists.infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] maple tree: Add some comments Message-ID: Mail-Followup-To: "Liam R. Howlett" , Dev Jain , akpm@linux-foundation.org, richard.weiyang@gmail.com, maple-tree@lists.infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20250703063338.51509-1-dev.jain@arm.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250703063338.51509-1-dev.jain@arm.com> User-Agent: NeoMutt/20250510 X-ClientProxiedBy: YT3PR01CA0059.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:82::6) To PH0PR10MB5777.namprd10.prod.outlook.com (2603:10b6:510:128::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR10MB5777:EE_|IA3PR10MB8163:EE_ X-MS-Office365-Filtering-Correlation-Id: 31a57006-8c7d-429a-938b-08ddbb04fa2c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|376014|7053199007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?LrpAV676jFDpDr4ZLO3h3vNJqTCEAddnk+tSTbpVet4RMWDv/8F3O4XNm1Fd?= =?us-ascii?Q?2kGInadj4dcA7JYqg2twCHc3YxRtA8x49iQwiT6S5zupekysH4tYjfWG0MOl?= =?us-ascii?Q?yT/ImheaxSuRRRImTxpdNa7G2gsQC2pZPmeyPjYHQlnlnQlPTauETpni5evW?= =?us-ascii?Q?OF8/LmNG70qwbvu+SVfaSktgePRpvAYEd5AxXnrU6kPEErEHPE6i87ZFLXFC?= =?us-ascii?Q?nsegXjNpiCWshOqWv4MIBkrPvtW1Ua/LzPlItJDJ036Dv/TYxul2ozpfohXq?= =?us-ascii?Q?A5kR+xf792TvukY74MRE2In+9VF167uwnykxGXhIrCzyEmO0bVQWR1gFmGSY?= =?us-ascii?Q?F/NLiv50hAIVwuP1qhcXqn53ssZ8YWey1CaXldvrm8YimajgFlYmzL0+Uso5?= =?us-ascii?Q?Fq+Oc7bUS5HJar6BH4zIjmrCtHQJt5dykvwoJ2WHpqHmvz9iQnlkPBB+Nnz7?= =?us-ascii?Q?zPzlsjwFLTRSAkZuJSAvduRsRex5++f8+3WZIzkvsFnEmyYOs8kPVx3nhNJW?= =?us-ascii?Q?h344LEJF7Nlng30a2jSonKiWVchIZk5kMlaebQKx+ZJx+uddORuqxTA2An7+?= =?us-ascii?Q?uG9IImvExqDg5G151kNWB9nK5eUFbjbjtxqDEt4KR/l9ztKJFpGt7q2hAp82?= =?us-ascii?Q?8xGym6w90FUbtFS5wLcl8VvDxxKmQXOphIxGZDXr+Y7EICr1kRhKGAz4FkfU?= =?us-ascii?Q?joeQEz64JcftFgSgvTOUfBpzAcIIRi8er6SkYx8Qp3KANBCfKA6izNmPF0Bf?= =?us-ascii?Q?bVWOL4Dr3UsNBqH2Y5wiX/ahGilRK9AoVoDXy1FFTFGKsidIhlpDAYPJqzgv?= =?us-ascii?Q?YpfBfU49AcioSlRmuFb/NCe89lup0MnhpWfK5xDaaxWWILc9P3Jq/FDt4tln?= =?us-ascii?Q?VSUy4FbcmZWTr+fmxfHgv4RH5tqPeKLqQZ2PTLHoMbkk5Hj2c+/e1pzNCC15?= =?us-ascii?Q?DFeD9CHq/zt7ZhEZIXSi/BQDEggMMNlPjle0w7F12nvFDKgZgdBeeLgydp0t?= =?us-ascii?Q?pf+FBMOX+ue3k10vw1SN9ua2xXQuc9p1pfDf/y+vCVxyibLCKBCRHpClDs2c?= =?us-ascii?Q?GzBNmMSEM+xnsg7IFxizAj11sszoFvXL69Xm5N4vHkxGkExa7jZsHWdP9DLs?= =?us-ascii?Q?/O98HktEHPbUDArOq82EDGpHuo/kLl/cJ9HCAWoEeYcOYE4ZUeU6ISBtPsxB?= =?us-ascii?Q?fDhUF8vGOqW+Sieohfx/IgWM4eBk3+szuFBAYsoQzPOMxZdggXvlo67x+7lb?= =?us-ascii?Q?rv6PA86sNpP1o6eF24aTDjNSpPpPxXPKTcAOl7aoH8/t59XIVzdvgI+6lvrm?= =?us-ascii?Q?DHeBlJVGf9+0oNNOo9DwWUGptM9wkj3oCfeGBspPI5lLIyZCa2gz4VvbOMOV?= =?us-ascii?Q?m7qvG2GHTKyKeiEpstk2h5G0Krxa7D9wgmNA7ARhXGb76xboQrUMYQQTdSxz?= =?us-ascii?Q?VGh1PBN2rlM=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR10MB5777.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(376014)(7053199007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?5Eh/uWYrqpNiqpxoO8/breP+RNTWcO6J4bb79gNSKdjTX5vladpdf4gMDPYq?= =?us-ascii?Q?dJ63gcHIxvDJk53KtH3nyxaXPneCQRIZyuyGtHV1lHzAsZkvdZ16XJWgoKEF?= =?us-ascii?Q?Rk0EBNY7T1Lb05L4smgC12wf1nTKCV/e/onvBquHCeyXHbwUi1ZE26mm7BY8?= =?us-ascii?Q?b1TkBzFBT1V5SSoLVOAb1I560V/xJa5jM4VZnj8N0NlQyTfxXV9FRgWBjiGv?= =?us-ascii?Q?xymtTGbOY5MI69zR2SwuIhRHcHKsUFXs7gFaRgk+ZwWgsf2ZWFblVUNU1Avt?= =?us-ascii?Q?Ze+jy6wImsM5dJXEWShMesEN/R0RF4BVi10qfDoXILHOnFsA1rSNQNbb/CaV?= =?us-ascii?Q?HN6v2u1XHbR0+cEwCqpCsjyu9elcq5bplMJQAa1wFy6mo5UGlnYNihGH6ZOz?= =?us-ascii?Q?soCIxu9LVlb9sUe6g7yL8S0ZqOI5D2QJfspVWm7mi3oj44mwhk/W3fjikufx?= =?us-ascii?Q?POUixXq1PJZa36BkmjLi0gA2WK+tkP6M9u7FxJfoQ84bDYou6cfZWnUonK7r?= =?us-ascii?Q?K3YlWgW/Hv4NKZwI061uZ9RQVtQbj9o7IgEdMsaUTfwExTtPE8U6UDzEx7Q8?= =?us-ascii?Q?5UjCKWeCuttZbkG6v7vC1TbgphQ2tRRcKs3KykSyScsJWbdiAtWYEDc/fA3K?= =?us-ascii?Q?YEsCtLP3tCHDexNNUR/4vX3H6MGIVwUwrFZxX5Htj3XDHyeJByQBXY9wPyke?= =?us-ascii?Q?UF54aTlbkev+HpKUwLHdwXpROqnFgkH3HOMgIBu2i1nGNDFZTCh/UgOwskaJ?= =?us-ascii?Q?+DAJGJr25AVlk1orSC61/zeXzuK9zE2SaRU8RRTD/nRiIHTRI8wMt9NPnlXr?= =?us-ascii?Q?a7N4h2ArSsUYUqcFme6NfvqoNpDNxLMfrnCINcpKgP+nZCd0wwcCnffhxDrg?= =?us-ascii?Q?hnhzQvmM5x0HZDTOCKjjEvWVU9ysiBr+0Ho2CNn4gol7gKafHFyZx6aaAliw?= =?us-ascii?Q?ZDXS1SLQRugGUFwrsMXKlnO4yPpl38yjq8pQKNVuN97hkMXJTDwosLd4T6wa?= =?us-ascii?Q?oFiGPiO3WMccMCRcCRIaf+mLzVrRACiBUmUo9+NmZIwiEkUfTwvA1FW8hm0h?= =?us-ascii?Q?DN6g0hFxXlGolDjZUaggplLkKQLFJ5md8SKin1RGjWrvVbDCW1FVp8XX0jKs?= =?us-ascii?Q?IYzrAEcgSBnhw8r1cC0HbXYY1lQe2cf489vRhhA5BI5T9pJ0vsBvDXj76G9T?= =?us-ascii?Q?zyF3t75SH13gMEssyWs20B9nQdp4ALyeElcHdTZiprB6+QDWYChWveQO9Bjh?= =?us-ascii?Q?/pIeS4ntd6dy5ogdrI9gij/X0/2r82+Vw6z9KGGvb/KwsVN3xeU5fHiCofAM?= =?us-ascii?Q?Z06eGtXEcZhpsXEac81UxWz5nTr/GENnhdGsGTksD3OWHB5sryFNec07eMF7?= =?us-ascii?Q?ugUrGxIZFMHPBi1hPymKAg0EskjeuSi5VoUdo0iDFruHar38gdvuSGVU0zcD?= =?us-ascii?Q?ReBaWpdTQKZ8SDoXwmuOJKlpmmHVtQKHRo/dDmGzC74jFFpD1+J1w+9xADGL?= =?us-ascii?Q?38mGOd7Ij/CVzSUSS/abtwXv1tMyEgxxhVYA1V2ZoS242bKjXgskuKyU/7lO?= =?us-ascii?Q?wyZ2VGy+IIfKzpT0RgRrhhkV88xqzPQD4pBvSTNb?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: eC964XxDX5FK/KBPNrlEK8/hK+iaNMzUUbOyMSq2BvqWUoN6SHYNJ4Z3/0ID7xdjzuXgifHid7bN23TZnyvs/CGWTU/cmIvPGbG9ID9yVulxfoxeLPKRBfs50Gd50JKgz4xOm9r8Zrf9i4dj5qM9wDBJ/KGHoP1x7n8MZt5RVGeTRiEuAR74yURZXBpN2c9u4pUrfHMFYldTQ6YnafXfcOXBfckDbLCVmxTVaQtKXdR7k2VHN6jAmYl80yGCyd8bM5FJnBhgPoCLANPqCLszhwtnEhFVtBNeBT/v3v28e/9WyF4DOe+64DnANujaRX/RciHGx8xWuPrnJQ8gky2Ojs917BOt3PgMLuZA953k6bdYwi1eumU7iVuf5ipbDDow3lidJ/4FIL49c0u4NGnKny2DeG7BAQXOWmN61vpmIDeHhI5wh8ShbYDZ+zj8EJZzrJRUa2V0fPIxdbyZCX5SUqK34kqJWB6zO1/fKFMLs0pbFS1v9U1Mm8/aEUAoxGD0hQLRUuGNlM55j8dTs4iWTINry4ewhgtcGn+7/Eo85f+6B2en6Kv+4jDv2k4vaArDUBuEZ15LjKi3a475gnAGU487iGqAGjtfnvUFqUoasHs= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 31a57006-8c7d-429a-938b-08ddbb04fa2c X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB5777.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jul 2025 14:13:41.0066 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 2J3ZJoNeHaoDb01M+i2CKn4T5n0wVfxv2rUZHIs0VG/Ceeu4He6JjBMEpcsC16PFDQNyBAF101X0kori5gwG5Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA3PR10MB8163 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.7,FMLib:17.12.80.40 definitions=2025-07-04_05,2025-07-04_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 adultscore=0 bulkscore=0 malwarescore=0 spamscore=0 phishscore=0 suspectscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2505160000 definitions=main-2507040108 X-Proofpoint-GUID: Clq17cZESG54kVw-d-w1v5MOpVcgxFVS X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNzA0MDEwOCBTYWx0ZWRfX7OHSynwfmpk+ vArflFDANFoWumsfM//Rk1oblHuD8pqjxGaoa6eVphJFQ7RZujk6Q7RhhmdsG6l01IXow8hwrWK T2s05W/kxTpZAWu2qET3Cmwp4njYsk9S9DFlXDX7j+pHwJ2fpaP+J29nDadzN1+Hx59v9T0vyj/ zxxt1hBJIO6JYJEgWXiw6fGeKXiNdjjOYob8wxWW5ZWmZUeuM0bfbOPs6rc5UcSW4rbcjXN5NjV 3czAOyEgwz0cMBrVnLLzOSngoatFVRyl1bQCvaBaJDXZ8E+G2Fxx6QjrC7P45X5E3wVoL32+1+s zsmLgzzzgAueh5xrpfwnsngyTajUySw2EfOp/7hbU48Q8i30OkBcktZMGxHjBMp1C5DiNarpaMG 2Xy186NXoeLgk/OPHz+lblB1DbE1IPeZUxYQKL3p5u6ok7lujkqX9r43lusfV49YEJN4kcKi X-Authority-Analysis: v=2.4 cv=D6hHKuRj c=1 sm=1 tr=0 ts=6867e1a5 b=1 cx=c_pps a=zPCbziy225d3KhSqZt3L1A==:117 a=zPCbziy225d3KhSqZt3L1A==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=wKuvFiaSGQ0qltdbU6+NXLB8nM8=:19 a=Ol13hO9ccFRV9qXi2t6ftBPywas=:19 a=xqWC_Br6kY4A:10 a=kj9zAlcOel0A:10 a=Wb1JkmetP80A:10 a=GoEa3M9JfhUA:10 a=VwQbUJbxAAAA:8 a=7CQSdrXTAAAA:8 a=JfrnYn6hAAAA:8 a=yPCof4ZbAAAA:8 a=7IPkZRsMv_DBGOYTekIA:9 a=CjuIK1q_8ugA:10 a=a-qgeE7W1pNrGK8U0ZQC:22 a=1CNFftbPRP8L7MoqJWF3:22 cc=ntf awl=host:12057 X-Proofpoint-ORIG-GUID: Clq17cZESG54kVw-d-w1v5MOpVcgxFVS X-Stat-Signature: c81u888wfeb94jx5q8cdicrxytnkjobi X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 6431C4000D X-HE-Tag: 1751638441-908414 X-HE-Meta: U2FsdGVkX1/Q4w8hBxiI0xq+Zn65so34sP78Mu8fsorbI+v3uaKwMIArx6Z/b313NSrXfR/7tZoPfjcSGH7PrUH0gaOdDmafRdVhBUV3SB3AIF/vBSsOxsdrruzvlVQwJygOWnmQBzeIGH5k03Cop02ofPLn18EbfuuomS0XZSxtNEeWZaGEanY42dYL1Xs2UHWOaqAnbFzNTcnYnYe6WOscPyWmV/gd0qx4VUqJFF0uJ+s8OEg0D280sfMARauzYjg9edeePa4StInK6etfQwqqflqId6sXwGofSFC2rJQsHOYi7Xj2ujJpbIMWN/w3hN6YsuMQ4imByEWLcbcwMO2AEQzvySCWhSm0KtCiM/lxYD2e1N3bNDbRookqZp6YPRvTWU6ahzVs1bdpGdbsGP9jSkc2fz2EshsC9PCwW0HqaC42qVB5ytjrEVpY93sTEMWWpl7FlDQS8P+u4q6wvh+Y3f2KB940Ua7JBKCD1qvkJle5u3Lc8+Hbp/WJXOeW8XFLQeJivYviFWwQI/NQbBpxAvTqHpB4/KEBIuht23kmHoWgN2ZpVcS16eZqAWQ5iwUwJ1WOb3nwsZYzuLpoKbg2EwBuqUWlwDkT4Ym4IZz08Mxo58ZKnWBloEFitFIi//YV7xnxZWcxJhm3Qc15U66l2FGiqjz36J6sbXr1g+GzxN/pUZ6Xb8ruIeV8cXxywXygEOXyCXGRiXxm1T9QKt6pkICrPUtHEKqY1xOD8BqYA51PvrqPp7RmPyUvc5tiveT2ISwh3aQ122Xeg0i1iI+SxOPm1UaqV1d4P++I9sI7gLpKlc50i85YOTkqogvi13e0s3m0Wq5YwmR7ZeC67nbAwIBvoGSLSF2A+oOtZXmJS8B4XluGYzF/qwJNBSkXIHyEuVvbY7zaLmHC1ScUF6wifM8AJUeKRzNO4C+wXvfbKTcbuvW3lyB3UCwO01kmSDqBeqT+MKsEd9xkFix dsPs3o7R atQdxVcAz87XUqaqVZzKh+AsGFqVSQEGzsjHeZaIaxBB+A5XZ+oq/1BE9L1XUWlq45UlRimiGVCDcnCVISsbbXW3Mmt89rJUd5d6pMadSBhn6pqyZ6ZPps13fEtUq/QjqDssHbyYdYuRHfH3NlVM3uNkyBhnOXeN3GIwBkxjRuKQ04zQBgflW1SFh0k0JqEzJe5jE7Xee6FKc8DseU6fJ+ZylV3mMvz+xTpLNQv7HauYmoMQT+fFP3afRhhWJptt8s1QAhp1CNLL6LGi3fvu9Hf3ru6n0ucxNtW+re3LUsMI6EwiVUnz79dnDzFsSlq4mlnHt+rK529dJQJig6gUvYFbLEoQhqOAm8Q+2Aw7YrJzcEhpU+nE6/hj4lgBQdSm2wpHEjI3eWL1j96GdF8Wh18lsgtc7WmJ7odv23w/wDrk2u3tuCMDjciILVYtS081rPX0OuX69Tl3XFOGQr8abaf9ie0Zt9T8JF8JxzlQsgh7IMNQraEHkcX0diQUlPUUi35GDYwc1isoKVHI2g+Icz51wDW1FgfiA6AdBFFY8KXiKHPd47r7hbWvb5hS9syUlSNACcEaQZ6sT9hkhFp7E3+A5ewHUlvn5PXGKjSLDHXOBFvDiOq/38cst37rZVj2UJi99TKUmt4C9PCDCVS2VtMZjNJ6mihyB/z7iy4bDeMLIfDbuMCXddYgdmSKvXj8ZY7/5X5s1Q7lXHoEL8LZ/zCQFYs8USi0dIdiyS53rCeB8izNcpTkFeEmY11H5eJYP5TxAPdsdqwngcTSncQbxCsRyXzs/EXjZwYWOKjWuEtNr3POqguBDD80aWSwn0tMjtJF8Z6ZPPgmZBMFfXw2gjOha5HjVE6yQGhJqiwHrV4YFnf3lPf1zsqEA7P2OR8KVXHcwbIeg1yutfqWt7RaacfmVVNqTn2kbgSWTzWdX0aoJWQikezAqOty6WNVzIjnh9lk1 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: * Dev Jain [250703 02:33]: > Add comments explaining the fields for maple_metadata, since "end" is > ambiguous and "gap" can be confused as the largest gap, whereas it > is actually the offset of the largest gap. > > Add comment for mas_ascend() to explain, whose min and max we are > trying to find. Explain that, for example, if we are already on offset > zero, then the parent min is mas->min, otherwise we need to walk up > to find the implied pivot min. > > Signed-off-by: Dev Jain Thanks! Reviewed-by: Liam R. Howlett > --- > > v1->v2: > - Drop MAPLE_ROOT_NODE comment modification > > v1: > - https://lore.kernel.org/all/20250626171918.17261-2-dev.jain@arm.com/ > > include/linux/maple_tree.h | 4 ++-- > lib/maple_tree.c | 8 +++++++- > 2 files changed, 9 insertions(+), 3 deletions(-) > > diff --git a/include/linux/maple_tree.h b/include/linux/maple_tree.h > index 9ef129038224..bafe143b1f78 100644 > --- a/include/linux/maple_tree.h > +++ b/include/linux/maple_tree.h > @@ -75,8 +75,8 @@ > * searching for gaps or any other code that needs to find the end of the data. > */ > struct maple_metadata { > - unsigned char end; > - unsigned char gap; > + unsigned char end; /* end of data */ > + unsigned char gap; /* offset of largest gap */ > }; > > /* > diff --git a/lib/maple_tree.c b/lib/maple_tree.c > index 0e85e92c5375..b4ee2d29d7a9 100644 > --- a/lib/maple_tree.c > +++ b/lib/maple_tree.c > @@ -1053,7 +1053,7 @@ static inline void mte_set_gap(const struct maple_enode *mn, > * mas_ascend() - Walk up a level of the tree. > * @mas: The maple state > * > - * Sets the @mas->max and @mas->min to the correct values when walking up. This > + * Sets the @mas->max and @mas->min for the parent node of mas->node. This > * may cause several levels of walking up to find the correct min and max. > * May find a dead node which will cause a premature return. > * Return: 1 on dead node, 0 otherwise > @@ -1098,6 +1098,12 @@ static int mas_ascend(struct ma_state *mas) > > min = 0; > max = ULONG_MAX; > + > + /* > + * !mas->offset implies that parent node min == mas->min. > + * mas->offset > 0 implies that we need to walk up to find the > + * implied pivot min. > + */ > if (!mas->offset) { > min = mas->min; > set_min = true; > -- > 2.30.2 > > > -- > maple-tree mailing list > maple-tree@lists.infradead.org > https://lists.infradead.org/mailman/listinfo/maple-tree