From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5556C2BBCA for ; Wed, 26 Jun 2024 00:49:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 55E916B008A; Tue, 25 Jun 2024 20:49:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 50E8B6B0092; Tue, 25 Jun 2024 20:49:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 387D36B0093; Tue, 25 Jun 2024 20:49:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 19F536B008A for ; Tue, 25 Jun 2024 20:49:06 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 9ADB91605FB for ; Wed, 26 Jun 2024 00:49:05 +0000 (UTC) X-FDA: 82271205450.22.2BB430C Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf16.hostedemail.com (Postfix) with ESMTP id 73635180012 for ; Wed, 26 Jun 2024 00:49:03 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=BcSvhmoQ; spf=pass (imf16.hostedemail.com: domain of gshan@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=gshan@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719362929; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=XGPSlA7WTVcLRiVfQ9BUqSjtD+lQaK58jEJVntu2EIE=; b=TJ+JvrEbpQHbzdR2I/6InXBSQrEhxLh3ikYR6/qG2wGkG6pEnOlmFtaV8gtPNcmBDUIGde omjVYQ7Fi8IYycVcszVCb99C/4r67FEdyd6gmSBJCR75fvq56CmPHUTwitreY7D3PayOT/ lG0iLnkz5jAeqDwznQiInuWXOHQagfg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719362929; a=rsa-sha256; cv=none; b=VbRZK3HNMk+YXhOIYfpntvJ4FfqwvweBJJSEPnIZ+r84zFoFbRO50HlK7JaTCMUBvYxSEX MRtQ2qBg1cwBRhklgZw7WmC88/wHqHtqsfYq4txr8Eg1QVc7EjBISkyTp24BzzR48AhF8y xyZVvYNTNq7j0502nkrxfHcmv40OLbA= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=BcSvhmoQ; spf=pass (imf16.hostedemail.com: domain of gshan@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=gshan@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1719362942; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XGPSlA7WTVcLRiVfQ9BUqSjtD+lQaK58jEJVntu2EIE=; b=BcSvhmoQaHIZmLybUejgEwVgwJG1t+DhKEiWw27/bwb7VZOEMTgNTKdCrCxtd1fx9PGVKQ 76ZX/kfmbFGty0+0582bLvpf9K9lbsrppGekN9WzsYzyvp2jdQAeuiodPi3MCwIhcLcNVb 6Qd9sesuAMaro8PN67Bu7GKsJAvovmk= Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-118-dsoH4oddMfm1B_7awdHt8A-1; Tue, 25 Jun 2024 20:49:00 -0400 X-MC-Unique: dsoH4oddMfm1B_7awdHt8A-1 Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-1f9c69af7easo61326765ad.2 for ; Tue, 25 Jun 2024 17:49:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719362939; x=1719967739; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=XGPSlA7WTVcLRiVfQ9BUqSjtD+lQaK58jEJVntu2EIE=; b=L6bBkqnq2lM5hL0Rmhh2S1IkRM6kCsCL3kaF/Ps+fjTb4AyJAChSws1ITarVsOyMPg /Hgdruj+MQxC9+aM038dRN5rLK+PoXh07paSXFsiym+uDFtIM5np87Om37alN1tyZfBZ 7SXk7HKHtC2e+YWGA1T5NQiOfrdZbJQKh7Zz4caKfbF8/+wBsm0rsHVSYpCOH3BBpJq4 xjY3GN5nabnZ7nclLQT6zH+sFU0lKluHJ855g9Oiq0GsWui3ws4dGe9O14T1UikW7i74 73aorN4zoYljxcIMhM+g/2YzveIwM5GIMmwX7h92kyDfylpBsvFhvRleCQ7gspHNDoOW vkgQ== X-Forwarded-Encrypted: i=1; AJvYcCVPDVsc005AJ0rkhbcfu6zBBqs1cMGGMOtDYbEoleJXb9o07uvrZOjv0+AFAU/+UATvXZCSD5FaYaG6/NAmOsUGs48= X-Gm-Message-State: AOJu0Ywe93q/CEbFgrC8joEE55iXe45EwwU1c1il0+cPeEE9a000d/Vo FF9k7hma3dvwYRiTlzF7nyRlvLzmp602Q2VbZ/EJT1uWfjD26YYlfoa/yJ2NpiFpu4voEenLWg2 6w3J0cZjO2YZfLsPHTGU6j3BoQ8UfsFHfxGtnQ0gCXqzhNOWZ X-Received: by 2002:a17:903:234f:b0:1fa:3428:53ba with SMTP id d9443c01a7336-1fa34285bb8mr101197225ad.64.1719362939549; Tue, 25 Jun 2024 17:48:59 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFdg8L1rPqETXUNyvWsHJ8NhP8lyoUTGeklOMi0XsgVFGiLooDy8aAoPg4Ip478gQazWq2s7A== X-Received: by 2002:a17:903:234f:b0:1fa:3428:53ba with SMTP id d9443c01a7336-1fa34285bb8mr101197015ad.64.1719362939087; Tue, 25 Jun 2024 17:48:59 -0700 (PDT) Received: from [192.168.68.50] ([43.252.112.224]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1f9ebabc62bsm87382095ad.253.2024.06.25.17.48.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 25 Jun 2024 17:48:58 -0700 (PDT) Message-ID: Date: Wed, 26 Jun 2024 10:48:52 +1000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/4] mm/readahead: Limit page cache size in page_cache_ra_order() To: David Hildenbrand , linux-mm@kvack.org Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, djwong@kernel.org, willy@infradead.org, akpm@linux-foundation.org, hughd@google.com, torvalds@linux-foundation.org, zhenyzha@redhat.com, shan.gavin@gmail.com References: <20240625090646.1194644-1-gshan@redhat.com> <20240625090646.1194644-4-gshan@redhat.com> <6a8fa8aa-fb6f-485b-92b6-868a522bd7fc@redhat.com> From: Gavin Shan In-Reply-To: <6a8fa8aa-fb6f-485b-92b6-868a522bd7fc@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 73635180012 X-Stat-Signature: snyrc8s68ggr3hrcaa7re5t158fqtgwa X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1719362943-470175 X-HE-Meta: U2FsdGVkX189R/xezcmBF1Hhe57kpglMDlcGLcKFVYhUtVKkhKAw79A1Kb9c5Wr90fU0bladRbdLvxhOqMSIxvTOoUsNlhOJa88CZ1iRqbDsihWq3p/z4eBJHy9QB/XqApKD6yKaB+bYk/c+E3aHj1FnL80Eup5vhe4KHJV3cmjbIlvKFKxEJsIt3PftWh3QZn+uYN2Em09RSZ1RJ50ZRsqH/77/yaLZW3JbWK3M+bm0fOXQZDvJ8Wz12ZQSsIK82ynvWO5CVRy6XbuktWQxsFfgHjqilCz4bGOhU9AKUv0DbwbiFm5gQOBv5Z10cbK+/+3NTghC1+mnuLKmk/zIRPO1/30keq44EEgUNrFxH3KB13q069AF+rTiTTJiuKy/u9oeedw/YVQ10jeMU/KNg02sz7mdLfUOvIlXzsMu5+BniR5pBEKjGaH/SJAV8tZtzQqaeKkief8orny0Vm/WF1lmetfaCAt+tcGkxinT2+5nL9UeW81PF4mpic5TseOU8J5vnZZ5l8jGEGNb4XI2ozLatCeUlZXzB1+9gUK3TNyfmIRR9z2XIkEgdMLkNTovx5Clcs9HrXNVLUI0cS4/e/mAebTs6GhV1X9gKdUf4eeNYb9ZEP6+3JAsvX2VbZwmmxFC8201Bgrz/nz/ekMxOtfphzqBKmdnRzzIc1lrc2Wi8+6q/41yJ0/cyCyH3iEWA/7lGSJYAlkxyVFeBOB9v04HHjVQ3rbFzJ2LPOAaPWFfEEVIcXDQZawPnZQr/tgKP3oe/vW9MU6xwC2tUaAR5kw3ISw2gllG1fVdS5yXJhb0pkT0eFccsCl4ygLhJ60LJZ0TyfwfC0knvJNLncPjSALZkqzgtT3vxOwx7lmrZtU152sLiWzNUircACkBWU/u2c4PsXyM32KMbXU+sDPy2MsfDwAu/PaKJDPF0ApC1bR+twsGxO0SAIwFcwxxhWDuLKExHd6ZYbIAA/HzWNo bO1gKOfe WHgg4tY2FzDr7TClE4l8JDCZtO1XOd+xgLMsCyG9/4/mKQVtAoQRpLzZfu7rsvpVEqCEbGSuHRddkNnS4lUYGoY3FGuPV4WUHPuaxCJqEmzDlUzfnq+4l6fx6TgOFabIqFdWjylSZPE/vn9T479BNVQ58c+lVc4OqP+D5FXAjdGhZGP+s6R9VbosA6QT4sdl5tsjrjLKz1JdvI57vWNtZb8k/7/A3ch4scbZc6YT1KQE17/8nkP5HcoZD3sJ0fjt0GMtxwZgsa3JUBJoV8DJ+k29BDgPpT6urYTK/Elt655JVodU7EYgul3/qyRJy68yzdTCZck1cwsPSbpxsyKYVfFe7FOi3DH8RNAWGLqyI0DigZTrQSz7Oa3F6LoDTtbbmEpi/kUc+6sKgvVxcdQFiF9lG8DjPG5rlf+9pJydGeGR9pThUTQdTVc6qIqIq+Pq6Svwq76FjRkTu32JIFOGEM2G3/5LBukKN5luNZ1T5MBmhHcdBLhRCi10WrWXHA999bD4LpScuImKvlxn4U9xwQkiJ2+Qyf/eknS3dI3FoTxtjHGs= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 6/26/24 4:45 AM, David Hildenbrand wrote: > On 25.06.24 11:06, Gavin Shan wrote: >> In page_cache_ra_order(), the maximal order of the page cache to be >> allocated shouldn't be larger than MAX_PAGECACHE_ORDER. Otherwise, >> it's possible the large page cache can't be supported by xarray when >> the corresponding xarray entry is split. >> >> For example, HPAGE_PMD_ORDER is 13 on ARM64 when the base page size >> is 64KB. The PMD-sized page cache can't be supported by xarray. >> >> Suggested-by: David Hildenbrand > > Heh, you came up with this yourself concurrently :) so feel free to drop that. > > Acked-by: David Hildenbrand > David, thanks for your follow-up and reviews. I will drop that tag in next respin :) Thanks, Gavin >> Signed-off-by: Gavin Shan >> --- >>   mm/readahead.c | 8 ++++---- >>   1 file changed, 4 insertions(+), 4 deletions(-) >> >> diff --git a/mm/readahead.c b/mm/readahead.c >> index c1b23989d9ca..817b2a352d78 100644 >> --- a/mm/readahead.c >> +++ b/mm/readahead.c >> @@ -503,11 +503,11 @@ void page_cache_ra_order(struct readahead_control *ractl, >>       limit = min(limit, index + ra->size - 1); >> -    if (new_order < MAX_PAGECACHE_ORDER) { >> +    if (new_order < MAX_PAGECACHE_ORDER) >>           new_order += 2; >> -        new_order = min_t(unsigned int, MAX_PAGECACHE_ORDER, new_order); >> -        new_order = min_t(unsigned int, new_order, ilog2(ra->size)); >> -    } >> + >> +    new_order = min_t(unsigned int, MAX_PAGECACHE_ORDER, new_order); >> +    new_order = min_t(unsigned int, new_order, ilog2(ra->size)); >>       /* See comment in page_cache_ra_unbounded() */ >>       nofs = memalloc_nofs_save(); >