From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E4D7AC77B73 for ; Wed, 24 May 2023 10:13:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 79B45900002; Wed, 24 May 2023 06:13:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 723DA6B0075; Wed, 24 May 2023 06:13:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5C71E900002; Wed, 24 May 2023 06:13:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 4C63B6B0074 for ; Wed, 24 May 2023 06:13:15 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id EDE601C779D for ; Wed, 24 May 2023 10:13:14 +0000 (UTC) X-FDA: 80824735908.29.135C410 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf02.hostedemail.com (Postfix) with ESMTP id A35D580014 for ; Wed, 24 May 2023 10:13:12 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=J854jhGb; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=8PPtdtNJ; dmarc=none; spf=pass (imf02.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684923192; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/ve4/TtYTb+xjne8MK5462M47xa5SsY8B2FkwW34+Ec=; b=lrlS2jOZCMcfC1tBdoj19jsUBceb0Zn5p83ys+rDp34L1bAV5piIg+5yfKcxrrbtf9Ndt5 FfqVUGY0QRXhk0SBJoDgQxqbJaYWvrHeaGU7nO4Ow8Sp5eOD812fSLuwuZyHE6b0fyDdS7 Afm/Cg0I7On+l1jIh0ZKsQQD5RZeZ1Q= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=J854jhGb; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=8PPtdtNJ; dmarc=none; spf=pass (imf02.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684923192; a=rsa-sha256; cv=none; b=6ao5ZyoJBUsASHK5ylak0MwVqNIZj37qAYTxSevM3tilE3QqUvi5sF6BFQcmxfJACTFs6z 2B14EpKBsnH60/sTl1Y+LyoZ/z68fD6OHDz4NN1z+2eRdCy1DxpgQtSTcRkgQhgH1tP9ob TpQvoPx9MNi5MxgVF7AdFL1i7uY1BqI= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 06883223C1; Wed, 24 May 2023 10:13:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1684923191; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/ve4/TtYTb+xjne8MK5462M47xa5SsY8B2FkwW34+Ec=; b=J854jhGb1iler25PD7IsLRhDY4qoNhjLVAy1/X25dxY5NIvulnv6l5hExoBxGabJwFyDN2 NtV6g1YcuEl6ruTvP88ymkpxRTHoCn0BVUvAOTmkCoZ9AwY1e9k1t94YkXMYx9xiS9PUiw Yuh7KrysetiKHjdZq0ICvFqn8qChoMs= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1684923191; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/ve4/TtYTb+xjne8MK5462M47xa5SsY8B2FkwW34+Ec=; b=8PPtdtNJ/oSkIBJ1FkAulBoYKRBsmhFmFPjHKM7RavKLfxQz/S+ayzKm2bWdeCdLTnCg1b YjnkN1s0fBFUg5Cw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 45D9B13425; Wed, 24 May 2023 10:13:10 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id OFd2EDbjbWTwGgAAMHmgww (envelope-from ); Wed, 24 May 2023 10:13:10 +0000 Message-ID: Date: Wed, 24 May 2023 12:13:09 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH v3 08/11] slub: Replace cmpxchg_double() Content-Language: en-US To: Peter Zijlstra , torvalds@linux-foundation.org Cc: corbet@lwn.net, will@kernel.org, boqun.feng@gmail.com, mark.rutland@arm.com, catalin.marinas@arm.com, dennis@kernel.org, tj@kernel.org, cl@linux.com, hca@linux.ibm.com, gor@linux.ibm.com, agordeev@linux.ibm.com, borntraeger@linux.ibm.com, svens@linux.ibm.com, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com, joro@8bytes.org, suravee.suthikulpanit@amd.com, robin.murphy@arm.com, dwmw2@infradead.org, baolu.lu@linux.intel.com, Arnd Bergmann , Herbert Xu , davem@davemloft.net, penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com, Andrew Morton , roman.gushchin@linux.dev, 42.hyeyoo@gmail.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-s390@vger.kernel.org, iommu@lists.linux.dev, linux-arch@vger.kernel.org, linux-crypto@vger.kernel.org, sfr@canb.auug.org.au, mpe@ellerman.id.au References: <20230515075659.118447996@infradead.org> <20230515080554.453785148@infradead.org> <20230524093246.GP83892@hirez.programming.kicks-ass.net> From: Vlastimil Babka In-Reply-To: <20230524093246.GP83892@hirez.programming.kicks-ass.net> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: A35D580014 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: c18i795bhn7a9crk576fae6pc6neuhda X-HE-Tag: 1684923192-207015 X-HE-Meta: U2FsdGVkX1/l0E2KeFF3hd6ELoywJFwarIBIiEvbE9uH7sKL+FWWWImbMAO0lDiJT9krUWavaGEmrpb9JpSubG5hu19c1hJu0g2x7JKjfxZPRvGnELuKowx2U5R3XDVi3liRxrwbsFG89QTa/tnOFAKwVkd2PzS2XyPTF7GCpESuj6+eYFJpQFBTxMKLcs30XNTkTMets3jhgA7K0zmN6j5UN0Tk7LUhVVIcajbpMpfLq99JY44ZuEHTs+vW4h9qw5J8cXc8BbZie2mAX1cn5ht5lNesa3uM8McgcjUqLjSgjkluUcfTgNoSJ5fUpsmEJT1mszvieRNcu0dlJIQexMlB6MdUvBsnOGVnWRJjfDY8sxiBPthLSgiRvV3z6p78jtf4QcxLqfV0EKxpkUvJ9emkw+hnGb5TOa+g32/oAuDhfRHazYXaq9lpwGDwImyEpekV+17NQZCnK8yaSsyWUVNtPD/ZbdO/p5zoOiSB2OUGlRrq2VK1oKSZdteHDSgwS6cBRpCB2vwPuEtGXlJ9iVy09WLpPMUhEdOlYTtMqhFEa/EGS96QlMzkU7jUAWzj4yL3GSbOsyhsV70XkV1UPINPwawyxkbB1jyieSpEdoeuSJOo7EtGLyOh/1D3Q5o/l0Zi8DoKLJrkDuTWYKrPt2RkxAx4K+YJePt8kyb/NGKUZP/s5JsfTeq0qQsaa3xhlOcxxnzpILf6AgGtjvxBtlvFVBx6YP4TOVvQ+6pwoR6aBTtBS8GY+L7Ts/jCBynGzc24n4y0ArsBUQdQXnq+jbQoUY0jUmAmOW44IUMxdeI5DTzr1+5skueKjC5RlRRWu4uF0F2Pu/ksjipW8xF3aQHyPUXM1fMmNgfH+JbNwkSQKZbCiN7vJHP+VAHZp1zrRrSUqvzERPBT5ImR2HKl8B0VlIs2s/1e+JAxKbSNrWj2XyomcNen7h3mp47PoLmzdLerO04c2BlK3Cqpg5M lFHzd+3x ls9prPA0+JoTSTcUck7GBV30d/7N+6H7SWqMIfh+SdTKf5sTZrY41CdC9Zol3qsy9zxCR3c+FWFjr8bAi/Zb4kOmP89WhDnZ35xQCL8rcmW7kZARnLAJk0xQe9gWU0AMJZE557kQTL60cV6/M6px5GtcWvE5AEXSycdHdPUvrYNogIfNRTf5ACrc+MZtMYB4mHxWTfdiHM9fj+Rd8arlZ3vqcidalLtwBqrjh/GN5QnccGolQgkYubumf6T8RVZc/Bg52w7UE4zZt0TFm0dg3VMB+FbdDZmS0tgzmk9ZhL1tQYjHld9/DNxMHBdH9DZ/bfIHV X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 5/24/23 11:32, Peter Zijlstra wrote: > On Mon, May 15, 2023 at 09:57:07AM +0200, Peter Zijlstra wrote: > >> @@ -3008,6 +3029,22 @@ static inline bool pfmemalloc_match(stru >> } >> >> #ifndef CONFIG_SLUB_TINY >> +static inline bool >> +__update_cpu_freelist_fast(struct kmem_cache *s, >> + void *freelist_old, void *freelist_new, >> + unsigned long tid) >> +{ >> +#ifdef system_has_freelist_aba >> + freelist_aba_t old = { .freelist = freelist_old, .counter = tid }; >> + freelist_aba_t new = { .freelist = freelist_new, .counter = next_tid(tid) }; >> + >> + return this_cpu_cmpxchg_freelist(s->cpu_slab->freelist_tid.full, >> + old.full, new.full) == old.full; >> +#else >> + return false; >> +#endif >> +} >> + >> /* >> * Check the slab->freelist and either transfer the freelist to the >> * per cpu freelist or deactivate the slab. >> @@ -3359,11 +3396,7 @@ static __always_inline void *__slab_allo >> * against code executing on this cpu *not* from access by >> * other cpus. >> */ >> - if (unlikely(!this_cpu_cmpxchg_double( >> - s->cpu_slab->freelist, s->cpu_slab->tid, >> - object, tid, >> - next_object, next_tid(tid)))) { >> - >> + if (unlikely(!__update_cpu_freelist_fast(s, object, next_object, tid))) { >> note_cmpxchg_failure("slab_alloc", s, tid); >> goto redo; >> } >> @@ -3736,11 +3769,7 @@ static __always_inline void do_slab_free >> >> set_freepointer(s, tail_obj, freelist); >> >> - if (unlikely(!this_cpu_cmpxchg_double( >> - s->cpu_slab->freelist, s->cpu_slab->tid, >> - freelist, tid, >> - head, next_tid(tid)))) { >> - >> + if (unlikely(!__update_cpu_freelist_fast(s, freelist, head, tid))) { >> note_cmpxchg_failure("slab_free", s, tid); >> goto redo; >> } > > This isn't right; the this_cpu_cmpxchg_double() was unconditional and > relied on the local_irq_save() fallback when no native cmpxchg128 is > present. > > The below delta makes things boot again when system_has_cmpxchg128 is > not defined. Right, that should do. > I'm going to zap these patches from tip/locking/core for a few days and > fold the below back into the series and let it run through the robots > again. I noticed some comments in mm/slub.c still mention "cmpxchg_double", dunno how much you want to clean it right now or can be postponed. Also some sysfs stats files for CONFIG_SLUB_STATS (not widely used) which we probably might try renaming without breaking anyone, but it's not guaranteed.