From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5911BC77B6E for ; Fri, 14 Apr 2023 10:25:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BDDEF900002; Fri, 14 Apr 2023 06:25:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B8C686B007D; Fri, 14 Apr 2023 06:25:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A83FC6B0078; Fri, 14 Apr 2023 06:25:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 972026B0078 for ; Fri, 14 Apr 2023 06:25:08 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 4DB82C01A2 for ; Fri, 14 Apr 2023 10:25:08 +0000 (UTC) X-FDA: 80679613896.19.C3082DB Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf22.hostedemail.com (Postfix) with ESMTP id 1CA62C0006 for ; Fri, 14 Apr 2023 10:25:04 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=BHLCDZx8; spf=pass (imf22.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681467905; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=QcY9UQN+sgDIeuyeA2i6LuRS8ISnfWHgkBht0s/19qA=; b=7QzprotfCnMLGBZdtijdfddKHXYDcZgQs/GFkmPscPHaAdr3C0DMxSHM6pcj0ebgetoFVq V0XFeQxrpXlTnYiWj996mdU5XWTT2sP50x7w2Mi5Qo8PXFANnGtuQ0SroZLYTI7bll9Y2X uVgg9jTTy/mvNbvVGXUG1i20ASTEhsk= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=BHLCDZx8; spf=pass (imf22.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681467905; a=rsa-sha256; cv=none; b=EmtKjvD2XH6GvMgx6tqhZWEEtROkwp92nNXYxJIrkV+T71S4fj7ky6Z4vBN1aoFFE3SC1r bGLZOvHndtYm5HEDI5peAGOxWJ54waEOJdbLlXkg971oZiaG6fiLFreP7w93LQYw1YQLOB qGa71Ncq4Fqiu8B3Yow5mM10iqJ+0/o= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1681467904; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QcY9UQN+sgDIeuyeA2i6LuRS8ISnfWHgkBht0s/19qA=; b=BHLCDZx8gCJweJzPMMZsMXXu4/ilnZLXDjuyBwzZMNXuPggmWbVihuerV4dgjE/Oy/FFnv yTxLZRQE8Vx6RvBB03PCF4lRyafAKuN0QTxkMA/v7HkX8tGfp9j4emUy5Ck1QuRLFha9Dy yte78GMaFa7tvZCpT1m6imHMjkmDnbI= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-326-nu5v7EGiMaWjYerdYJ6l8A-1; Fri, 14 Apr 2023 06:25:03 -0400 X-MC-Unique: nu5v7EGiMaWjYerdYJ6l8A-1 Received: by mail-wr1-f71.google.com with SMTP id m9-20020adfa3c9000000b002f4a18aed73so1980563wrb.20 for ; Fri, 14 Apr 2023 03:25:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681467902; x=1684059902; h=content-transfer-encoding:in-reply-to:subject:organization:from :references:cc:to:content-language:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=QcY9UQN+sgDIeuyeA2i6LuRS8ISnfWHgkBht0s/19qA=; b=Im6hTe9OoP7oMCEBId5YbrHfShI0CaacWvtbWijf+Doq1zVO/iAJgR2ebuTNsLHU8b WvrKdJH3rteSuTMekYOBsLdMny+/Q8Olb528RDxSWV/O5huw2gb80OeG7iaX9cR+X1QM 90CapPTxHgwhI43H326BwIVlgi9OA8HMK5A87+WW1eSbC6q8eQKdPCklXqMiYPHG8V9L czaR0eEOgz7QuxLjft31saD70SFcxf31IXE9tBd+eA59ZsnsW/YHEvSMkbmpS8qtxD0x cobS3U8ozZb2XfHEKOytkW9r3B7/Rfcf4j4fvYTKXPVNwi+TjkXMQhTTkL81+a2Ph/Qt gxIw== X-Gm-Message-State: AAQBX9c2ck5poiS29JXr6oVNtdUT/47LZtQfP3fCUJdBqDQaIloU2yZ/ rLLPYSO3rZ5y21epkuuXbFw3gPYja9PLqueRET1EIjxuTrjKz9nnzGI2Q4A+Yt4NOdlD+qVVwok pvgc1ck3Ofy8= X-Received: by 2002:a1c:f60a:0:b0:3ed:9ce3:4a39 with SMTP id w10-20020a1cf60a000000b003ed9ce34a39mr4168144wmc.26.1681467901816; Fri, 14 Apr 2023 03:25:01 -0700 (PDT) X-Google-Smtp-Source: AKy350aE0fJ16pyJLzb3fBgzbhX9M+NiOEOq9BBo6MIjOgyR17TW6oYD8CgWOQk9CaCcb1Vv4AXb3A== X-Received: by 2002:a1c:f60a:0:b0:3ed:9ce3:4a39 with SMTP id w10-20020a1cf60a000000b003ed9ce34a39mr4168127wmc.26.1681467901399; Fri, 14 Apr 2023 03:25:01 -0700 (PDT) Received: from ?IPV6:2003:cb:c702:5700:cb5b:f73a:c650:1d9? (p200300cbc7025700cb5bf73ac65001d9.dip0.t-ipconnect.de. [2003:cb:c702:5700:cb5b:f73a:c650:1d9]) by smtp.gmail.com with ESMTPSA id k21-20020a05600c1c9500b003ee74c25f12sm7605573wms.35.2023.04.14.03.25.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 14 Apr 2023 03:25:00 -0700 (PDT) Message-ID: Date: Fri, 14 Apr 2023 12:24:59 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 To: Stefan Roesch , kernel-team@fb.com Cc: linux-mm@kvack.org, riel@surriel.com, mhocko@suse.com, linux-kselftest@vger.kernel.org, linux-doc@vger.kernel.org, akpm@linux-foundation.org, hannes@cmpxchg.org, willy@infradead.org, Bagas Sanjaya References: <20230413233115.1878303-1-shr@devkernel.io> <20230413233115.1878303-2-shr@devkernel.io> From: David Hildenbrand Organization: Red Hat Subject: Re: [PATCH v7 1/3] mm: add new api to enable ksm per process In-Reply-To: <20230413233115.1878303-2-shr@devkernel.io> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: 4eky4h9uchzmmtyym1cmu89iqmgit7nz X-Rspamd-Queue-Id: 1CA62C0006 X-HE-Tag: 1681467904-852396 X-HE-Meta: U2FsdGVkX1/VGicNEi3vd0gMShpGmXfGgb1T2u+2JhvyCk+6Q+xkFoaeQvx+yGjvA7KA/4cqnaos8Qxrm8fxK9+uTqx8yVOAFj1upxBtR9orLxdrhOn0ceWkq/sHelwzCueEmvGlAe7ttKhSIak9Q206dYGUYhXhzDtKyI8Y05ED25fBzDz3Z08RrfmxHZ7/bssIyNQRXMtpKu3EmbFp3snkW4eq6wrvTuLcBY1RmLhQj8dcRYhpSYwDdxsOqgYaBTUmvxUS2nf+2YUCnkojvNHp/D7ngwTna7P2F9dwNPG1jsjoL8MllqhPfGmhOhXLQBmjfYSjlzdnGOI9KForMdK07rOCC3z+uIKsfaQEvMX/DpZeD/DqYGDKLgKEsz2NyCfPyZNtyuGUNxiy44skVL4KYLRvnjqz7db8tDIW44mAW/FaEUb3/2wF6ZGP1exWRUlm0RRnPJVbVAbamlBoZFX2zegtnL4rDCDUdcciqdSN6L1NHanePu5BIOX1eD7HH1kDA4pfga+/gA9CifoPkoMMPK5vIuD6TmENGYvgaNZY9xulqN4jvoU14nJJTOKyevg0/USqzH8QQpVQI16Ou634pZPZDupS7t5rV0RQkQ047D6lwm3yYcYCvdx2iNvR2xlEiRNNPbYCGNXScKgf27iMkW9rngFCwTB3gCU/vTb9faCNkU0bKPQ4QF5142L6JhTUCR0r0ZSIi2J/nSB60LnX5Mz4bXXJJWQFygPTSGHtwjtRJi55fv+tslAoJXtPRXv3acZ/llulwRxjuNUNmTW2Yi+4eYzla98A2U0viXLy4tbVLHHZ7Myj7awkWW7dNKxY82iodVN6/N5034tMXBpxjmtSHlKBsF9XuT+7d/fntIvXj6ckzce4AcLbx7d7kw+X6otwmM+8+8cy7D9l5LGiaf0Pc048gc/b6lPyieRBO7atNBRuftA2R3PaN5gODsHA1dceNkorZn4x0Jz ujUgFj4M cnWRhzizAznfX570o8386sHmYeblRecMMv9RSZVsr0RRxPGvg6AeBZk6uiAwCC6fgCpv2jS+FCMTHnntCUDgu9GVjqNrufQFYf8GKfgvVXxW/xdsvzaVwTumMaVWUYtJdApOPitNGYeslKpSp7wP3AFkvmZ5/sPeap6AW1G44GaRbcE5mCmm7XsnW5aMknl9j2YfNhsQ2+S5g7H2t9WF/iZU0hZ92tisnq8lo7gxVw7X9z3RI8VJAiDrVtAxUiknD4cGuJScdeKIPUnFlQVu0bX7eCxBB+EaL1UsJuY23lFpHrOoeH6Vs5KmdsM0dLad/YPZ1gJWlV8rb9SA9Y1OfSFdpJ0keDmb9V3Qp7cfMi/dQ72UOaNrJZ/leyfUBYrB8Y9ZYtNjaVRuLI3FL594cLfDgCQMYOch3oYgfK8ZXbqwYrKuCDkq0BUBW+x1xWguHbhPiFzcDmjKfLz4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Thanks! In general, Acked-by: David Hildenbrand Two nits below, after staring at some other prctl implementations. > +#define PR_SET_MEMORY_MERGE 67 > +#define PR_GET_MEMORY_MERGE 68 > #endif /* _LINUX_PRCTL_H */ > diff --git a/kernel/sys.c b/kernel/sys.c > index 495cd87d9bf4..8c2e50edeb18 100644 > --- a/kernel/sys.c > +++ b/kernel/sys.c > @@ -15,6 +15,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -2661,6 +2662,30 @@ SYSCALL_DEFINE5(prctl, int, option, unsigned long, arg2, unsigned long, arg3, > case PR_SET_VMA: > error = prctl_set_vma(arg2, arg3, arg4, arg5); > break; > +#ifdef CONFIG_KSM > + case PR_SET_MEMORY_MERGE: Looking at some other code (PR_SET_NO_NEW_PRIVS/ PR_SET_THP_DISABLE) I wonder if we also want if (arg3 || arg4 || arg5) return -EINVAL; For PR_GET_MEMORY_MERGE it looks good already. > + if (mmap_write_lock_killable(me->mm)) > + return -EINTR; > + > + if (arg2) { > + error = ksm_enable_merge_any(me->mm); > + } else { > + /* > + * TODO: we might want disable KSM on all VMAs and > + * trigger unsharing to completely disable KSM. > + */ > + clear_bit(MMF_VM_MERGE_ANY, &me->mm->flags); > + error = 0; > + } > + mmap_write_unlock(me->mm); > + break; > + case PR_GET_MEMORY_MERGE: > + if (arg2 || arg3 || arg4 || arg5) > + return -EINVAL; > + > + error = !!test_bit(MMF_VM_MERGE_ANY, &me->mm->flags); > + break; > +#endif > default: > error = -EINVAL; > break; [...] > +/** > + * ksm_enable_merge_any - Add mm to mm ksm list and enable merging on all > + * compatible VMA's > + * > + * @mm: Pointer to mm > + * > + * Returns 0 on success, otherwise error code > + */ > +int ksm_enable_merge_any(struct mm_struct *mm) > +{ > + int err; > + > + if (test_bit(MMF_VM_MERGE_ANY, &mm->flags)) > + return -EINVAL; I'm curious, why is enabling the prctl() supposed to fail if already enabled? (it would not fail if disabling and already disabled) For example, PR_SET_THP_DISABLE/PR_SET_NO_NEW_PRIVS doesn't fail if already set. -- Thanks, David / dhildenb