From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7279DC76196 for ; Tue, 28 Mar 2023 15:29:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E584B6B0072; Tue, 28 Mar 2023 11:29:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E0798900003; Tue, 28 Mar 2023 11:29:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CD03A900002; Tue, 28 Mar 2023 11:29:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id C07A26B0072 for ; Tue, 28 Mar 2023 11:29:30 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 6C635ABE93 for ; Tue, 28 Mar 2023 15:29:30 +0000 (UTC) X-FDA: 80618691300.06.34DAD39 Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by imf13.hostedemail.com (Postfix) with ESMTP id 5987220018 for ; Tue, 28 Mar 2023 15:29:28 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=arndb.de header.s=fm1 header.b=sfdyKRAb; dkim=pass header.d=messagingengine.com header.s=fm2 header.b=c+gYfBNX; spf=pass (imf13.hostedemail.com: domain of arnd@arndb.de designates 66.111.4.28 as permitted sender) smtp.mailfrom=arnd@arndb.de; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680017368; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=04hLKD+xWhkBIhadK/hWrq7vdkof5TtjWTzhRNoj4zI=; b=fL/kfY7KiFPGJAXn0Gv5mse57aGMaUnJAu1C3iIlBQ/BdYXWL9NDvDQWIqGRQU8lfjuCFp rMxYF0980Yss0TnGUPk29NG1GH3/BH03nHKj0Lb360eNOdkq4rUvVK340nR4qWE9D1dWII F7s/6rrMHNeUiWkEhnzThgRbR1wr/BU= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=arndb.de header.s=fm1 header.b=sfdyKRAb; dkim=pass header.d=messagingengine.com header.s=fm2 header.b=c+gYfBNX; spf=pass (imf13.hostedemail.com: domain of arnd@arndb.de designates 66.111.4.28 as permitted sender) smtp.mailfrom=arnd@arndb.de; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1680017368; a=rsa-sha256; cv=none; b=3ro5tDC//SM9ni9x8xBxPw0eEDa5OBF9iy2EEc3yTxiQm423T9BV7bZL+CaWUt9ge0WPQ+ +MTdWouBihTwNjbAEmb7NtzmPLupeKanaadGNqCwe0vefQrOoG76aPfzy4rpWI3dXwQE4/ arijjBwUVKXU0P9fe3QZsqENCHxSKxw= Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id C0EE75C012F; Tue, 28 Mar 2023 11:29:27 -0400 (EDT) Received: from imap51 ([10.202.2.101]) by compute6.internal (MEProxy); Tue, 28 Mar 2023 11:29:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm1; t=1680017367; x=1680103767; bh=04 hLKD+xWhkBIhadK/hWrq7vdkof5TtjWTzhRNoj4zI=; b=sfdyKRAbmeckYWZiFB yn3stllbfomGQuvPuTYnXgO87XQLUHUxTxi1ioyqHqwAdEV0+iOJE/yodinmZ0Bu EYMBPzMBSKLkKqRPlC2Ka6k/xHpI5Lh3Vs7Fh+bNooRj2KYvkbzQXogsqcauFARe 6BKpsitj9rMabyu+xDMljGQivtJyKNmlcmTzC8VJWT7jD/otdLs2b95HcI2s4khf ZCkCOwLYzyoFYQb15ACBhA5mUbFmXv3htVvaiPfqI3JQ/5IdN6WekSEjgOHFgpVV NDXU9y6hYltc1HW2GaYWveCEUR2xQvM/J3dod1wVjspev4R9lI50gn6vhrvOGlGJ kjQQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; t=1680017367; x=1680103767; bh=04hLKD+xWhkBI hadK/hWrq7vdkof5TtjWTzhRNoj4zI=; b=c+gYfBNXg3rKbHpriliIwcBagbXUs L1K2QLpzIVuzG/tqsHeU2V3ImrUUeiovxOoEqjek0Q3dJ0M30wZVmNGVG+WPPTjm 0gVtmveVB61U4lMrVkrohnqOHonVhe9zBmVmRoZ1ITqah75tyvu1XJh85ebA8qWs x7dVNA6Z5Y6O68F5fb81ESV4Rz0nE24GQkpshId3klReW0uivCG2Q7htBfFq1l/J 8xCmPgsJ3NTAkd3wuLgjoZP6owU8b+0pUm7i747H9NBoPoKwNjp78GL2Ysu7DpKO XdWOPbpdl7DXyrPVT9tFXsjACtPStc1EIY89OMewKy/UiDt00B8JsyYYw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvdehgedgkeelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepofgfggfkjghffffhvfevufgtsehttdertderredtnecuhfhrohhmpedftehr nhguuceuvghrghhmrghnnhdfuceorghrnhgusegrrhhnuggsrdguvgeqnecuggftrfgrth htvghrnhepffehueegteeihfegtefhjefgtdeugfegjeelheejueethfefgeeghfektdek teffnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheprg hrnhgusegrrhhnuggsrdguvg X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id 795A7B6008F; Tue, 28 Mar 2023 11:29:27 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.9.0-alpha0-237-g62623e8e3f-fm-20230327.001-g62623e8e Mime-Version: 1.0 Message-Id: In-Reply-To: <20230328122138.GA1275@willie-the-truck> References: <202303281539.zzI4vpw1-lkp@intel.com> <20230328122138.GA1275@willie-the-truck> Date: Tue, 28 Mar 2023 17:29:07 +0200 From: "Arnd Bergmann" To: "Will Deacon" , "kernel test robot" Cc: "Marc Zyngier" , llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev, "Linux Memory Management List" , "Zaid Al-Bassam" Subject: Re: [linux-next:master 6577/7309] drivers/perf/arm_pmuv3.c:44:2: error: use of undeclared identifier 'PERF_MAP_ALL_UNSUPPORTED' Content-Type: text/plain X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: dsmi671qnd9rmogu78a6pmgqxwiyxmro X-Rspamd-Queue-Id: 5987220018 X-HE-Tag: 1680017368-585463 X-HE-Meta: U2FsdGVkX1/InSIKAStK9eugSF0qBXHT6jDKC9l6bX16+JwbhMydqC0DZ59i9iR+m+GeGcE+mQAfjcUQD1MrOAylsK1jkp8lDl7H28uhPzKdmjArFqW48NxPZp2TyXRFkC1otpNQWzyeiv0PcGMKHmDiwo1N+8FJkUdJblLXF3vmXQm+EIpBU+HLkqm/UIQRAo9r7I4bo50WZGHU9p+PR5t7V7NcExg4mMdnjb3oYjhKSbfXHOYKAcZGxUzaNAr7+RG7B0oad1zt20wMayu5l0kCtLyhzBegRES1cAj3PyliYn4m7OselrEeliJVNWtXhYu38weFZFAAmwOcas+Nk4fU4ns1mHlczK8xxx8mUZOMHPhmFYywEOM3+WPHsRJCoM//KUBD8Ll3z3/PUa3M5exaaW//QRDHRgOiWL9DjafXBRQXQSy3Culb8SW1w65PZ5LPTSS18bmoMzPQBZQfpwq9vamgkeCOGXCNIllU25G+WcNrr4ampyz5cxoOLfK6coOS3PA7HL7fOY5jj7GSeZN7wXezud1jPk5XzznEaAMit1E7Fra/jguKhHD+uxQwdPQTiAwoELLzoerbqtGjk1SRugIV/Eqr0r9tRFsns/9Ly3vLtcT76WD2OpfZPGU8ErbFRZ74W0rTJUi3MD8epdp3fhpUydZnPVnrRSFL1hN0T8JY4esEneQmV705kugMG2xDAsKQznfXkNDvCVMNB/WKPbDX9fYnX3tPn7wojKOe27LMIYsS58YHPWgmS4Fwu2SOcOmO+372cvSo0NVWn+FjDZVoFvYpqt5jaPF4UaG6eyOiLC7jN1JRT9kYmNmcO9pYyivgyS3kdnxKyYuSWfL2/mRGpCc7HtxkkAGnY+PS22Rp84gV5gXNg+g7+2+Sm8sJ/jCWQg4xQhbspt+qmtCPt/qMol/rzZz4py3mlxwzw1wlKBccU1Po5ZwtRjR03lTa7O/TbA8uIipP+8P IyhWuGjs Kib8q2Chd5ka4iSvxcQyC4Xp4PB9JdudgWEeGFd++dkZlzKkNCHo8HW6wfvQRmWGDqYzRVG+5KdKijPxQnQOOR0QKd38Vx3cJsU0FPPbthAmPmOASi3TOATAAFpUsWi54mZeFiqQykDt1hyJmSE7N/fE2MgqXhBhbaCEFUc/MSer5+kIf7sd6WRPKqbqxs6ydHwMR X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Mar 28, 2023, at 14:21, Will Deacon wrote: > On Tue, Mar 28, 2023 at 04:01:49PM +0800, kernel test robot wrote: > I think the Kconfig warning is relevant here: > >> Kconfig warnings: (for reference only) >> WARNING: unmet direct dependencies detected for ARM_PMUV3 >> Depends on [n]: PERF_EVENTS [=y] && HW_PERF_EVENTS [=n] && (ARM [=y] && CPU_V7 [=y] || ARM64) >> Selected by [y]: >> - ARCH_VIRT [=y] && ARCH_MULTI_V7 [=y] && PERF_EVENTS [=y] > > Since we're selecting an option which has its own dependencies. I think > the easiest bet is to invert the linkage so that PMUV3 has a dependency > on ARCH_VIRT for 32-bit Arm (diff below). > > Marc, Zaid -- what do you think? I think dropping the 'select' is best, as this is still a user-visible option. How about this instead: --- a/drivers/perf/Kconfig +++ b/drivers/perf/Kconfig @@ -103,7 +103,7 @@ config ARM_SMMU_V3_PMU config ARM_PMUV3 depends on HW_PERF_EVENTS && ((ARM && CPU_V7) || ARM64) bool "ARM PMUv3 support" if !ARM64 - default ARM64 + default ARM64 || ARCH_VIRT help Say y if you want to use the ARM performance monitor unit (PMU) version 3. The PMUv3 is the CPU performance monitors on ARMv8 This way, it's still enabled by default for most people, but there is no dependency problem and it's also possible to turn it off. Arnd