From: "Arnd Bergmann" <arnd@arndb.de>
To: "Will Deacon" <will@kernel.org>, "kernel test robot" <lkp@intel.com>
Cc: "Marc Zyngier" <marc.zyngier@arm.com>,
llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev,
"Linux Memory Management List" <linux-mm@kvack.org>,
"Zaid Al-Bassam" <zalbassam@google.com>
Subject: Re: [linux-next:master 6577/7309] drivers/perf/arm_pmuv3.c:44:2: error: use of undeclared identifier 'PERF_MAP_ALL_UNSUPPORTED'
Date: Tue, 28 Mar 2023 17:29:07 +0200 [thread overview]
Message-ID: <d2de874e-d2e8-435e-a90e-a3aef763f2b3@app.fastmail.com> (raw)
In-Reply-To: <20230328122138.GA1275@willie-the-truck>
On Tue, Mar 28, 2023, at 14:21, Will Deacon wrote:
> On Tue, Mar 28, 2023 at 04:01:49PM +0800, kernel test robot wrote:
> I think the Kconfig warning is relevant here:
>
>> Kconfig warnings: (for reference only)
>> WARNING: unmet direct dependencies detected for ARM_PMUV3
>> Depends on [n]: PERF_EVENTS [=y] && HW_PERF_EVENTS [=n] && (ARM [=y] && CPU_V7 [=y] || ARM64)
>> Selected by [y]:
>> - ARCH_VIRT [=y] && ARCH_MULTI_V7 [=y] && PERF_EVENTS [=y]
>
> Since we're selecting an option which has its own dependencies. I think
> the easiest bet is to invert the linkage so that PMUV3 has a dependency
> on ARCH_VIRT for 32-bit Arm (diff below).
>
> Marc, Zaid -- what do you think?
I think dropping the 'select' is best, as this is still a user-visible
option. How about this instead:
--- a/drivers/perf/Kconfig
+++ b/drivers/perf/Kconfig
@@ -103,7 +103,7 @@ config ARM_SMMU_V3_PMU
config ARM_PMUV3
depends on HW_PERF_EVENTS && ((ARM && CPU_V7) || ARM64)
bool "ARM PMUv3 support" if !ARM64
- default ARM64
+ default ARM64 || ARCH_VIRT
help
Say y if you want to use the ARM performance monitor unit (PMU)
version 3. The PMUv3 is the CPU performance monitors on ARMv8
This way, it's still enabled by default for most people, but
there is no dependency problem and it's also possible to
turn it off.
Arnd
next prev parent reply other threads:[~2023-03-28 15:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-28 8:01 kernel test robot
2023-03-28 12:21 ` Will Deacon
2023-03-28 15:14 ` Zaid Al-Bassam
2023-03-28 15:29 ` Arnd Bergmann [this message]
2023-03-28 15:35 ` Marc Zyngier
2023-03-28 16:37 ` Zaid Al-Bassam
2023-03-28 17:51 ` Will Deacon
2023-03-28 15:42 ` Marc Zyngier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d2de874e-d2e8-435e-a90e-a3aef763f2b3@app.fastmail.com \
--to=arnd@arndb.de \
--cc=linux-mm@kvack.org \
--cc=lkp@intel.com \
--cc=llvm@lists.linux.dev \
--cc=marc.zyngier@arm.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=will@kernel.org \
--cc=zalbassam@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox