From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA81DC4345F for ; Fri, 19 Apr 2024 09:07:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4DF746B0083; Fri, 19 Apr 2024 05:07:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 48D906B0085; Fri, 19 Apr 2024 05:07:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 37C846B0087; Fri, 19 Apr 2024 05:07:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 19F7A6B0083 for ; Fri, 19 Apr 2024 05:07:30 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 8E87480498 for ; Fri, 19 Apr 2024 09:07:29 +0000 (UTC) X-FDA: 82025703018.21.0AB5E11 Received: from szxga05-in.huawei.com (szxga05-in.huawei.com [45.249.212.191]) by imf19.hostedemail.com (Postfix) with ESMTP id 5F0511A0002 for ; Fri, 19 Apr 2024 09:07:26 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf19.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.191 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713517646; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Slt31qUcXR41VCzHptxc5ElFV6zMN/8SWyRYMtvlgbo=; b=wGbXYj5g+qHRcTnPpE7dG6aqiN3oNmHZDirx7SzoLp1HRGodCmsxoslB9ePAF3uPbKgztj N1oZnYsFZSBfTCNv0uF6Yh1M1Bk14HekkEOqNN9EdVH+rUxu4BzSfNu2HWJ5f2LX5WdZGp nI1X5ZtlhvH1x4o4bql/I0l0GN0jF2g= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf19.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.191 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1713517646; a=rsa-sha256; cv=none; b=63mnyJRaiX4/J+mOCYBjgwi6s/uhpDMhOR9lzfYkFiZiISz72LAe0iM/oo8JBSdRnNuQnd DZ5veohm3KiA78k1KBSivM7YuuFtmmEXXH8Ypo6vYS8r7CYq0Ktc/vgtOh3e8lrKu8yU38 8K8gyn7N7F33aVe8uBT7QCgla94IByc= Received: from mail.maildlp.com (unknown [172.19.163.17]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4VLTGr4Clqz1hwlS; Fri, 19 Apr 2024 17:04:20 +0800 (CST) Received: from canpemm500002.china.huawei.com (unknown [7.192.104.244]) by mail.maildlp.com (Postfix) with ESMTPS id 30D651A0188; Fri, 19 Apr 2024 17:07:20 +0800 (CST) Received: from [10.173.135.154] (10.173.135.154) by canpemm500002.china.huawei.com (7.192.104.244) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Fri, 19 Apr 2024 17:07:19 +0800 Subject: Re: [PATCH 2/2] mm/hugetlb: fix unable to handle page fault for address dead000000000108 To: Andrew Morton CC: , , , , , References: <20240418022000.3524229-1-linmiaohe@huawei.com> <20240418022000.3524229-3-linmiaohe@huawei.com> <20240418133817.afb65c8dcd11cfea7c686d25@linux-foundation.org> From: Miaohe Lin Message-ID: Date: Fri, 19 Apr 2024 17:07:19 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20240418133817.afb65c8dcd11cfea7c686d25@linux-foundation.org> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.173.135.154] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To canpemm500002.china.huawei.com (7.192.104.244) X-Stat-Signature: 917mcpmd7oryz49kcznrqgdfbzpyndj8 X-Rspamd-Queue-Id: 5F0511A0002 X-Rspamd-Server: rspam02 X-Rspam-User: X-HE-Tag: 1713517646-302824 X-HE-Meta: U2FsdGVkX18JJb+91O5kibRQN50X8BZIcA/ekhTyJZ3F+YEpLAtkSB9ToFagJRvpu996F8N6wM+pNDDldojOBeab5/4vMyGybngri3nmY4EVRBt+hoFsidOhTZQBqzxsxAvoL3UmyDo/lGi1b1dygB7Oo5QQU8xJtXz7l9vR3ZGB1lp5M48B4HWSJSP/SEMmSS+K0BCJoHrA3tYX4VQ3mAZWQXpGIQOygj3lmJmUcKC4jPSoEw/HqiMw2G5sh0h/xTnhkpqHfC8IMNXcB5r47nDX5ozE5I9svUpcSYPjPo/Jfp//vBZ4OpsIlvZ58qUhod9EMExgeLVI7ax5TTmBGqnR2KVDFWByJoX/dahcRkMXCICzCB+CPGa1FYjcSalp2upTVltO/t+0ywMvR23KDgXXH+luFe8doMuV/53mxSCnOIRH8ah5VDXjLMgr+GHPzuNvfUwD4tyEbveZmOo2fg64wRfnhwWBeEDT8y1w08IcGd2y2wd5Y7kTzri0/Pi3f1jXBm5M1Uo7bZzZa3PSii0ExISkbMmZ8UBepXN1GLJC+ds/wQ9MpGtEqKAxb551bPUo0afsD7Rr0QMt3/Ea/3VbNoKh26hHger75uk+qOlelzQziZx2fxDnY/KV0gDjsGczgG/vicLMS5tZ+W9aBmuZcPIIm71H6nd2yPSwYQyXuqFoCQofhquhdKGUqoFtYQAxMQqd0XGCdV6zrP6hrF8/WP8a83hEL2OsstVfrciFdyXo6LvthBVBDvNjzFqZRQAYaJB70cH+nTSZZ62OncIqOXaNsUAl6rs0qNFV3IUBmQ9woGTNFuzGiep7xCAdaIsjdoW3WktqCzS/HWAdFJ4St8AwvIPUpyoD0QEXurW9uBK45OnK9DJhGxPhzWmvVRte3zkD6W/I/lGKvY/uI2LQjqJcV+PNhPDaUaMS+z31VGTotD5mPAYaEBA7gDeXTPHZ+LbCfH0r11COi5D lwagfXPk RPKoMESpOBdSroZKoVEJw8yXNhj0D8qyxDZkI6/hjR2dffU9lL9mxhsyJjhbNc7FVxtzVlVBWONVnz9NZWDlX5sBtQTW3QBmPJeQ+qSdlEofR9xVyOBBQB8Tf+zlS6APCGZhTdBPYQtCVxWu8+pZbM32z0g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/4/19 4:38, Andrew Morton wrote: > On Thu, 18 Apr 2024 10:20:00 +0800 Miaohe Lin wrote: > >> Below panic occurs when I did memory failure test: >> >> BUG: unable to handle page fault for address: dead000000000108 >> >> ... >> >> The root cause is that list_del() is used to remove folio from list when >> dissolve_free_hugetlb_folio(). But list_move() might be used to reenqueue >> hugetlb folio when free_huge_folio() leading to above panic. Fix this >> issue by using list_del_init() to remove folio. >> >> ... >> >> --- a/mm/hugetlb.c >> +++ b/mm/hugetlb.c >> @@ -1642,7 +1642,7 @@ static void __remove_hugetlb_folio(struct hstate *h, struct folio *folio, >> if (hstate_is_gigantic(h) && !gigantic_page_runtime_supported()) >> return; >> >> - list_del(&folio->lru); >> + list_del_init(&folio->lru); >> >> if (folio_test_hugetlb_freed(folio)) { >> h->free_huge_pages--; > > We should cc:stable and find a Fixes:. This appears to predate > 6eb4e88a6d27022ea8aff424d47a0a5dfc9fcb34, after which I got lost. I think this series can be dropped because this didn't fix the root cause. Please see my v2 patch for details. So this Fixes tag isn't needed anymore. Thanks. . > . >