From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 866EBC433EF for ; Fri, 29 Apr 2022 09:28:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0C7A96B0074; Fri, 29 Apr 2022 05:28:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 04F176B0075; Fri, 29 Apr 2022 05:28:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E32EE6B0078; Fri, 29 Apr 2022 05:28:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.26]) by kanga.kvack.org (Postfix) with ESMTP id D1D926B0074 for ; Fri, 29 Apr 2022 05:28:57 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id B2C00202AD for ; Fri, 29 Apr 2022 09:28:57 +0000 (UTC) X-FDA: 79409392314.25.9D924AA Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf12.hostedemail.com (Postfix) with ESMTP id 1C37B4004A for ; Fri, 29 Apr 2022 09:28:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1651224536; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kC+rdIYX7c86XP7hqAoeoKmiKMXkQmQ2uMl1ygcYcWc=; b=Q//Un54pGx6CENH/NVp/Yk2HNut52EKqOCgJlsIt5ZRsFfxTcdjUje1RqkQqB57IqPMqL7 dE1fy9cYP9wlE8BcQxI4N8R/0cSaiQdYgTaQVMpHPk99xgzd4TtPnoIDruJ5cI01X5uyfB HrVj5/uXy6Im9hfvFUpnWhhnfV6sA/M= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-392-_ACQChwuN6ChvfGimv72vQ-1; Fri, 29 Apr 2022 05:28:55 -0400 X-MC-Unique: _ACQChwuN6ChvfGimv72vQ-1 Received: by mail-wm1-f69.google.com with SMTP id i131-20020a1c3b89000000b00393fbb0718bso4492507wma.0 for ; Fri, 29 Apr 2022 02:28:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:organization:in-reply-to :content-transfer-encoding; bh=kC+rdIYX7c86XP7hqAoeoKmiKMXkQmQ2uMl1ygcYcWc=; b=E/Za48QJFT7mFrOj4lEsykL0a82ixIoW+rs7gBQ4NvUSNA46HxHUDFqEIc1M2P9uEI E61glYav1njkolrrcwH5opIoODLb/0zi7xxn8C2dyl46jj6/W5i/itIKetUiYMVCVPtT GZRF4tJP5kd3vaqXVopeLMRrUQ6AUHCreJhHaWZlgehh1UIvPZon6/wn0F9M+mGz9rQ5 k1wn5fzB5nAG6GRpa/VMJ81aro4xkBFVRyxi7CkFrGoQSKth7FdntZ4SzZaqTRWtKbC2 H+t5SzsGEhuq9Gfh/Sd1+MlYTByg+igQvckIKEwq15W+a75ENx0WpmxCS2I2bs4S3RB+ dW8g== X-Gm-Message-State: AOAM532e13sfJ6M7/4at4RM1YiGkpn+wOIqjPiL86mIRlA3SkkMoErTh lT3DeY92oahPDdXnQgZxs4CthvUNlzoo5KbiQJxB6NjFF/MYqpmDFv63e0YLvEL9Db0GU0ywYis qNhbVlgM3NnE= X-Received: by 2002:adf:e7c1:0:b0:20a:b724:cedd with SMTP id e1-20020adfe7c1000000b0020ab724ceddmr30695050wrn.409.1651224533819; Fri, 29 Apr 2022 02:28:53 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyfSVLq6mn3NtyCS59FHRJIwazRa2JwPUJpPbEwBXPToDHs98ejC2T4phMaRy9QqV+8eeKFYg== X-Received: by 2002:adf:e7c1:0:b0:20a:b724:cedd with SMTP id e1-20020adfe7c1000000b0020ab724ceddmr30695035wrn.409.1651224533583; Fri, 29 Apr 2022 02:28:53 -0700 (PDT) Received: from ?IPV6:2003:cb:c707:fe00:bbeb:98e6:617a:dea1? (p200300cbc707fe00bbeb98e6617adea1.dip0.t-ipconnect.de. [2003:cb:c707:fe00:bbeb:98e6:617a:dea1]) by smtp.gmail.com with ESMTPSA id g25-20020adfa599000000b0020aeb9e5bdfsm2054937wrc.43.2022.04.29.02.28.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 29 Apr 2022 02:28:53 -0700 (PDT) Message-ID: Date: Fri, 29 Apr 2022 11:28:52 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.2 Subject: Re: [PATCH v3 4/4] hugetlb: Clean up hugetlb_cma_reserve To: Peng Liu , mike.kravetz@oracle.com, akpm@linux-foundation.org, yaozhenguo1@gmail.com, baolin.wang@linux.alibaba.com, songmuchun@bytedance.com, liuyuntao10@huawei.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20220413032915.251254-1-liupeng256@huawei.com> <20220413032915.251254-5-liupeng256@huawei.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20220413032915.251254-5-liupeng256@huawei.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Stat-Signature: kihqd87dgfbkyragpmsmpiqfb9ineim8 X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 1C37B4004A Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="Q//Un54p"; spf=none (imf12.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.133.124) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Rspam-User: X-HE-Tag: 1651224525-349165 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 13.04.22 05:29, Peng Liu wrote: > Use more generic functions to deal with issues related to online > nodes. The changes will make the code simplified. > > Signed-off-by: Peng Liu > --- > mm/hugetlb.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mm/hugetlb.c b/mm/hugetlb.c > index 2e4d8d9fb7c6..4c529774cc08 100644 > --- a/mm/hugetlb.c > +++ b/mm/hugetlb.c > @@ -6953,7 +6953,7 @@ void __init hugetlb_cma_reserve(int order) > if (hugetlb_cma_size_in_node[nid] == 0) > continue; > > - if (!node_state(nid, N_ONLINE)) { > + if (!node_online(nid)) { > pr_warn("hugetlb_cma: invalid node %d specified\n", nid); > hugetlb_cma_size -= hugetlb_cma_size_in_node[nid]; > hugetlb_cma_size_in_node[nid] = 0; > @@ -6992,7 +6992,7 @@ void __init hugetlb_cma_reserve(int order) > } > > reserved = 0; > - for_each_node_state(nid, N_ONLINE) { > + for_each_online_node(nid) { > int res; > char name[CMA_MAX_NAME]; > Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb