From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9E53C54E41 for ; Wed, 28 Feb 2024 09:45:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 207046B0072; Wed, 28 Feb 2024 04:45:12 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1B8156B008C; Wed, 28 Feb 2024 04:45:12 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 00A696B00A7; Wed, 28 Feb 2024 04:45:11 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id DFCB86B00A5 for ; Wed, 28 Feb 2024 04:45:11 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id AADB1C0FAB for ; Wed, 28 Feb 2024 09:45:11 +0000 (UTC) X-FDA: 81840729222.02.859A178 Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) by imf03.hostedemail.com (Postfix) with ESMTP id EB28620009 for ; Wed, 28 Feb 2024 09:45:08 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=hMbXG9Gg; spf=pass (imf03.hostedemail.com: domain of zhouchengming@bytedance.com designates 209.85.214.179 as permitted sender) smtp.mailfrom=zhouchengming@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1709113510; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=bdtDjYqbHw4N9R6tFKPHGKX5xI8wlaodQ+T0JbRKQBg=; b=Af4zc9dlahlpsPDxVaSttKXxl4nWWwoIJp5xcq/dJKwpfV55TO0h6sb0cLvpxgIiKaVElT xmm2YtH9SFVObb6iAwWflBd+Y5pmeSrDr4G56KDSF6r3KWNaBKthupWQzUzjIr8EFVWSNi k3QJyw5tHKtrElOg0Ew7+WpfGPuBqSw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1709113510; a=rsa-sha256; cv=none; b=Y/08dkAgqwXLKv+F8wL2zg4EhgVLrCdJs5Kizk9DY8I7UBfv2JLfzgPiYQ8V7WO9kT5XvX OWu9PkneaS2fia4mfrIh0MwquagfXqSa2JxXGh5Z2G4ZeY5fprgMckkNwiKBIONrBKSmBw 5Uu4oXAg0OpmtT4QIKKXEx+e+jKz+Xo= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=hMbXG9Gg; spf=pass (imf03.hostedemail.com: domain of zhouchengming@bytedance.com designates 209.85.214.179 as permitted sender) smtp.mailfrom=zhouchengming@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com Received: by mail-pl1-f179.google.com with SMTP id d9443c01a7336-1dc3b4b9b62so6131375ad.1 for ; Wed, 28 Feb 2024 01:45:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1709113507; x=1709718307; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=bdtDjYqbHw4N9R6tFKPHGKX5xI8wlaodQ+T0JbRKQBg=; b=hMbXG9Gg+GdKDKlQVpT8gRxF8CBpnNWmnZeJQM1lQ5NNkG+Pk4s8b/RAiQMbRmh9Ru mRXuDIBsYMPg7ZyyXr+oCgu6zcZX50cePNWGsBslGBl/4c0qmmowmpkDze3UeI27LbEg NOkCuVSY8JTp2+gyl2VjrbbHYDHPt1Lrv+ujcjJNNScAXIRnuMLNzTkJr+f0HIhlz8bW b3wb+R0bg9Zt1MIbSd/5DwMhpU8BTdc1RzyYGPUddk1OB7S4eoJ4cMusCEg313xc/E2i tKymEH+ZMsXtNcYHsW5jARIQMdUzL3mPg3gVVKJU7L52aUJDrWh/edovDn4MvskE9R4B B2cQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709113507; x=1709718307; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=bdtDjYqbHw4N9R6tFKPHGKX5xI8wlaodQ+T0JbRKQBg=; b=J225UPuCT75D0zPOejGM+luJ4xNrbaYmPQ9pNof4LQPQHSliwHl7W1fLMregHFdCm8 vEiZwAN8vnz9TulM/LwvyrjVxMxz4Bjz+PPOOxKvXxekJMRNEiTCcbzdMM8QE2Lgtrp6 0D9VtV/H/DuT4YoOkN+AXj4RhQkxghx4rtkYrYiTODhrfeGeopqRXJnXTYKOmj+D1UQv SRyVvr5ThoeuYa5qvRxJgAq49JuftS7IyBB8ssrGApOKeHOlExfIJqbNdtQllrmOGXY/ RNBhtVZPEX1mThBbjahkXSXvHOigasVvyTAUEMsOVJKVtQaizZjB2CVVwN2l15m6EuVi fslg== X-Forwarded-Encrypted: i=1; AJvYcCX82nFQvBjwLK34TldOwdoegTFhcsed4/P1zQWFH1GV49QcpvmikivhkmY5bMB6vdEfRqKR9LZ/F52X6TGgeQck9rM= X-Gm-Message-State: AOJu0YzhHAqKmC8kRgUfSQqeUfnX0osWsIvEGO8oEgQ2TMF4lMnKxt5G FH38hVMx3rzoLsaleGfOiTpQ2+bhufrJAZ3aXb5BkJjicrecabg1YmOp4EWrCbg= X-Google-Smtp-Source: AGHT+IHfOpB9FG4OVBJ1p/m39z+7wpIGQENZumzD77mzjtCwGXkGUX3WR5Pro7qqZmQtj5dSXQqwUQ== X-Received: by 2002:a17:902:f544:b0:1dc:b6ef:e237 with SMTP id h4-20020a170902f54400b001dcb6efe237mr2203762plf.31.1709113507533; Wed, 28 Feb 2024 01:45:07 -0800 (PST) Received: from [10.254.95.105] ([139.177.225.237]) by smtp.gmail.com with ESMTPSA id bb8-20020a170902bc8800b001dca3a65200sm2882479plb.228.2024.02.28.01.45.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 28 Feb 2024 01:45:07 -0800 (PST) Message-ID: Date: Wed, 28 Feb 2024 17:45:01 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm/zsmalloc: move get_zspage_lockless into #ifdef Content-Language: en-US To: Arnd Bergmann , Minchan Kim , Sergey Senozhatsky , Andrew Morton Cc: Arnd Bergmann , Nhat Pham , Domenico Cerasuolo , linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20240228094036.2267912-1-arnd@kernel.org> From: Chengming Zhou In-Reply-To: <20240228094036.2267912-1-arnd@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: EB28620009 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: nsnax3teen7hnwwikwd45xegk1k34fr6 X-HE-Tag: 1709113508-44756 X-HE-Meta: U2FsdGVkX19SzSX1XohdnwmIzSE3lvwucNrlQUJ5b2VAIW/yGnsHgRVa8ody2OYi8C76Pe87o60m4rTHuQ5oa0vQFAFyjm9MB8MpzkNeuPwy+v6tz5JOyp5g+zjmJAGdFLfabKi78nN2piGZgyv/roNozCbuDKwV4Sstf5Uc1F0JRu7q0DK9oixGQnWu1BTh9gNXDF74oIcKqpw1ScS6wVk/rkkJ0NQV/wBuVjYswogR99tmswho+iGH7wSqhu5R2f3EX/qkQHdMZHLYa2zIa0kB5v3ZLqhe4paWksRmb5HseHsdKT0vn0YPOlkNdkPu/FbCBZaKYGGyl4TW0uYQUhwap5x23jlXpXoMWUKstEUuWpVsj6CYt2MDJzksvD05FiZUlVeio/2+Y7onx/KVFMVqEKwFXvCswZBLfiZt8ahV0HQV8I7vDP+8jESGxRFkvatO4KPxAsljOfHGnekWijjSLfI8HUYvpeYotgLv0ZavBqodgwz8v5h3e9r7O532M97x9sfgbvREmpxIKolB8B0KUpYN2YCGYDAmrNfqVGt1LX1wLhj0Am/e4LEnH6MynFIVKcd4/B5j7fx5TxGyA1+7xRZg0T87EkUQ7Kpdu3FRBkuzYadga3rrDHhqr0Sg+M1XA1KBAXvKrPc+q5vfH7aAzp/bQTjWH4whFokd6PqZ+Sl0Rls0Pi11kPjuzU1ORM5A9e2oYs5PqEfd2w8uf0LsLX5APP4O9SCroil27fDxy/3ZF9bkJ2wJgi31CsNbH72iPhAud3rUj9UxklV7AMKw8iJFqWVmtu4rPiZ0OPbxqysnmKdGfTIYdR8rqEPk7sex+Pc0+mrgVrftUF17tIwiBfGR5LnX8ah7vEHZGTeVmWsIHiTR8ISCIdfyZMuOHFyunc7O33Ds5Kd1wAmrgHwJyUjGDlAn8wHLjYPHti/dKgALR4cQBL/0LuPyXnP90II65Bq7iri/vgOH+iZ akRTV4/B 59wA6+51bdmXCy9Ud/rZ73VjJaAYqOcgNNlpyi6u7306RhGAngim2rn5ddI5GeRDc+Y4sgTVkcaVxv7paH32Y0kfi5g0DgQvXiv1qy1jRkYeDzdUb+oUMcsbNaftbbbYR6di5SYG7aZ7fD3PnKEo/VOnKjGQr3xjRrvu/sJFVaR3XH7WT1FJMuqm6hg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000017, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/2/28 17:40, Arnd Bergmann wrote: > From: Arnd Bergmann > > It's only used from inside of an #ifdef section, causing a warning otherwise: > > mm/zsmalloc.c:735:23: error: unused function 'get_zspage_lockless' [-Werror,-Wunused-function] > 735 | static struct zspage *get_zspage_lockless(struct page *page) > | ^~~~~~~~~~~~~~~~~~~ > > Move it down into that block to avoid adding another #ifdef. > > Fixes: 2258bdebb55e ("mm/zsmalloc: don't hold locks of all pages when free_zspage()") > Signed-off-by: Arnd Bergmann Hello Arnd, Thanks for your fix! But this series has problem and should be removed by Andrew later[1][2]. [1] https://lore.kernel.org/all/20240228043534.GG11972@google.com/ [2] https://lore.kernel.org/all/20240228035403.GE11972@google.com/ Thanks!