From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 897D4C7EE39 for ; Mon, 30 Jun 2025 10:38:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2DD3C6B00A6; Mon, 30 Jun 2025 06:38:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 28E3B6B00A9; Mon, 30 Jun 2025 06:38:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 12F476B00AA; Mon, 30 Jun 2025 06:38:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id F217F6B00A6 for ; Mon, 30 Jun 2025 06:38:54 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id BC72B80415 for ; Mon, 30 Jun 2025 10:38:54 +0000 (UTC) X-FDA: 83611718988.10.11B7759 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf04.hostedemail.com (Postfix) with ESMTP id 3D0F540009 for ; Mon, 30 Jun 2025 10:38:52 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=RD3uGtkN; spf=pass (imf04.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751279932; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=67aFXQrWHbpI4Fyl5DLESwSzgu+5w69Ws3Jiartc4Ao=; b=5bylpAs2wPjoBcwMwsSbkOuMui4z12scyYBBiyQSVcODnFT1Q7HW3MCxKoFCHMBN6l7z7l dqSSdmUuivmUdxRjrJGfWHcpqcsSx4Sa1wU0tNtBrkK+krcLDhc98GVN52mGt68vWpKHxk tdlwabXHe/Y4Uxs7w3dR312AqLOhYnw= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=RD3uGtkN; spf=pass (imf04.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751279932; a=rsa-sha256; cv=none; b=uN2UKOylEavOVBq+5kLRdkaaOhTtckCnz3aNzqbU1ALe7zujZrqZyF7zQNxfB0FoRbKr1B Q/2o6mFo87HuJRC3nxwiRhdaCfgbm9elAlnvZrmwfbl5g1x2/kF5dD6rIJU1mxFgThksgO aB37qKBAvEY9bXASB8I/164ENKjTx0w= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1751279931; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=67aFXQrWHbpI4Fyl5DLESwSzgu+5w69Ws3Jiartc4Ao=; b=RD3uGtkN+JYOYFfMNRIKav0MQrPyJZQsyxPXdSTokctidZxXF7FnnwHwrPROft/ewy5gXO HH5/JMorw6tzwPtzeqa545kB8UQQRKh0N1JmhxalqmDZrwZAktdAPZcYj4rlKvdBhuCTcM 9IZdEYZi3v9q5K7OlN1XSIaVrUzm44U= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-438-I6C0udxeMB-zA9yywbRBzA-1; Mon, 30 Jun 2025 06:38:46 -0400 X-MC-Unique: I6C0udxeMB-zA9yywbRBzA-1 X-Mimecast-MFC-AGG-ID: I6C0udxeMB-zA9yywbRBzA_1751279923 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-4530c186394so8406695e9.0 for ; Mon, 30 Jun 2025 03:38:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751279923; x=1751884723; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=67aFXQrWHbpI4Fyl5DLESwSzgu+5w69Ws3Jiartc4Ao=; b=wXLoXFWQkPpJgOE5MAZ69Ch2CPBMX1qHf1p8w3Rqeq+LjcFuFyO+M71BFnPlAaqtoS TOacVcNYkq+OXADSnB7lzHPTyMCgKKsdTMYHwNCtdLxDSKtE3os9VfMYlkxxh3e2q+UD PHgFXF8oHzGVAeC1UeNlgE49ajcFbkFTjliF4d1o5pwrhvSO9qaElTrkD7jSJNfsbTrV gRBgSRqYH8XQw+0F5qXcMa8DZbUr4XUKnIKTZnNrf6xy9mIrKImHuxw38C1StDZMvGs1 eqR1qWqPgORONpo76RrscVIR1o6TX58xKBpcpA0uMXdezOg7PvWupL2yE2ZvheBtadIV CI2Q== X-Gm-Message-State: AOJu0YyscAN8HgDzcl4rPvpDZKSPhqAqaE8UaCnAsYpQ8GKINAksIRm6 maX7owC+jlKxK3QRB3gz1qX87LdrPiWP9c2ffCY7QfZROijcwysUWxY5chBO0K6CZCX7bDSdrNC InwMr4Eyzw0z+uvvrN2lVjv72kfxDeGT70KAo2KaGgko51UvvWior X-Gm-Gg: ASbGncuHFdoaNT2C3gJZp716CZuX3JhOJ6pXnFvroXWXb6GRywGw/UNWYNGZ5atuxgP IDxIwwFdKYXIxPJlZdWLIIEHvN+dq6k18agXsqrA8Qx6Sw4zmQbRS/87NxgHeFnxGZUGOmAKWMy cHMer1IPsmPmS/6aTpaRuglcCV/R3kO/L7hJAF64PA2blypxVS85gCwDZ2JWFzX/l9/nkSHxmQL A2s1nh7x9E2VLAuywH/PdY/fmoQfPYMPKun9KdGio5VvKYMd9s698oQ/4LTgoXgIjEvmRJgoEI6 SJZehdJgEE2Mb8SKW1TNky1D8OsGFGuJJ+0SZqtqD3UqrpY2cvan/lyIvX9cY64uYup86PIOFlV jhz0L7rRXA5Y0DSSCIS6pWm4xmggDIQA6s13ANQzqiTzBLSWJQA== X-Received: by 2002:a05:600c:1d18:b0:450:d07e:ee14 with SMTP id 5b1f17b1804b1-4538ee60815mr148032445e9.17.1751279922814; Mon, 30 Jun 2025 03:38:42 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFbR0EXwYLOIn4B0J77nh6IYL3kQZ2rdcN1jUT78ZTpALrM9RwX6OgAGv5YOD7axO14le8E/Q== X-Received: by 2002:a05:600c:1d18:b0:450:d07e:ee14 with SMTP id 5b1f17b1804b1-4538ee60815mr148031685e9.17.1751279922315; Mon, 30 Jun 2025 03:38:42 -0700 (PDT) Received: from ?IPV6:2003:d8:2f40:b300:53f7:d260:aff4:7256? (p200300d82f40b30053f7d260aff47256.dip0.t-ipconnect.de. [2003:d8:2f40:b300:53f7:d260:aff4:7256]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4538a406ab6sm132793025e9.30.2025.06.30.03.38.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 30 Jun 2025 03:38:41 -0700 (PDT) Message-ID: Date: Mon, 30 Jun 2025 12:38:39 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFC 18/29] mm: remove __folio_test_movable() To: linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org, linux-doc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, virtualization@lists.linux.dev, linux-fsdevel@vger.kernel.org, Andrew Morton , Jonathan Corbet , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Jerrin Shaji George , Arnd Bergmann , Greg Kroah-Hartman , "Michael S. Tsirkin" , Jason Wang , Xuan Zhuo , =?UTF-8?Q?Eugenio_P=C3=A9rez?= , Alexander Viro , Christian Brauner , Jan Kara , Zi Yan , Matthew Brost , Joshua Hahn , Rakie Kim , Byungchul Park , Gregory Price , Ying Huang , Alistair Popple , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , "Matthew Wilcox (Oracle)" , Minchan Kim , Sergey Senozhatsky , Brendan Jackman , Johannes Weiner , Jason Gunthorpe , John Hubbard , Peter Xu , Xu Xin , Chengming Zhou , Miaohe Lin , Naoya Horiguchi , Oscar Salvador , Rik van Riel , Harry Yoo , Qi Zheng , Shakeel Butt References: <20250618174014.1168640-1-david@redhat.com> <20250618174014.1168640-19-david@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250618174014.1168640-19-david@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: yma-a5EhEZ0LlzLgbymSkM_sSxE_c9tMvPJhMcHtgVs_1751279923 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 3D0F540009 X-Stat-Signature: 5ct5m7j9bmmsgakemtxgqmeg5xd69u4f X-Rspam-User: X-HE-Tag: 1751279932-357479 X-HE-Meta: U2FsdGVkX1+mIhN9K5owFYOyIGlHK0fVdBXB9tp/fPuB0enc5kHvXZKWyxrowFYW3vjEzPYAViUvKd2M6II5LO3Okx4aXSHQLAStcwlH3tdnoiMvmB7ghij5tozKgJNVwyLVDSVgpR9erRRjT/bX5pa36NYh0b9+vjxkKLZrSXtmo23Gq2hkKkPCgWeaiY7StV99e3yE1HXjFm8QZUI+JFZudX/UI5QPrGyfD7I8+pF5LmrM0KMo43WvRt/MPMa3AZ+lnEJR281MaKETdaiMwkHU7pqO/rppkSU+mqKyJ7JmfdGzl8GnVs16FTVpqToBMJfCfiO53T+Eq7QOdKh+U0Sn2S29YWFsRrewSiwNbEYavWHZ4wpSxmrCHl6ukHpW71b7Ho0Es4IxOuj0W329EOTw82eKW3k5h0+1uOiFaBpGK2xa21KXWGPXBJqLNTCtVlOxaKQERWGuyy2HygLnJLGzv7XtaocPDAcQSDoBRMliId/IjQjwvuug+dpGtU+KQ1O/9WtfZpVayh3oXeK7oy6OrxMWliVbim1BX1Y6FHfX+mptsgJtBkUycOCKjTnxN6TO7YWBdmm9KEOkGndcP1yt78g1IDowL3LV56g/6rZ3pA8RAUucfxbL2adxhykNBFRG9a/dPRKFTGXazlhpqJ6Qet4gcByeJOY12dgHQwpmki3IRCHKCBgZpKTSFTEwNUlyS9yUbUUGyamISLu8ejSdymg5k5KudIUpzDKoyKtjjuW+wnpeEsDpu21I7ENeZLGW3ptaPuvwb/rlxPqtGvsMgK+likltiLqrhJPk3cbqgNEecKl1UXfjuyDrs23msuw13NAFq+lhgRRIOvCd+G68rg08mVDz1pVTzsyfjO1EJ1Sh9gLGQNt7dfz7JK2/A5CoodmGasGOHZRQiqpkNJ8/SRyD4miC+lVvoEbT0AoJuH5J1CsyJ0PBKGPtUbY31qA+izmIhzTE1NWz9jJ B+MDxgsV 6Nk733947drxbpAQv6WLw2vGCjmnAs9CcxWRxjdcDl2pOnR8tQdJB0+GJZvhcq1DFywknuUbCeYDW8vD3Fr9nVo91hNlEC68TLAqNu9R2PtLJDAKxqCSFrBEW+AULrNCl9c2nxU41MFPtetcCucouHi4EAwHNC5v4bkUrasxfoqJeqI/YTWvcPYW+0eBStSsDyq/EiOSzgB2UBDsXe7UL0g00hJjIqPqJ6o1U1Nj005ILjgsnFhDG8djL180c1zY6ica/ht+S7YKNweWUh4kfi0PYlihUUGx9vARpK++QbQhBqOfKWQzN3Nf0MNiBuzKgC5m8uFSaLsZW3+KNipIH3ezINEsSi1UTcdHcjaXksdG23ByXZH/CaBSN2zjdMyfP5e6CFdJsWkXyRRioiw1AS72yWfdpLgkr/QWsNuRd9g6prXujnlIPPv3JGCnrkjAdQXk5hyIwxI+qzRR1fxYUQXOnh/BvxocHAyQ2nYxWB2Wixl/YoW/O/uf3eyT5KbsuPMnyYNU7RIOtF8F+SpBmUcqXLCUjWYwW7S/njNINsBiCc32fuwnnRq0IuSTtPPeztjp1bJjdDmXsFKHdGQaNw7X8JEx9x5EN50qX X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > @@ -1164,7 +1148,6 @@ static int migrate_folio_unmap(new_folio_t get_new_folio, > int rc = -EAGAIN; > int old_page_state = 0; > struct anon_vma *anon_vma = NULL; > - bool is_lru = data_race(!__folio_test_movable(src)); > bool locked = false; > bool dst_locked = false; > > @@ -1265,7 +1248,7 @@ static int migrate_folio_unmap(new_folio_t get_new_folio, > goto out; > dst_locked = true; > > - if (unlikely(!is_lru)) { > + if (unlikely(page_has_movable_ops(&dst->page))) { While doing more testing, I found a weird bug where we end up having balloon pages isolated forever, and never putback/migrated. So neither the balloon can deflate them nor the migration migrate them. This line here must be if (unlikely(page_has_movable_ops(&src->page))) { But I am not sure yet if that's the issue I am chasing :) -- Cheers, David / dhildenb