From: David Hildenbrand <david@redhat.com>
To: Wei Yang <richard.weiyang@gmail.com>, akpm@linux-foundation.org
Cc: linux-mm@kvack.org, Lorenzo Stoakes <lorenzo.stoakes@oracle.com>,
Rik van Riel <riel@surriel.com>,
"Liam R . Howlett" <Liam.Howlett@oracle.com>,
Vlastimil Babka <vbabka@suse.cz>,
Harry Yoo <harry.yoo@oracle.com>
Subject: Re: [PATCH] mm/rmap: do __folio_mod_stat() in __folio_add_rmap()
Date: Mon, 4 Aug 2025 09:43:03 +0200 [thread overview]
Message-ID: <d297547a-a0f7-49c9-8d5b-5e7d6fbe1fc9@redhat.com> (raw)
In-Reply-To: <20250804064106.21269-1-richard.weiyang@gmail.com>
On 04.08.25 08:41, Wei Yang wrote:
> It is required to modify folio statistic after rmap changes, so it looks
> reasonable to do it in __folio_add_rmap(), which is the current behavior
> of __folio_remove_rmap() and folio_add_new_anon_rmap().
>
> Call __folio_mod_stat() in __folio_add_rmap(), so that rmap adjustment
> family shares the same pattern.
>
> Signed-off-by: Wei Yang <richard.weiyang@gmail.com>
> Cc: David Hildenbrand <david@redhat.com>
> Cc: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
> Cc: Rik van Riel <riel@surriel.com>
> Cc: Liam R. Howlett <Liam.Howlett@oracle.com>
> Cc: Vlastimil Babka <vbabka@suse.cz>
> Cc: Harry Yoo <harry.yoo@oracle.com>
> ---
Looks cleaner and nothing jumped at me
Acked-by: David Hildenbrand <david@redhat.com>
--
Cheers,
David / dhildenb
next prev parent reply other threads:[~2025-08-04 7:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-04 6:41 Wei Yang
2025-08-04 7:43 ` David Hildenbrand [this message]
2025-08-04 12:48 ` Wei Yang
2025-08-04 13:20 ` Lorenzo Stoakes
2025-08-04 13:58 ` Wei Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d297547a-a0f7-49c9-8d5b-5e7d6fbe1fc9@redhat.com \
--to=david@redhat.com \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=harry.yoo@oracle.com \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=richard.weiyang@gmail.com \
--cc=riel@surriel.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox