From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9142C0015E for ; Tue, 15 Aug 2023 12:04:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 73F998D0003; Tue, 15 Aug 2023 08:04:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6EF4F8D0001; Tue, 15 Aug 2023 08:04:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5B8068D0003; Tue, 15 Aug 2023 08:04:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 4A3668D0001 for ; Tue, 15 Aug 2023 08:04:53 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 014C9160D3F for ; Tue, 15 Aug 2023 12:04:52 +0000 (UTC) X-FDA: 81126207666.01.BC7CA1E Received: from dggsgout11.his.huawei.com (dggsgout11.his.huawei.com [45.249.212.51]) by imf16.hostedemail.com (Postfix) with ESMTP id 0073A180005 for ; Tue, 15 Aug 2023 12:04:48 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=none; spf=none (imf16.hostedemail.com: domain of shikemeng@huaweicloud.com has no SPF policy when checking 45.249.212.51) smtp.mailfrom=shikemeng@huaweicloud.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1692101090; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=z5UjtoWAVCx1ciHpuEo+cPIZgiTpF/1Q6nqWMCwe7Wg=; b=RmCINvjRuFHbOfI7cKJz+krHMCuA4KPJ67V3jqrBLDsmpi9+g/MALtxXnd6boGGEiXRrMo W2Z7PVsv/r17hICeYzJefbYmbVPXEhD/tZq1JSD+vwmCafSx7FHwxi2mSkHzqVaq9lZP50 TYmEj/3J1lAC0MGymWXgkQGWrH+50Ks= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1692101090; a=rsa-sha256; cv=none; b=5nxfezrxXqKuCrc3zRjEvdOw8qdyBLtSC6T/ru2qsUUAXlN1Z0FJ/XEDHu87E6bdvIhNo3 KBzKYfsaNGKTSVeRSQCe1ccO9CsMqttgx2eqSkElsmX9ZQJEX1Xxc+0+94g9QTzwJNkHKd KGLi3oQbiCf+q/+B5WiBdG2TDBFjJdc= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=none; spf=none (imf16.hostedemail.com: domain of shikemeng@huaweicloud.com has no SPF policy when checking 45.249.212.51) smtp.mailfrom=shikemeng@huaweicloud.com; dmarc=none Received: from mail02.huawei.com (unknown [172.30.67.169]) by dggsgout11.his.huawei.com (SkyGuard) with ESMTP id 4RQ91J4XnMz4f3pJ0 for ; Tue, 15 Aug 2023 20:04:36 +0800 (CST) Received: from [10.174.178.129] (unknown [10.174.178.129]) by APP4 (Coremail) with SMTP id gCh0CgCngqXUadtkcY0UAw--.26382S2; Tue, 15 Aug 2023 20:04:37 +0800 (CST) Subject: Re: [PATCH 6/9] mm/compaction: rename is_via_compact_memory to compaction_with_allocation_order To: Baolin Wang , linux-mm@kvack.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, mgorman@techsingularity.net, david@redhat.com References: <20230805110711.2975149-1-shikemeng@huaweicloud.com> <20230805110711.2975149-7-shikemeng@huaweicloud.com> <111c3142-e20b-3e3c-f107-cbb64a16c2b0@linux.alibaba.com> From: Kemeng Shi Message-ID: Date: Tue, 15 Aug 2023 20:04:36 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.5.0 MIME-Version: 1.0 In-Reply-To: <111c3142-e20b-3e3c-f107-cbb64a16c2b0@linux.alibaba.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-CM-TRANSID:gCh0CgCngqXUadtkcY0UAw--.26382S2 X-Coremail-Antispam: 1UD129KBjvJXoWxur1UJFyxGr1fCr13Jr1kZrb_yoW5Gw4DpF 10yrWxXa4jqFn3Gr1xKw18Ga48Jw4xK3WUJrs293WUXw1akF1FvF1jqFyF9ryUZ393t3yj qFWqg3W7ZasrA3JanT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUkjb4IE77IF4wAFF20E14v26r1j6r4UM7CY07I20VC2zVCF04k2 6cxKx2IYs7xG6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rwA2F7IY1VAKz4 vEj48ve4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_Xr0_Ar1l84ACjcxK6xIIjxv20xvEc7Cj xVAFwI0_Gr1j6F4UJwA2z4x0Y4vEx4A2jsIE14v26rxl6s0DM28EF7xvwVC2z280aVCY1x 0267AKxVW0oVCq3wAS0I0E0xvYzxvE52x082IY62kv0487Mc02F40EFcxC0VAKzVAqx4xG 6I80ewAv7VC0I7IYx2IY67AKxVWUJVWUGwAv7VC2z280aVAFwI0_Jr0_Gr1lOx8S6xCaFV Cjc4AY6r1j6r4UM4x0Y48IcVAKI48JMxk0xIA0c2IEe2xFo4CEbIxvr21l42xK82IYc2Ij 64vIr41l4I8I3I0E4IkC6x0Yz7v_Jr0_Gr1lx2IqxVAqx4xG67AKxVWUJVWUGwC20s026x 8GjcxK67AKxVWUGVWUWwC2zVAF1VAY17CE14v26r126r1DMIIYrxkI7VAKI48JMIIF0xvE 2Ix0cI8IcVAFwI0_Jr0_JF4lIxAIcVC0I7IYx2IY6xkF7I0E14v26r1j6r4UMIIF0xvE42 xK8VAvwI8IcIk0rVWrZr1j6s0DMIIF0xvEx4A2jsIE14v26r1j6r4UMIIF0xvEx4A2jsIE c7CjxVAFwI0_Gr0_Gr1UYxBIdaVFxhVjvjDU0xZFpf9x07UE-erUUUUU= X-CM-SenderInfo: 5vklyvpphqwq5kxd4v5lfo033gof0z/ X-CFilter-Loop: Reflected X-Rspamd-Queue-Id: 0073A180005 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: mao5e3yxhs7ahuewfjhcgx7a5z9oiex6 X-HE-Tag: 1692101088-491158 X-HE-Meta: U2FsdGVkX1+F8W+VtdnL2peb58YZOZjCmFS3+T9KUhejncAx+nCFHtCPfrB/5Jl4x8YNY/nRIWT+ZT9jMRX3A7rrL81FIJT+USLJfUdDVpYYeV/E3dPhIQ5uIloMhFytRRa+OeLpl2WyYRpPXtup2nbwMk4yYvBgMMkMB2gN/Z2mjSY5WryaZoSzpMVeKjUT7RwR/BktL5/G/OMk2dhWetleAljmRtMTnAVK2Is5fUMq9yhb3SYkemC+LlLsgyo1uv2jSeWFT61bQgh0hToTFkomxVYR9iGWuMw06I9Ow3kd/iO8MpHr3Amygbk1nWogZVUC/diy8tRTYsmM4FjEh7ikhPzWfO6UFPhU82vJkXvg+7yx9JONIjX4SYd+PNJGceBrzkOgUWzNUobda0bSyEJX6suWTY7MoMTbLK7DC2or9IlhM4f0GHYs4MNz8t9aWozjzQo77hVQyKxwfgp/i3NFcg8OkmAkvWdTyb51diTcB6uoK7qDpqbGzQOuXZvxTt81nTkuygb9imvjpz0UeMobF7qSQfNMm1r15BgiT+g9TQVSevYYVUAtbp5LHZ8hl8G8F6VdrfjmB65QMq3vEaO+OAWRKx+O1x+QlVQ9bflcf6m7zZsPX+P2vNBiN8LQ5dgLb0vKth+Cd1nKA61npyPsS7jvTWW+06FRFSrOv7V5Rek78sZp89yVkSQDq2XNDxPIhQh9ROYHLpivI/LYWh0IbWSSIESf5Z1syu5wjfZo1IP+53SIFqhj3Grb3nkDTbDIqes6DDLSogn71vch3hyx9AcxZCloQyKTcTalsfgL3k5MhNvhgMOZGLVCCrvlY3g8HepD1VCmEDfuWHwOZn/+PEc5JcvMeih8oeAZ/1wEavwisPDQs7kJl+K34+f5Y2emVtzqlmESB9x611/aAvuj6xqSC0KZNou7ZEsj2qsHVDYqDiQefX1Z73CHWcxhmZ64NEF97cxfSJ3RRjC YV1D9jda UTN8rgRB+uAvfzwkqNWH0wCdBIjnSnU3vSliL506tPYka6XfxawvhkiAuOH6ETSimnppP03mFSr7i/ixARd99+WnUuJwcaI0vzp2ycJ65OihqG6BW2AWBbdDZ5FNL12bdHBOl41wP+KL4dGKZIPree7u/Gi+VAVTBuK+56H1ZFQdJ/LXj47j4CxhNAWQhcr34zagBb+ksBoI4gZPB513QD3uaBzb2+nMmaHAYXUxsRw1p164= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: on 8/15/2023 4:58 PM, Baolin Wang wrote: > > > On 8/5/2023 7:07 PM, Kemeng Shi wrote: >> We have order = -1 via proactive compaction, the is_via_compact_memory is >> not proper name anymore. >> As cc->order informs the compaction to satisfy a allocation with that >> order, so rename it to compaction_with_allocation_order. >> >> Signed-off-by: Kemeng Shi >> --- >>   mm/compaction.c | 11 +++++------ >>   1 file changed, 5 insertions(+), 6 deletions(-) >> >> diff --git a/mm/compaction.c b/mm/compaction.c >> index d8416d3dd445..b5a699ed526b 100644 >> --- a/mm/compaction.c >> +++ b/mm/compaction.c >> @@ -2055,12 +2055,11 @@ static isolate_migrate_t isolate_migratepages(struct compact_control *cc) >>   } >>     /* >> - * order == -1 is expected when compacting via >> - * /proc/sys/vm/compact_memory >> + * compact to satisfy allocation with target order >>    */ >> -static inline bool is_via_compact_memory(int order) >> +static inline bool compaction_with_allocation_order(int order) > > I know naming is hard, but this name is not good enough that can show the compaction mode. But the original one could. > Yes, I agree with this, but name and comment of is_via_compact_memory may mislead reader that order == -1 is equivalent to compaction from /proc/sys/vm/compact_memory. Actually, we have several approaches to trigger compaction with order == -1: 1. via /proc/sys/vm/compact_memory 2. via /sys/devices/system/node/nodex/compact 3. via proactive compact Instead of indicate compaction is tirggerred by compact_memocy or anything, order == -1 implies if compaction is triggerrred to meet allocation with high order and we will stop compaction if allocation with target order will success. >>   { >> -    return order == -1; >> +    return order != -1; >>   } >>     /* >> @@ -2200,7 +2199,7 @@ static enum compact_result __compact_finished(struct compact_control *cc) >>           goto out; >>       } >>   -    if (is_via_compact_memory(cc->order)) >> +    if (!compaction_with_allocation_order(cc->order)) >>           return COMPACT_CONTINUE; >>         /* >> @@ -2390,7 +2389,7 @@ compact_zone(struct compact_control *cc, struct capture_control *capc) >>         cc->migratetype = gfp_migratetype(cc->gfp_mask); >>   -    if (!is_via_compact_memory(cc->order)) { >> +    if (compaction_with_allocation_order(cc->order)) { >>           unsigned long watermark; >>             /* Allocation can already succeed, nothing to do */ >