From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9D4E5C3DA4A for ; Sun, 11 Aug 2024 20:26:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 328386B0083; Sun, 11 Aug 2024 16:26:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2D7CC6B008A; Sun, 11 Aug 2024 16:26:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 177AC6B008C; Sun, 11 Aug 2024 16:26:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id E98EA6B008A for ; Sun, 11 Aug 2024 16:26:21 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id A5124140371 for ; Sun, 11 Aug 2024 20:26:21 +0000 (UTC) X-FDA: 82441096962.04.CEA45B4 Received: from mail-il1-f178.google.com (mail-il1-f178.google.com [209.85.166.178]) by imf05.hostedemail.com (Postfix) with ESMTP id E0A0F10000E for ; Sun, 11 Aug 2024 20:26:19 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=H6taOoq0; spf=pass (imf05.hostedemail.com: domain of rientjes@google.com designates 209.85.166.178 as permitted sender) smtp.mailfrom=rientjes@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1723407945; a=rsa-sha256; cv=none; b=4KAv/LmYEyoIdT6yik4RLDLjRFF0zcEie3mpMueVv0XIjuZes5/ZTckT+aEHHTpL8z2JpB DdWZFs1aI+3xQuOQzY3iSRykxyT7iei8Loq3teznc6E+sP2BG/Ryegcz+OvnoXalKgvEzt mvGloVGMrp4oPR3LIFoZJrKETj0pNz0= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=H6taOoq0; spf=pass (imf05.hostedemail.com: domain of rientjes@google.com designates 209.85.166.178 as permitted sender) smtp.mailfrom=rientjes@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723407945; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=YlExk0c05J5NkENFEJVDSS8e9y+ZVkGFZx53tZxGePI=; b=2hiopPzz++l2MjYsswy4oB6789xoTrRfeJEGFNyNwtR7gmaESBlGJ6tQqxAJxkwkr+CNgv 3p7ZqUtG0OLACCmsTnMjsx1wvFzdcQFeNEADgjFfKMoTdlVnOJ2ITk5qi6vrbvxQAb7DKT VrILZmabM7tgVRXCwedkgGArp7DQ1lc= Received: by mail-il1-f178.google.com with SMTP id e9e14a558f8ab-39c3bf0584cso75685ab.1 for ; Sun, 11 Aug 2024 13:26:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1723407979; x=1724012779; darn=kvack.org; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:from:to:cc:subject:date:message-id:reply-to; bh=YlExk0c05J5NkENFEJVDSS8e9y+ZVkGFZx53tZxGePI=; b=H6taOoq0irBct9Z/zks3CRCWYEemxVYFqjAxLLuVgE2fxuKc23l/SZPThK1FwwGUg0 jWK1wTZxVLnVO4EGWs3IYEPGWqoMyQOUEsTBvkWQ3Si9DPRH8fvlzaYpl0WE/+AEcfMA xmLYcXM2yCUuPHiSovlsr5NH1TOLS8scWGmy3Wtr7d896YkJ7DVxWz72nxoYwza3kgYN +h20RXs4gJyKpDXzHqf/EiJ5CKYejtRcJM7Zo6hmY6p/2qAqiboBfn5LU3aj/bMVBJMa 5/QQckfpiJBS0ULDDEWv7tziC8Fyk486t7PA/1AA+DC7laD4PRpGIwdSFDjecWL9p51C QdSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723407979; x=1724012779; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=YlExk0c05J5NkENFEJVDSS8e9y+ZVkGFZx53tZxGePI=; b=STX9D68RgtqZn7wLegZEQDHq53oQlfRLPvArt0Cyc+WFbKd0vQOgijM3Xd91csCfV6 HTDfe/8bmMFKNPNM6xF2R+qM0lv/VHlnsJYFSdrdUR9scO9VSYH5ambabztPSdVS3WkD nQC/mPkL7tfTgZlydSwoZfdyvXxr6zgoQXKPZWeWboiLpezN9LPpJoAIZPl9xaqkJlR1 eLyFORB/+sLmcUrC2oaop6wdd7Xwkr4Eu9/HZ1B0me2KUveJCZdsGX0XnU1wRU9dg9j/ CzY7caRZw4qgfK6i/fQenyiMd+ntCND6nOfRcqDTc1oBGl/wkDUWGrPvEZAOib0WkCim snuQ== X-Forwarded-Encrypted: i=1; AJvYcCVwE17zcT/IazHTfV/ZubI0DlDnuYl8v5EVtCYI+AOQP98t/HOueaM/5Bykb9ujB5wIDKdg3axDuw==@kvack.org X-Gm-Message-State: AOJu0Yx0jX6f56zKGekB0NbArb9GuNkuZBeW9bgSK1Hh+SbLCeVjajD+ Zu7uTObgXj+L/Uo4G5EcDPt+4XTI701MHzkMcYMeqax8d6ktnfJL6R+6D+9q8Q== X-Google-Smtp-Source: AGHT+IFNQ0p46pnP6bxX/WTrVF/mvF4EBfHhnSN4CI+EuUQ20mscDwAHHXkGESoFnpmkjNh2iN6wIQ== X-Received: by 2002:a05:6e02:1ca4:b0:39b:b1f:5be1 with SMTP id e9e14a558f8ab-39c3140c826mr3120085ab.1.1723407978557; Sun, 11 Aug 2024 13:26:18 -0700 (PDT) Received: from [2620:0:1008:15:49ba:9fa:21c6:8a73] ([2620:0:1008:15:49ba:9fa:21c6:8a73]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-7c3dbe04bd8sm2895240a12.19.2024.08.11.13.26.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Aug 2024 13:26:17 -0700 (PDT) Date: Sun, 11 Aug 2024 13:26:17 -0700 (PDT) From: David Rientjes To: Pasha Tatashin cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-cxl@vger.kernel.org, cerasuolodomenico@gmail.com, hannes@cmpxchg.org, j.granados@samsung.com, lizhijian@fujitsu.com, muchun.song@linux.dev, nphamcs@gmail.com, rppt@kernel.org, souravpanda@google.com, vbabka@suse.cz, willy@infradead.org, dan.j.williams@intel.com, yi.zhang@redhat.com, alison.schofield@intel.com, david@redhat.com, yosryahmed@google.com Subject: Re: [PATCH v5 3/3] mm: don't account memmap per-node In-Reply-To: <20240809191020.1142142-4-pasha.tatashin@soleen.com> Message-ID: References: <20240809191020.1142142-1-pasha.tatashin@soleen.com> <20240809191020.1142142-4-pasha.tatashin@soleen.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Stat-Signature: uca3eeooxu5kqy4c5aezkaxr3cwbyxt5 X-Rspamd-Queue-Id: E0A0F10000E X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1723407979-222317 X-HE-Meta: U2FsdGVkX19crYZFu1Q2bTKjPOMKDPcidi6EsVAD9YKuKBEGhWVTnrutiGZ+ObSkSgG+wBiXpvU4UzIFyvyMi866f7FcohfbR1TzJUCyAJJFQs5d+aZVoZnbUoW7S8sdGVsESAFq5FnqzD/gM3F5lrDFV8rr4jt5QnlqaBYIY7KNvJe16zcn4KfrIToCFOBjRXjET1FCUK+/V+zwzxyQy97hmszoPD35QxvxASb4aHyhQP9fC2VFhxJUHtUgo5olljl1+osU9yyDPmsDS1Q79MuClufzwAkxAPRItG64UN0ZAd4KqzmbC4O8HeGF0CvUwKfNZkpZqG51yo/9G9/bkfonpfwDVGOH9dSBhe17434pQ5oHDtqG14uK2Ic2X/sln5rnClwx9jH1LuXb/HkxCJl5b9GwgSko4lpZdNq0TC2SGlwvjYX/ttWYDILc3095mQgjaXblGh9WLv9L/MpOWV9DRc2T4Dw/RKdq7N/KNTmiv3zuFp81+ROAQgzgAesdkNqJwHbDAGDAdTyptCCfWs/1biqdY0SJBmc9afQjMd+rfEnxwGFg00f5PZmOynjEQO4YoQGSVKTNGJ0Hx6nqE3FbILGMTMYcm5A4TxMvqKzDxzGtin3cbeck+K25buxi3rUVdCEUhAFOnsnJuKqrf2JDKwlQDmzKzcKin9GgACPfe5ArW1FCChF6W34JglayF2ji2oPsgzIitGESt7/Gs4zzwth3Wm87q+4Htt4ylIaNXUeDF1ZeR7w2SGXQts4YlRmTYum2YMPhZThAhiXrXOQ135WV2B1CLvm6+WaJ+AbGEXi3QjynI5PnSgeVbGxFWwwOJLys/XTaqJkxHCBncA+oc5FKaZ+GGBltTD3Rqc82ONJA/1kNs9CH8soi2TJjghuKStqCbcUpZS0lvyEhNdm/URndq4IKqYA4zyVdRTQE37Gvx9owKDpwjVBz6BP1DGFNb11PoEeSkmOvB9I bZFQdnBL 9y4W64zEhR9FLngcHHJVU1wxzpAMgNYmWbCep0R4LdEdLLevnPu9Ltj/6WPmRVolb//NzocCeWjpVrcUv3fYozYwGC6MrqBbzl5ebieRDUizcToAsWanqFaJmOeYJCQukG5Vl6/6VhquzhwlVSmtoQbG6W4FCM4LiKbYTH67gbVUVI70SonDuuPtuV6UYE47Qr9yVeyo9Bcj3Mbgzoa4/ok7WIUnc/5RgyC7FMDfs9iz08Me47wFbEnDTjl2oOnvf5wd/1f4sn4KyjDqlrxSuz6OE/yWzxnKLk/fIGb7pG/YuzVha0UgI4I3M8nWIF429tgw1O3HombrKPhGL+A9jO5a6XDZMt8VIz9FKifhlT5VYWcyaob5idz2YWzwEU+ki95aWEN4HqAMVCYtD2xU1K5DXoa778+EGV58zpd1OyHpb4+022G55ZJS2GpEu2712jF69mDMJ2P2t24Gr/w2u0FazIauRFJCxzkxsu3FTHdKQXW+TYJgx0tIw5c6xZkfCSx30C4DerxrxEQw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, 9 Aug 2024, Pasha Tatashin wrote: > Fix invalid access to pgdat during hot-remove operation: > ndctl users reported a GPF when trying to destroy a namespace: > $ ndctl destroy-namespace all -r all -f > Segmentation fault > dmesg: > Oops: general protection fault, probably for > non-canonical address 0xdffffc0000005650: 0000 [#1] PREEMPT SMP KASAN > PTI > KASAN: probably user-memory-access in range > [0x000000000002b280-0x000000000002b287] > CPU: 26 UID: 0 PID: 1868 Comm: ndctl Not tainted 6.11.0-rc1 #1 > Hardware name: Dell Inc. PowerEdge R640/08HT8T, BIOS > 2.20.1 09/13/2023 > RIP: 0010:mod_node_page_state+0x2a/0x110 > > cxl-test users report a GPF when trying to unload the test module: > $ modrpobe -r cxl-test > dmesg > BUG: unable to handle page fault for address: 0000000000004200 > #PF: supervisor read access in kernel mode > #PF: error_code(0x0000) - not-present page > PGD 0 P4D 0 > Oops: Oops: 0000 [#1] PREEMPT SMP PTI > CPU: 0 UID: 0 PID: 1076 Comm: modprobe Tainted: G O N 6.11.0-rc1 #197 > Tainted: [O]=OOT_MODULE, [N]=TEST > Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 0.0.0 02/06/15 > RIP: 0010:mod_node_page_state+0x6/0x90 > > Currently, when memory is hot-plugged or hot-removed the accounting is > done based on the assumption that memmap is allocated from the same node > as the hot-plugged/hot-removed memory, which is not always the case. > > In addition, there are challenges with keeping the node id of the memory > that is being remove to the time when memmap accounting is actually > performed: since this is done after remove_pfn_range_from_zone(), and > also after remove_memory_block_devices(). Meaning that we cannot use > pgdat nor walking though memblocks to get the nid. > > Given all of that, account the memmap overhead system wide instead. > > For this we are going to be using global atomic counters, but given that > memmap size is rarely modified, and normally is only modified either > during early boot when there is only one CPU, or under a hotplug global > mutex lock, therefore there is no need for per-cpu optimizations. > > Also, while we are here rename nr_memmap to nr_memmap_pages, and > nr_memmap_boot to nr_memmap_boot_pages to be self explanatory that the > units are in page count. > > Reported-by: Yi Zhang > Closes: https://lore.kernel.org/linux-cxl/CAHj4cs9Ax1=CoJkgBGP_+sNu6-6=6v=_L-ZBZY0bVLD3wUWZQg@mail.gmail.com > Reported-by: Alison Schofield > Closes: https://lore.kernel.org/linux-mm/Zq0tPd2h6alFz8XF@aschofie-mobl2/#t > > Fixes: 15995a352474 ("mm: report per-page metadata information") > Signed-off-by: Pasha Tatashin > Tested-by: Dan Williams > Tested-by: Alison Schofield > Acked-by: David Hildenbrand Acked-by: David Rientjes