From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B368D6A22F for ; Thu, 14 Nov 2024 21:19:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0D2CF6B008C; Thu, 14 Nov 2024 16:19:10 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 081FA6B0092; Thu, 14 Nov 2024 16:19:10 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E63D66B0093; Thu, 14 Nov 2024 16:19:09 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id C77156B008C for ; Thu, 14 Nov 2024 16:19:09 -0500 (EST) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 6E8FEC038C for ; Thu, 14 Nov 2024 21:19:09 +0000 (UTC) X-FDA: 82785964968.05.7259151 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf04.hostedemail.com (Postfix) with ESMTP id 800544001C for ; Thu, 14 Nov 2024 21:18:10 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=WmSJDYyU; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf04.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1731619083; a=rsa-sha256; cv=none; b=JqxxVRd6TiXFNNmjsKmOzCc9QGyjt0xPCWSCnRuATOGDb3dhSuUn0ExSItGpiAbdvIvmIu wv7FVl+S2XkBbfz9LSPW9Lol6CnvMSHzoCQxI7K5EpBq6N4s+kQCMijUWqCvlIcMGLa0ua J1FLv4p0twRoEdBVxiBWAg0GVWrDuTE= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=WmSJDYyU; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf04.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1731619083; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=95HXltx35X3axEEyU5I1xFjQCoAgrgxAeN7bNmC+/tk=; b=Fj3rZSAOTdw2cvrhQbbzCJJrKbgkPUKxWKl9xhGy9aCgCV6B8GF72M0RHFIWN1b+QBEmRU 8HB/842+KOx9gLCkp/hTyH/pF6ezWG/e+Pp8LpjKIsL8qfmjQt6enFGUytW91apDNltZTR 9uMw69UyXK+fhmW9UOpHMpwu3tFiuyY= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1731619146; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=95HXltx35X3axEEyU5I1xFjQCoAgrgxAeN7bNmC+/tk=; b=WmSJDYyUzKqG1RVyIry7SpBDmcMlunDwf6pMTjM3nMqnVExrEX+FBTsL7ktNL/YwyKukMt MLVyLB9Qpf8C0geTh/PvVsEUt3ASFFz0H3mcYijz7nZwjVyqsWIaejL0OeP0Z8yEfmLehK EAotA5m+B5lFIJDgpBvq0WQ2s+NDQhw= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-65-aZDrESCUPj-LtPkvUTQvqg-1; Thu, 14 Nov 2024 16:19:05 -0500 X-MC-Unique: aZDrESCUPj-LtPkvUTQvqg-1 X-Mimecast-MFC-AGG-ID: aZDrESCUPj-LtPkvUTQvqg Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-43151e4ef43so196225e9.3 for ; Thu, 14 Nov 2024 13:19:04 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731619144; x=1732223944; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=95HXltx35X3axEEyU5I1xFjQCoAgrgxAeN7bNmC+/tk=; b=YB+BkSR+TW1SFAVVC2CiBsj1gcn+3zvccjjfC2ZcIL9VITZR9NuPwiL9YWt+ApI6I9 o4JwBRWWEReM0aaFAA8QLxR1cxKo+kK/g3fA1xYvTHBt5DK8dOJEu5LXnKNhLT3S8ht/ GEyLoJUwxGq4swU9Mn/csC8Bqv/Keq+keAiHg27e0XJWVfmTtl9FE2cBtXT+im3B6xIG Dw2p4aZXhNnS1BlmeI8nja/tSRf/aSaXttg0uDE/4VJDIRAurm2VBtSH/Lj/IgTxOCxA pOevQ8B3a6RJajG/hyo1+xnqYonbwbNUX6l/CcN2EwAQlt/lbqG3EQF/Fzbfo3poVCyC YJJQ== X-Forwarded-Encrypted: i=1; AJvYcCXtnE9VwAU9n+0oX0/dtFmvd5myfAsfz76miJKyyXlWdtjboPqj+AtHETVDXvY5/mMEnBZXibmmlw==@kvack.org X-Gm-Message-State: AOJu0Yyc5JCAV7v4he983xRUiFWGmZlUCcqi2SANX33rUj0g7UHeDqJz sixJboPau7qOxJ8gw79E6O/+MhexDE+G9uEX6PfchQ0HSXqPQUbTqWWsWQXvja0RgwM35+kA7MK XJQLr8uKHa8EVDHPwZzkoE5OW5ahI5CfNOVLkYEyRaGaBcebR X-Received: by 2002:a05:600c:4ed3:b0:431:40ca:ce5d with SMTP id 5b1f17b1804b1-432df78ddf0mr1481015e9.23.1731619143823; Thu, 14 Nov 2024 13:19:03 -0800 (PST) X-Google-Smtp-Source: AGHT+IHcOH1bMpb/+3vao6wvut1KxS5uDUNYjzvwxxxG1CfKJaiJxPZnMW4C72pa+al2x4jen3oYoQ== X-Received: by 2002:a05:600c:4ed3:b0:431:40ca:ce5d with SMTP id 5b1f17b1804b1-432df78ddf0mr1480765e9.23.1731619143415; Thu, 14 Nov 2024 13:19:03 -0800 (PST) Received: from ?IPV6:2003:cb:c715:6600:a077:c7da:3362:6896? (p200300cbc7156600a077c7da33626896.dip0.t-ipconnect.de. [2003:cb:c715:6600:a077:c7da:3362:6896]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-432dac0ae3asm32070715e9.27.2024.11.14.13.19.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 14 Nov 2024 13:19:02 -0800 (PST) Message-ID: Date: Thu, 14 Nov 2024 22:19:00 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 4/9] mm: introduce skip_none_ptes() To: Qi Zheng Cc: jannh@google.com, hughd@google.com, willy@infradead.org, muchun.song@linux.dev, vbabka@kernel.org, akpm@linux-foundation.org, peterx@redhat.com, mgorman@suse.de, catalin.marinas@arm.com, will@kernel.org, dave.hansen@linux.intel.com, luto@kernel.org, peterz@infradead.org, x86@kernel.org, lorenzo.stoakes@oracle.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, zokeefe@google.com, rientjes@google.com References: <574bc9b646c87d878a5048edb63698a1f8483e10.1731566457.git.zhengqi.arch@bytedance.com> <617a063e-bd84-4da5-acf4-6ff516512055@bytedance.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: qIZ1jSe2M9idG95uPA7OSul_ud4Q7rGLtFGcgQRg_WQ_1731619144 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Queue-Id: 800544001C X-Rspamd-Server: rspam11 X-Stat-Signature: ammt7nwdabxz4f4f5eo4dgncfjokoc47 X-HE-Tag: 1731619090-944191 X-HE-Meta: U2FsdGVkX1+dywnlM9XrxkwVGShowA7jyL4L907zlClPSqO+j+TONAr4EiD3MOgC4+T0vvysPWVba3LtoQn5pMpKHbo70/0RV7J2Y4/pO2oP5NwOFyGNFqX5Pt22ZRMcjuPv4sPAXmnQW7Ur/PszKQvivD7zRbtjSPQlwuv5xvb+pXp93I77cLpKAaEwbMFsNOZhl+OANwdsbmo1vCa8/611wc8zkollCXZfp9n0dY/KiVgEgKp5PiunLgRHn1ogAhR8MNTd1RMp9ec6un9JrA7G23VwjoQl8Rkjs/FOWjy+88rWe75Hj3tgqfiVPZmqQTO+ygv9ol1dHwIXa139X9sp/9ejqLSWFMoWRMrBWpaDnXhG6/66MvDySureXK69Z3FX8DZeBXQyqAOVSSX6zkeh5fT9bTF9HnN8PletiWxfd6aNtqnMKpB94v7u959LaAGJFmBDwz1Af9aelaCGJAfFR0isW6ska3dajqubhoGxvqm6B7VTg6zbFBErlcGbotexVMdKZZlAnZGbR4wlVXQXPXiNYLRGUehFy7XJB8JvSTK32rXIOF+GHFZDdpHzSa89JlRjs7b/AhGw8SijPA4CADiCxrF7+bjhPKICTYwGN4W0IxZlDPi/68Jj1unQjk2g9IQViFYfp84ya3dg9rnKsELTtk82XDhmlBIrVNjrOhzLpFLpESC5oKXb8aTcITYv4nwAOSD81w0gp3WMq/6BI1ey16mNXVYjV0L/bCBDOlTn8oadgwyiSwXgNO3BRRbGipGQ5yB6neCOeOBMlhu7KEWg/NuYOzpCctk6dflZF4Mj2ZkYiOdQt3/L3dAfnX9Hyh62QbnbcqxUt9ldPsGRBuzpa83AHvBggniOMPtrmrdnkWX140xIFApFDeHcDKjGWU8tzPvlSf8JkiNXBDJ9ZuvDXJ71hDdHoM9BpZB8yGhXjRxqsQabqAD42tfOOG9tYX2bUhZn/unwbQa GFZbGGiX KQK5l+SCf/2Tww2kJ412ZZw3bP9cXRWa8HuzCyqRhHG0t/MPraygeaP3M9rULnzYlljL/EjhgCFqbcojMYz4/RTaw4IaHeUsjTH1YtlqrYsZj2Ic0an8XXmQbuUPy99leL91bDylcBmSnnnFYReDELJj6iBwNoinbf09UqB+aNmRpesDQDycGCViMe6lzw0LWMxu4FpYt7omKhoCq3emciKFfYe27irDXiYhZFv4IvRvorGgYxRWcpbWAnp/iKDM9FGXIuMp63ldOWbAuuepYBjr5bI7EjMaGEXtAMUfFo60afBRGBIeHQi/k1je1BvXIl/06HU+v2k3hIIWNYckR7BEOsVpgkL5N1YJlDfXHVXUIidBGkrZHNU/bg3rBeOzcS7trms+7wK8JKbzmuZz6rjK5Fl6TKUtkUuJ49OIBb3xHEgvuLJsTvSlNL0xRuBd9R88+OEcUbkg60s/wt7p1dsZ0mQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 14.11.24 13:51, Qi Zheng wrote: > > > On 2024/11/14 20:32, David Hildenbrand wrote: >> On 14.11.24 10:20, Qi Zheng wrote: >>> >>> >>> On 2024/11/14 16:04, David Hildenbrand wrote: >>>> >>>>>    static unsigned long zap_pte_range(struct mmu_gather *tlb, >>>>>                    struct vm_area_struct *vma, pmd_t *pmd, >>>>>                    unsigned long addr, unsigned long end, >>>>> @@ -1682,13 +1704,17 @@ static unsigned long zap_pte_range(struct >>>>> mmu_gather *tlb, >>>>>            pte_t ptent = ptep_get(pte); >>>>>            int max_nr; >>>>> -        nr = 1; >>>>> -        if (pte_none(ptent)) >>>>> -            continue; >>>>> - >>>>>            if (need_resched()) >>>>>                break; >>>>> +        nr = skip_none_ptes(pte, addr, end); >>>>> +        if (nr) { >>>>> +            addr += PAGE_SIZE * nr; >>>>> +            if (addr == end) >>>>> +                break; >>>>> +            pte += nr; >>>>> +        } >>>>> + >>>>>            max_nr = (end - addr) / PAGE_SIZE; >>>> >>>> I dislike calculating max_nr twice, once here and once in skip_non_ptes. >>>> >>>> Further, you're missing to update ptent here. >>> >>> Oh, my bad. However, with [PATCH v3 5/9], there will be no problem, but >>> there are still two ptep_get() and max_nr calculation. >>> >>> If you inline it you can >>>> avoid another ptep_get(). >>> >>> Do you mean to inline the skip_none_ptes() into do_zap_pte_range()? >> >> Effectively moving this patch after #5, and have it be something like: >> >> diff --git a/mm/memory.c b/mm/memory.c >> index 1949f5e0fece5..4f5d1e4c6688e 100644 >> --- a/mm/memory.c >> +++ b/mm/memory.c >> @@ -1667,8 +1667,21 @@ static inline int do_zap_pte_range(struct >> mmu_gather *tlb, >>         pte_t ptent = ptep_get(pte); >>         int max_nr = (end - addr) / PAGE_SIZE; >> >> -       if (pte_none(ptent)) >> -               return 1; >> +       /* Skip all consecutive pte_none(). */ >> +       if (pte_none(ptent)) { >> +               int nr; >> + >> +               for (nr = 1; nr < max_nr; nr++) { >> +                       ptent = ptep_get(pte + nr); >> +                       if (!pte_none(ptent)) >> +                               break; >> +               } >> +               max_nr -= nr; >> +               if (!max_nr) >> +                       return nr; >> +               pte += nr; >> +               addr += nr * PAGE_SIZE; >> +       } >> >>         if (pte_present(ptent)) >>                 return zap_present_ptes(tlb, vma, pte, ptent, max_nr, >> >> >> In the context of this patch this makes most sense. >> >> Regarding "count_pte_none" comment, I assume you talk about patch #7. > > Yes. > >> >> Can't you simply return the number of pte_none that you skipped here >> using another >> input variable, if really required? > > Suppose we add an input variable nr_skip to do_zap_pte_range(), you mean > to return the above nr to zap_pte_range() through: Maybe "cur_none_nr" or something similar. > > *nr_skip = nr; > > and then: > > zap_pte_range > --> nr = do_zap_pte_range(tlb, vma, pte, addr, end, details, &skip_nr, > rss, &force_flush, &force_break); > if (can_reclaim_pt) { > none_nr += count_pte_none(pte, nr); > none_nr += nr_skip; > } > > Right? Yes. I did not look closely at the patch that adds the counting of pte_none though (to digest why it is required :) ). -- Cheers, David / dhildenb