From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64431C3ABDD for ; Tue, 20 May 2025 09:14:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 095AF6B0095; Tue, 20 May 2025 05:14:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 06D4B6B0096; Tue, 20 May 2025 05:14:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EC5C76B0098; Tue, 20 May 2025 05:14:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id CD5326B0095 for ; Tue, 20 May 2025 05:14:38 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 539E5BBD58 for ; Tue, 20 May 2025 09:14:38 +0000 (UTC) X-FDA: 83462725836.11.94508B1 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf27.hostedemail.com (Postfix) with ESMTP id E3E4D40009 for ; Tue, 20 May 2025 09:14:35 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=CUlbTlXN; spf=pass (imf27.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747732476; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ZJTOBMlTlNPP2FNS/azBK/bEROBAE69fDrYhowmzN0g=; b=3mgqjMIHqYodFMoG32e0+EUwRpvi9sPuOncgNGYz9eMF0gFc2eMYzeTNlPBHxV/QAvwm0j EYDZeNI+rub0Gga1ZWIKMabwenXrvKNQl+9B4IS6OWx1E/fh+u3ZtJ/StWaqVTxE7GWfhY BQoYrsWQud8WKyn6TwZ0LTrqa7+Zc0s= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=CUlbTlXN; spf=pass (imf27.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747732476; a=rsa-sha256; cv=none; b=8fEA/wrtn11JOpPpdTY54jzHOERq0Z0uaN5HGl4lhH59XzML8MluHYB8OE21qFg0Eo/bP5 Cpp7EG0Lzyy2GhzaHQ3yHKlCEu4dUQbn3dBFtvgJxnXsUCRDYjV56RhJI5r8MF35Npz5tm MMu72DHA+e7H/NGwv0KPgHKdNxsvTNI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1747732475; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=ZJTOBMlTlNPP2FNS/azBK/bEROBAE69fDrYhowmzN0g=; b=CUlbTlXNb8yQP6j1cAQRK6bQB9sNpbAHvadvCQPv0BTGtqM8i78uhsQTXbblkvFn3d4qI/ yp8z+mTkxr8/CbvmPL5IqqhC2k1X8aalGr8WCjGvOsLS8mtzYmAFg7/FgUvIF5KRSUdXFV TiY2B7ePoafUoOjnhhCEngX67VIR7WA= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-452-IFZCgdKgOE2KGEJ7gn34iQ-1; Tue, 20 May 2025 05:14:31 -0400 X-MC-Unique: IFZCgdKgOE2KGEJ7gn34iQ-1 X-Mimecast-MFC-AGG-ID: IFZCgdKgOE2KGEJ7gn34iQ_1747732471 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-3a370309dcbso983543f8f.1 for ; Tue, 20 May 2025 02:14:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747732470; x=1748337270; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=ZJTOBMlTlNPP2FNS/azBK/bEROBAE69fDrYhowmzN0g=; b=wx9/i/TB6G38V98DEJo7t3jCf169LEHjsPs0SFXrjo7L7/AU7IaGkRYPeR4+Qo66us rDHddSpYqToPAKJoqJMr6Zg2oCg3DFhOBA82JvpFgKScWjmAPFDLMhwZn2TZwndDQcBq pjnJde1UTCshJQjLJ0EqRqomsd2t1E/jm39DFCr4+7ukfUYAmu+5jfnitFDxRLOik/Z7 mbrGzE6S6B82MOIK4E3uQOYhwn+51PNbaHkMHBL8tXXS+CVbcfThWH//6G1AgTBJK0Jx xMPjWOfK6RNvarFTvbO0xGw19WG2dfwuzMS2Z/+LmpHcGEFEMJHwY9busrpn25LLA/D1 c4Gw== X-Forwarded-Encrypted: i=1; AJvYcCVPEnqdshdfu6TBV4cnkgYl8NyN2C+7iSTNyjM/veAeBkoWvO2JATER94SJ2wKdm4mGjfYFTjQi1w==@kvack.org X-Gm-Message-State: AOJu0Yxj6HbqQvPDLGybe2jr/7ID2pnWjEcU/AzLVOU4o4o3qpPGtiAW wz0VmEPjzmGS4/R6wGj5JjYC6ACWguWNnFricYOol2wFWI6o7HhJfu+XCmRbPBXEJpkBP9A7vP5 dI9TxNEq7V9ZxU1iK8UNCU3H/RJETs4+5Hdsrd4k5HZCIenRNzUzk X-Gm-Gg: ASbGncuwcuCjsndxc+VvZPhmViD1LEMdF3MIUJrHHecbUaPUGv/+dLzBt9czA94pocJ qIqdyJg+pnT7e3NhILJ1ekwngWsYGnF1LAidFnf4uPK+U/kWwdWLyrpufu2aoBDssenrAUz1kVh 4tgp1hEw4X0D4x7kn+7AIpe/LkOY3OF6q+kxRCQ+lEKXcWV3QL2uh/nvymDT/Vs9mrFV7ejAkmU JrjvWB4MfgU+zOca+Pdl9dA+3e7vl64JrTSU56X/5sRoHVAU+mJfdaFwco6YI+bfM1m19nLHHQM PCONJdmIDVXJeNmFjH9fKLO06a98mKPfY2BDWfCG0jaUGEzzPkoh984FPnt1dIXBA9Q5RSGpx2P NR+sVceFocwIrUL8o0x91xNdRu5KcJjSoTUZMPGM= X-Received: by 2002:a05:6000:2907:b0:3a3:64b7:6206 with SMTP id ffacd0b85a97d-3a364b76415mr9743323f8f.23.1747732470601; Tue, 20 May 2025 02:14:30 -0700 (PDT) X-Google-Smtp-Source: AGHT+IELMRoyUb9B3CaSwn6aeLm29eDIv1JwJLh9XwSyajwCeGHStBwP7y68AeGNILCinRr/i6UJUA== X-Received: by 2002:a05:6000:2907:b0:3a3:64b7:6206 with SMTP id ffacd0b85a97d-3a364b76415mr9743306f8f.23.1747732470226; Tue, 20 May 2025 02:14:30 -0700 (PDT) Received: from ?IPV6:2003:d8:2f16:e400:525a:df91:1f90:a6a8? (p200300d82f16e400525adf911f90a6a8.dip0.t-ipconnect.de. [2003:d8:2f16:e400:525a:df91:1f90:a6a8]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a35ca5a84csm15726820f8f.31.2025.05.20.02.14.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 20 May 2025 02:14:29 -0700 (PDT) Message-ID: Date: Tue, 20 May 2025 11:14:28 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm/cma: make detection of highmem_start more robust To: Oscar Salvador , Mike Rapoport Cc: Andrew Morton , Alexandre Ghiti , Pratyush Yadav , linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org References: <20250519171805.1288393-1-rppt@kernel.org> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: qYKQLn7RApyqARAmIsGKoDmDWwpEVGxEyItC_0MZfpw_1747732471 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: E3E4D40009 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: 3od854orgj66o7r94huquemoyzpd11td X-HE-Tag: 1747732475-982233 X-HE-Meta: U2FsdGVkX1+52Gn2pcMrJ8aIpQP+DlwpPzfKKopTuBh9OaXJ7rxMPdSkz9jw49xPtARH7SY77mqiyGyPiuz1KbFxgvp7cPnd+ngHcW242JRphLIM30v/KRUO0Sp/RoqYluwif7t5EqWb/Pdj+y/uuTHg+Jx2/t4zEroHdc8uLRMo3/2weI8TNpk4EXB6OJ5tJwcfQhh8ecndP7+Yef0IlK2LIITn/WApa5bjd4oZOIB3YKkrEKHNIVpbKZeXnPbQYdro+M6ypmY3/Zry+rWLJ+cznBHX6XCXGA5reblGfgqBUcamzZINd9gPmFpKt5CxEfFUJZhMr9v9w13Yd5/1tw7F15WONoPUS5LbMA7yY490r523QMd24XbpDDTuTwimg7YBaUeuMC9MbsW8+Im/uKd64d4gae4BlW8loJRllSGnud1PvkIhK4xQkyr/8/PZH+ew6Hbs+aPP9aNlrSg0wn0sZGJmzpyoJ9RaeGZE5ksZoVvMRsPMiN7kMF1Toymq+mU8Z3i3Bx7NCkj7JAnuXvqsm4k1qA5ctqxJa7HI3cjFct46Jjm5oJ/rnUzksw/lGjTkeM6QWZoMw7f7zoPXyIs/3dsmMvkBukHIfWDhfibjHud5KB7vrq0yrurGhGbs3udo8vEY+BwH8PG90GTED6U5JpCBp1sow90nnhM51dwrovWrfgvguzdtoCIaYNTOmKkckhj7ztxC3NcLkaVJUkvv3ksk+lPfQkm/1vuf5JdJEHIaLYA4z3HwI3JF1+Q/xPOX3xscVO/vCBUrrIHMatnNOwE1Vjy4x1LbYvqAzLNcfrkeFlHn71JRFLNd7vTjzUBasPAWktiREBAjasUDpXdTY0YRUjMOKKTpqHhRbyw8HwjSZQSkcSGDe6waCLl0s0SS4BBo16vrSTT7oGiWw1SMMyERm237eJQ6tKr10AE+qvAc7rk/+mXQv6tPluXdPtbTD2UVquOsogBzTit brDmmmA+ 2BT6tmHb5XSpwxcr+85YIjBQd5ypNsgpkJld8ozK3VsajhHz7pr5OIqzFjsB2MY87K5Q4anhWi0kVGkTxsMEc2y1PjVJY0ObFS36T/lxo5+vD+WrsePzeb/cdRpgK8v77DabCAxi1LOONZs/8PGZKUFA5p2/fpyrzcLPY9lmilqp+FYk6Dt7VgNAY64nSerBvXNFW7uwnlUlCzWcVjqUXVlAYN4Pg9UwB5lMAvp9fyDm6T88liFPIBYw9TMsmQqDAVGdSs5RNhBMbctMkm3879ikJtG+bhiVssY00OOQ1c9oIg5x26Vb6NUABnNBVYI8urCT8A1rJXCKxAnoo0LRux5QTxRZ7qrJHr99Dxn45bosYEbUKBlYodVFbdRN5L7/7cSY9PzI4bv3DJx/ukzMoZseFRxUafFhXOINcQ5LOVzsSYhY2wIRG/jUnhdtEKTRbvp0qTQDawqQhsDPB5VbwfK/txo0DClbU27omk1vaSzVFR5Hk0JFd8H6yTuNOQhIoEIRr2l+U+r7x3G63CjY7S57g8Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 20.05.25 10:30, Oscar Salvador wrote: > On Mon, May 19, 2025 at 08:18:05PM +0300, Mike Rapoport wrote: >> From: "Mike Rapoport (Microsoft)" >> >> Pratyush Yadav reports the following crash: >> >> ------------[ cut here ]------------ >> kernel BUG at arch/x86/mm/physaddr.c:23! >> ception 0x06 IP 10:ffffffff812ebbf8 error 0 cr2 0xffff88903ffff000 >> CPU: 0 UID: 0 PID: 0 Comm: swapper Not tainted 6.15.0-rc6+ #231 PREEMPT(undef) >> Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS Arch Linux 1.16.3-1-1 04/01/2014 >> RIP: 0010:__phys_addr+0x58/0x60 >> Code: 01 48 89 c2 48 d3 ea 48 85 d2 75 05 e9 91 52 cf 00 0f 0b 48 3d ff ff ff 1f 77 0f 48 8b 05 20 54 55 01 48 01 d0 e9 78 52 cf 00 <0f> 0b 90 0f 1f 44 00 00 90 90 90 90 90 90 90 90 90 90 90 90 90 90 >> RSP: 0000:ffffffff82803dd8 EFLAGS: 00010006 ORIG_RAX: 0000000000000000 >> RAX: 000000007fffffff RBX: 00000000ffffffff RCX: 0000000000000000 >> RDX: 000000007fffffff RSI: 0000000280000000 RDI: ffffffffffffffff >> RBP: ffffffff82803e68 R08: 0000000000000000 R09: 0000000000000000 >> R10: ffffffff83153180 R11: ffffffff82803e48 R12: ffffffff83c9aed0 >> R13: 0000000000000000 R14: 0000001040000000 R15: 0000000000000000 >> FS: 0000000000000000(0000) GS:0000000000000000(0000) knlGS:0000000000000000 >> CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 >> CR2: ffff88903ffff000 CR3: 0000000002838000 CR4: 00000000000000b0 >> Call Trace: >> >> ? __cma_declare_contiguous_nid+0x6e/0x340 >> ? cma_declare_contiguous_nid+0x33/0x70 >> ? dma_contiguous_reserve_area+0x2f/0x70 >> ? setup_arch+0x6f1/0x870 >> ? start_kernel+0x52/0x4b0 >> ? x86_64_start_reservations+0x29/0x30 >> ? x86_64_start_kernel+0x7c/0x80 >> ? common_startup_64+0x13e/0x141 >> >> The reason is that __cma_declare_contiguous_nid() does: >> >> highmem_start = __pa(high_memory - 1) + 1; >> >> If dma_contiguous_reserve_area() (or any other CMA declaration) is >> called before free_area_init(), high_memory is uninitialized. Without >> CONFIG_DEBUG_VIRTUAL, it will likely work but use the wrong value for >> highmem_start. >> >> The issue occurs because commit e120d1bc12da ("arch, mm: set high_memory in >> free_area_init()") moved initialization of high_memory after the call to >> dma_contiguous_reserve() -> __cma_declare_contiguous_nid() on several >> architectures. >> >> In the case CONFIG_HIGHMEM is enabled, some architectures that actually >> support HIGHMEM (arm, powerpc and x86) have initialization of high_memory >> before a possible call to __cma_declare_contiguous_nid() and some >> initialized high_memory late anyway (arc, csky, microblase, mips, sparc, >> xtensa) even before the commit e120d1bc12da so they are fine with using >> uninitialized value of high_memory. >> >> And in the case CONFIG_HIGHMEM is disabled high_memory essentially becomes >> the first address after memory end, so instead of relying on high_memory to >> calculate highmem_start use memblock_end_of_DRAM() and eliminate the >> dependency of CMA area creation on high_memory in majority of >> configurations. >> >> Reported-by: Pratyush Yadav >> Tested-by: Alexandre Ghiti >> Signed-off-by: Mike Rapoport (Microsoft) > > Reviewed-by: Oscar Salvador > > I will note though that it is a bit akward to have highmem involved here > when we might not have CONFIG_HIGHMEM enabled. > I get that for !CONFIG_HIGHMEM it is a no-op situation, but still I > wonder whether we could abstract that from this function. Same thought here. Can't we do some IS_ENABLED(CONFIG_HIGHMEM) magic or similar to not even use that variable without CONFIG_HIGHMEM? -- Cheers, David / dhildenb