From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8BC2EC77B6E for ; Wed, 12 Apr 2023 08:25:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 25E02900006; Wed, 12 Apr 2023 04:25:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 20F48900004; Wed, 12 Apr 2023 04:25:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0D715900006; Wed, 12 Apr 2023 04:25:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id F2303900004 for ; Wed, 12 Apr 2023 04:25:42 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id A261C81001 for ; Wed, 12 Apr 2023 08:25:35 +0000 (UTC) X-FDA: 80672055030.16.A5E05F2 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf21.hostedemail.com (Postfix) with ESMTP id BAC121C0011 for ; Wed, 12 Apr 2023 08:25:31 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=fuzg+A1W; spf=pass (imf21.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681287931; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=r4IJICmTyYhGT2gtwna9xdp+oOGGlb++xfNzV+F8TtI=; b=gE+vqbHyb58DB3tTSDMcj1bPe6cW6bl75zGkT7b+iuJynI5OmlO2kyi1SMuGgY5bLgewa/ HWcB0JNIXGGlCEfd+hD1M8o/oxasVLfSQlaWDIEr5i2XZSHJjtj/IUieqJL/RlWUjjLbHu pS5DhihiHUNuX1Y52JY1m33vLA3G/rs= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=fuzg+A1W; spf=pass (imf21.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681287931; a=rsa-sha256; cv=none; b=3bFNiyq0Vqa7f01a8CafrmNRNtpg7rC2v8Y4J4iWjdS9ChTxpDjxK7cnNQZM+96SgKJGbu TVnsPBT3+8JcwW9YoJkoe7uLYk/QaGSbRtdNOkNrrywVN+9jAiqySH4c2lfG8/VvfhZ6C5 07wSw2RqVzDuobshldFD/X7tZIuS4EU= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1681287930; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=r4IJICmTyYhGT2gtwna9xdp+oOGGlb++xfNzV+F8TtI=; b=fuzg+A1Wj82Hj8xbw+mTp+AG6JZC6rU6HL9EIxary7oZRInodokJPkoZFeRbSLkAtnb1dJ G5fO6HqhKLHE5X8NjSqi864Vzn1wodP9BxSM6/DvHqj52G0EryABOZsnlJtf86l6y9BwIk ZmaTe8VYx6GBC8BgSk923RYV/1bQS0w= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-29-Ah3JFPxIN0OyJVri9CPM4w-1; Wed, 12 Apr 2023 04:25:22 -0400 X-MC-Unique: Ah3JFPxIN0OyJVri9CPM4w-1 Received: by mail-wm1-f71.google.com with SMTP id z20-20020a05600c0a1400b003edcff41678so1060213wmp.0 for ; Wed, 12 Apr 2023 01:25:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1681287921; x=1683879921; h=content-transfer-encoding:in-reply-to:subject:organization:from :references:cc:to:content-language:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=r4IJICmTyYhGT2gtwna9xdp+oOGGlb++xfNzV+F8TtI=; b=l/Z3gbAJdZqTVwxla1g8f0ax6bOimHns5oMgfEViyWCCt3FZezfLErox7jZF7T+83O QAKAN9xCCrn0x6O86TNnGJRMDwcjh/KR+D3CTZjCd89IyAv7ATprU4vbA714tGPsI0R8 BDc5UVJSJjcEjuFKoSTLNsDVaqeePXVq8PSiGCI3T/43wkcIq/JaW08zrXShNPXhOkd/ lSotMZvVlmCzcjuIH80vz8JSJ6H32Pj2h29r5f/DfLW1udIxrn1fAGWS937Jo8y0LYT3 AT11ZAWGY+u34+qd5m/UKUIw9iQMAuGwJtdQ7gnnsQFzvr1HXnSSFCWTWEDn0SpEw7ZQ SCag== X-Gm-Message-State: AAQBX9eeF1+0/LxLs9i9iNFgx7T50vTKq1+Eqt5LX5UJvRgtvnv2oREz 6xLQBaI0f2Gh2hf0P9zQlEwr96Ork7RcnINxbApJ/4voHeD10szNMnkIbBdaL+Y7x15vpXmRp94 Hn/YNM31heos= X-Received: by 2002:a1c:ed02:0:b0:3f0:7dd1:8e4b with SMTP id l2-20020a1ced02000000b003f07dd18e4bmr10910964wmh.6.1681287921022; Wed, 12 Apr 2023 01:25:21 -0700 (PDT) X-Google-Smtp-Source: AKy350a1WECB1kk68NRdJPbyNjAlu6PPKO9jxkSM5x5lIq92uVGPiP705lFjSOj5uP6sSkJPeDZ5vQ== X-Received: by 2002:a1c:ed02:0:b0:3f0:7dd1:8e4b with SMTP id l2-20020a1ced02000000b003f07dd18e4bmr10910945wmh.6.1681287920628; Wed, 12 Apr 2023 01:25:20 -0700 (PDT) Received: from ?IPV6:2003:cb:c702:4b00:c6fa:b613:dbdc:ab? (p200300cbc7024b00c6fab613dbdc00ab.dip0.t-ipconnect.de. [2003:cb:c702:4b00:c6fa:b613:dbdc:ab]) by smtp.gmail.com with ESMTPSA id o7-20020a05600c4fc700b003ef5b285f65sm1520457wmq.46.2023.04.12.01.25.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 12 Apr 2023 01:25:20 -0700 (PDT) Message-ID: Date: Wed, 12 Apr 2023 10:25:19 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 To: Deming Wang , akpm@linux-foundation.org, shuah@kernel.org Cc: linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230412072741.2116-1-wangdeming@inspur.com> From: David Hildenbrand Organization: Red Hat Subject: Re: [PATCH] selftests/mm: Replace obsolete memalign() with posix_memalign() In-Reply-To: <20230412072741.2116-1-wangdeming@inspur.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: BAC121C0011 X-Stat-Signature: uaa9axz8u3f63qebuppngb9zj7w34qt7 X-HE-Tag: 1681287931-122092 X-HE-Meta: U2FsdGVkX1+MQVPXC7yNaXy5845oik3ozDKnPO+dP44wpwvGJFqvk+FUP/O8VIzy8ouwaTcdmrLaDMSlQ5FEp23IDr1opjMC5Yhp3DvXeyBCm3WoMEplynM8hN2vOQSnNEIU8xn54tM7tekSNoF7FbuSWCzBIGbNucFC4jEDKWoOMZEE80apPyJMBPfjcXlc2hatjk6nawebIMvTONbQDNRk3RRrGtEZOToFIQPH+1svAl4YWlfCsZylSvfv2Ee0b9wgiIO9rC2+qdGulJXyP3AOIRiBOAtkx7AEeosjdZWmrlSXT5PeVWWhS4sYYsC8j6g/+VV3XGleZXjE9zc/yk6KRdGajNBg5qM/1RLEqEH71fCq4kn+630ko5ky+pEMYH2jngV61AJF364Toc2VlMvMx7k4Hf/RYHBjc8OPu1m+E1fpyr/7MxN0JR9f1HNh9Bl9E83AhBNElf+WzYlUWTlu7K68WOYq0ECcc7nEOFD6BnZ0SP4H2uNie8QbWCxBxqidPWN0LnU+t5h0AiBtZ4nDRptlRWmPZgpNWdG81TD5U3fjNMzl9HNmb8KxeFPlk2zrvU9GbgWRvkua6p+rgEQ5lHRiU4iQCqN7inQ7lzF80d9LPrWAcKgs5iklr3APH5wJUysk4NximLN/qeVvEaf9WGHg5HSGtrLR7NY/ksqpVo2X7rHNEmDtjsspIr5iCdv1W6shTOAEDFugf1op/ycbRKyE2obZlQVpQ3LiqRo+C5uesb5K/mqubgBQXDl/s7+VUVnZpr82vCZoV3pem9XyDgWCdxyTwRXJJrrIknQL30KMmGlsKBu0Il0P/2Ryj0cG4lu/5PUMZjgLAUovnT20usibqHJHOgOg28e189DZTLREyP5g4TbM8shrfkj66bDhlgc77dCtbxKls42TgmX6hcdXTZKoBpTe45VEUI+Qj3gkB/L+2Te5wcz84fAuzt1C/DhoamRyNjufyMQ pMCbyeMq GzYxfFrLURcNJuAIJpVjFBqHaIR0yAqrx7iYR/HkaagPpNh1x67NL9vf4AAqph44s54XDM6rmLrkZYKIYZv17nhvt6roGIK1t5SWOvfRxMvHXuSc/YcOWKZeIWwvhRvsQUKUQNjqgdnp7hHMXVfTdnGAya1uKW9Xmz9xJB79Zr3iXroylLw3y3a2/abDddTgll0kl58/qbjXt/6ZJ0mQxU5mSUYOXvnlBNQiWnkTeehjalzoPgHSrvnoLw/hS3s2wuTgX0O4XKmG5fGSYLz7Kaz3QzVfZ9TrO3mFF1IsjXFr1eZU1fYPqROU6HEZK0NQtM3/7DtSK8VGW72tpmW2vegzESdLHPhAPuhuDNFQsLqr0/VZrsZxukSW1PllGyfjgy+QMPgxMEmemMV8ZvBf/Pdl9a+9ViziDLURY985Ayxd1revK84B/h2PG+w9RUhSEQ7qTuT+xiFMSrYRgzzc93nI+8yZij+5UrKNyHDrbEjWU9s+9mv6e55rQXujueGsu3Fft X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 12.04.23 09:27, Deming Wang wrote: > memalign() is obsolete according to its manpage. > > Replace memalign() with posix_memalign() and remove malloc.h include > that was there for memalign(). > > As a pointer is passed into posix_memalign(), initialize *p to NULL > to silence a warning about the function's return value being used as > uninitialized (which is not valid anyway because the error is properly > checked before p is returned). I don't follow how that comment here applies to the patch. What is p? Where is it initialized to NULL? > > Signed-off-by: Deming Wang > --- > tools/testing/selftests/mm/soft-dirty.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tools/testing/selftests/mm/soft-dirty.c b/tools/testing/selftests/mm/soft-dirty.c > index 21d8830c5f24..4bb7421141a2 100644 > --- a/tools/testing/selftests/mm/soft-dirty.c > +++ b/tools/testing/selftests/mm/soft-dirty.c > @@ -80,8 +80,8 @@ static void test_hugepage(int pagemap_fd, int pagesize) > int i, ret; > size_t hpage_len = read_pmd_pagesize(); > > - map = memalign(hpage_len, hpage_len); > - if (!map) > + ret = posix_memalign((void *)(&map), hpage_len, hpage_len); posix_memalign expects an "void **memptr", casting to "void *" looks weird. Further, you can drop the parentheses around &map. ret = posix_memalign((void **)&map, hpage_len, hpage_len); > + if (ret < 0) > ksft_exit_fail_msg("memalign failed\n"); Better adjust the comment to "posix_memalign() failed\n" -- Thanks, David / dhildenb