From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB169C61D9D for ; Sat, 25 Nov 2023 12:16:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5079D8D00B5; Sat, 25 Nov 2023 07:16:39 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4B5958D0096; Sat, 25 Nov 2023 07:16:39 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3A57E8D00B5; Sat, 25 Nov 2023 07:16:39 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 2B9D88D0096 for ; Sat, 25 Nov 2023 07:16:39 -0500 (EST) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 0C214403EE for ; Sat, 25 Nov 2023 12:16:39 +0000 (UTC) X-FDA: 81496374918.05.6610377 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by imf24.hostedemail.com (Postfix) with ESMTP id 9A9DE180005 for ; Sat, 25 Nov 2023 12:16:35 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf24.hostedemail.com: domain of linyunsheng@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=linyunsheng@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1700914596; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oDLnp1HBdEWC3qDTRTogIeUfTI5p555FkGgJ7dnGMhc=; b=orr7se5fMPSQSUUbPX7fuW5rTRH2IqGrQpevKO6IjKGGbrLA+konutCoLx0QWTMocN34xU 0fVwo3fyYBy/j4lt7atMeCyKZ861bW6rfqyiRDI4Mm0ulfncQI/pD4cGo51KmaeFDRWe+p EH5akDx9N0m1i3hswL5FuaMk/n3sec0= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf24.hostedemail.com: domain of linyunsheng@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=linyunsheng@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1700914596; a=rsa-sha256; cv=none; b=lHcOcwHAD69xu9Zrn8N24GTjFmD+sE+tH/aLlgak6tGku5fr61CWeqoQLMMt9DsD51H35T P8SzH9W1QXg1D1HnHWIfXoT/QV9TuhMyqbtD4mMbeebsBOOpFmINDAWUoq6hekPYGu/n9l AEvY4fTrLjc6179M/keXf9yS+L2kntA= Received: from dggpemm500005.china.huawei.com (unknown [172.30.72.53]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4ScrM10vbCzSgwg; Sat, 25 Nov 2023 20:12:13 +0800 (CST) Received: from [10.69.30.204] (10.69.30.204) by dggpemm500005.china.huawei.com (7.185.36.74) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Sat, 25 Nov 2023 20:16:29 +0800 Subject: Re: [PATCH net-next v3 3/3] skbuff: Optimization of SKB coalescing for page pool To: Liang Chen , , , , , , CC: , References: <20231124073439.52626-1-liangchen.linux@gmail.com> <20231124073439.52626-4-liangchen.linux@gmail.com> From: Yunsheng Lin Message-ID: Date: Sat, 25 Nov 2023 20:16:29 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0 MIME-Version: 1.0 In-Reply-To: <20231124073439.52626-4-liangchen.linux@gmail.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.69.30.204] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To dggpemm500005.china.huawei.com (7.185.36.74) X-CFilter-Loop: Reflected X-Rspam-User: X-Stat-Signature: hzibabkxmd9b9st3kmhi3p199fki49ak X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 9A9DE180005 X-HE-Tag: 1700914595-834337 X-HE-Meta: U2FsdGVkX1910pFkDiPRk/jXYobrmjkeP6s2jVH5RSNX3wSg/7bD2OXrhNXMTfzc9T6cAoNBJa8RiPVyqD/7OjpwDFupPUDG25OPz00IuqN9NS4emBmtqA6XQZc7+TOuF/iMR4D25W6VsTmawCKREigDU96HZLYfOgxq3gEEA1uhI9tDUc0K4TpVe49icVJrsG/wFOhNC75WTQcpW/IS/L4d/j8JESSIyx8Bgb7f5efEHpMUVSl1Aty++9XU22Kwo51wGSK4lO657tqIgxgSvuZ1nHdAJsTUq8NmdIxrpdOkMCRfNgeyHfEaTfxc8RUWC13/R8WVfyJs53qNoeMVTJ/Z2Pzr++K5yGewRx6E8iLE49pPM1Un6BBFgPL/xHSeMJ10BofXYfQqEvIpfC37c6YQI7nBPL9KykmmJu/Mgi3Sc+8a8nFbKJPx323JdTFKRgGSlZAqOaTqsDumGyLzdvXNAhMgu00S4VUBniRwI17zq6RX4y0ruKnRVVVyXXBVbVVvHOzMoulE83P5ITxuXwii+Lp+S3EvHZt1iZBAL0+2yIFFe9fbjR1rxvihw90QJ1olw4dgAHLz+4hUHwcD+sGvz2J8uH9lHjiait6lcPpO897F9QcO15eEFf85Mq1sSU0zQ5qrGBJFQj5RZaK9vbrEHxKRNccXNZgf5eAZHaHj/egaGQztIa84vvRzNU2RXyNsr2upzEDnYw+kv4KlOwxY2RrUKLQLX9n8DjaLywE1rSdKWkRaedYZvgl9Ugs6tkyVuycm0tsteKoAHCajznegGLtrLgeQbkQ166itxWXAgU3xNQSgl2dKjw6N0p4TtRM58ZTKRyl/VhOhvGiL/cVN1xGcUW98UMIdIHO65B1dUo4DWtu4wXmLkYJHoVC+o+sdMZdH/BY64qSeua4/13ZyTXh6VrMys/lzk9xiQ84rbA8rzMZWUiOhIFytVGmUoLzF4c0okEC2TaGFHFT fMh6FyK0 eS72ERFcRacfgZi+fLqdFYu5ukkI6FKKtNW8k8AGd2L0D/YMSLlSjvRVrgTn4wv0aXsntZGP1+2YzukUR+0Vdu4Tm3bS8qhkSXwW4O4LAYZEmigJQ1HIDyOx2i/6wTQxnCt+CEW7Y26HOsvrQl9JmQEi0rqHACvFrfiF05FAKfqCxdqlY4Fc5lbd0J9eUa9cuVpcO0dgrmEdNLP2OMDXza87/FdthZAm+ofs8 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2023/11/24 15:34, Liang Chen wrote: ... > --- a/include/net/page_pool/helpers.h > +++ b/include/net/page_pool/helpers.h > @@ -402,4 +402,26 @@ static inline void page_pool_nid_changed(struct page_pool *pool, int new_nid) > page_pool_update_nid(pool, new_nid); > } > > +static inline bool page_pool_is_pp_page(struct page *page) > +{ We have a page->pp_magic checking in napi_pp_put_page() in skbuff.c already, it seems better to move it to skbuff.c or skbuff.h and use it for napi_pp_put_page() too, as we seem to have chosen to demux the page_pool owned page and non-page_pool owned page handling in the skbuff core. If we move it to skbuff.c or skbuff.h, we might need a better prefix than page_pool_* too.