From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 77F00C001DF for ; Tue, 25 Jul 2023 03:09:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D8F978E0001; Mon, 24 Jul 2023 23:09:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D3F9D6B0074; Mon, 24 Jul 2023 23:09:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BE0778E0001; Mon, 24 Jul 2023 23:09:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id AB90D6B0071 for ; Mon, 24 Jul 2023 23:09:25 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 8963A80C29 for ; Tue, 25 Jul 2023 03:09:25 +0000 (UTC) X-FDA: 81048653490.19.A5EA4CD Received: from mail-pj1-f50.google.com (mail-pj1-f50.google.com [209.85.216.50]) by imf09.hostedemail.com (Postfix) with ESMTP id 8904B140009 for ; Tue, 25 Jul 2023 03:09:23 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=T37460kh; spf=pass (imf09.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.216.50 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690254563; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ZLkcXzJjvvDBLgu5DbJbwRAKtejO8FK7VlKqBEYpGhg=; b=uu1V3S4wY4fQ+6Ez5pou2yl+Q8FJ27g9k/xiVc1Ytyr6XoI3xy9Tnlpj7+kIUEOS2ydBRz iexZjGOVnDclRGxMLrwqLdymL+OKS9LiPLHBckzVUySrpr0l7lMAPivhqerREQRlw7dxtM ju45YgwuOHfVeNRlxNjbTozuHBHtymc= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690254563; a=rsa-sha256; cv=none; b=uXONZePcLUHY97fBJW+hG/nuqmZ+L+YnBJyE17up5cl+ReIleSEhSx1nJHph3Bmhhqw4hk fQFPJExvtleR6Lk4kjuTFK5UFkVkaDRPG4fThiT2Jv+mfL1slbuyoGezgfDhYkBSUrym7g WK8/Fuz+YkKF2qYfnootOfo7MINJX6E= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=T37460kh; spf=pass (imf09.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.216.50 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com Received: by mail-pj1-f50.google.com with SMTP id 98e67ed59e1d1-25e847bb482so707982a91.1 for ; Mon, 24 Jul 2023 20:09:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1690254562; x=1690859362; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ZLkcXzJjvvDBLgu5DbJbwRAKtejO8FK7VlKqBEYpGhg=; b=T37460khNMPot0VVWdDz4lB6VWzVdicUBxVfz7CttLqrgD8g0MkXpwdKxm81+5qM3E yM+KFmnDFeQa0ZY5ZeNvvyumpxFJqPDg3oixgT5YKKGKOt9qmtbXs6vK0nUKy4kqsaDS iJ3utK1jXEfJapBrHYjK+SRbiAPBWHkzR4mO0jKk+qC4Stl39POzbhCCP4MwAtpmSso5 ynGZ9erR4hLoA8pCdH+sRZpUbw1kMvKh2ycfFI2IzmOqd8Zq8Q0hlgUcK6mejCeashGS UzcYSPHM74qvjYTTAriMRhyDbW62IR+NfEc7uD2qj/U2RIYLpDl8fGFG28yoLGatJrqh GkTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690254562; x=1690859362; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ZLkcXzJjvvDBLgu5DbJbwRAKtejO8FK7VlKqBEYpGhg=; b=Js/EsfOtCpclUTTOwJxgAh7fdvFvZDaIC5l75dlQgQqG9eKfSc8DxY7pOBjfe6f3wu ronoqjRr4xl6aHke04K9IE1F7TyJ4eh8uwd5i0DO8YKYtmlD9usYkwqrT93w+ucrHffb EPrYmXT+zBGRoW46Qm/Ls/blaEmCdRwLDKSD5BF0qOyFeHX6qFyBMrDti4IeCriHFOe+ ON6fK1gqJKCrKZTyRUURUHLEBwwb8JwcjGHGgoJKbZLnbDA0yooyuWnXVb1DBfV1LPci d4k5PKPPRjwPSacMooNM3P95Itpx3lDamZUA/4cnva6eTp7dGSTKeptBODdQH3HQJVE3 yipw== X-Gm-Message-State: ABy/qLbEX5E7tGSDdcbfhMTLC2r0SdGHJjmR5WoVd2hq+vGIz2ken8wi oHy+wy+MAW0uhB3SKAKxfDQBFg== X-Google-Smtp-Source: APBJJlEruF0WFFXXZAOwcLJKfTF/P8Yek4Wx/bwgxp4VRr2IRHJr9OEk7izXq54CPTEEiNehAqKYyg== X-Received: by 2002:a17:90a:50f:b0:263:730b:f568 with SMTP id h15-20020a17090a050f00b00263730bf568mr10246975pjh.3.1690254562043; Mon, 24 Jul 2023 20:09:22 -0700 (PDT) Received: from [10.70.252.135] ([203.208.167.147]) by smtp.gmail.com with ESMTPSA id 21-20020a17090a199500b002633fa95ac2sm9540001pji.13.2023.07.24.20.09.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 24 Jul 2023 20:09:21 -0700 (PDT) Message-ID: Date: Tue, 25 Jul 2023 11:09:07 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v2 01/47] mm: vmscan: move shrinker-related code into a separate file Content-Language: en-US To: Muchun Song Cc: Andrew Morton , david@fromorbit.com, tkhai@ya.ru, Vlastimil Babka , Roman Gushchin , djwong@kernel.org, Christian Brauner , "Paul E. McKenney" , tytso@mit.edu, steven.price@arm.com, cel@kernel.org, Sergey Senozhatsky , yujie.liu@intel.com, Greg KH , LKML , Linux Memory Management List , x86@kernel.org, kvm@vger.kernel.org, xen-devel@lists.xenproject.org, linux-erofs@lists.ozlabs.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-nfs@vger.kernel.org, linux-mtd@lists.infradead.org, rcu@vger.kernel.org, netdev , dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, dm-devel@redhat.com, linux-raid@vger.kernel.org, linux-bcache@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, linux-btrfs@vger.kernel.org References: <20230724094354.90817-1-zhengqi.arch@bytedance.com> <20230724094354.90817-2-zhengqi.arch@bytedance.com> <97E80C37-8872-4C5A-A027-A0B35F39152A@linux.dev> From: Qi Zheng In-Reply-To: <97E80C37-8872-4C5A-A027-A0B35F39152A@linux.dev> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 8904B140009 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: h4tt7jehk3a1etzj8wnpxzyy45mx1wdf X-HE-Tag: 1690254563-828379 X-HE-Meta: U2FsdGVkX1/bG2TWYi/hPZSXGSz1VXbvL1mPhQKWLWWTZXrutlc3jhW4g7IhSjE8jbtP7Gkavnz/ptjFr+DqpU9WOOn6tYhICEcIXDhSFtWlhvM4ywGy/JR+sG4llg8XDmd9CqFh3j1GD8zfcWuCQD3QDHKx9AZQImpO8XNNl2a9YC5/bLbAM1vZPfT05p7RgeWT5h2K8c6ssDDJ7n+8T2PJf+lMG1fBCyCSG2MCGnX4s2FoE+GAe0KlB4BTBWpzdHmqavN0b/CDl+KZr0v1jGwfl6t/CCJJewCn5QFKhy303shvHIl7J36AESzAzVM6YtZh1A66cux9MEguImQcloLk0HlzhkjY5LJZrOc5iVNgEG92d+DkCwNLtTf1d9L5Yp2SZ5dUMHLnNJm6/bRQesr2CwsmjKZ+dJn5bbHdRrFtQ5dJJ8h7Rx1FpW6GziUHH3fMbf43c38IWtZXvOHj8hP27uUvo3itCcyFPqdStt0r3Rny/fmrjJSZr56Ck4yieqStJaNBDV4i2LPiCEBO/xOLJlV2n42Ph28bGeA+HMuUV7E8RMFQ0QFjk0svCzW7N6PdcHBvLg+U84zIFkjfufs/OabmMmvFxml2QbxfYhLxbGVuaMzdn9iEFBrmpcAoxVeeemfkQC+Ql5klkl1OcFzp7NUe4jXiGmuNVipPPdwHaoLzj3+/k5Th6L2ETtR0YYt1hNAVj4IH2+IuHQTw/Ngh2mnuZ63oy+HZ1P3CP3Ul8FIC3b7Il6vQvC0TNEaImbCqPSJuGhltldlJ7bioTAvzwc0Lw1SvutLYPOQsHVoq7DzTiHL5MoyXraODtOkn9p6ZatvMBPtWg+xOoZspBV4G+yB7knryxyqi/hXx7v+Z/REF8EwLvMdubxxXfx+jK7t2Z8HOY3d6+z3JlubO/lHkWUDW2LjrC0uZO2KgCAZLvVnOVzPRkEeHIwJaMM0nheZpU9pcxT2tl+ZSWJ2 haxg0fsg HAUPsCMotf4L1uiJ5mITYZl4RqisGkdalNjJLoXXh2q92OqhPbVjxAzpSMZ7UQLLtCBsKg68uwAwl+Cz+vgKr7iPDP8S+Se7eaODtz4GfFfkDQJIyyQpQ1NJpITr0PI1m6W4db8eS5U0wWAKgFj5Wy7lktK0lLvq21gryluvLLhUIijIpPvSCHnN2vGweyoYs5LoFK7rDowPcpCSkBwtPQ9bT5WSZ5VphEgt2Q2u2KMWVLltMZCFhuuZNjiLhEOGMLBkj0FJ4KNO6NAluBGFVQyoU0u8QUpbizlTZhG4J6GVdMWltp4LMfa/gnU4biqBqOlhZ7bYJ7hpLYqUcLY/rlb531D4FJjL88+ya5l+70v4oklfH7vG3h1UnrvPLOs7K1ay/oJqeYgmImicHn/UBrqM0tijTjhrspgla2YDnWtfuInc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2023/7/25 10:35, Muchun Song wrote: > > >> On Jul 24, 2023, at 17:43, Qi Zheng wrote: >> >> The mm/vmscan.c file is too large, so separate the shrinker-related >> code from it into a separate file. No functional changes. >> >> Signed-off-by: Qi Zheng >> --- >> include/linux/shrinker.h | 3 + >> mm/Makefile | 4 +- >> mm/shrinker.c | 707 +++++++++++++++++++++++++++++++++++++++ >> mm/vmscan.c | 701 -------------------------------------- >> 4 files changed, 712 insertions(+), 703 deletions(-) >> create mode 100644 mm/shrinker.c >> >> diff --git a/include/linux/shrinker.h b/include/linux/shrinker.h >> index 224293b2dd06..961cb84e51f5 100644 >> --- a/include/linux/shrinker.h >> +++ b/include/linux/shrinker.h >> @@ -96,6 +96,9 @@ struct shrinker { >> */ >> #define SHRINKER_NONSLAB (1 << 3) >> >> +unsigned long shrink_slab(gfp_t gfp_mask, int nid, struct mem_cgroup *memcg, >> + int priority); > > A good cleanup, vmscan.c is so huge. > > I'd like to introduce a new header in mm/ directory and contains those > declarations of functions (like this and other debug function in > shrinker_debug.c) since they are used internally across mm. How about putting them in the mm/internal.h file? > > Thanks. >