From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 354FCC61D97 for ; Sun, 29 Jan 2023 03:27:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8D7946B0074; Sat, 28 Jan 2023 22:27:09 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8874D6B0075; Sat, 28 Jan 2023 22:27:09 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 701076B0078; Sat, 28 Jan 2023 22:27:09 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 6058E6B0074 for ; Sat, 28 Jan 2023 22:27:09 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 186171A015D for ; Sun, 29 Jan 2023 03:27:09 +0000 (UTC) X-FDA: 80406400578.12.EBFDBDA Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255]) by imf18.hostedemail.com (Postfix) with ESMTP id 68D0D1C0004 for ; Sun, 29 Jan 2023 03:27:04 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf18.hostedemail.com: domain of chenwandun@huawei.com designates 45.249.212.255 as permitted sender) smtp.mailfrom=chenwandun@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1674962825; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CqJH6/EKLlUQLxN86NuLmSjmfNCZZib96Rj4Z5lHC+8=; b=exh62fPjM4spmqxvqBykp3rcvd/uVxjKt5PPktSjhA8U0f5YVPP1gS7SIMVzdpRsinuLB7 wsyd7qiSioV5Jxtmc4/cVHJ63M2xgGZbSQhH3ZVS6YYY1LEUmD5F2gXiAaywNQopiV+LYq E+YHv94OoPk3IoR3V5UF8KMQyDwiT8A= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf18.hostedemail.com: domain of chenwandun@huawei.com designates 45.249.212.255 as permitted sender) smtp.mailfrom=chenwandun@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1674962825; a=rsa-sha256; cv=none; b=J89Gdk3Z/K4lBp+KeZ4652IMUHsmgGsH9JHCdzx/Px4P/WjS6MnFjFaDGQm6cikCLLRHFE 7ekdAwsJTRbQBP8bIQ9j0FGrsV+HHpkO4n2Rt/bJvEdASlvLS3xSHYVd33tlPK3LodChVY 6KIzuVyMkcwim81kxVxeG32wy+FSMY0= Received: from dggpemm500002.china.huawei.com (unknown [172.30.72.56]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4P4Gs85W9wz16Mlw; Sun, 29 Jan 2023 11:25:00 +0800 (CST) Received: from [10.174.178.178] (10.174.178.178) by dggpemm500002.china.huawei.com (7.185.36.229) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Sun, 29 Jan 2023 11:26:58 +0800 Message-ID: Date: Sun, 29 Jan 2023 11:26:57 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.0.3 Subject: Re: [PATCH] mm/migrate: Continue to migrate for small pages To: "Huang, Ying" CC: , , References: <20230129025404.1262745-1-chenwandun@huawei.com> <875ycqcad0.fsf@yhuang6-desk2.ccr.corp.intel.com> From: Chen Wandun In-Reply-To: <875ycqcad0.fsf@yhuang6-desk2.ccr.corp.intel.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.178.178] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To dggpemm500002.china.huawei.com (7.185.36.229) X-CFilter-Loop: Reflected X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 68D0D1C0004 X-Stat-Signature: n3wotkc4d46n4m6dp8t9sexqzj8epg4x X-HE-Tag: 1674962823-811146 X-HE-Meta: U2FsdGVkX1+ed0ay6Kcrke07GkYhDK5X4k7asTs0PdldhvF1dEVDVPoaShmgg29GFpLlpXNDOrp649Vbx2juBu2JMI+ZjVmzREXhH/KbnRRz3DIMHd7O2JSrESki60h+alkZup2dIPj+gFu1WHbTuGy5RBobxuRkgkUcsGsOMMHOlXI5gxe2cPZGZNF63poTOZjIyebL1TJHLM25ljdJPVt6NjK8oYTX4K6JBPDdW5FYJERZRxi+Tln7dRfTxo28RTTmReUPnXy6LYIQqDwcHCIYg6OMHNOgAdsvHSS5NlQjCRrV6zc+y0zTYqvpJgC+bf6fL75j3qRWBWJwharM8CEm3HoyL/jRRQ1uLelUfbG81Tpy+R1OspyM8STyhDRtrJNoMU+dOkCgmcgd+ksUwJNGb5x9oRec+MdtfEu+VS9aYwOKxWqzd/cLVoFVOvU63Eok7KHWF05pCbfhw1ywTXFs6WZueRz8TObc9wGowuUDoFjJ4b6a9A4NveUxaFLIqWBW8Q5WBiraL8ZMtJu8YF0uAKAN5dQRWdSNzO9N3c6W5tdkQZUxQq+2c/zIDFipqwTQpcmVFAU6aoAnd6fJVCZI/xQbikcf7CGs7+Hs8Mc4m/z0fTxWzgu3ZAiUggMpzjT11pyPSaKanepx84O/1jkiwT4kc1l2M63HWeX5Eb3lvlR9WZhUSx0uIHBOQAzZ3KqEK7F2/40WLvoXvhnVipojZcThKZ9MWlXVoKus1817SJXg4/crYDfJgd7kqwSxywtHJt4t9a6WT3CxakGSEyasBIBocKfv0ILsZNfEEiup9f+rrNWilk1OV+RNUU2L3Ra4tYrri4DFS7zn5FUToiwWNUIoSxP2AIH1yOEAGzGNMu/buRxSb8PSCwtCrYum5kLAegY80CPfUPAvK1BlDsvff9WSdFJg7kAwywuweb7UP/o3yqf7BSrAbnGdr84cu98KBJzBJNZcx6nTSTj YFPU/d7r RqdkqnLvqxpEIpy+MnunmiA2Jecq5eUNvZuNmCjcz9eNR7dgvQf4cLp0y/MOxIgcBVuyUxD7o5JNhPjXFHsgV6UFT0hfbvxNDotaCXK1YOrn1WeWqBRYEyJOrmNT74a/tZg4WF5FMyhL5s1q3bfj/y9DhtzXMzWzpcoJwrd239lHQlao= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2023/1/29 11:01, Huang, Ying wrote: > Chen Wandun writes: > >> migrate_hugetlbs returns -ENOMEM when no enough huge page, >> however maybe there are still free small pages, so continue >> to migrate for small pages. > Better to replace "page" with "folio", and "small" with "non-hugetlb". Will do. > >> Signed-off-by: Chen Wandun >> --- >> mm/migrate.c | 7 ++++++- >> 1 file changed, 6 insertions(+), 1 deletion(-) >> >> diff --git a/mm/migrate.c b/mm/migrate.c >> index b971edbf32fc..c9d0d2058036 100644 >> --- a/mm/migrate.c >> +++ b/mm/migrate.c >> @@ -1939,7 +1939,12 @@ int migrate_pages(struct list_head *from, new_page_t get_new_page, >> >> rc_gather = migrate_hugetlbs(from, get_new_page, put_new_page, private, >> mode, reason, &stats, &ret_folios); >> - if (rc_gather < 0) >> + /* Maybe there are free small pages, continue to migrate. > There may be free non-hugetlb folios available, continue to migrate. will do > >> + * Nowdays the only negtive return value of migrate_hugetlbs >> + * is -ENOMEM, keep compatible for coming negtive return >> + * value instead of ignore return value. > This can be moved to patch description. will do thanks for your review. Best Regards. Wandun > >> + */ >> + if (rc_gather < 0 && rc_gather != -ENOMEM) >> goto out; >> again: >> nr_pages = 0; > Best Regards, > Huang, Ying > .