From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0223E77188 for ; Fri, 20 Dec 2024 14:16:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 206556B0089; Fri, 20 Dec 2024 09:16:31 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1B6906B008A; Fri, 20 Dec 2024 09:16:31 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 07E836B008C; Fri, 20 Dec 2024 09:16:31 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id DCB3A6B0089 for ; Fri, 20 Dec 2024 09:16:30 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 748F8A0ACA for ; Fri, 20 Dec 2024 14:16:30 +0000 (UTC) X-FDA: 82915535304.17.BB460C2 Received: from mail-il1-f181.google.com (mail-il1-f181.google.com [209.85.166.181]) by imf08.hostedemail.com (Postfix) with ESMTP id 77D07160011 for ; Fri, 20 Dec 2024 14:16:05 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=kernel-dk.20230601.gappssmtp.com header.s=20230601 header.b=zptAy3pv; spf=pass (imf08.hostedemail.com: domain of axboe@kernel.dk designates 209.85.166.181 as permitted sender) smtp.mailfrom=axboe@kernel.dk; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1734704172; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8Od2zcnvy+Skob7o4jzUxcFwew46oxr58HydCMFgN+I=; b=BTs7M+7m/yqQ2vCeyY8Z0SbevXWnq/sXN8FajGbqqaFcjOJtkgpkbKouBrheqJ5znxj1N0 95SICQuFXxcXtzLET+rywnbOr0Ckac01SmHMVXadXMTr+NYEyBxLraQ88Lqc8H+oCrtfem ukYoGH8jrDy6DONSkY/T+oJGCebwaKA= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1734704172; a=rsa-sha256; cv=none; b=y8cgA9aa0bKixpvxBT3ATGrL9vC0QFa3aloyTv+2zmlcuLifnHgEpwlpSUmXqFzSkWakzC dgbUythPO4/xdSwxJaUfAYXrFCLXMaJ01nfDACtn38cjY8KQz1sgJZq9Qs8TpbUOtemM2A dN0GWW/0c9ocNHbXAuC2I/WFMU9JL6A= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=kernel-dk.20230601.gappssmtp.com header.s=20230601 header.b=zptAy3pv; spf=pass (imf08.hostedemail.com: domain of axboe@kernel.dk designates 209.85.166.181 as permitted sender) smtp.mailfrom=axboe@kernel.dk; dmarc=none Received: by mail-il1-f181.google.com with SMTP id e9e14a558f8ab-3a9cb667783so13870415ab.1 for ; Fri, 20 Dec 2024 06:16:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20230601.gappssmtp.com; s=20230601; t=1734704187; x=1735308987; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=8Od2zcnvy+Skob7o4jzUxcFwew46oxr58HydCMFgN+I=; b=zptAy3pvDDDlJdm5eavJ4xFPrLd1xjNReEIObFMwZ19hv5GbWoQvD7Md7eKu1Ud5YG 116qYbFoIge2ahANiX4ffmynhcjPE44u/yH0icWMAQ9jfq3F+y4Y4LbgCaWL218+eFIc 7WpW8Kuu/DE/3Tx1coKAEBKUdUZh0yybFSDQwJ/SRQu9onCw3P+BwmykdYLb+SBO+35a TPdPlepaqIj0zX1mig1pob7tvzN8MVnRyV4Ljm0S2/TF0ZZBoSCriTMTEPmG1jjL8Nsy k0IrBzh12iAWo0gSSJySPMXPrpzHCYBh0Ygzhv+rR/SUOnyhpKzW0yeKLxF9+L9IErv3 /WgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734704187; x=1735308987; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=8Od2zcnvy+Skob7o4jzUxcFwew46oxr58HydCMFgN+I=; b=e42fidmIp/U/WnaMGz0PV6f36SURNog2XnqOyCgu7CwfkGy2Rk0T5dWn6MUidZaqxb t6qoRHnEYvq1MgZRZfGGfmnuLAGgLRHYJQhiqs/4Qm0OorH7DtKWE0G9oHPhwBTK99VZ wUEnDCCTspJjXTZc/vk9tM+PedGjSscidlJIU/TEteuF2CZka6XKrH9oZdNwktG5Dtx/ 6uXUv6TE2FrqaJHjOC20QNNfXdrpl1JV3n/1tv2U5OwNKqMxC1gmmzHfSVc8LUZMqIZL I/OMkz3TznHMenKk3mf6mGKr9P21brXbOUx1xTVPHoYb/gbCZ9O9fkxdFj3FjxEZJv0L 47zw== X-Gm-Message-State: AOJu0Yzz97uLMwI33WJk7GLtMGRwWGjC0LTRS5XFetzAzT27ki83TAAf wqWXBUdQBA1c4H5eo2E4ffzp+zyOsQt7m7JQ20u83QTkaSUjO7ZohNCQUQhIIUE= X-Gm-Gg: ASbGncvaF4K3ELTOeZS0GjIT6QfsQZk2rXOSJjnZ9cdg5bWg3/0qsU1NJiiEQYf8rtL YJ2v2vFrvMCSUyryXXQLM7V9GlbQfzNdlJ1HdqYFoa8N5iA6Ez/JFAAWtjZqA01zbalC3Co8+1Q 5aNnxTpo93ax35kxMPnxc3Uiq5BFf4nLrJWRJtDBv2h+MzveeRSwkzySKle7l8dW+mmnZeMLlrA s/0O+ZCO+vw4WPEZn+yVRsLUCMZFSHDSDujZHH2tb5IlYUEHxCY X-Google-Smtp-Source: AGHT+IFK4GJzPS9PuZHJQMBiKb29k8t0eWkw3zO63tOvzuoY8e1x5vNSt8Y4g8JbZBqvV+ZRETd90A== X-Received: by 2002:a05:6e02:1c8d:b0:3a7:96f3:bb3c with SMTP id e9e14a558f8ab-3c2d1e7df7amr28390245ab.2.1734704186767; Fri, 20 Dec 2024 06:16:26 -0800 (PST) Received: from [192.168.1.116] ([96.43.243.2]) by smtp.gmail.com with ESMTPSA id e9e14a558f8ab-3c0dfb3264asm8870215ab.41.2024.12.20.06.16.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 20 Dec 2024 06:16:25 -0800 (PST) Message-ID: Date: Fri, 20 Dec 2024 07:16:24 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 06/11] mm/truncate: add folio_unmap_invalidate() helper To: "Kirill A. Shutemov" Cc: linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, hannes@cmpxchg.org, clm@meta.com, linux-kernel@vger.kernel.org, willy@infradead.org, bfoster@redhat.com References: <20241213155557.105419-1-axboe@kernel.dk> <20241213155557.105419-7-axboe@kernel.dk> Content-Language: en-US From: Jens Axboe In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 77D07160011 X-Stat-Signature: zqfobcjjgthbfod6tmb787g5t55gb8mg X-Rspam-User: X-HE-Tag: 1734704165-572961 X-HE-Meta: U2FsdGVkX19mu5xymfYswpRLVuiSnhVoEwPMF9YcpKylqqOZQhQL0wgisln0VzPqKCXLuQminyufrOyoqaXj+X0ivQpgRA8rHKdSUTUCFec6Ga/88KMVqC3yD9jQcJvhM557U3eiCUp1m/Ho/mVd1Glrkm20dSgm6OQGeK2CQMwzFPRzvYuCw6qsoY1tneOkcfvDQaq9zA5JS+g2HcFaJcw7YeuLX4T1lrZD74MDVoKm6Lkwphm4zxaFD/Wl7ohsr14uY+KJ+QgozEgaBMTpD+TYTKo6IXN7foyBPIEY+ImM9n4EuvTsHMzgFbS2IDcaqDi+TEGCjgeSShrH3R4q6GAuFB8Y9125my02dtiV95reGOZ6v0keBJPy7ehDbeRrkB2IKx7rcy/q8E8yGNdDNrnDS63NDVnxvGpY5y9nQ71NRmCiS9HLx5IcFNakJc3to+dPAJaBtcB1TizhEctSU7hJFv0gN5AzK42Cc9HTMae2Va2VuF2u0EY5m/a3UZ0NK5lwektZetfInC0LeClIUFENUBB6uE+70yqe6CrC1QOaKd77H48OY1B44BiuoTHs9hk4FLfENUpIGO9mbybF+YVudbw4gCbtKOlPfaGA35EiHMizsCm2jN1rPWKAbFgkjVf0JMJJ4Yuw90eGDyVlrCvb64vFGnsBeU3lCJgWVPQ7pRdAyBkBRqNSakOPfc6VtGd3d2rkwqU6ukVIeFHwItBoBaOkF0BC1v5MCZTqu4OnAF8jMDkcF5MvkQKMJeMMW0zBTv+Mffh13tnM4wFcRICuLVEa90jjuW1kEPLjlIy4WJ1VtgL5M8DpodqGE/p9iDwycg5FfGPsyWLdKL61nZkeqxVbCAs9qpNKHqpgbOV3A5shoG9LomZXiH1ieR6YAxUkd0eJmCR+DHLvGU5XGTU3n8Ta43agEfpgawPTRdmbdo0L4U0Zzekx99Pktp7Ut6mH5dgWkzzjBBeA7OJ DQwQvCSD ltrHGVG4x2TqcO4vFh/ddJ1r6zXtDOooqW48eC1van+cjJ2idlNzkK5EOls2KC0es/az7RLLPFMqclqD1sTR2odTVlmJ9po3s9nqKxvPlHBpzi6uiWzR224wObxTDjHwvLAGX83eLpmWUzRIh7ihhIJF0gGimpUhUNhzHrDJpVxJvYLW52moT1TCMTp0nVOiaciVtmaW+UeGVpj2Arls/tyKyGwUQv1H4ay6hxqWtHU69pHYGHtO/i5Zcm6fdqDBl1JlubZpzLMu/CtckQWxo+RlqD9v/nlsC2Kr5KNh5EPqMDvkZQuvjJ8zakB+yyC2LBdFjx/AyxV06ToVB37S2EWDJWR6JtxTWSsKTRWY+vmxGN4QBjrq7p/ebPOra2q8Dae3P+8j6+UTQ7Q54DtGQ9gHBBw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.289238, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 12/20/24 4:13 AM, Kirill A. Shutemov wrote: > On Fri, Dec 13, 2024 at 08:55:20AM -0700, Jens Axboe wrote: >> @@ -629,18 +641,8 @@ int invalidate_inode_pages2_range(struct address_space *mapping, >> folio_unlock(folio); >> continue; >> } >> - VM_BUG_ON_FOLIO(!folio_contains(folio, indices[i]), folio); >> folio_wait_writeback(folio); > > Any particular reason you drop this VM_BUG_ON_FOLIO()? No reason at all, I think it just slipped under the radar. I've put it back now, thanks! -- Jens Axboe