From: Jens Axboe <axboe@kernel.dk>
To: "Kirill A. Shutemov" <kirill@shutemov.name>
Cc: linux-mm@kvack.org, linux-fsdevel@vger.kernel.org,
hannes@cmpxchg.org, clm@meta.com, linux-kernel@vger.kernel.org,
willy@infradead.org, bfoster@redhat.com
Subject: Re: [PATCH 06/11] mm/truncate: add folio_unmap_invalidate() helper
Date: Fri, 20 Dec 2024 07:16:24 -0700 [thread overview]
Message-ID: <d24ee33b-4207-4696-b878-5b2c4d47bec8@kernel.dk> (raw)
In-Reply-To: <e5rdpzjosbzrddun7vx66dlb522pyo35qpcchaw6eywa3ylxkz@noj2be2j7vjl>
On 12/20/24 4:13 AM, Kirill A. Shutemov wrote:
> On Fri, Dec 13, 2024 at 08:55:20AM -0700, Jens Axboe wrote:
>> @@ -629,18 +641,8 @@ int invalidate_inode_pages2_range(struct address_space *mapping,
>> folio_unlock(folio);
>> continue;
>> }
>> - VM_BUG_ON_FOLIO(!folio_contains(folio, indices[i]), folio);
>> folio_wait_writeback(folio);
>
> Any particular reason you drop this VM_BUG_ON_FOLIO()?
No reason at all, I think it just slipped under the radar. I've put it back
now, thanks!
--
Jens Axboe
next prev parent reply other threads:[~2024-12-20 14:16 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-13 15:55 [PATCHSET v7 0/11] Uncached buffered IO Jens Axboe
2024-12-13 15:55 ` [PATCH 01/11] mm/filemap: change filemap_create_folio() to take a struct kiocb Jens Axboe
2024-12-20 10:51 ` Kirill A. Shutemov
2024-12-13 15:55 ` [PATCH 02/11] mm/filemap: use page_cache_sync_ra() to kick off read-ahead Jens Axboe
2024-12-20 10:56 ` Kirill A. Shutemov
2024-12-13 15:55 ` [PATCH 03/11] mm/readahead: add folio allocation helper Jens Axboe
2024-12-20 10:59 ` Kirill A. Shutemov
2024-12-13 15:55 ` [PATCH 04/11] mm: add PG_dropbehind folio flag Jens Axboe
2024-12-20 11:08 ` Kirill A. Shutemov
2024-12-20 14:38 ` Matthew Wilcox
2024-12-20 15:11 ` Kirill A. Shutemov
2024-12-20 15:45 ` Matthew Wilcox
2024-12-20 15:03 ` David Hildenbrand
2024-12-20 15:12 ` Kirill A. Shutemov
2024-12-20 15:20 ` David Hildenbrand
2024-12-13 15:55 ` [PATCH 05/11] mm/readahead: add readahead_control->dropbehind member Jens Axboe
2024-12-20 11:09 ` Kirill A. Shutemov
2024-12-13 15:55 ` [PATCH 06/11] mm/truncate: add folio_unmap_invalidate() helper Jens Axboe
2024-12-20 11:13 ` Kirill A. Shutemov
2024-12-20 14:16 ` Jens Axboe [this message]
2024-12-13 15:55 ` [PATCH 07/11] fs: add RWF_DONTCACHE iocb and FOP_DONTCACHE file_operations flag Jens Axboe
2024-12-13 15:55 ` [PATCH 08/11] mm/filemap: add read support for RWF_DONTCACHE Jens Axboe
2024-12-13 15:55 ` [PATCH 09/11] mm/filemap: drop streaming/uncached pages when writeback completes Jens Axboe
2024-12-13 15:55 ` [PATCH 10/11] mm/filemap: add filemap_fdatawrite_range_kick() helper Jens Axboe
2024-12-13 15:55 ` [PATCH 11/11] mm: call filemap_fdatawrite_range_kick() after IOCB_DONTCACHE issue Jens Axboe
2024-12-17 15:58 ` [PATCHSET v7 0/11] Uncached buffered IO Jens Axboe
2024-12-18 17:16 ` [PATCH] nfs: flag as supporting FOP_DONTCACHE Mike Snitzer
2024-12-19 16:54 ` Jens Axboe
2024-12-20 11:25 ` [PATCHSET v7 0/11] Uncached buffered IO Kirill A. Shutemov
2024-12-20 14:21 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d24ee33b-4207-4696-b878-5b2c4d47bec8@kernel.dk \
--to=axboe@kernel.dk \
--cc=bfoster@redhat.com \
--cc=clm@meta.com \
--cc=hannes@cmpxchg.org \
--cc=kirill@shutemov.name \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox