From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 689E2D0C5E6 for ; Fri, 25 Oct 2024 08:57:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EF4066B0083; Fri, 25 Oct 2024 04:57:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EA3C26B008A; Fri, 25 Oct 2024 04:57:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D6A946B008C; Fri, 25 Oct 2024 04:57:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id B3F696B0083 for ; Fri, 25 Oct 2024 04:57:07 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id DFF44AB979 for ; Fri, 25 Oct 2024 08:56:28 +0000 (UTC) X-FDA: 82711519296.27.BD632FC Received: from sipsolutions.net (s3.sipsolutions.net [168.119.38.16]) by imf04.hostedemail.com (Postfix) with ESMTP id AA7694000E for ; Fri, 25 Oct 2024 08:56:40 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=sipsolutions.net header.s=mail header.b=bDE16kXV; dmarc=pass (policy=none) header.from=sipsolutions.net; spf=pass (imf04.hostedemail.com: domain of johannes@sipsolutions.net designates 168.119.38.16 as permitted sender) smtp.mailfrom=johannes@sipsolutions.net ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729846455; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=qJSFjIpnl6Nk8kryfd+s56qg6w0ha2aCPbFyn5Yc4wY=; b=t7q+ZPVEW3Avak/wv3o1JehHbxvksO3d3c6Aet8mNUu/Dht3mAC8xrYsqJNIGtmOkEyeCD V6pJXcsEBQt05vBtnDJgvvsBDGdYBMVAFkJrI2pnmRH3Rg0P+p7fH9LPQV2MwVZKKl6xSH kK5Ctq1GVpvKirEhD4AL0nq0cPYMomI= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729846455; a=rsa-sha256; cv=none; b=GgUYyt4ROmGJq8tOh/lbYCibqhORkE3xPQ76tL8Kjws+coUedXXaOKk8TDNk64E4CXcACR BDlFe+TYBROrmMA157ZIxcS+gY6qeoEEeFqbdV1rWPOc1onA8K5e2VTBXPB+MsP4KXBS8u kxt7Q/WVF9wk5IdL1n5ijHNi2EQyoic= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=sipsolutions.net header.s=mail header.b=bDE16kXV; dmarc=pass (policy=none) header.from=sipsolutions.net; spf=pass (imf04.hostedemail.com: domain of johannes@sipsolutions.net designates 168.119.38.16 as permitted sender) smtp.mailfrom=johannes@sipsolutions.net DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sipsolutions.net; s=mail; h=MIME-Version:Content-Transfer-Encoding: Content-Type:References:In-Reply-To:Date:Cc:To:From:Subject:Message-ID:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-To: Resent-Cc:Resent-Message-ID; bh=qJSFjIpnl6Nk8kryfd+s56qg6w0ha2aCPbFyn5Yc4wY=; t=1729846625; x=1731056225; b=bDE16kXVBqbzydXcYINQi8qUVRX+ZoR7Kdmy9oox6FKpVjV bnTV7acdOwghCsu5vAmfi4xVblLB5iL9dcG1rzpEcezwSemh6Jzp6OEWpy+e6YOdI7hESWbk8sJ5s 67xJoz2ZJonooZoHINUAPVEdAeRKZtSNtJgpNS/Ynk8j1/o1rJDC7xGcRQm+M3ez9bKzMQ5J5iZEi KJojsaiTIzeXRw1XicjhQz7CNuKFUe08I3yFd2uq0bAOFMgeTUoR6UKsj++fgEmWwzFfr1LDIpYJh V692zM00G239kEh6qtzgY0o2fT+7APcVu+vxs060f4ES6LP1KyO9IjYagVKVTXPQ==; Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.98) (envelope-from ) id 1t4G7p-00000004RoO-0ixE; Fri, 25 Oct 2024 10:56:53 +0200 Message-ID: Subject: Re: [RFC PATCH 02/13] x86/um: nommu: elf loader for fdpic From: Johannes Berg To: Hajime Tazaki , linux-um@lists.infradead.org, jdike@addtoit.com, richard@nod.at, anton.ivanov@cambridgegreys.com Cc: ricarkol@google.com, Eric Biederman , Kees Cook , Alexander Viro , Christian Brauner , Jan Kara , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org Date: Fri, 25 Oct 2024 10:56:51 +0200 In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.52.4 (3.52.4-2.fc40) MIME-Version: 1.0 X-malware-bazaar: not-scanned X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: AA7694000E X-Stat-Signature: ue9jfzneicafofbqwxcoy5cf5xqyq7yp X-Rspam-User: X-HE-Tag: 1729846600-370303 X-HE-Meta: U2FsdGVkX1+oIzwGRp9ch2OjvDbV7QWqNdXL/czttwbGFFqkCyzHGx/Gajy8tBIjXl6CLF4IQLAqWiODlmb5McqnxCXVKTOJCD0WA4Mr5+04cn1RAwTRQXqvU95vCULyPtu/RXsfhVGjdRIA6NsW+iqt5mC/hf+uUlPEZAnD9hWONGnqQOjY8WS9s7Emgs1uZT/HnmYY7de6RF6vXkZJQ7cFRlcNpZ+kPl910rYm+kM7qjXS2d9Z8MljXyf70nzdwX0Ur/XuBuhDc7NpePE4uCfprKoHkxQn0pyDOCNg17VZDCIOT10aaYy7RaCRDLjb0eVScAVcaCJVd+GtvqfA9fvOQHo5hVnOadfJxaENKGpINy/zESiytiA9CngHxhJQsS4BJFXmAd0ZUKqa0CYDBWSNVP3WTWXBx3kfZTPryWVPU9l7rR05yXYs8rGd17jU+jGgyLEzBaIaBnwfb5kXJdRzHw/id5hSrI1o+05tClt7qH4KTpqq9m5OVibC9NCR9heHVURTrlkByG8MVRY7byUjRvy/8NHROFHDcXFbI7G4jDKZzuE3zcH90H6nvaCf9ICV0B7jr6e7R1kwwI3CsZczcTvrLvN/bTyUpQtf1PvXfOSdYX3uk3aGbYbDGOpIruhuE3XF2v9hTPIBtzHurAySvf1tRP3N6OUo48bNkXiNkyF7q74+Yk3vujFw/ATVkGap3KZuTZXc4+9AmM0ppGTWU86UgChNpTCY3DYhbkIIBkgnenog/+zti2LO5Q4UMCbWCGSJJdfQgAyWccxsASOcTn5OonveYG2WTqn/NETjq4Fvi/Se8kComOH7IKOyeTqG/p30Wn82HG51l1ersekPCPwQszt8yy+p1E7XwEdNTAIpHG3gzh9RwizATJLMV5JQ5j1RIGwB8k+/K1n6n2Vif39OlK99eEJNGJZC9coE5KwiDmccYAfzYsFIYeU2pd6bwT9I6ywDX9mbk9I mWEhzefE funwWl8YT/tBrXE5dalBSOypx+lDnM1A8AVuBBCt0OX3OkaH8zu4FkgBuwuqDs+q4KjCAwyzwbybeqgnm6dacoUR/3EPakQ/E4o06/DEXLJM/qWAQmw3t6bxayOWiQ9f8VpLzcUm/WIkuNhb55Bf8KHUzq7AXpvARrt9FL9HvZg+xqJePffh1FGa2EwRd0/4dVjNvh31QOMOfe6Ubf5iXIw2rEyeSZWzbdpVsZMUmDk4cSycpj/r8kb8ARg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 2024-10-24 at 21:09 +0900, Hajime Tazaki wrote: >=20 > +#ifndef CONFIG_MMU > +#include Not sure that makes so much sense in the middle of the file, no harm always having it? >=20 > +static inline const struct user_regset_view *task_user_regset_view( > + struct task_struct *task) What happened to indentation here ;-) static inline const ..... * task_user_regset_view(....) would be far easier to read. > +++ b/arch/x86/um/asm/module.h > @@ -2,23 +2,6 @@ > #ifndef __UM_MODULE_H > #define __UM_MODULE_H > =20 > -/* UML is simple */ > -struct mod_arch_specific > -{ > -}; > - > -#ifdef CONFIG_X86_32 > - > -#define Elf_Shdr Elf32_Shdr > -#define Elf_Sym Elf32_Sym > -#define Elf_Ehdr Elf32_Ehdr > - > -#else > - > -#define Elf_Shdr Elf64_Shdr > -#define Elf_Sym Elf64_Sym > -#define Elf_Ehdr Elf64_Ehdr > - > -#endif > +#include > =20 > #endif That seems like a worthwhile cleanup on its own, but you should be able to just remove the file entirely? johannes