From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2FF34C433E0 for ; Tue, 9 Feb 2021 09:19:41 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id BBBAC64EB9 for ; Tue, 9 Feb 2021 09:19:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BBBAC64EB9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 41C086B0005; Tue, 9 Feb 2021 04:19:40 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3CBBE6B006C; Tue, 9 Feb 2021 04:19:40 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2BC896B006E; Tue, 9 Feb 2021 04:19:40 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0231.hostedemail.com [216.40.44.231]) by kanga.kvack.org (Postfix) with ESMTP id 158DC6B0005 for ; Tue, 9 Feb 2021 04:19:40 -0500 (EST) Received: from smtpin08.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id D13A5BA0E for ; Tue, 9 Feb 2021 09:19:39 +0000 (UTC) X-FDA: 77798181678.08.41086C2 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by imf05.hostedemail.com (Postfix) with ESMTP id 06399E0001AA for ; Tue, 9 Feb 2021 09:19:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1612862378; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=BFjv4UtzY9Kq1FYF0dpb6VHrc3ljOiW5dWjb2Re6blw=; b=PLFNavfW+GMNCji0tDjhaHVOAEB6Y3Jva66Pfj6+4RY6xZwkhoy81zxKt2wKk2frYiSj7X Vyot/NPXBD7jNcILq1LccuXve74FuichFDWizbyUgKjHKFmj3ic1kYnMRCL6Pfoi6C5Yvl xesyNUrHw7DyJqFTel4ciuKLn7er0/w= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-233-WVYNpRFENHiHcAYPh3-EKw-1; Tue, 09 Feb 2021 04:19:37 -0500 X-MC-Unique: WVYNpRFENHiHcAYPh3-EKw-1 Received: by mail-wr1-f72.google.com with SMTP id o17so16385408wrv.4 for ; Tue, 09 Feb 2021 01:19:36 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=BFjv4UtzY9Kq1FYF0dpb6VHrc3ljOiW5dWjb2Re6blw=; b=sPUPxq0Die+8vqhQngZQrKAGZaKd1S8hugKpw7fbgMk7J1fRmMZo2fvrIvdwe/9a2o KL2ntUmJwQ0W8i2x32Es1k2uvPEZZIuyfp+Jfpro4bgXIAA9erVpmCD4N+unkoAB+QJl /q7p/xKzPJ1YzXlgkb42bDNH6SOWY0g7iN8OWR/Z6dtjuoSfVE+GlyP/W713KLCdcSXz IIhNYGHEh2tbx4eeoriXaP2OC1yYg6tQM2/Vo9SZd2hGm3gl5TrgQas7oj4CwlZIne5H nphexCKHKXVqh1c3zvPo+9UMEt/DnaFN+epEnd2bqZgFChqF4kdoXy9I+DbbBpL33ARD jq+g== X-Gm-Message-State: AOAM530d4PHH+R+FZzKMQInDx6wwkIPVRWn9WjhGK8tUzHOjysO57yt8 124KH/hoOaKVY0cR9eV6OxPpoIhzpD/A/PpZMsLdavB3FOpHOgM7A2L6+UWMxPK080ORWWeOh3Q SWV85HgCf6S8= X-Received: by 2002:a1c:7905:: with SMTP id l5mr2532090wme.171.1612862375927; Tue, 09 Feb 2021 01:19:35 -0800 (PST) X-Google-Smtp-Source: ABdhPJylyGxN6rAcQNsffz+2zGcPZnteVoUtmo8yoEcEep7Stu6LpFbD+RJDHfXVYYs7gR1qW5cazQ== X-Received: by 2002:a1c:7905:: with SMTP id l5mr2532068wme.171.1612862375679; Tue, 09 Feb 2021 01:19:35 -0800 (PST) Received: from ?IPv6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.gmail.com with ESMTPSA id u142sm3652118wmu.3.2021.02.09.01.19.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 09 Feb 2021 01:19:34 -0800 (PST) Subject: Re: [PATCH 1/2] mm: provide a sane PTE walking API for modules To: Christoph Hellwig Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, jgg@ziepe.ca, linux-mm@kvack.org, Andrew Morton , dan.j.williams@intel.com, Daniel Vetter References: <20210205103259.42866-1-pbonzini@redhat.com> <20210205103259.42866-2-pbonzini@redhat.com> <20210208173936.GA1496438@infradead.org> <3b10057c-e117-89fa-1bd4-23fb5a4efb5f@redhat.com> <20210209081408.GA1703597@infradead.org> From: Paolo Bonzini Message-ID: Date: Tue, 9 Feb 2021 10:19:33 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20210209081408.GA1703597@infradead.org> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=pbonzini@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Stat-Signature: tdxmp8zz1n5hcsuy6864dytgugd86ypf X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 06399E0001AA Received-SPF: none (redhat.com>: No applicable sender policy available) receiver=imf05; identity=mailfrom; envelope-from=""; helo=us-smtp-delivery-124.mimecast.com; client-ip=216.205.24.124 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1612862377-682345 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 09/02/21 09:14, Christoph Hellwig wrote: > On Mon, Feb 08, 2021 at 07:18:56PM +0100, Paolo Bonzini wrote: >> Fair enough. I would expect that pretty much everyone using follow_pfn will >> at least want to switch to this one (as it's less bad and not impossible to >> use correctly), but I'll squash this in: > > > Daniel looked into them, so he may correct me, but the other follow_pfn > users and their destiny are: > > - SGX, which is not modular and I think I just saw a patch to kill them > - v4l videobuf and frame vector: I think those are going away > entirely as they implement a rather broken pre-dmabuf P2P scheme > - vfio: should use MMU notifiers eventually Yes, I'm thinking mostly of vfio, which could use follow_pte as a short-term fix for just the missing permission check. There's also s390 PCI, which is also not modular. Paolo > Daniel, what happened to your follow_pfn series?