From: Dan Magenheimer <dan.magenheimer@oracle.com>
To: Konrad Wilk <konrad.wilk@oracle.com>
Cc: gregkh@suse.de, Chris Mason <chris.mason@oracle.com>,
akpm@linux-foundation.org, torvalds@linux-foundation.org,
matthew@wil.cx, linux-kernel@vger.kernel.org, linux-mm@kvack.org,
ngupta@vflare.org, jeremy@goop.org,
Kurt Hackel <kurt.hackel@oracle.com>,
npiggin@kernel.dk, riel@redhat.com, mel@csn.ul.ie,
minchan.kim@gmail.com, kosaki.motohiro@jp.fujitsu.com,
sfr@canb.auug.org.au, wfg@mail.ustc.edu.cn, tytso@mit.edu,
viro@ZenIV.linux.org.uk, hughd@google.com, hannes@cmpxchg.org
Subject: RE: [PATCH V1 1/3] drivers/staging: kztmem: in-kernel tmem code
Date: Wed, 9 Feb 2011 08:55:50 -0800 (PST) [thread overview]
Message-ID: <d21f1970-225e-4f5a-9e72-97991bd1a2c0@default> (raw)
In-Reply-To: <20110207160253.GA18151@dumpdata.com>
> From: Konrad Rzeszutek Wilk
> Subject: Re: [PATCH V1 1/3] drivers/staging: kztmem: in-kernel tmem
> code
>
> On Tue, Jan 18, 2011 at 09:19:50AM -0800, Dan Magenheimer wrote:
> > [PATCH V1 1/3] drivers/staging: kztmem: in-kernel tmem code
>
> Hey Dan,
>
> I never finished this review, but sending my fragmented comments
> in case the one you posted has overlap.
Thanks Konrad for the thorough review! I'll fix the nits at the
next version of zcache but will assume (unless you feel otherwise)
that none of these is a showstopper for zcache to be accepted as
a staging driver.
To answer your one question:
> persistent and ephemeral pages can both be in PAM space?
Yes, persistent vs ephemeral is an attribute of the
"struct tmem_pool" and a pointer to the pool is passed
to all PAM callbacks.
Thanks,
Dan
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2011-02-09 16:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-18 17:19 Dan Magenheimer
2011-02-07 16:02 ` Konrad Rzeszutek Wilk
2011-02-09 16:55 ` Dan Magenheimer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d21f1970-225e-4f5a-9e72-97991bd1a2c0@default \
--to=dan.magenheimer@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=chris.mason@oracle.com \
--cc=gregkh@suse.de \
--cc=hannes@cmpxchg.org \
--cc=hughd@google.com \
--cc=jeremy@goop.org \
--cc=konrad.wilk@oracle.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=kurt.hackel@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=matthew@wil.cx \
--cc=mel@csn.ul.ie \
--cc=minchan.kim@gmail.com \
--cc=ngupta@vflare.org \
--cc=npiggin@kernel.dk \
--cc=riel@redhat.com \
--cc=sfr@canb.auug.org.au \
--cc=torvalds@linux-foundation.org \
--cc=tytso@mit.edu \
--cc=viro@ZenIV.linux.org.uk \
--cc=wfg@mail.ustc.edu.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox