From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83FE0CA0FE6 for ; Fri, 1 Sep 2023 08:15:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 07BE88D0021; Fri, 1 Sep 2023 04:15:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 02B698D0002; Fri, 1 Sep 2023 04:15:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E5CC88D0021; Fri, 1 Sep 2023 04:15:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id D4AD88D0002 for ; Fri, 1 Sep 2023 04:15:10 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 9146B12018E for ; Fri, 1 Sep 2023 08:15:10 +0000 (UTC) X-FDA: 81187318380.06.5451524 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf04.hostedemail.com (Postfix) with ESMTP id B18984000D for ; Fri, 1 Sep 2023 08:15:08 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf04.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1693556108; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VJCX7ojm7e1UQAugHWq7BFbUkgRooN6Ld3kSzmq4S1s=; b=erh3ZnD2DKXSQVoC30c/8HdSv6+3T+ndCxHbGWHHs6C7Bprs3lU7RGRSq1O70ANpNrm46T xJ6JIEU+XS/Hp0pbstN62yXSXntZnqMmBRWcA+Z9QaNJ7NnIQM/+Pggk99RjSS/jdlYXn8 3PaI/fDahe+j2uKhpXvUE4+iocaktIo= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf04.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1693556108; a=rsa-sha256; cv=none; b=WmEcK6R2qqgFXL0su5XTmaH2r5qHS3aUInHN3WaBKZEPWx4XiSZb94SsE3wE24/zzbFCq6 nWj17utt18Rzsy0dRaPcEc4fn+01phclaZ2jh3yJqjAohATY+UUw8Gnf5mk4X/uJb7XQGK ZbVqEuv+Jh+Mbc0SORyT65K3vzxunkQ= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 74036FEC; Fri, 1 Sep 2023 01:15:46 -0700 (PDT) Received: from [10.57.65.16] (unknown [10.57.65.16]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 2EFBC3FBB1; Fri, 1 Sep 2023 01:15:07 -0700 (PDT) Message-ID: Date: Fri, 1 Sep 2023 09:15:06 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH 02/14] mm: Convert free_unref_page_list() to use folios Content-Language: en-GB To: Matthew Wilcox Cc: linux-mm@kvack.org References: <20230825135918.4164671-1-willy@infradead.org> <20230825135918.4164671-3-willy@infradead.org> <035c50f0-5bbf-4e57-bef1-aa4b55c7cfd7@arm.com> From: Ryan Roberts In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: B18984000D X-Stat-Signature: rno8fz19usdneq5ykz1fks9fdxjxeqzy X-Rspam-User: X-HE-Tag: 1693556108-905589 X-HE-Meta: U2FsdGVkX1+U+K+NjD/IAINk53+oHOCIZmbqJL0QwZjgihjSHdjTZxDCuZy1hgVFGfqLQkLgvEwaoK4AfZ3rfakW6NOJ3tmS9U/JBjZAlve59jKB+jGgfQqbm3cTb6iZZmzJ7JpsaYTdRwqnlJdelwkpFKsPeiLahu6VFuq96JOOeUwabQth19gx1aGWvJYWsJ5StgDKR/8jKpV1QrksRAtitpLd3C0pi/VfiSAQsN6mWYewR4G6sJyPgLFar+Ns+57r1cO6BBf09zwDtLHcP2aC+KK31WH8GIInL399bmCFVOWmaS5O72MJXxVFFGbr4HzlSen9AtvVSTOmF6gI2mikEZxMVWsXvJ3XIoghNkV+vsEZlApkWNCK/w22IReWkw467J25KoGUj2M7NlHETOY+1yCHpLP4DbUk+gOrth4u0WEBeFk/+PTO1MZhBNzvm451B95FxnnCvD4HTXBBH9kTE0YlasdFVBzVmbgZ3axZp1rYD5hZVWD1OkdS8Yn4M8sz/Jl8owX7XIGZtBoAwFJC8C2dUO9AMh3U//5X/8xw++Kw8ZVcAHOpJD6nl6AmwqbKMuIyvMl+S29JCXeuOr1RtY5MafGJjkVSMDiik5r2QOk30yUQtcQDwTKxvoFuwLT5zGwkq6LAZvDN6MZXSqmrgq+AENypYNBsX0+2A45Q5JQsOZGMBRTcuqfdf7RXsE95R4AFSaKmw5TP5nLCfSZy2Q4OF8rHYvPY9jflBRkbLNMozcoqvvJ+ie3/c67XseKzCuRnRl0js9KO6EbmXk2D+xi1z+5lomqKxPpUtqVVhMTGvNvGjeuQ/a2JcrObagwdc5suWt+/45amUcmh68yjg13DniocyeYDB5SZwfaiUeAyoI+YLrRoWnUbW2L5OFeuve15IGxd2tcFCkEV7w25+v3ZWHIA47wMe5G0+4VGVVf6NHi7DkVkgVtgespjjTtWGel51ALM5d64Xmc TakTTJ/S iVIKenrtHn3xawRa+yTPMhIj9FmDZHWoZ5ltjtsBbwL9+hfEQbfqH5kbixnepVhZ8j/NVfqDXfZTCXXF4iSoMKfmbaSg/xgECZsHzwU+j9qxeiMa5EQ1LkE+I8fXnD6Tt3QKNdskbQxZjqcs4ICzR/UUCnAegwqEy1mJMvtpwdAhzxgP31ImuxgMC6NQLn73peJP0 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 01/09/2023 05:03, Matthew Wilcox wrote: > On Thu, Aug 31, 2023 at 03:29:59PM +0100, Ryan Roberts wrote: >> On 25/08/2023 14:59, Matthew Wilcox (Oracle) wrote: >>> Most of its callees are not yet ready to accept a folio, but we know >>> all of the pages passed in are actually folios because they're linked >>> through ->lru. >>> @@ -2469,17 +2469,17 @@ void free_unref_page(struct page *page, unsigned int order) >>> void free_unref_page_list(struct list_head *list) >> >> Given the function has *page* in the title and this conversion to folios >> internally doesn't actually change any behaviour, I don't personally see a lot >> of value in doing this conversion. But if the aim is that everything eventually >> becomes a folio, then fair enough. > > It makes the next patch _way_ more obvious ;-) If you merge the two > patches together, almost every line changes. Yep, agreed now that I have the context of the whole series!