From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA76BE77188 for ; Fri, 20 Dec 2024 18:54:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4DA736B008C; Fri, 20 Dec 2024 13:54:14 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 489036B0092; Fri, 20 Dec 2024 13:54:14 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2DBBD6B0093; Fri, 20 Dec 2024 13:54:14 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 10E9A6B008C for ; Fri, 20 Dec 2024 13:54:14 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id B6BE41C7CF1 for ; Fri, 20 Dec 2024 18:54:13 +0000 (UTC) X-FDA: 82916236494.23.61C20BD Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf01.hostedemail.com (Postfix) with ESMTP id D0C6B40019 for ; Fri, 20 Dec 2024 18:53:44 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=UZu6Dh+c; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf01.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1734720819; a=rsa-sha256; cv=none; b=5rMbUF3iutTXQhu4TTXTN1B3Oyc4wuviuFB4dzvU2umIN0J9QssilUPX1te+rqi/xcFftz FXrEg20btHnBLEvrgKK0LrZcFhM03xDOd8PeA66/1FJS8nEH7fPe853IepYBfClrKvBPgs 6P9iF+pxG0EU/mgfy5FXYGVzOB6pDFs= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=UZu6Dh+c; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf01.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1734720819; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=dwul1B0ZjRX8XHXiw9S5GpTdynHuc37dTo3qyY+Q/Ok=; b=l5BJbUR5HTQkSuCNSrzSfJ+PRriFd/+57bkeVRdFJQ0tG/wgVrWV/OCp4K15zjkP74/aHr +pd2XcbCFoR9+Z4l78FBv3WnRiS+1VrYrX2tK0F480pnE4Hr2v7akyzuWwW6bJL2RUzy5S lKHEpKwkdYlk8H7Jlx6YNh4nlo9YD/s= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1734720850; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=dwul1B0ZjRX8XHXiw9S5GpTdynHuc37dTo3qyY+Q/Ok=; b=UZu6Dh+cGF/1BWrwEpEV/tSDGoUvMHHbn/RFIeZD7TfLjeLTtM4F9uNQIF6sioSC1q5uBC JMh6jnU+kv8PcVNUx9gfju0+PiSJTCaxYuCZnl2smff9EueFwqtadL9k9mbwCXz7uq/YHs XXN/XOGY6FCpTnOE6FipgEYkc7UgnZM= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-264-BKo_9Ep9OLKAdn3bIg3EUA-1; Fri, 20 Dec 2024 13:54:09 -0500 X-MC-Unique: BKo_9Ep9OLKAdn3bIg3EUA-1 X-Mimecast-MFC-AGG-ID: BKo_9Ep9OLKAdn3bIg3EUA Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-4361fc2b2d6so12936145e9.3 for ; Fri, 20 Dec 2024 10:54:08 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734720848; x=1735325648; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=dwul1B0ZjRX8XHXiw9S5GpTdynHuc37dTo3qyY+Q/Ok=; b=Wv7mIioEcoqiI4nSLFkKwKu80KN/TQJaRDRSMOku0zOtxAtlLYr4SXmWd+bLFgsyCj dVhhJ+nGmr3BVu1ObqHeCBC5bUSVviqg/rkdIqucUyYpDOX2XINl+pfhY5SgPGyNd/mw mZ9TN1YwIi1hPUz0qHMLsFt+SHuzOKql15matecmeVAJUvoVNqc1N23sHuLLojy7WgmW uUDm70Tq+a7jBD9oWWELesKMwRYJAgFCS1iQWE0oXBlK25mEVOfpchn9Jr7S+4gNlEOT NHm13E57Fg5SJtcAZYYLtYwbXjNoWAZFca0W8rbv+yPojcbxwpEYgdsFJwvn/ifkNF/X gMEg== X-Forwarded-Encrypted: i=1; AJvYcCXV9pjXMm22LNvVQKi6QwZ5dxgHpNzX6SeWGmMNqLosryzeKD4N1832wbPt1wq2Y/jHIYZadFBgdw==@kvack.org X-Gm-Message-State: AOJu0Yy5q2/QyDjeXGdFrHY3kgqRG6WUd73PXacmLiTAGebtzrrer73j 26SmADr2Sfyn+tsgQq6hi+uUWujoZD/Z8pcRV2OLACHOT306CydlkYMpjXYJj/29OC8eH/9G9vA GTJDNt6zRu8sxpjPrfMFVG04254vm5dGfeh2cApasnuIKOjoF X-Gm-Gg: ASbGncvsgld9TkhRWZM8cPz1nAkO7VmHb0MYEf3QmUbWAkgUMmYPSW40eiFzcRa5qZP f0Tc4/i2fX4wSB/UKAQ3s1yazLvKH1svwM4Ucg4VNYA9KuhSmncUVpduhrA2OhvnTMNh7bxq84t XpJF9J+nkUkrRbeUsqtQN7Q3fwFnWbYHRmdrddAAbMJnCoNwLmDzzLspqOFR2hV6djw45ONkTxX n1hax6BCMe0ZJRqLl2c/efmH+Io9BT478NXg4ZO/4+EqMzGTDE0gN1bhx2LX/T9960Ddb2e83Fr 6g4RAg4qzmeBA5ploNs65ecXtV0IPwuzC7zbMGneHqeyh5ybOeIUoCCNLV5rqRTPqgNKSAMICU+ Lu7v3eow6 X-Received: by 2002:a05:600c:468f:b0:434:f335:855 with SMTP id 5b1f17b1804b1-43668b78324mr30167685e9.28.1734720847738; Fri, 20 Dec 2024 10:54:07 -0800 (PST) X-Google-Smtp-Source: AGHT+IE+mu6LGdXIB0NGv4yM1Fr/+Tla9eI5H7TAKe928/ZkOL89O5OYg43H9k6wobb3o6UoxzSHnA== X-Received: by 2002:a05:600c:468f:b0:434:f335:855 with SMTP id 5b1f17b1804b1-43668b78324mr30167405e9.28.1734720847387; Fri, 20 Dec 2024 10:54:07 -0800 (PST) Received: from ?IPV6:2003:cb:c708:9d00:edd9:835b:4bfb:2ce3? (p200300cbc7089d00edd9835b4bfb2ce3.dip0.t-ipconnect.de. [2003:cb:c708:9d00:edd9:835b:4bfb:2ce3]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38a1c89e2d2sm4757808f8f.71.2024.12.20.10.54.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 20 Dec 2024 10:54:06 -0800 (PST) Message-ID: Date: Fri, 20 Dec 2024 19:54:03 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 16/25] huge_memory: Add vmf_insert_folio_pmd() To: Alistair Popple , akpm@linux-foundation.org, dan.j.williams@intel.com, linux-mm@kvack.org Cc: lina@asahilina.net, zhang.lyra@gmail.com, gerald.schaefer@linux.ibm.com, vishal.l.verma@intel.com, dave.jiang@intel.com, logang@deltatee.com, bhelgaas@google.com, jack@suse.cz, jgg@ziepe.ca, catalin.marinas@arm.com, will@kernel.org, mpe@ellerman.id.au, npiggin@gmail.com, dave.hansen@linux.intel.com, ira.weiny@intel.com, willy@infradead.org, djwong@kernel.org, tytso@mit.edu, linmiaohe@huawei.com, peterx@redhat.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, nvdimm@lists.linux.dev, linux-cxl@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, jhubbard@nvidia.com, hch@lst.de, david@fromorbit.com References: From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: NxZLScoVLa0GrHC6_EbH1AMrUvGRr9aMzbDifGwEXB0_1734720848 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: D0C6B40019 X-Stat-Signature: d4jo7r4yy3a8pxstc9topc1s65k3pcbu X-Rspam-User: X-HE-Tag: 1734720824-788652 X-HE-Meta: U2FsdGVkX1+Qpjhaox5p17WFrGOhweGbeMAOBfnv/SjkiyOfnSYn0eA6doW64P75HVwu+v4t81x7SduVCaX2mr/eXAcJMAxcR2VHfeH79l1tv9agNHGfzjF0nwNDA//OA7ME1WBP5jlPSQ8FMq7e4uPhrjKbrlYblOFUOLESBpvynj7SAcDHNO6GZxhpN/x0BhZiRgHnfIQBNlx9f6Bx2gHMkqWH12N9INZwMqtlALvhsCqJp5o5EhIW4E4KgtU8wWOShvg1X0+B6zh4hhglidFxji1L1UX5JQH5Ktkmd404qftypTBJ8uozY7+T2SrQZs0cVe52PMzk7qcXvC0WVzH0EtC0VePxnhsYJXZckkEC5eoUi8ms09AjMC0ynTwPXBJw7itSPbtVTGijTLc5eZFkHajMRGHRSjr54Dl4x/+trnhzFUtGJQU96/OE5wygBkXMCQD5/wR4cPQxHMgHyexeJ4YwzyN5tYdn+FFHn4xwpe2LUkzOl0KU0qfz3XgUhMVmOY45m1bA7zoJA6aDA55cx+jNMOnHtDMVoyIsxh+LZJfXJLtkFpJdx7lkWUxwNKDBI98r0R8zFLPdo+GK5iOMubj4Ghyg/ycO36L08wLa8bS4+dZg7QXcbTcS2/xv7wuVrqCdw+H2tkfLEl8w+/agU+ntwRC3eJ+SG5rkqlMJNdM/WLOOlgHyNlkTBsTJBLm6Fx7Lqk5qdhc4QxVIHsFdG7JDQGq/GX0CVwa1dL1cm3L+gNtGqufgQ7K79SDYCwzFTBXMvvgJfVFOcIY6k1pP/vJ4gavbedq5p691oXN66q7h9Nak+B1CkOPaXTo5LBgXiw9w4L/EcyW83pYpgucO/i0KO6d8LxwGNwwQlnsJOLM56ELVyBfe0EmbghsqOpd3/U1K2IoW6qXqD1s/cfneiPOmR1lzccbXPEG1rTDR7szdCzO4M4NRMOqVJ2Tvm7trF7UexFktJbb6s44 ul5uj1nG CCgW4m+6ZZKp64OykGDJBI04XRh6dqn+9Gn2mXBj5Rwxkgop3Egx83nf65dfTJT5o4gUQdUsTWqjHsstStFbK/pPsQr8DU+VyTGcTM6I9UOXoUmqoN0uON09nIqYOlIhBse8z3m/LwwOIN4BN+2GktdrGL/5enFFWj64D/71gfB1lq/EF9D1rxFTbkWRLbIE7WMSnCJjSl62YtiRrv6Yo5pfGSXVozk7krN2khBp3FGaApHVwXmUxFA6hW7+oWW+L6v1MWs2f4eAWeC0ly3MTVToOIk7DIo0/JThfD+dt45iRGAo19wzLv13eA18ZZeh3U3Ra0jlmzHRQxqZSFJYjuRkq8e9J5Spc2lOvSK8ybkfEDMR5sW26POXVM0AQXKWqE7XZawS4qLn9kSs6BkjXWZhia2oJEdDeexyyzD8e7A2UbAkiCL4YH4sTWgETP6sF8Rkqk9nrsCCQDyyKdcZYe8KakAvn8v4+mGPhKWlYkcdwZj+/KSZa4dIohd7fIfhe3QD5HRb493QLRsA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.020923, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > +vm_fault_t vmf_insert_folio_pmd(struct vm_fault *vmf, struct folio *folio, bool write) > +{ > + struct vm_area_struct *vma = vmf->vma; > + unsigned long addr = vmf->address & PMD_MASK; > + pfn_t pfn = pfn_to_pfn_t(folio_pfn(folio)); > + struct mm_struct *mm = vma->vm_mm; > + spinlock_t *ptl; > + pgtable_t pgtable = NULL; > + struct page *page; > + > + if (addr < vma->vm_start || addr >= vma->vm_end) > + return VM_FAULT_SIGBUS; > + > + if (WARN_ON_ONCE(folio_order(folio) != PMD_ORDER)) > + return VM_FAULT_SIGBUS; > + > + if (arch_needs_pgtable_deposit()) { > + pgtable = pte_alloc_one(vma->vm_mm); > + if (!pgtable) > + return VM_FAULT_OOM; > + } > + > + track_pfn_insert(vma, &vma->vm_page_prot, pfn); > + > + ptl = pmd_lock(mm, vmf->pmd); > + if (pmd_none(*vmf->pmd)) { > + page = pfn_t_to_page(pfn); > + folio = page_folio(page); > + folio_get(folio); > + folio_add_file_rmap_pmd(folio, page, vma); > + add_mm_counter(mm, mm_counter_file(folio), HPAGE_PMD_NR); > + } Same comments as for the PUD variant, apart from that nothing jumped at me. -- Cheers, David / dhildenb