From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E00FEB64DE for ; Tue, 10 Sep 2024 12:17:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C25918D005F; Tue, 10 Sep 2024 08:17:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BD4D28D0056; Tue, 10 Sep 2024 08:17:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A9BE68D005F; Tue, 10 Sep 2024 08:17:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 8EF378D0056 for ; Tue, 10 Sep 2024 08:17:31 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 484D0401B0 for ; Tue, 10 Sep 2024 12:17:31 +0000 (UTC) X-FDA: 82548729102.18.EDAEC17 Received: from mail-ed1-f52.google.com (mail-ed1-f52.google.com [209.85.208.52]) by imf13.hostedemail.com (Postfix) with ESMTP id 42C202000D for ; Tue, 10 Sep 2024 12:17:29 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="khpG/q4X"; spf=pass (imf13.hostedemail.com: domain of asml.silence@gmail.com designates 209.85.208.52 as permitted sender) smtp.mailfrom=asml.silence@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725970512; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=B5DPIEmhfcFK/wmXZkZn8+119vQ+vEDZcvMKdE6RVNc=; b=wFI5ptAj+UnE+MSNjUVvmqxL88c5+HZkg9a/N5tnDM5t4Gwi9E/HADzCiWsKGs28XkYXIl h1NgnGFkjDq8XahNyDEtmgVuLbIr7pP57m0ZozGNqrmPvy5KPk/FdIOtMS0+yMuIZ2JMHZ mM4mVQvBeoVOockcvEL3/Boj9v+IW1U= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="khpG/q4X"; spf=pass (imf13.hostedemail.com: domain of asml.silence@gmail.com designates 209.85.208.52 as permitted sender) smtp.mailfrom=asml.silence@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725970512; a=rsa-sha256; cv=none; b=4ADAy0XNJgVYJHY6vMkIfC4XaI8cnQjdQJ+4gq7ykKqIeqZ2nahqv8lvKMjNSK056LYA1w Zy/v7avXq/yeowOTm9/iwfgt/xuGlXIGkrUEwNTmVvyRvaNNfr5wwdb/EVNMORvkALX9dk VaLc3KmY4nZEv6DetAkxv203CyrZNBo= Received: by mail-ed1-f52.google.com with SMTP id 4fb4d7f45d1cf-5c25554ec1eso7151149a12.1 for ; Tue, 10 Sep 2024 05:17:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1725970648; x=1726575448; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=B5DPIEmhfcFK/wmXZkZn8+119vQ+vEDZcvMKdE6RVNc=; b=khpG/q4Xmts/nQbOzwE9pXtMrg1VToPt+NR3OjhdocYz0+BblzGGzjflkPmqt74oxF zsTkycdwj/rVFi9VydDTVxPsHeNZh/PX/gDpYpgCd8GR+io7f9im61Xc92SmWE4pllum e+fl9HBkrNAd9YqHt9y9Y2fsZ7xkMfMUyBx2RfsFD/k9VAlDPZXvnFKp0FBk0RqeLWvV ybM52myC/RvRFTT5laPgyz1sauo2ANczEEPECWKniVuKfzYRD75jvMbjhkbDp+M2xDlY BZ3cgJXKwpimMzBitDYK/HxgtuhFihE+1Tm/VnHce1E4QL5RVNct+JAwCFRRGBhtnUWh 8K8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725970648; x=1726575448; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=B5DPIEmhfcFK/wmXZkZn8+119vQ+vEDZcvMKdE6RVNc=; b=FKxvEY1EDuHeWQz7zr3av0FuJJPMgoRnz15K7A8X2ALS3+h2Pd6ouLTSGOzfXr+0La sPN3ygSSaOG8UIji2PFoFlkLu/YvRLRqUWZLhJh6BRh4Zm3LzLUl3tmNI5oua5b4io3X zxdPsAILvZEc4/mYZrEbrKECcxAdB/Tancv+dumAn2lVttiBzpvEukOyqryCSIOgdtMS tHWNFeLyZyS1Piztb39GBaKG0NgVPqwQp0/x3T/GiWghQg5Pi2hcRpTz92GZ0iUCwpkJ 3kdQ/0WGeW7PASK1PK1exFskJT078zmyesJn3hUXfKaM6ZKzlcFp70Enk4i4YW2597VC GuTg== X-Forwarded-Encrypted: i=1; AJvYcCWkF3oNi4JV+eJrLIClxb4em28xC7cq2DvObQO2lJaAd2o3VfIZKpU7wxBoVSod/HO9fEa6Md+6Lg==@kvack.org X-Gm-Message-State: AOJu0YzVMRGo7ajeIgD7oBigFXzZvB9Ck7ZAgg7XemGL79p4xaoosFue GgooqUYWgEXHHiK0NcDfFRqp7dudjr/gBeuMZ6bVHrCkWu2R/e2r X-Google-Smtp-Source: AGHT+IGHgFXvFqhW46dxw/Rl6tc8g6NF17PuqJzB9Ts9iesmgZYFqjPLcEVz/kCVwFwT2vrIUj1Yrg== X-Received: by 2002:a05:6402:4015:b0:5c3:d251:e4ad with SMTP id 4fb4d7f45d1cf-5c3e963695dmr11804171a12.22.1725970646719; Tue, 10 Sep 2024 05:17:26 -0700 (PDT) Received: from [192.168.42.252] ([163.114.131.193]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5c3ebd8c4d4sm4175886a12.82.2024.09.10.05.17.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 10 Sep 2024 05:17:26 -0700 (PDT) Message-ID: Date: Tue, 10 Sep 2024 13:17:48 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 8/8] block: implement async write zero pages command To: Christoph Hellwig Cc: io-uring@vger.kernel.org, Jens Axboe , Conrad Meyer , linux-block@vger.kernel.org, linux-mm@kvack.org References: Content-Language: en-US From: Pavel Begunkov In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 42C202000D X-Stat-Signature: c55ffj71tamdhsgisdwkxydmh7jc6q4n X-Rspam-User: X-HE-Tag: 1725970649-435969 X-HE-Meta: U2FsdGVkX18BNiT51DY5mQyXsPk/6CGFOdU9q5J0sFeNtLh9eu/MzNU3/U1V5+Wu+/E3MbBNI4wcpkDNmFQl27Kl2P4sgBch/QoN9kNPZLTPaKng5gorEBLysu8uMmWN3J9IHEUsFLzPuiBe8W+m5ghkWSFz349FqmCBCGyS9slQnNSthahZEq4xBRVLxQGZy+S6xLeje+/4PNjSd51Vb/kthiz3bkEdyzdtNpXvXAm5JTV7tZ6jFe+1v2iU9Kyp8/lYvmbYN4FhjBm+9P/uWAqIUZX/6v3+il9M15lVMjaham0sfOuFKmmLfH5N2PyOxqy5gx9ePlfSkXMG1Rt16xLW9BofveSY7GnsEeKne8LuaKxPY2DXsF1VgxtU9+qw4wI7kuA9az5ts6dqvnHSETxPE3wsnwGNBArXk4S2j7qq6fh4QTpG7rp9K+3T5HnAMp53n+wh+s2eiGbfoblpaKlWRTz2NmP87Hev1t9Vhg6QL8GacLAwQh8Hre9OllrAZD4u17oDKPyiElUheVvfqQArtmIMT0JXMcico0HhAqfKnB+UZaJc4MX76ExTrCaieaQsaXj1DFcoNe9ds0Xp13lu6mxaF3PaZ4wI8MnsiYMmyvTyL2Ojcj2N5Hgz3QFigmK1OqJonrhd62HjH2Zn9l9w1rP0wpOyqhEuGmqXwKZ3n9jobbilIYSiMD5rUeWVvNe/kTeeHAzbtNQdoptaoxBZyH6iJU+9CXMgKBGqjJqojubaLyhMe/5q3Zr8F8Zq4huzV5XavqaJPz+ItqiB0JclbsD2sYGnMOzO//80gEIvcuR7iryub6KDureeY58ABqALDmTlnqOMs2IWu44crvvCS2h61V8bXffOUABEj54Jk7iyfhZD6IirxBKIF3Qy1FBeRVVC9QK+PBgaxoxLAl7ZBJjHfj+/i6V6SwgGFadKPLVyoD5IUiD2OqjCLYaNNFUq5nlhhNEhCpu+63F RvFeD1xT EPAMAi1lRHbVBxMq2aOkIDX+kgfufFYwTPY5MzNoCTNqMnT7l9+wdeFaIxilhhGF5Qz//WDEPT8St/qS0YhH7tlaXrTweWGJrv1O2tBd0uMZNR+Mv/AVjRbHETT3Oqw3/znnN7HsJ1OieCcuoWEqmgSfQYlD6R0opUceK6mJs5v35ZYtj5aYabh4xudjcOvjXZoliyaUhRnyqzfEYI0CQTydVo6syL7VBEWxlgSvJgetWeL8YXF82sgI3h3KDp3L6702ZCavuN5JM5jCfctBV3p9hNhudU4H/udZ7hbMwAFZa1uVX9ze49idgWO2V0JV87qPO6kckGsvKhuEHDr+BC9Ax+ZIlIix+qCo3kSHXf8d4oPfHtr8XTutFKuom0LNZX0U5EpnMrGQNe1VjS7bd60uz2dYltjZ9NlZj2VpgPRHzSrCWSdH0k9uz0A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.002193, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 9/10/24 09:02, Christoph Hellwig wrote: > On Fri, Sep 06, 2024 at 11:57:25PM +0100, Pavel Begunkov wrote: >> Add a command that writes the zero page to the drive. Apart from passing >> the zero page instead of actual data it uses the normal write path and >> doesn't do any further acceleration, nor it requires any special >> hardware support. The indended use is to have a fallback when >> BLOCK_URING_CMD_WRITE_ZEROES is not supported. > > That's just a horrible API. The user should not have to care if the > kernel is using different kinds of implementations. It's rather not a good api when instead of issuing a presumably low overhead fast command the user expects sending a good bunch of actual writes with different performance characteristics. In my experience, such fallbacks cause more pain when a more explicit approach is possible. And let me note that it's already exposed via fallocate, even though in a bit different way. -- Pavel Begunkov