From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7E8CC4332F for ; Tue, 12 Dec 2023 13:21:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 61C636B02D9; Tue, 12 Dec 2023 08:21:55 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5CCB06B02DB; Tue, 12 Dec 2023 08:21:55 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3FA2B6B02DC; Tue, 12 Dec 2023 08:21:55 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 270926B02D9 for ; Tue, 12 Dec 2023 08:21:55 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 0CDE3A1ECA for ; Tue, 12 Dec 2023 13:21:55 +0000 (UTC) X-FDA: 81558228990.17.3E50614 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf23.hostedemail.com (Postfix) with ESMTP id D42E414001D for ; Tue, 12 Dec 2023 13:21:52 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=eKCnuhHn; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf23.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1702387312; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=syfyWfGRNUfPDo7zPcIQT5xwT3PP/oriHgVXxnBzp6M=; b=wjeJmHQxbz6/qlRZnbE9Ogn8MJ1u84hbuvw150nYzU30B3nnhTi80OAnYIvVeWO6HXTQbh szBkejZLe9o25HTtCUplCAU0mj1cnTqxDw05v1iI3/fxAekOduREXooKT3QYmdSCfkDuQ9 W/0cCgWCR3ypsYalHzqs2fV2uD6iHCE= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=eKCnuhHn; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf23.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1702387312; a=rsa-sha256; cv=none; b=E+ox7B0y5EUDcW1rBk8FnRepwCL3bYicYFw0JB9xGimX1WwArQREUBQzsuTbb6zzheyTd4 lqehrniTM5pAnxqJLTNuHLdXVi28Vs1mnRBUBgwN5fjHeHr76RX+vQFZ7XXcNMr3f7pDU5 4YpGOIsMc2e5yDYiayWJurGhHyayFUg= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1702387312; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=syfyWfGRNUfPDo7zPcIQT5xwT3PP/oriHgVXxnBzp6M=; b=eKCnuhHnQ6mkGyRW+Q8VY/GpgXVOWHUNyAk+Xdx9Nlhqj172c15NK/0r21f7eciMdNM8wa aJu3cwNuaHH+Wj8kdBVQoOaS7UyZBX+fQmig1ww2FKgD7yYrxJJ1pHujljeFGNqbe2sPnr 7KLML5cnw7S8IGbXBsZp0VmSfXkP8jk= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-121-kQOeDDSBOeaSkDH-Yd1S5Q-1; Tue, 12 Dec 2023 08:21:51 -0500 X-MC-Unique: kQOeDDSBOeaSkDH-Yd1S5Q-1 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-3334286b720so4952017f8f.1 for ; Tue, 12 Dec 2023 05:21:50 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702387310; x=1702992110; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=syfyWfGRNUfPDo7zPcIQT5xwT3PP/oriHgVXxnBzp6M=; b=uKb0QluQ/ZhXIxeSe+BVIj0ZnfgvvtmvVDIUdXnSxNryp0T+yh8IneG4j3QsvWcWO/ te7Gz6gbvOOEkcXWXRUblUMaWMQ16BKs5dkCImB2rBA+8pkgbgSG4pAZNhiW3vPdT2WM jGG78wQyDvJ8rSSNQqRbLY3nXi7oX9WuMEk3nPmqBhI7+DTInpPfvW56bS8g1BcWNgBE ClPa2CBIkeifTvM+dkWsIz9n/cm5cBixxH5yIblwZeDEKrFz3x/nrEYqs87zSGotfeok vQtfFjilk/bHobMOOovKmuAAbAkhQXrRdlTdVYrjUpWPvcZzV5i8AvITNE4omg/zt4o5 BdoA== X-Gm-Message-State: AOJu0Yy4VkoaSxi/J+w/5I0Bg8ya06DJTf+q2q23KMs0HMwtHzQ9mChH kNSVUhpKics5pC7tDnD/LuQ2WpV8Tem9e7ypndNVObSF3EbZ3bowVAxbYcSBkHum/zC0m/PyGuS 2luImz5Ic8JkHAMgQb7k= X-Received: by 2002:adf:e10f:0:b0:333:2fd2:7695 with SMTP id t15-20020adfe10f000000b003332fd27695mr1370346wrz.134.1702387309900; Tue, 12 Dec 2023 05:21:49 -0800 (PST) X-Google-Smtp-Source: AGHT+IHRBn/67vpC7f/6aDpVbAg/RXu3Tg0O16SXBJDgwvBBgWz91NX442VEuauzlrviHYbbhzZzzw== X-Received: by 2002:adf:e10f:0:b0:333:2fd2:7695 with SMTP id t15-20020adfe10f000000b003332fd27695mr1370341wrz.134.1702387309554; Tue, 12 Dec 2023 05:21:49 -0800 (PST) Received: from ?IPV6:2003:cb:c74b:ca00:4ca2:ff2c:9092:f070? (p200300cbc74bca004ca2ff2c9092f070.dip0.t-ipconnect.de. [2003:cb:c74b:ca00:4ca2:ff2c:9092:f070]) by smtp.gmail.com with ESMTPSA id v14-20020a5d4a4e000000b003333541a5bdsm10845248wrs.80.2023.12.12.05.21.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 12 Dec 2023 05:21:49 -0800 (PST) Message-ID: Date: Tue, 12 Dec 2023 14:21:48 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 9/9] mm: Remove page_add_new_anon_rmap and lru_cache_add_inactive_or_unevictable To: "Matthew Wilcox (Oracle)" , Andrew Morton Cc: linux-mm@kvack.org References: <20231211162214.2146080-1-willy@infradead.org> <20231211162214.2146080-10-willy@infradead.org> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20231211162214.2146080-10-willy@infradead.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: D42E414001D X-Stat-Signature: 5f5mbepeanjjyqayogr5f938djsqqfic X-HE-Tag: 1702387312-522871 X-HE-Meta: U2FsdGVkX1+d96HcF8tEIT1ouHf1MLtgm3dZm1uzRuviXAzOUcZQrPtTGjlOs8hKY9M5JIk3NAbhf4c7HpD4BbANfHSk16IcR98Kkpk57xT7p/pMg5SeUYKO/UdIhX42bmvvPTxRU5Dd7ER9TkbySoXyNesjTJWLpdIN8WgBEtS6uYsk/2lHaKN4w1P6uW8vi6UpYdu+S1ab0wWHADnCnH5LTQfwGjClgKdjHcGvsCVrLQROpFeA7OkTONZPDk6vy5Iye8crVoje1ZnjNn33J6QDzCCuS37NW0XxBW+TzY1S7sfI/9hKD/hEHiVf10KCC+MHwgiorcFdVn6XXMJLM7LzblduX6Oj/KOsa+M4O416BajLqtSr1clD1CVas19S9e4iOptIc4W4j2KSzAW9I2EXQOrNez6VVRgjTdKzg0bjVjkvzlh3YKfIBL+APkA+oEK73n4VumqMctW7CIFj1yo87WfIswLqJYxKkHVrDSXcWl7E/AwRT5zowCLwJDhv2wn1KwU2p/gY8w2vEBEeL4+w6B9BtthBaZld4SkEaKHFn8nG73DNCQ99JWOZBkc7ne66bwcbj8YLH7j7MKHPQwGXImlo6yQgCUZdFEDuZAsQaF7UGujmCc70eG5RjrhCFE4O2NpyGtfpci7Oa81nmgyJdqhME0EIdh1YivvLtf+fbmmk8bfZTYNlRoQKJkTsZodllropGtiH4Oh9IQlJiA/UsHJAR7wZvgKo4FzqI5wXT+sCapK5UVjDy17BRBADUK2MDJWf7XsOAOHVoKXMP5bnpLzh9pYcIg0mXeG7zbKa5jBk6OKqiir1roQ+IpBMOLDkeWEysuq8gK5zds0sNW6AtLxcqZzgwsvbXhWzYMzqk06k6+/7oW/+vVZzW8e2DvoTW9cPswaS70B/pE3bhavmeYj7C7+fTHS47ZRWhYTRPlRYcTqVlS9Zh55rADAa3SzIxTvDmuJbVmbW9cV D4/vaoB4 IrUMidHR9V+hRdl1bloWnGIklmx+T346AqqZc7Gbsxcm2IaG3/UQtcg+YeudXkg7w0YUOqxW/acrt5WyeiQLlOEQOe+EzDF/Xn+OroupOlbXK8SfQMiAtIF9jjhSNTYfhFd7I0bNPddNIc1Th3gzjEomgJpJjzPwMe5CZhS6PhayTrrhl4yNYU1tLDYes87194lhedbaQdXjYMbdMDdYIcbdLbp8K555fLX2xgmLv/FSdUCsYEg6BnLLtCtKFG3b2PibYBzSs0hJsPIsGYO/B9fzWQUuR/tkL2FdskTggTENrCbbAA6WDzdnjP1Ox9EF/fhvqR1//Q7DhMXeMVp+B8HiX/gKhyq54T16vN7wG9dD6BKyWTc9a7Lhh3/0F+FOjnF/AgNSZF1wCJ0TC8ZD/AzqMwoAXUmSiE+x6afTYexHyBbRVlPwDr2N1fjnfrXGpYpysPpbC411zUnfejAEsBWG1hIerxFUUVfGqzg8Pl/JRo2usdu0oHjGvHoAGsDuZioegaMLQwJa7cVau5rU2aD1Nt5sAL13aBXO4HSsqxmuGaGU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 11.12.23 17:22, Matthew Wilcox (Oracle) wrote: > All callers have now been converted to folio_add_new_anon_rmap() and > folio_add_lru_vma() so we can remove the wrapper. > > Signed-off-by: Matthew Wilcox (Oracle) > --- > include/linux/rmap.h | 2 -- > include/linux/swap.h | 3 --- > mm/folio-compat.c | 16 ---------------- > 3 files changed, 21 deletions(-) > > diff --git a/include/linux/rmap.h b/include/linux/rmap.h > index af6a32b6f3e7..0ae2bb0e77f5 100644 > --- a/include/linux/rmap.h > +++ b/include/linux/rmap.h > @@ -197,8 +197,6 @@ typedef int __bitwise rmap_t; > void folio_move_anon_rmap(struct folio *, struct vm_area_struct *); > void page_add_anon_rmap(struct page *, struct vm_area_struct *, > unsigned long address, rmap_t flags); > -void page_add_new_anon_rmap(struct page *, struct vm_area_struct *, > - unsigned long address); > void folio_add_new_anon_rmap(struct folio *, struct vm_area_struct *, > unsigned long address); > void page_add_file_rmap(struct page *, struct vm_area_struct *, > diff --git a/include/linux/swap.h b/include/linux/swap.h > index 4f25b1237364..edc0f2c8ce01 100644 > --- a/include/linux/swap.h > +++ b/include/linux/swap.h > @@ -397,9 +397,6 @@ void folio_deactivate(struct folio *folio); > void folio_mark_lazyfree(struct folio *folio); > extern void swap_setup(void); > > -extern void lru_cache_add_inactive_or_unevictable(struct page *page, > - struct vm_area_struct *vma); > - > /* linux/mm/vmscan.c */ > extern unsigned long zone_reclaimable_pages(struct zone *zone); > extern unsigned long try_to_free_pages(struct zonelist *zonelist, int order, > diff --git a/mm/folio-compat.c b/mm/folio-compat.c > index aee3b9a16828..50412014f16f 100644 > --- a/mm/folio-compat.c > +++ b/mm/folio-compat.c > @@ -77,12 +77,6 @@ bool redirty_page_for_writepage(struct writeback_control *wbc, > } > EXPORT_SYMBOL(redirty_page_for_writepage); > > -void lru_cache_add_inactive_or_unevictable(struct page *page, > - struct vm_area_struct *vma) > -{ > - folio_add_lru_vma(page_folio(page), vma); > -} > - > int add_to_page_cache_lru(struct page *page, struct address_space *mapping, > pgoff_t index, gfp_t gfp) > { > @@ -122,13 +116,3 @@ void putback_lru_page(struct page *page) > { > folio_putback_lru(page_folio(page)); > } > - > -#ifdef CONFIG_MMU > -void page_add_new_anon_rmap(struct page *page, struct vm_area_struct *vma, > - unsigned long address) > -{ > - VM_BUG_ON_PAGE(PageTail(page), page); > - > - return folio_add_new_anon_rmap((struct folio *)page, vma, address); > -} > -#endif Reviewed-by: David Hildenbrand -- Cheers, David / dhildenb