From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0780DC433E0 for ; Fri, 8 Jan 2021 09:29:00 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 4FF8923435 for ; Fri, 8 Jan 2021 09:28:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4FF8923435 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 548948D0171; Fri, 8 Jan 2021 04:28:58 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4F8AD8D0156; Fri, 8 Jan 2021 04:28:58 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3C0D08D0171; Fri, 8 Jan 2021 04:28:58 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0201.hostedemail.com [216.40.44.201]) by kanga.kvack.org (Postfix) with ESMTP id 267458D0156 for ; Fri, 8 Jan 2021 04:28:58 -0500 (EST) Received: from smtpin08.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id E93A3181AEF30 for ; Fri, 8 Jan 2021 09:28:57 +0000 (UTC) X-FDA: 77682083514.08.lace84_5f11deb274f1 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin08.hostedemail.com (Postfix) with ESMTP id CAB1B1819E798 for ; Fri, 8 Jan 2021 09:28:57 +0000 (UTC) X-HE-Tag: lace84_5f11deb274f1 X-Filterd-Recvd-Size: 2178 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf50.hostedemail.com (Postfix) with ESMTP for ; Fri, 8 Jan 2021 09:28:57 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 9222431B; Fri, 8 Jan 2021 01:28:56 -0800 (PST) Received: from [192.168.0.130] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 2734F3F70D; Fri, 8 Jan 2021 01:28:53 -0800 (PST) Subject: Re: [PATCH] mm,hwpoison: Fix printing of page flags To: Oscar Salvador , akpm@linux-foundation.org Cc: n-horiguchi@ah.jp.nec.com, dan.carpenter@oracle.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20210108085202.4506-1-osalvador@suse.de> From: Anshuman Khandual Message-ID: Date: Fri, 8 Jan 2021 14:59:12 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210108085202.4506-1-osalvador@suse.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 1/8/21 2:22 PM, Oscar Salvador wrote: > Format %pG expects a lower case 'p' in order to print the flags. > Fix it. > > Reported-by: Dan Carpenter > Signed-off-by: Oscar Salvador > Fixes: 8295d535e2aa ("mm,hwpoison: refactor get_any_page") Reviewed-by: Anshuman Khandual > --- > mm/memory-failure.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/memory-failure.c b/mm/memory-failure.c > index 5a38e9eade94..04d9f154a130 100644 > --- a/mm/memory-failure.c > +++ b/mm/memory-failure.c > @@ -1940,7 +1940,7 @@ int soft_offline_page(unsigned long pfn, int flags) > goto retry; > } > } else if (ret == -EIO) { > - pr_info("%s: %#lx: unknown page type: %lx (%pGP)\n", > + pr_info("%s: %#lx: unknown page type: %lx (%pGp)\n", > __func__, pfn, page->flags, &page->flags); > } > >