linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Anshuman Khandual <anshuman.khandual@arm.com>
To: Oscar Salvador <osalvador@suse.de>, akpm@linux-foundation.org
Cc: n-horiguchi@ah.jp.nec.com, dan.carpenter@oracle.com,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm,hwpoison: Fix printing of page flags
Date: Fri, 8 Jan 2021 14:59:12 +0530	[thread overview]
Message-ID: <d1d4face-71a7-3526-bcdb-b48d41f32da4@arm.com> (raw)
In-Reply-To: <20210108085202.4506-1-osalvador@suse.de>



On 1/8/21 2:22 PM, Oscar Salvador wrote:
> Format %pG expects a lower case 'p' in order to print the flags.
> Fix it.
> 
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Signed-off-by: Oscar Salvador <osalvador@suse.de>
> Fixes: 8295d535e2aa ("mm,hwpoison: refactor get_any_page")

Reviewed-by: Anshuman Khandual <anshuman.khandual@arm.com>

> ---
>  mm/memory-failure.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/mm/memory-failure.c b/mm/memory-failure.c
> index 5a38e9eade94..04d9f154a130 100644
> --- a/mm/memory-failure.c
> +++ b/mm/memory-failure.c
> @@ -1940,7 +1940,7 @@ int soft_offline_page(unsigned long pfn, int flags)
>  			goto retry;
>  		}
>  	} else if (ret == -EIO) {
> -		pr_info("%s: %#lx: unknown page type: %lx (%pGP)\n",
> +		pr_info("%s: %#lx: unknown page type: %lx (%pGp)\n",
>  			 __func__, pfn, page->flags, &page->flags);
>  	}
>  
> 


  reply	other threads:[~2021-01-08  9:29 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-08  8:52 Oscar Salvador
2021-01-08  9:29 ` Anshuman Khandual [this message]
2021-01-08 10:09 ` HORIGUCHI NAOYA(堀口　直也)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d1d4face-71a7-3526-bcdb-b48d41f32da4@arm.com \
    --to=anshuman.khandual@arm.com \
    --cc=akpm@linux-foundation.org \
    --cc=dan.carpenter@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=n-horiguchi@ah.jp.nec.com \
    --cc=osalvador@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox