From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79F2EC3DA7F for ; Fri, 26 Jul 2024 12:06:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E1F9B6B007B; Fri, 26 Jul 2024 08:06:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DCE046B0098; Fri, 26 Jul 2024 08:06:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C21406B009A; Fri, 26 Jul 2024 08:06:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id A25496B007B for ; Fri, 26 Jul 2024 08:06:38 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 529A51C130E for ; Fri, 26 Jul 2024 12:06:38 +0000 (UTC) X-FDA: 82381776876.24.2E8E91A Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf19.hostedemail.com (Postfix) with ESMTP id 0D71D1A0013 for ; Fri, 26 Jul 2024 12:06:35 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=TTQKdsPh; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf19.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721995559; a=rsa-sha256; cv=none; b=mL7jHnxtoZEmbtux3F1ODjFRUVXXfYlvQE9jiisyhaCz7/fIXewdJKYTqpDPygSb5eL2RQ RFlLkw/AZ+2TJ3MM/nQ8PdO9jsJuNGqL0keJFeEB24umH1AyKoeYvRrjQQ19/m5yr6wweG 8VZtrl6MqpPd/kxZat4Q/aEcxQbRF+k= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=TTQKdsPh; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf19.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721995559; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=pyWLe22bnzx1/C7IKzsX767y+X09dpPQZ0XHgrhwDuU=; b=2G9KDNLLLsqWv67J6PDsksMvaGFmUGzH9GrIHi/UQFUpgvywR/2bv8NrY/FOwfakaF9Z66 sJdYSX4B9cw+HNhIpILqo63YDYrZ5m2/dSUQkK8Gn+FPzd5M0gaoDSsj6sMj+WOx9dsUkr kxiu1kyx/I9Wvly79Pc9lY7zM9Umv7A= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1721995595; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=pyWLe22bnzx1/C7IKzsX767y+X09dpPQZ0XHgrhwDuU=; b=TTQKdsPhD90fZM4iZeMe3BHRXzIHZ5CtkFV4lqPWzqNufadLl9pZk7VspiS15uhzFCysyE qzFG2ZptKMJiVXFUe3PApQA/nFCLuQ2/byaN0LfW70cjknPKxWzwmmwA1eQ88hBv9rYCFW sKdalrxSpfHVBIlIOo2IVzMg0cBE5gQ= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-116-0sX39afNNpa0oWj-9ym7-A-1; Fri, 26 Jul 2024 08:06:33 -0400 X-MC-Unique: 0sX39afNNpa0oWj-9ym7-A-1 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-42808685ef0so9939255e9.2 for ; Fri, 26 Jul 2024 05:06:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721995592; x=1722600392; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=pyWLe22bnzx1/C7IKzsX767y+X09dpPQZ0XHgrhwDuU=; b=bY0tmRHlg89Y5l77bR/K2EOvVaf20h+lUiYMxCNyydYY91rS0fZyW0lEAf9Wcxat7o Kxi3UYkk6Kj0UVbeMFU8MjQhXeWSdc8G8sSBPaJFHWJKDhPWF/kRQJyN8O+w+XmCBcLs 0CPywGynZF+CDMTYQIcRET/nzDOkWeq8SS5eqcNNHdNeeDTjJLEetQZtRV92YVWPzk7h ybUYL0kYesG8qM04oh7L9u9ZDzeGufE+aomCQLkdDtLrQRJdKFnGEQ6oSP2RPPioHiBO 6fNiNTac0GzyuqQwQoFNfd0nD4+x16P4lAwsb1RsDZZFc8DIx3dLDWeD5/qhDwKkUZ8g kBIw== X-Gm-Message-State: AOJu0YxUCfSLDERr0dd7ibrEkAcRH18Z1mpgXzJa0BznAtqdNLcAHY8E o37RUH9vyAgQkouTqez5PhAZMbdqKFGNKcWEKHEdHcE4p3Gxp9IyeWuBGWmKglRad4X2Hu4eyll UvjvU8kiSyAf46oGNKiATJhHiHSpSP59DnEq2TC16koLxaIHhpCyXPbVP X-Received: by 2002:a05:6000:1bc1:b0:35f:1f8a:e69a with SMTP id ffacd0b85a97d-36b36421841mr3528554f8f.49.1721995592433; Fri, 26 Jul 2024 05:06:32 -0700 (PDT) X-Google-Smtp-Source: AGHT+IH9AafJr1HfNNcV/tL/gwjwLl1PEACX4GQV6xWJDMFjk37P5JinVX/zf3fzMzf8myYQvqkmlw== X-Received: by 2002:a05:6000:1bc1:b0:35f:1f8a:e69a with SMTP id ffacd0b85a97d-36b36421841mr3528531f8f.49.1721995591986; Fri, 26 Jul 2024 05:06:31 -0700 (PDT) Received: from ?IPV6:2003:cb:c713:a600:7ca0:23b3:d48a:97c7? (p200300cbc713a6007ca023b3d48a97c7.dip0.t-ipconnect.de. [2003:cb:c713:a600:7ca0:23b3:d48a:97c7]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-36b367c090dsm4963201f8f.11.2024.07.26.05.06.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 26 Jul 2024 05:06:31 -0700 (PDT) Message-ID: Date: Fri, 26 Jul 2024 14:06:30 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] mm: increase totalram_pages on freeing to buddy system To: Wei Yang , rppt@kernel.org, akpm@linux-foundation.org Cc: linux-mm@kvack.org References: <20240726003612.5578-1-richard.weiyang@gmail.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240726003612.5578-1-richard.weiyang@gmail.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 0D71D1A0013 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: dogjd481bftuxwnn3wqhmjdgopf9ngko X-HE-Tag: 1721995595-912039 X-HE-Meta: U2FsdGVkX1+svI11xZtr0uFApR5UykJguJ569ap5fffS1typUGWiLHulF4Li2HfSUzsdlqOMp2AgRC3OUYp9haPVlA8FUDBDbE/mR5Lna2dm+ojV/BNsj5UL4Ll67P8+FQzRY3nuBXihCrnhIr8adtNh3Z3CEIy94qxWybtclL+Vn449VfZ+O2YRRLFaj3UuUmuKnNSFJXTmDjQdyIexfJilKEeVJfpAJWoahtpr70+aUiL8nlgUaiQ0UcjDD0J0ynUBQi8jB8xanRUOc+X1blQQTPyTRBVD6k/uo2D4+HJq8PJQE1F68nc5zzEKtl3B0yUZ5AjRvRYukCh4s/k8Vwe4diiHfumeFXmmd1MSY/20t65Xm6MIY/L1lrt0FEc7y9NCWt0MqoGYSyCpitIqqIprspkrR36EWqoZMRg0m3qWRb2SWAjejR/en7AjBU+hzDttF0o6pAgGCu9XOrrzBf7k3bYVNBGFEW1H/yc0spRQ9NiRlwsdymfsPI+Paz7QR+5oVaFPlPOuEzZi52LaQAe5JLhqY/b83wU8fJR6l+gbb/4PlJLr+LMB6yNhjLgsAlREgICbFAOQ5EOIOKXoJ8FCMJq5gErZQ823SeLYwSZSdMu45FyjRJVCz0IxIv9Rn9uvrmmB0KnTY60XtiLmJj/KUl128dZxb8i6Fy/76vkKfV4LfXd76GXIpQv34/Pt/Gnbnwq9ASiqi79tiS1qbFY9XWU+ZB3vOkdrDa2t/VTqch3Iiz93ozsGabsyzFLmUErZtX6Yi2y3iA56ukm9YRWHLglit9VDplwiljLYkYOymyOuQiIX9bFDNDuiSP+7vaHSrUndf1NcV+1jemywGXKd8DPCbJdBlgVxMf89kOq+HDfkLMFG0GX7vpssSr5ddn0yjsGsNE7zWC/GCfBCLg6yx83cpTUzkBsIWYTWfQtErJJiJnczMgkA3uxJEbi8nz4ZZdB+i9eGU1VeVc8 SYhbgAgm aw1/mx+Li8Xl9LJLfPkgsFIUD1jyfADf4+LgL4smUysLDkr/wzPmz7ImZo/vZA9FUIObWgWqrXVrHZv6Z8K6wnfA71BjcxQm3twIRBq5ev3JrmWlcbjNXOum6QwDBOx9VCvqlHeZ11PQqH3lC8aygEc5UqbuHLKgaOxn4D/zZxejS0IGoMvURdyX4j9RFRrLI9QawXGwAUjuGNRJrDPomzCtHPQ7dP6G0bS4gT3b0O4AIEwIa6aP5ATVzFVDNDPlJQhgHAvenrF6AAAS9dMc9VlXvjGRsXyNip7CEqIYaAxDCQFk5ufHDjUe8DxWWdQ5u4EyawqKiHfIIOYf99vm113+FaecqTib0017oYJGNi06sTCFci+Gii7zOeO1+t5BsHIO74OzCJVKxJAaPpPCNBlvVvaCoE2enxqS/eTJoF9l082Obk0H+HIw0mkf4141j3ukCXUkVszKPMmCGt4odTyba6gNxSBfjyNDpOsERyiD8cLCFKsml6OhQ8ParVzKoWzaYFX341nQAAFmsbv2gkNneqg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 26.07.24 02:36, Wei Yang wrote: > Total memory represents pages managed by buddy system. After the > introduction of DEFERRED_STRUCT_PAGE_INIT, it may count the pages before > being managed. > > free_low_memory_core_early() returns number of pages for all free pages, > even at this moment only early initialized pages are freed to buddy > system. This means the total memory at this moment is not correct. > > Let's increase it when pages are freed to buddy system. > > Signed-off-by: Wei Yang > CC: David Hildenbrand [...] > index 71d2716a554f..4701bc442df6 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -1248,16 +1248,14 @@ void __meminit __free_pages_core(struct page *page, unsigned int order, > * map it first. > */ > debug_pagealloc_map_pages(page, nr_pages); > - adjust_managed_page_count(page, nr_pages); > } else { > for (loop = 0; loop < nr_pages; loop++, p++) { > __ClearPageReserved(p); > set_page_count(p, 0); > } > > - /* memblock adjusts totalram_pages() manually. */ > - atomic_long_add(nr_pages, &page_zone(page)->managed_pages); > } > + adjust_managed_page_count(page, nr_pages); > > if (page_contains_unaccepted(page, order)) { > if (order == MAX_PAGE_ORDER && __free_unaccepted(page)) Nice! Acked-by: David Hildenbrand -- Cheers, David / dhildenb