From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85A42C49EA6 for ; Fri, 25 Jun 2021 01:57:37 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 2F997613B9 for ; Fri, 25 Jun 2021 01:57:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2F997613B9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id ED4076B0036; Thu, 24 Jun 2021 21:57:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E84856B005D; Thu, 24 Jun 2021 21:57:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CD7066B006C; Thu, 24 Jun 2021 21:57:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0162.hostedemail.com [216.40.44.162]) by kanga.kvack.org (Postfix) with ESMTP id 9A3B36B0036 for ; Thu, 24 Jun 2021 21:57:35 -0400 (EDT) Received: from smtpin29.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id C3199250B1 for ; Fri, 25 Jun 2021 01:57:35 +0000 (UTC) X-FDA: 78290584470.29.C01B594 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by imf19.hostedemail.com (Postfix) with ESMTP id 53D7A9001460 for ; Fri, 25 Jun 2021 01:57:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1624586254; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WJNYehYQCtO8YDW37Sjtn9L+6gPkmZnTc6gkgATiy7A=; b=FwYuxm3cXuso3BmGVoEud2mY5WB2wl92yNFNL9KjEdlM3I3u9HcFeXSVk6YT5w2c5XtY56 W/uXjfagk/y1TbNKvYa/4S/GxFhdE/6I7X9R8Uj5GBD0HTA6glPRECW4tlU5Lu//7mjOQR 5biDA53yCpj+jGLTfkhG1BkvMprBLis= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-389-9pqjGF28NtqQRkJbB8oetA-1; Thu, 24 Jun 2021 21:57:33 -0400 X-MC-Unique: 9pqjGF28NtqQRkJbB8oetA-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 0FC3B100CAB1; Fri, 25 Jun 2021 01:57:30 +0000 (UTC) Received: from [10.64.54.70] (vpn2-54-70.bne.redhat.com [10.64.54.70]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 56DBB822F6; Fri, 25 Jun 2021 01:57:25 +0000 (UTC) Reply-To: Gavin Shan Subject: Re: [PATCH v4 2/4] mm/page_reporting: Export reporting order as module parameter To: Alexander Duyck Cc: linux-mm , LKML , David Hildenbrand , "Michael S. Tsirkin" , Andrew Morton , Anshuman Khandual , Catalin Marinas , Will Deacon , shan.gavin@gmail.com References: <20210625014710.42954-1-gshan@redhat.com> <20210625014710.42954-3-gshan@redhat.com> From: Gavin Shan Message-ID: Date: Fri, 25 Jun 2021 13:58:53 +1000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 53D7A9001460 Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=FwYuxm3c; spf=none (imf19.hostedemail.com: domain of gshan@redhat.com has no SPF policy when checking 216.205.24.124) smtp.mailfrom=gshan@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Stat-Signature: mrbxn9bru7z4cex6a8pabokyeqai46ye X-HE-Tag: 1624586255-385033 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 6/25/21 11:14 AM, Alexander Duyck wrote: > On Thu, Jun 24, 2021 at 4:46 PM Gavin Shan wrote: >> >> The macro PAGE_REPORTING_MIN_ORDER is defined as the page reporting >> threshold. It can't be adjusted at runtime. >> >> This introduces a variable (@page_reporting_order) to replace the >> marcro (PAGE_REPORTING_MIN_ORDER). MAX_ORDER is assigned to it initially, >> meaning the page reporting is disabled. It will be specified by driver >> if valid one is provided. Otherwise, it will fall back to @pageblock_order. >> It's also exported so that the page reporting order can be adjusted at >> runtime. >> >> Suggested-by: David Hildenbrand >> Signed-off-by: Gavin Shan >> Reviewed-by: Alexander Duyck > > So this patch looks like it is technically broken. We need a line in > page_reporting_register that will overwrite the value with > pageblock_order if it is less than page_reporting_order. > Yes, but it's not broken after next (PATCH[3/4]) is applied. However, It's still worthy to be fixed, to be "git bisect" friendly. I'll update in v5. Thanks, Gavin >> --- >> Documentation/admin-guide/kernel-parameters.txt | 6 ++++++ >> mm/page_reporting.c | 9 +++++++-- >> mm/page_reporting.h | 5 ++--- >> 3 files changed, 15 insertions(+), 5 deletions(-) >> >> diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt >> index cb89dbdedc46..566c4b9af3cd 100644 >> --- a/Documentation/admin-guide/kernel-parameters.txt >> +++ b/Documentation/admin-guide/kernel-parameters.txt >> @@ -3566,6 +3566,12 @@ >> off: turn off poisoning (default) >> on: turn on poisoning >> >> + page_reporting.page_reporting_order= >> + [KNL] Minimal page reporting order >> + Format: >> + Adjust the minimal page reporting order. The page >> + reporting is disabled when it exceeds (MAX_ORDER-1). >> + >> panic= [KNL] Kernel behaviour on panic: delay >> timeout > 0: seconds before rebooting >> timeout = 0: wait forever >> diff --git a/mm/page_reporting.c b/mm/page_reporting.c >> index df9c5054e1b4..34bf4d26c2c4 100644 >> --- a/mm/page_reporting.c >> +++ b/mm/page_reporting.c >> @@ -4,12 +4,17 @@ >> #include >> #include >> #include >> +#include >> #include >> #include >> >> #include "page_reporting.h" >> #include "internal.h" >> >> +unsigned int page_reporting_order = MAX_ORDER; >> +module_param(page_reporting_order, uint, 0644); >> +MODULE_PARM_DESC(page_reporting_order, "Set page reporting order"); >> + >> #define PAGE_REPORTING_DELAY (2 * HZ) >> static struct page_reporting_dev_info __rcu *pr_dev_info __read_mostly; >> >> @@ -229,7 +234,7 @@ page_reporting_process_zone(struct page_reporting_dev_info *prdev, >> >> /* Generate minimum watermark to be able to guarantee progress */ >> watermark = low_wmark_pages(zone) + >> - (PAGE_REPORTING_CAPACITY << PAGE_REPORTING_MIN_ORDER); >> + (PAGE_REPORTING_CAPACITY << page_reporting_order); >> >> /* >> * Cancel request if insufficient free memory or if we failed >> @@ -239,7 +244,7 @@ page_reporting_process_zone(struct page_reporting_dev_info *prdev, >> return err; >> >> /* Process each free list starting from lowest order/mt */ >> - for (order = PAGE_REPORTING_MIN_ORDER; order < MAX_ORDER; order++) { >> + for (order = page_reporting_order; order < MAX_ORDER; order++) { >> for (mt = 0; mt < MIGRATE_TYPES; mt++) { >> /* We do not pull pages from the isolate free list */ >> if (is_migrate_isolate(mt)) >> diff --git a/mm/page_reporting.h b/mm/page_reporting.h >> index 2c385dd4ddbd..c51dbc228b94 100644 >> --- a/mm/page_reporting.h >> +++ b/mm/page_reporting.h >> @@ -10,10 +10,9 @@ >> #include >> #include >> >> -#define PAGE_REPORTING_MIN_ORDER pageblock_order >> - >> #ifdef CONFIG_PAGE_REPORTING >> DECLARE_STATIC_KEY_FALSE(page_reporting_enabled); >> +extern unsigned int page_reporting_order; >> void __page_reporting_notify(void); >> >> static inline bool page_reported(struct page *page) >> @@ -38,7 +37,7 @@ static inline void page_reporting_notify_free(unsigned int order) >> return; >> >> /* Determine if we have crossed reporting threshold */ >> - if (order < PAGE_REPORTING_MIN_ORDER) >> + if (order < page_reporting_order) >> return; >> >> /* This will add a few cycles, but should be called infrequently */ >> -- >> 2.23.0 >> >