From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09BE8C4741F for ; Fri, 25 Sep 2020 19:30:52 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 3C2F3206C3 for ; Fri, 25 Sep 2020 19:30:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=web.de header.i=@web.de header.b="rMukLhrB" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3C2F3206C3 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=web.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 773206B0072; Fri, 25 Sep 2020 15:30:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6373C6B0078; Fri, 25 Sep 2020 15:30:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2B4326B0072; Fri, 25 Sep 2020 15:30:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0216.hostedemail.com [216.40.44.216]) by kanga.kvack.org (Postfix) with ESMTP id 0C9326B0073 for ; Fri, 25 Sep 2020 15:30:47 -0400 (EDT) Received: from smtpin26.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id CAE0D4DB3 for ; Fri, 25 Sep 2020 19:30:46 +0000 (UTC) X-FDA: 77302576092.26.ring52_060a6792716a Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin26.hostedemail.com (Postfix) with ESMTP id A76A41804B66E for ; Fri, 25 Sep 2020 19:30:46 +0000 (UTC) X-HE-Tag: ring52_060a6792716a X-Filterd-Recvd-Size: 8443 Received: from mout.web.de (mout.web.de [212.227.15.4]) by imf36.hostedemail.com (Postfix) with ESMTP for ; Fri, 25 Sep 2020 19:30:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1601062226; bh=ZFci3HZ4hKXwECUr1RYNRKlf4gtxf4/CtQDzFoleeF4=; h=X-UI-Sender-Class:To:Cc:Subject:From:Date; b=rMukLhrBgr8Gi9Lxi9g5zIGFh4CdtFeKsM9obhiRGE36x+trkYJyeIat37KjIEvsC ghBWMGHNThLYzkO6ar73ojhHw2b6GmFebIZOOFZjRwcamtXMCbGBYpcemn8c7uKgf9 JsssddTenna4t6bCtj80bptMo6+C96VAmBSU8zHo= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Received: from [192.168.1.2] ([93.135.109.0]) by smtp.web.de (mrweb001 [213.165.67.108]) with ESMTPSA (Nemesis) id 0M9Xfb-1k9YhK3Uqt-00Cw92; Fri, 25 Sep 2020 21:30:26 +0200 To: Dan Carpenter , linux-mm@kvack.org, Andrew Morton , Stephen Rothwell , Dan Williams Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, Andy Lutomirski , Ard Biesheuvel , Ben Skeggs , Benjamin Herrenschmidt , Borislav Petkov , Brice Goglin , Catalin Marinas , Daniel Vetter , Dave Hansen , Dave Jiang , David Airlie , David Hildenbrand , Greg Kroah-Hartman , "H. Peter Anvin" , Ingo Molnar , Ira Weiny , Jason Gunthorpe , Jason Gunthorpe , Jeff Moyer , =?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= , Jia He , Joao Martins , Jonathan Cameron , Michael Ellerman , Mike Rapoport , Paul Mackerras , Pavel Tatashin , Peter Zijlstra , "Rafael J. Wysocki" , Ralph Campbell , Thomas Gleixner , Tom Lendacky , Vishal Verma , Wei Yang , Wei Yongjun , Will Deacon Subject: Re: [PATCH v2] mm/hmm/test: use after free in dmirror_allocate_chunk() From: Markus Elfring Autocrypt: addr=Markus.Elfring@web.de; prefer-encrypt=mutual; keydata= mQINBFg2+xABEADBJW2hoUoFXVFWTeKbqqif8VjszdMkriilx90WB5c0ddWQX14h6w5bT/A8 +v43YoGpDNyhgA0w9CEhuwfZrE91GocMtjLO67TAc2i2nxMc/FJRDI0OemO4VJ9RwID6ltwt mpVJgXGKkNJ1ey+QOXouzlErVvE2fRh+KXXN1Q7fSmTJlAW9XJYHS3BDHb0uRpymRSX3O+E2 lA87C7R8qAigPDZi6Z7UmwIA83ZMKXQ5stA0lhPyYgQcM7fh7V4ZYhnR0I5/qkUoxKpqaYLp YHBczVP+Zx/zHOM0KQphOMbU7X3c1pmMruoe6ti9uZzqZSLsF+NKXFEPBS665tQr66HJvZvY GMDlntZFAZ6xQvCC1r3MGoxEC1tuEa24vPCC9RZ9wk2sY5Csbva0WwYv3WKRZZBv8eIhGMxs rcpeGShRFyZ/0BYO53wZAPV1pEhGLLxd8eLN/nEWjJE0ejakPC1H/mt5F+yQBJAzz9JzbToU 5jKLu0SugNI18MspJut8AiA1M44CIWrNHXvWsQ+nnBKHDHHYZu7MoXlOmB32ndsfPthR3GSv jN7YD4Ad724H8fhRijmC1+RpuSce7w2JLj5cYj4MlccmNb8YUxsE8brY2WkXQYS8Ivse39MX BE66MQN0r5DQ6oqgoJ4gHIVBUv/ZwgcmUNS5gQkNCFA0dWXznQARAQABtCZNYXJrdXMgRWxm cmluZyA8TWFya3VzLkVsZnJpbmdAd2ViLmRlPokCVAQTAQgAPhYhBHDP0hzibeXjwQ/ITuU9 Figxg9azBQJYNvsQAhsjBQkJZgGABQsJCAcCBhUICQoLAgQWAgMBAh4BAheAAAoJEOU9Figx g9azcyMP/iVihZkZ4VyH3/wlV3nRiXvSreqg+pGPI3c8J6DjP9zvz7QHN35zWM++1yNek7Ar OVXwuKBo18ASlYzZPTFJZwQQdkZSV+atwIzG3US50ZZ4p7VyUuDuQQVVqFlaf6qZOkwHSnk+ CeGxlDz1POSHY17VbJG2CzPuqMfgBtqIU1dODFLpFq4oIAwEOG6fxRa59qbsTLXxyw+PzRaR LIjVOit28raM83Efk07JKow8URb4u1n7k9RGAcnsM5/WMLRbDYjWTx0lJ2WO9zYwPgRykhn2 sOyJVXk9xVESGTwEPbTtfHM+4x0n0gC6GzfTMvwvZ9G6xoM0S4/+lgbaaa9t5tT/PrsvJiob kfqDrPbmSwr2G5mHnSM9M7B+w8odjmQFOwAjfcxoVIHxC4Cl/GAAKsX3KNKTspCHR0Yag78w i8duH/eEd4tB8twcqCi3aCgWoIrhjNS0myusmuA89kAWFFW5z26qNCOefovCx8drdMXQfMYv g5lRk821ZCNBosfRUvcMXoY6lTwHLIDrEfkJQtjxfdTlWQdwr0mM5ye7vd83AManSQwutgpI q+wE8CNY2VN9xAlE7OhcmWXlnAw3MJLW863SXdGlnkA3N+U4BoKQSIToGuXARQ14IMNvfeKX NphLPpUUnUNdfxAHu/S3tPTc/E/oePbHo794dnEm57LuuQINBFg2+xABEADZg/T+4o5qj4cw nd0G5pFy7ACxk28mSrLuva9tyzqPgRZ2bdPiwNXJUvBg1es2u81urekeUvGvnERB/TKekp25 4wU3I2lEhIXj5NVdLc6eU5czZQs4YEZbu1U5iqhhZmKhlLrhLlZv2whLOXRlLwi4jAzXIZAu 76mT813jbczl2dwxFxcT8XRzk9+dwzNTdOg75683uinMgskiiul+dzd6sumdOhRZR7YBT+xC wzfykOgBKnzfFscMwKR0iuHNB+VdEnZw80XGZi4N1ku81DHxmo2HG3icg7CwO1ih2jx8ik0r riIyMhJrTXgR1hF6kQnX7p2mXe6K0s8tQFK0ZZmYpZuGYYsV05OvU8yqrRVL/GYvy4Xgplm3 DuMuC7/A9/BfmxZVEPAS1gW6QQ8vSO4zf60zREKoSNYeiv+tURM2KOEj8tCMZN3k3sNASfoG fMvTvOjT0yzMbJsI1jwLwy5uA2JVdSLoWzBD8awZ2X/eCU9YDZeGuWmxzIHvkuMj8FfX8cK/ 2m437UA877eqmcgiEy/3B7XeHUipOL83gjfq4ETzVmxVswkVvZvR6j2blQVr+MhCZPq83Ota xNB7QptPxJuNRZ49gtT6uQkyGI+2daXqkj/Mot5tKxNKtM1Vbr/3b+AEMA7qLz7QjhgGJcie qp4b0gELjY1Oe9dBAXMiDwARAQABiQI8BBgBCAAmFiEEcM/SHOJt5ePBD8hO5T0WKDGD1rMF Alg2+xACGwwFCQlmAYAACgkQ5T0WKDGD1rOYSw/+P6fYSZjTJDAl9XNfXRjRRyJSfaw6N1pA Ahuu0MIa3djFRuFCrAHUaaFZf5V2iW5xhGnrhDwE1Ksf7tlstSne/G0a+Ef7vhUyeTn6U/0m +/BrsCsBUXhqeNuraGUtaleatQijXfuemUwgB+mE3B0SobE601XLo6MYIhPh8MG32MKO5kOY hB5jzyor7WoN3ETVNQoGgMzPVWIRElwpcXr+yGoTLAOpG7nkAUBBj9n9TPpSdt/npfok9ZfL /Q+ranrxb2Cy4tvOPxeVfR58XveX85ICrW9VHPVq9sJf/a24bMm6+qEg1V/G7u/AM3fM8U2m tdrTqOrfxklZ7beppGKzC1/WLrcr072vrdiN0icyOHQlfWmaPv0pUnW3AwtiMYngT96BevfA qlwaymjPTvH+cTXScnbydfOQW8220JQwykUe+sHRZfAF5TS2YCkQvsyf7vIpSqo/ttDk4+xc Z/wsLiWTgKlih2QYULvW61XU+mWsK8+ZlYUrRMpkauN4CJ5yTpvp+Orcz5KixHQmc5tbkLWf x0n1QFc1xxJhbzN+r9djSGGN/5IBDfUqSANC8cWzHpWaHmSuU3JSAMB/N+yQjIad2ztTckZY pwT6oxng29LzZspTYUEzMz3wK2jQHw+U66qBFk8whA7B2uAU1QdGyPgahLYSOa4XAEGb6wbI FEE= Message-ID: Date: Fri, 25 Sep 2020 21:30:09 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-GB X-Provags-ID: V03:K1:J143cK1xQMxgYwaWy7OiDbc3cJndgCEWp5BjiG+8XNDLRF0nS1R 6PrL0sBa9z54AYXKRhYV3ZPGuQ4uFaTv8Dn/ud6ddw3gmnReS4BI8CH8xK/NMYr4ot1eANI 2V/iyXXF0mkJ1frOLlN2CkP2lvKr4vb+ZOAQOtRyySCi/0OfHirAkgSV3DsqJlPEqmVbhAx iZHRMbGSmR9EfBKJ0FTRA== X-UI-Out-Filterresults: notjunk:1;V03:K0:5LV30AMQRRc=:OVEK283p1BOkjZYhsXjCbG KG14RPV8LAxHK+oU+os4DyTN01WQz2NfNUd7v6zQqlbNntv8Cj9XXn9FBEtVDGB1+rAJODu7G Wp9YysudetLe7dd7mewIxrevrHbgDwoCkQPgO/x4U/ygvZo2OmTDK3RENbw/vruaCrqS8aYc4 DpHMcVw/uxKFuXjlYMmrhWhGaJ7thXh0qGj1MKyn2MzdHuhPNeGfzaSzj9l+zfbJMz07/SMgu kyO1+dR8zW+E9VuxUeZz0a0r5ERIfiYPBUiFECKxjqXWIzFa/Zff+1vaw53kHsf+jg0rMHrqq g3+Rd/PaqqguoF2Rgif/a0J9kp3O3Z6rlZFYD7ApzqBgJIpMlJ3rkA+5jlJ5dtoM80k/2hNYO 5HXjMUrzURZ/n0wbTf+IerotS/zIBA4oAzrZRYVADpswAHe+g8RI+ytYAmsVq3yvvuBv31Aly 8MbQfgQjkiwKAM8Qp49f1VvS/imMZhxpuqzTyZyT82LINtzZFjZ1VYl6uk18sP4d8JRCGqaKc TenTIKfmh+O5x3KUMFMkLLgcr0Ww4Ac/YQmY/3Y21/pRavZ+GVE2n/sH2F2i1NnEpvlm3Dc5Z FK4SznK63RH2bMLKwzDE7Y5iqk+R3aYns8RL0vi3t6k6LiLChHga2Se2RoqGiyNuT5i+mq077 XVtUHPf690PTU5YiqYk+HOdH9O6LyPzIlmIAcirj+dQrOHxJFjLsezw2jHujReJINeJkIjHQh a6IWLyE2esfSUDADP0rP1uknSLw0J9z6zmQid9J/7mO+hacvzRJ4qQQ5Fd3w2fUVd4ke4QOXy YXzvi7yA4l7vSvKnuJEPwq/GAZlszTNC0QVehYRUe06mGOeayrod3Do6y9BdUvxUo8p2nSWJ0 y4Qws1J4f+OxUIJZMAkvNnJYaZCFk538OCfpxH/wuv4pvZGkG8WS8lKKr3dz6EFO3rGV85+IF hMs6BXvdDWJ8ReI18GNJgJTqZT1GOdk5Xj2EFX4fvH85S+ZRiG6mzPPwWmgJHyG0qeXanVRRL MXQTt+kFrMSYeG9iaft4CySj1xxvjcZCKzAwfk+HmAfYb6npD2xjXJfpbWzZ6Z5Sse8ZGvqbe FSFNElzNPTlIGEsKE5oY+/IhqYuYlC6cZ9iSVPm9sbgWZ1dPmU2TFjCrDGA4UEMuyry5xuxbX Ev4JYzRj5bZoTNurPA0wR4xr9jqMcg/7yI98gI9BHprDYauIbE6WAdSX8knvNfJ8Kz+VYDSfy KM6bAgBPvxNgDIj4ZoVlT8bTURpBe7PjkjshzkA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > Neither the allocation nor the call to request_free_mem_region() has to > be done under the lock so I moved those to the start of the function. Can this information become relevant for another update step? > Fixes: b2ef9f5a5cb3 ("mm/hmm/test: add selftest driver for HMM") I find this commit reference interesting somehow. How do you think about the commit 786ae133e07f2a6b352a0efad16b555ee45a2898 ("lib: fix test_hmm.c reference after free" from 2020-06-26) and the commit 1f9c4bb986d978a5e39153b39a71c9d098b65c5c ("mm/memremap_pages: convert to 'struct range'" from 2020-09-23) for your update suggestion? Regards, Markus