linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Markus Elfring <Markus.Elfring@web.de>
To: Dan Carpenter <dan.carpenter@oracle.com>,
	linux-mm@kvack.org, Andrew Morton <akpm@linux-foundation.org>,
	Stephen Rothwell <sfr@canb.auug.org.au>,
	Dan Williams <dan.j.williams@intel.com>
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
	"Andy Lutomirski" <luto@kernel.org>,
	"Ard Biesheuvel" <ardb@kernel.org>,
	"Ben Skeggs" <bskeggs@redhat.com>,
	"Benjamin Herrenschmidt" <benh@kernel.crashing.org>,
	"Borislav Petkov" <bp@alien8.de>,
	"Brice Goglin" <Brice.Goglin@inria.fr>,
	"Catalin Marinas" <catalin.marinas@arm.com>,
	"Daniel Vetter" <daniel@ffwll.ch>,
	"Dave Hansen" <dave.hansen@linux.intel.com>,
	"Dave Jiang" <dave.jiang@intel.com>,
	"David Airlie" <airlied@linux.ie>,
	"David Hildenbrand" <david@redhat.com>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"H. Peter Anvin" <hpa@zytor.com>,
	"Ingo Molnar" <mingo@redhat.com>,
	"Ira Weiny" <ira.weiny@intel.com>,
	"Jason Gunthorpe" <jgg@mellanox.com>,
	"Jason Gunthorpe" <jgg@ziepe.ca>,
	"Jeff Moyer" <jmoyer@redhat.com>,
	"Jérôme Glisse" <jglisse@redhat.com>,
	"Jia He" <justin.he@arm.com>,
	"Joao Martins" <joao.m.martins@oracle.com>,
	"Jonathan Cameron" <Jonathan.Cameron@huawei.com>,
	"Michael Ellerman" <mpe@ellerman.id.au>,
	"Mike Rapoport" <rppt@linux.ibm.com>,
	"Paul Mackerras" <paulus@ozlabs.org>,
	"Pavel Tatashin" <pasha.tatashin@soleen.com>,
	"Peter Zijlstra" <peterz@infradead.org>,
	"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
	"Ralph Campbell" <rcampbell@nvidia.com>,
	"Thomas Gleixner" <tglx@linutronix.de>,
	"Tom Lendacky" <thomas.lendacky@amd.com>,
	"Vishal Verma" <vishal.l.verma@intel.com>,
	"Wei Yang" <richard.weiyang@linux.alibaba.com>,
	"Wei Yongjun" <weiyongjun1@huawei.com>,
	"Will Deacon" <will@kernel.org>
Subject: Re: [PATCH v2] mm/hmm/test: use after free in dmirror_allocate_chunk()
Date: Fri, 25 Sep 2020 21:30:09 +0200	[thread overview]
Message-ID: <d1b31586-426a-e0b1-803e-3eff30196c05@web.de> (raw)

> Neither the allocation nor the call to request_free_mem_region() has to
> be done under the lock so I moved those to the start of the function.

Can this information become relevant for another update step?


> Fixes: b2ef9f5a5cb3 ("mm/hmm/test: add selftest driver for HMM")

I find this commit reference interesting somehow.
How do you think about the commit 786ae133e07f2a6b352a0efad16b555ee45a2898
("lib: fix test_hmm.c reference after free" from 2020-06-26)
and the commit 1f9c4bb986d978a5e39153b39a71c9d098b65c5c ("mm/memremap_pages:
convert to 'struct range'" from 2020-09-23) for your update suggestion?

Regards,
Markus


             reply	other threads:[~2020-09-25 19:30 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-25 19:30 Markus Elfring [this message]
2020-09-26 12:14 ` [PATCH v3] " Dan Carpenter
2020-09-26 13:10   ` Markus Elfring
2020-09-26 22:17   ` Jason Gunthorpe
2020-09-29  0:52     ` Andrew Morton
2020-09-29  1:25       ` Dan Williams
  -- strict thread matches above, loose matches on Subject: below --
2020-09-22 17:31 [PATCH] " Ralph Campbell
2020-09-24 13:46 ` [PATCH v2] " Dan Carpenter
2020-09-24 19:25   ` Ralph Campbell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d1b31586-426a-e0b1-803e-3eff30196c05@web.de \
    --to=markus.elfring@web.de \
    --cc=Brice.Goglin@inria.fr \
    --cc=Jonathan.Cameron@huawei.com \
    --cc=airlied@linux.ie \
    --cc=akpm@linux-foundation.org \
    --cc=ardb@kernel.org \
    --cc=benh@kernel.crashing.org \
    --cc=bp@alien8.de \
    --cc=bskeggs@redhat.com \
    --cc=catalin.marinas@arm.com \
    --cc=dan.carpenter@oracle.com \
    --cc=dan.j.williams@intel.com \
    --cc=daniel@ffwll.ch \
    --cc=dave.hansen@linux.intel.com \
    --cc=dave.jiang@intel.com \
    --cc=david@redhat.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=hpa@zytor.com \
    --cc=ira.weiny@intel.com \
    --cc=jgg@mellanox.com \
    --cc=jgg@ziepe.ca \
    --cc=jglisse@redhat.com \
    --cc=jmoyer@redhat.com \
    --cc=joao.m.martins@oracle.com \
    --cc=justin.he@arm.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=luto@kernel.org \
    --cc=mingo@redhat.com \
    --cc=mpe@ellerman.id.au \
    --cc=pasha.tatashin@soleen.com \
    --cc=paulus@ozlabs.org \
    --cc=peterz@infradead.org \
    --cc=rafael.j.wysocki@intel.com \
    --cc=rcampbell@nvidia.com \
    --cc=richard.weiyang@linux.alibaba.com \
    --cc=rppt@linux.ibm.com \
    --cc=sfr@canb.auug.org.au \
    --cc=tglx@linutronix.de \
    --cc=thomas.lendacky@amd.com \
    --cc=vishal.l.verma@intel.com \
    --cc=weiyongjun1@huawei.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox