From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C631CD1284 for ; Tue, 9 Apr 2024 07:36:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E47D26B0087; Tue, 9 Apr 2024 03:36:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DF7E76B0089; Tue, 9 Apr 2024 03:36:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C98236B008A; Tue, 9 Apr 2024 03:36:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id AB9236B0087 for ; Tue, 9 Apr 2024 03:36:33 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 2E74B1402BC for ; Tue, 9 Apr 2024 07:36:33 +0000 (UTC) X-FDA: 81989185866.03.453000A Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf09.hostedemail.com (Postfix) with ESMTP id D8A03140002 for ; Tue, 9 Apr 2024 07:36:30 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=MoocWgrS; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf09.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712648190; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=arqq0gGTSQSzvYcmcny09G7FBRrACeMLaQtHwD/pOao=; b=wSJaAoWkmY8PMOZhKN21Dv5eT0OZpHrM47MrclnBOEzKrtOgc4IzdZKtZj1hcFtMrtL1ZC 4KELv6yfS80RRG43nBzuSywjqMWOlIAJI3VvEQTTkPJyDC6GCLGXYmnOl5SMi+6vEhOqCb YQG7bCi0YRxZbygnXH2N8ykE2GB5fKk= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=MoocWgrS; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf09.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712648190; a=rsa-sha256; cv=none; b=7VVXx/laVV9oD4aXA9T95CdFuT+zNAi/SHZCXHAtrCbhIv1N/roPJOSUQcZzMG5YLfpz2J 1Bzl5gvXc7UKH5rzY4Yvx/lAdnZFsPnQ/VyenH2clr9Cvv0QozlMG20ot72bXcZMzllU3B pxum+M6F5B4NB5TVcXpngyycVdcATy0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1712648190; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=arqq0gGTSQSzvYcmcny09G7FBRrACeMLaQtHwD/pOao=; b=MoocWgrS68N5RjC2BQ2Wx0ctmA+RBAd7Ua3/J3T43lS3dwHPRIMjbJxL2k7NWpts8HyQvF sd5vYBY2CTclv5u/d0bcCKMsO5zkxU3xjbRt92DSbb1CiyrDfGwJ3f8xhaio/ShcqEXm/W oRcg/vILrtmy9HmpGhzATTGG6Q4bbqA= Received: from mail-lf1-f70.google.com (mail-lf1-f70.google.com [209.85.167.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-408-nqok0YBiPtCPLQZyMohcig-1; Tue, 09 Apr 2024 03:36:28 -0400 X-MC-Unique: nqok0YBiPtCPLQZyMohcig-1 Received: by mail-lf1-f70.google.com with SMTP id 2adb3069b0e04-517470e8db0so290661e87.2 for ; Tue, 09 Apr 2024 00:36:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712648187; x=1713252987; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=arqq0gGTSQSzvYcmcny09G7FBRrACeMLaQtHwD/pOao=; b=kP5bBZNqzqe67syzKW3coZOnu9sOG4dP77dON5pjY/aG4J/nHhOL0gzhsfEufLIhq4 3Y6V4xcKNPjPoLOUAgX6NKWfoRRlYWMct/zI36vEWfzAoMMsETL5wOda9wt/li6u7MMr lY0Z82T0DvolLWeUy3PFh2FeIlxsyKBR5OBdsEGYWEGQXI33kd9q2rOd54I5ove4HJfy mKW/Fqceu0mmAunirYggUy+bfcAm/EFhD0CDnfaQITyKaRnoYwl9Bqw1R8W4pMkV+tuJ F2MI4TiysvcDLhWE+Mf8j36VA+XNZ7iP4xNNDsaFPC97yCdQfjWCHVxPMrIQgIjV2SZU p/1g== X-Gm-Message-State: AOJu0YzOw44KxXq9235f2824uJEsQrfSldDtNRrIvAHn7xH8GFoh0N/d 1834zKYvDH7v6eXK+FF3AT7G18jX3uh1JXqWMOC3CiWE54WcqkrkVXZgWu/mewZSVvZlSEXjxbg FLw5sO9gyKC7VSL/k0dDeVDjkqpefgxy7WYbehqD/yscYZdH4 X-Received: by 2002:a19:8c5c:0:b0:516:cf0a:9799 with SMTP id i28-20020a198c5c000000b00516cf0a9799mr7943793lfj.64.1712648186815; Tue, 09 Apr 2024 00:36:26 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEVV5PlGURhMCt3hZYUXxHJ9NweAt6e9ypMNeZkCFslLbW1tBjbVDMYU5+fJ9rY0AT1ixuj6g== X-Received: by 2002:a19:8c5c:0:b0:516:cf0a:9799 with SMTP id i28-20020a198c5c000000b00516cf0a9799mr7943775lfj.64.1712648186436; Tue, 09 Apr 2024 00:36:26 -0700 (PDT) Received: from ?IPV6:2003:cb:c70a:be00:a285:bc76:307d:4eaa? (p200300cbc70abe00a285bc76307d4eaa.dip0.t-ipconnect.de. [2003:cb:c70a:be00:a285:bc76:307d:4eaa]) by smtp.gmail.com with ESMTPSA id s7-20020adff807000000b00343d6c7240fsm10696224wrp.35.2024.04.09.00.36.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 09 Apr 2024 00:36:25 -0700 (PDT) Message-ID: Date: Tue, 9 Apr 2024 09:36:24 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 4/7] mm: swap: Update get_swap_pages() to take folio order To: Ryan Roberts , Andrew Morton , Matthew Wilcox , Huang Ying , Gao Xiang , Yu Zhao , Yang Shi , Michal Hocko , Kefeng Wang , Barry Song <21cnbao@gmail.com>, Chris Li , Lance Yang Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20240408183946.2991168-1-ryan.roberts@arm.com> <20240408183946.2991168-5-ryan.roberts@arm.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240408183946.2991168-5-ryan.roberts@arm.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: D8A03140002 X-Stat-Signature: j55kdyjh9uxge3fs185ctxqaxj7tfx3m X-Rspam-User: X-HE-Tag: 1712648190-498451 X-HE-Meta: U2FsdGVkX1/gVgZX5/bGS46LyPwDGEuUVCBhGIAJuepEF+fntIC5V+pqEHW/LvMQtgvJ6pWlRg2nkSz/h/cI0atwQo4uciRFmFFpLFHyJG4go13rQnbY8vyKKGW2Siab/SK3hv3e8F1MqZ5IQd8bkSCIwW3P0vkuGCiqK1eRimrbo1o8I9dIx8zJ6IPihKq/bzsh/xloLF3BwZPfU6lyrpBPjPWGeLDpZu1TNFAqCWuaAsBPk5PA9BnYpLF51oSRBTnFEVyzAi6vHDvRSxWbQRJyZCRAK9ZHHTOLsznwUvtFIvYy3vVEirMrBvAQidGKpwR/2ELCub3iAfg9OYySgANBMwlCsgM/b83MK7IvjOaEFKD6I7j+bHhTG7XBsHeMIlDMrqwofU1Shf/TNg6JvIWaoIPXpVzlx4DSxwdXui1JjEM2tQZxwlb75CdGovQWV/tT2kUCuCuy6yGdZTFj/pNfj5ThcXxp0001zEwhBH9rm73W9boziatqoVWKoP1F0nqa1YvaPrfj3lHdAL4EcGu1o+5Kfr60hy8kf3kmtq2oFk5nraOVhotN4yC/VMVx09zLHJsAdfWUTqqknDACtCPp1Zfkr++LC6XB2mpiIyvxM7eQcvtEEoFkgwbwkQwJ2E1JXwY46d0saNRjmTYxMjo5CuWfOKS26LE6YnGA+WA4HSVP+pf0Wqgat+JzFdZ6SffgGDNG+lNtTdJ47JV6ysf/wlWxjcRjlJP+liHJCfSfYQodykc9TlnvxCPBiWQHfH9CzaYN7l102SCPfD5Sn83HVxFQg7GUqkCohGjuHn1OXd54EI2t/iJOSXNdfsOrJ0T2YMYCbLxyX9Xg0+IhZUeuPPvuOs73hbOAJe0tBnHaqBWSRzSZiyQ/6+rQYqQCRKG21tZS+c4B+xUG4yFAz8JNnfAscY0sk0M72ZzcUT7hSjhp+dmt7gG+sCMO7yXXbl/dLtlEFy49PfA8x7C h6RpEDOm zY9oQO3T5A3PFbzzIH2kkGlcDFnpCCSGdiVSTMyHjbxXAwM2BznMNiBBgHf9clhausQorrxb8sh2GSF4sjzv+D3wz5VBDq4WrA+J7j3O+G7cma95rgbmlDdAl7RzGk/VbD/JxezoJZjRRstAgPTQgRQIRzMk7Vx3c6Pl/jzGH4wtP0qOha63hExsjOSvZN0BPh94V9QjRGj3aC9GPC91S3n9MOePDg/UBPeIrHPIVQSJWvitbn6lU3XWiprh/Oazg0zqB9gLiaXgvA7pZA3/s+6CucuDH09kDs1eYRODU+UeMAUTyh7oaPqzvh4UM37biOaaJ24jmWtevZCbGwPlEDURwk1BCEsX3N02o6zPZPcaafCpwYo3eHy3Yzn0JdOmB9zaSG7cPElgUPGHh6Br7A4ZtaDRLANZ2ch6VLxLKDuChWlSuvg2gwuG+c4NKbafatSPjolG8zjWVst2Rx/Aka1VDJqJHsGDkjvSiCqItXMcCsJIgFpDb9W+oGincWZQd963sW72737/bY+vlvoICwvMDJj+rGnFWBUAWTVapduXnu/1xVz24ZRhz49KOx7Ziqcfl X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 08.04.24 20:39, Ryan Roberts wrote: > We are about to allow swap storage of any mTHP size. To prepare for > that, let's change get_swap_pages() to take a folio order parameter > instead of nr_pages. This makes the interface self-documenting; a > power-of-2 number of pages must be provided. We will also need the order > internally so this simplifies accessing it. > > Reviewed-by: "Huang, Ying" > Signed-off-by: Ryan Roberts > --- Reviewed-by: David Hildenbrand -- Cheers, David / dhildenb